JonChesterfield added a comment. > I see some problems with using llvm-objcopy for that. First issue is that > symbols created by llvm-objcopy for embedded data depend on the input file > name. As you know these symbols are referenced from the offload registration > code that is currently added to an object by the clang at compile time. I not > sure how you can guarantee that symbol names will match.
That seems solvable by renaming the input file / passing a string to clang. > And another, more important problem is that it won't work on Windows because > llvm-objcopy produces ELF object according to the description. objcopy works with coff in the meantime, and we already need a bunch of unix tools to build llvm on windows. > Anyway I am going to change entries section name to "omp_offloading_entries", > remove omptargetbegin.o/omptargetend.o and upload the revised patch. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
