[PATCH] D66765: [analyzer] (Urgent!) Add 9.0.0. release notes.

hans added a comment. In D66765#1645726 , @Szelethus wrote: > Please note that LLVM 9.0.0-final is due on the 28th of August. There are still a lot of open bugs, so it will probably slip at least a little. Comment at: clang/docs/Relea

[PATCH] D66765: [analyzer] (Urgent!) Add 9.0.0. release notes.

martong added inline comments. Comment at: clang/docs/ReleaseNotes.rst:269 + +- New frontend flag: ``-analyzer-werror`` to turn analyzer warnings into errors. Could you please also add: - Numerous`` ASTImporter`` related fixes and improvements which increase t

[PATCH] D66731: [Driver] Add an option for createInvocationFromCommandLine to recover on errors

ilya-biryukov updated this revision to Diff 217319. ilya-biryukov added a comment. - Add a comment to CreateFromArgs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66731/new/ https://reviews.llvm.org/D66731 Files: clang-tools-extra/clangd/Compile

[PATCH] D66787: GlobList: added a clear test for pattern priority

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr added a reviewer: ilya-biryukov. The last glob that matches the string decides whether that string is included or excluded. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D66731: [Driver] Add an option for createInvocationFromCommandLine to recover on errors

ilya-biryukov updated this revision to Diff 217320. ilya-biryukov added a comment. - Fix english grammar in the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66731/new/ https://reviews.llvm.org/D66731 Files: clang-tools-extra/clangd/Comp

[PATCH] D66788: Refactor GlobList from an ad-hoc linked list to a vector

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I think it makes method implementations more obvious. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66788 Files: clang-tools-extra/clang-tidy/GlobList.cpp clang-tools-e

[PATCH] D66787: GlobList: added a clear test for pattern priority

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66787/new/ https://reviews.llvm.org/D66787 _

[PATCH] D66788: Refactor GlobList from an ad-hoc linked list to a vector

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clang-tidy/GlobList.cpp:46 +GlobList::GlobList(StringRef Globs) { + do { +GlobListItem Item; NIT: I sug

[PATCH] D66590: [clangd] Fix toHalfOpenFileRange where start/end endpoints are in different files due to #include

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:284 + return SM.getComposedLoc(IncludingFile, Offset); +if (Buf[Offset] == '\n' || Offset == 0) // no hash, what's going on? + return Sou

[clang-tools-extra] r370028 - GlobList: added a clear test for pattern priority

Author: gribozavr Date: Tue Aug 27 01:42:42 2019 New Revision: 370028 URL: http://llvm.org/viewvc/llvm-project?rev=370028&view=rev Log: GlobList: added a clear test for pattern priority Summary: The last glob that matches the string decides whether that string is included or excluded. Subscriber

[PATCH] D66731: [Driver] Add an option for createInvocationFromCommandLine to recover on errors

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Frontend/CompilerInvocation.h:150 /// + /// If an error was encountered while parsing the arguments, \returns false + /// and a

[clang-tools-extra] r370029 - [clangd] Fix toHalfOpenFileRange where start/end endpoints are in different files due to #include

Author: sammccall Date: Tue Aug 27 01:44:06 2019 New Revision: 370029 URL: http://llvm.org/viewvc/llvm-project?rev=370029&view=rev Log: [clangd] Fix toHalfOpenFileRange where start/end endpoints are in different files due to #include Summary: https://github.com/clangd/clangd/issues/129 Reviewer

[PATCH] D66787: GlobList: added a clear test for pattern priority

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd2315ce2101: GlobList: added a clear test for pattern priority (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66787/new/ https://re

[PATCH] D66590: [clangd] Fix toHalfOpenFileRange where start/end endpoints are in different files due to #include

This revision was automatically updated to reflect the committed changes. Closed by commit rL370029: [clangd] Fix toHalfOpenFileRange where start/end endpoints are in different… (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D66759: [clangd] Surface errors from command-line parsing

kadircet added a comment. Thanks! This looks really useful when we can't build an AST due to unknown compiler commands, but I am not sure about how useful it is to surface command-line parsing errors once we are able to build an AST. Because people most likely won't care about these errors once

[PATCH] D61758: [driver][xray] fix the macOS support checker by supporting -macos triple in addition to -darwin

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. Herald added a subscriber: ributzka. LGTM -- apologies for the delay, I hope this isn't too late. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D66751: [clangd] Add targetDecl(), which determines what declaration an AST node refers to.

ilya-biryukov added a comment. Mostly LGTM, thanks! Just a few clarifying questions and suggestions This API allows us to get a target declaration for a reference, but does not help with finding the source locations for those references. Do you plan to put this into the API? Have this as a sepa

[PATCH] D66290: [clang] Pragma vectorize_width() implies vectorize(enable)

SjoerdMeijer added a comment. Thanks, and sorry for the delay. Back in the office now, and I am addressing this: > I think it would be slightly better to split off the change to disable > vectorization via llvm.loop.vectorize.enable=false instead of width=1. Yep, I agree CHANGES SINCE LAST A

[clang-tools-extra] r370030 - [clangd] Fix for r370029 test that got left in my client

Author: sammccall Date: Tue Aug 27 02:27:00 2019 New Revision: 370030 URL: http://llvm.org/viewvc/llvm-project?rev=370030&view=rev Log: [clangd] Fix for r370029 test that got left in my client Modified: clang-tools-extra/trunk/clangd/unittests/SourceCodeTests.cpp Modified: clang-tools-extra/

[PATCH] D66743: [clangd] Cleans up the semantic highlighting resources if clangd crashes.

hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:60 + // Any disposables that should be cleaned up when clangd crashes. + private disposables: vscode.Disposable[] = []; fillClientCapabilities(capabilities:

[PATCH] D59692: [ASTImporter] Fix name conflict handling with different strategies

martong marked 4 inline comments as done. martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3452 << FoundField->getType(); - - return make_error(ImportError::NameConflict); + ConflictingDecls.push_back(FoundField); }

[PATCH] D66765: [analyzer] (Urgent!) Add 9.0.0. release notes.

devnexen added inline comments. Comment at: clang/docs/ReleaseNotes.rst:240 + +- The Static Analyzer recieved a + :ref:`developer documentation `. typo `recieved` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6676

[PATCH] D59692: [ASTImporter] Fix name conflict handling with different strategies

martong updated this revision to Diff 217330. martong marked 2 inline comments as done. martong added a comment. - Revert changes in VisitFieldDecl and in VisitIndirectFieldDecl - Remove test suite ConflictingDeclsWithConservativeStrategy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D66759: [clangd] Surface errors from command-line parsing

ilya-biryukov added a comment. In D66759#1646509 , @kadircet wrote: > Thanks! This looks really useful when we can't build an AST due to unknown > compiler commands, but I am not sure about how useful it is to surface > command-line parsing errors once w

[PATCH] D66792: [ReleaseNotes] MemorySanitizer support of ASLR on FreeBSD

devnexen created this revision. devnexen added reviewers: sylvestre.ledru, kcc. devnexen created this object with visibility "All Users". Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D66792 Files: clang/docs/MemorySaniti

Re: r369749 - [Docs][OpenCL] Several corrections to C++ for OpenCL

Hi Hans, Can this be merged to the release, please? Thank you, Anastasia From: cfe-commits on behalf of Anastasia Stulova via cfe-commits Sent: 23 August 2019 12:43 To: cfe-commits@lists.llvm.org Subject: r369749 - [Docs][OpenCL] Several corrections to C+

[PATCH] D66731: [Driver] Add an option for createInvocationFromCommandLine to recover on errors

ilya-biryukov updated this revision to Diff 217335. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Start a paragrah with \returns instead of putting it in the middle Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D667

[PATCH] D66792: [ReleaseNotes] MemorySanitizer support of ASLR on FreeBSD

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Looks good, thanks Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66792/new/ https://reviews.llvm.org/D66792 __

Re: r369749 - [Docs][OpenCL] Several corrections to C++ for OpenCL

Yes, r370031. Thanks, Hans On Tue, Aug 27, 2019 at 11:43 AM Anastasia Stulova wrote: > > Hi Hans, > > > Can this be merged to the release, please? > > > Thank you, > > Anastasia > > > > > From: cfe-commits on behalf of Anastasia > Stulova via cfe-commits > Sen

[PATCH] D66516: [clangd] Added highlighting to types dependant on templates.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:177 return; +if (TP->isPointerType() || TP->isLValueReferenceType()) + // When highlighting dependant template types the type can be a pointer or j

[PATCH] D59692: [ASTImporter] Fix name conflict handling with different strategies

martong updated this revision to Diff 217337. martong added a comment. - Apply clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59692/new/ https://reviews.llvm.org/D59692 Files: clang/include/clang/AST/ASTImporter.h clang/lib/AST/AST

[PATCH] D66731: [Driver] Add an option for createInvocationFromCommandLine to recover on errors

ilya-biryukov added inline comments. Comment at: clang/include/clang/Frontend/CompilerInvocation.h:150 /// + /// If an error was encountered while parsing the arguments, \returns false + /// and attempts to recover and continue parsing the rest of the arguments.

r370033 - [Driver] Add an option for createInvocationFromCommandLine to recover on errors

Author: ibiryukov Date: Tue Aug 27 03:02:18 2019 New Revision: 370033 URL: http://llvm.org/viewvc/llvm-project?rev=370033&view=rev Log: [Driver] Add an option for createInvocationFromCommandLine to recover on errors Summary: Previously, it would always return nullptr on any error. This change add

r370035 - [ReleaseNotes] MemorySanitizer support of ASLR on FreeBSD

Author: devnexen Date: Tue Aug 27 03:04:03 2019 New Revision: 370035 URL: http://llvm.org/viewvc/llvm-project?rev=370035&view=rev Log: [ReleaseNotes] MemorySanitizer support of ASLR on FreeBSD Reviewers: sylvestre.ledru, kcc Reviewed By: sylvestre.ledru Differential Revision: https://reviews.ll

[clang-tools-extra] r370033 - [Driver] Add an option for createInvocationFromCommandLine to recover on errors

Author: ibiryukov Date: Tue Aug 27 03:02:18 2019 New Revision: 370033 URL: http://llvm.org/viewvc/llvm-project?rev=370033&view=rev Log: [Driver] Add an option for createInvocationFromCommandLine to recover on errors Summary: Previously, it would always return nullptr on any error. This change add

[PATCH] D66751: [clangd] Add targetDecl(), which determines what declaration an AST node refers to.

kadircet added a comment. I agree with Ilya's concerns on SourceLocations, even though most of the time user will have the source locations available in the dyntyped node, they might need some traversals to fetch the exact range especially in cases of nested name specifiers. It would be nice to

[PATCH] D66770: Move EH spec mismatches under -fms-compatibility

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66770/new/ https://reviews.llvm.org/D66770 ___ cfe

[PATCH] D66731: [Driver] Add an option for createInvocationFromCommandLine to recover on errors

This revision was automatically updated to reflect the committed changes. Closed by commit rL370033: [Driver] Add an option for createInvocationFromCommandLine to recover on errors (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

[PATCH] D66792: [ReleaseNotes] MemorySanitizer support of ASLR on FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rGbccbd74c6255: [ReleaseNotes] MemorySanitizer support of ASLR on FreeBSD (authored by devnexen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66792/new/ htt

Re: r369834 - PR42513: Enter the proper DeclContext before substituting into an

Merged to release_90 in r370038. On Sat, Aug 24, 2019 at 4:28 AM Richard Smith via cfe-commits wrote: > > Author: rsmith > Date: Fri Aug 23 19:30:00 2019 > New Revision: 369834 > > URL: http://llvm.org/viewvc/llvm-project?rev=369834&view=rev > Log: > PR42513: Enter the proper DeclContext before s

[clang-tools-extra] r370039 - Refactor GlobList from an ad-hoc linked list to a vector

Author: gribozavr Date: Tue Aug 27 03:56:13 2019 New Revision: 370039 URL: http://llvm.org/viewvc/llvm-project?rev=370039&view=rev Log: Refactor GlobList from an ad-hoc linked list to a vector Summary: I think it makes method implementations more obvious. Subscribers: cfe-commits Tags: #clang

[PATCH] D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

lenary added a comment. In D57450#1641308 , @jyknight wrote: > In D57450#1641190 , @lenary wrote: > > > @jyknight I hear where you're coming from. I'll see what I can do about the > > psABI document. > > > > In tha

[PATCH] D66788: Refactor GlobList from an ad-hoc linked list to a vector

gribozavr marked an inline comment as done. gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/GlobList.cpp:46 +GlobList::GlobList(StringRef Globs) { + do { +GlobListItem Item; ilya-biryukov wrote: > NIT: I suggest using `for (;!Globs.

[PATCH] D66796: [clang] Loop pragma vectorize(disable)

SjoerdMeijer created this revision. SjoerdMeijer added reviewers: fhahn, Meinersbur, hsaito, Ayal. This changes the behaviour of vectorize(disable). I.e., disabling vectorization now means disabling vectorization, and not setting the vectorization width to 1. This is a follow up of the discussion

[PATCH] D66290: [clang] Pragma vectorize_width() implies vectorize(enable)

SjoerdMeijer added a comment. > I think it would be slightly better to split off the change to disable > vectorization via llvm.loop.vectorize.enable=false instead of width=1. This is now D66796 . I will now start stripping it out from this patch. CHANGES SINC

[PATCH] D66788: Refactor GlobList from an ad-hoc linked list to a vector

This revision was automatically updated to reflect the committed changes. Closed by commit rL370039: Refactor GlobList from an ad-hoc linked list to a vector (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D66627: [clang-tidy] add checks to bugprone-posix-return

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. LGTM with all comments addressed. Comment at: clang-tools-extra/test/clang-tidy/bugprone-posix-return.cpp:169 int posix_fadvise(int fd, off_t offset, off_t len, int ad

r370041 - [clang] Ensure that comment classes are trivially destructible

Author: brunoricci Date: Tue Aug 27 04:21:00 2019 New Revision: 370041 URL: http://llvm.org/viewvc/llvm-project?rev=370041&view=rev Log: [clang] Ensure that comment classes are trivially destructible As in D66646, these classes are also allocated with a BumpPtrAllocator, and therefore should be t

[PATCH] D66722: [clang] Ensure that comment classes are trivially destructible

This revision was automatically updated to reflect the committed changes. Closed by commit rG2535f04338c6: [clang] Ensure that comment classes are trivially destructible (authored by riccibruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66722/ne

[PATCH] D66797: ArrayRef'ized CompilerInvocation::CreateFromArgs

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr added a reviewer: ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66797 Files: clang/include/clang/Frontend/CompilerInvocation.h clang/lib/Frontend

r370044 - [clang] Ensure that statements, expressions and types are trivially destructible

Author: brunoricci Date: Tue Aug 27 04:35:49 2019 New Revision: 370044 URL: http://llvm.org/viewvc/llvm-project?rev=370044&view=rev Log: [clang] Ensure that statements, expressions and types are trivially destructible Since statements, expressions and types are allocated with the BumpPtrAllocator

r370045 - [ASTImporter] Fix name conflict handling with different strategies

Author: martong Date: Tue Aug 27 04:36:10 2019 New Revision: 370045 URL: http://llvm.org/viewvc/llvm-project?rev=370045&view=rev Log: [ASTImporter] Fix name conflict handling with different strategies There are numorous flaws about the name conflict handling, this patch attempts fixes them. Chang

[PATCH] D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

Szelethus added a comment. Note how I am partially at fault here, which is why the bug reports state that the crash originates from `TrackControlDependencyVisitor`, but even after that is fixed, the diagnostics construction flopped on an out-of-bounds error. Repository: rG LLVM Github Monore

[PATCH] D66743: [clangd] Cleans up the semantic highlighting resources if clangd crashes.

jvikstrom marked 2 inline comments as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:114 + // restarts. + public crashDispose() { +this.disposables.forEach((d) => d.dispose());

[PATCH] D66743: [clangd] Cleans up the semantic highlighting resources if clangd crashes.

jvikstrom updated this revision to Diff 217367. jvikstrom added a comment. Renamed disposables to subscriptions and removed clangd crashes in api. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66743/new/ https://reviews.llvm.org/D66743 Files: cl

[PATCH] D66646: [clang] Ensure that statements, expressions and types are trivially destructible

This revision was automatically updated to reflect the committed changes. Closed by commit rL370044: [clang] Ensure that statements, expressions and types are trivially destructible (authored by brunoricci, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Cha

[PATCH] D59692: [ASTImporter] Fix name conflict handling with different strategies

This revision was automatically updated to reflect the committed changes. Closed by commit rGf035b75d8f07: [ASTImporter] Fix name conflict handling with different strategies (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59692/n

[PATCH] D66564: [clang-tidy] new FPGA struct pack align check

alexfh added a comment. Thanks for the contribution and welcome to the LLVM community! A few more comments from me. I hope, this will help to tune to the LLVM coding style and conventions. This doc may be useful to read, if you haven't done so already: http://llvm.org/docs/CodingStandards.html

[PATCH] D66588: [ARM NEON] Avoid duplicated decarations

dnsampaio planned changes to this revision. dnsampaio added a comment. Breaks the header. Needs to avoid generating calls to functions with predicated __noswap when it is BigEndianSafe. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66588/new/ https://reviews.llv

r370051 - Testing commit access; NFC

Author: jranieri Date: Tue Aug 27 05:36:25 2019 New Revision: 370051 URL: http://llvm.org/viewvc/llvm-project?rev=370051&view=rev Log: Testing commit access; NFC Modified: cfe/trunk/www/index.html Modified: cfe/trunk/www/index.html URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/www/inde

r370052 - Implement codegen for MSVC unions with reference members.

Author: aaronballman Date: Tue Aug 27 05:42:45 2019 New Revision: 370052 URL: http://llvm.org/viewvc/llvm-project?rev=370052&view=rev Log: Implement codegen for MSVC unions with reference members. Currently, clang accepts a union with a reference member when given the -fms-extensions flag. This

[PATCH] D66797: ArrayRef'ized CompilerInvocation::CreateFromArgs

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Yes, please! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66797/new/ https://reviews.llvm.org/D66797 ___

[PATCH] D66759: [clangd] Surface errors from command-line parsing

kadircet added a comment. In D66759#1646599 , @ilya-biryukov wrote: > How common is this? Do we have any particular examples? Well, I don't have any data to prove, but my experience has been so far; most of the people don't touch Makefiles apart from a

[PATCH] D62571: Implement codegen for MSVC unions with reference members

aaron.ballman closed this revision. aaron.ballman added a comment. In D62571#1646227 , @domdom wrote: > Rebased onto master, clang format the patch. > > Merge conflict resolve by having the bitcast of the field reference happening > after recording access

[PATCH] D66290: [clang] Pragma vectorize_width() implies vectorize(enable)

SjoerdMeijer updated this revision to Diff 217383. SjoerdMeijer edited the summary of this revision. SjoerdMeijer added a parent revision: D66796: [clang] Loop pragma vectorize(disable). SjoerdMeijer added a comment. Stripped out the functional change related to vectorize(disable). CHANGES SINC

[PATCH] D66759: [clangd] Surface errors from command-line parsing

ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. Just to clarify: we only want to surface errors, not warnings from command-line to avoid too much nosie; I'm totally on board with not spamming users with "unknown compiler warning" errors at the start of each file. W

[PATCH] D66199: [docs] loop pragmas

SjoerdMeijer added a comment. Many thanks for your clarification! > What we were discussing was that these settings would remove 0) from the > candidate list as well. Yep, that's crystal clear now. And my expectation would indeed be that this would be the case. CHANGES SINCE LAST ACTION h

[PATCH] D66759: [clangd] Surface errors from command-line parsing

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:465 +Diags.insert(Diags.end(), Preamble->Diags.begin(), Preamble->Diags.end()); + // Finally, add diagnostics coming from the AST. + { ilya-biryukov wrote: > kadircet wrote:

[PATCH] D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

asb added a comment. This LGTM, but given how much discussion there has been about MaxPromoteWidth it would be great to get some test coverage for it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57450/new/ https://reviews.llvm.org/D57450

[PATCH] D59692: [ASTImporter] Fix name conflict handling with different strategies

martong added a comment. Jenkins is not green http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/743/ However, the newly failing test is `TestTargetCommand.py`, which seems to be unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59692

[PATCH] D66751: [clangd] Add targetDecl(), which determines what declaration an AST node refers to.

sammccall added a comment. First a wall of text to reply to the general comments. Let's chat if this doesn't make sense. In D66751#1646545 , @ilya-biryukov wrote: > Mostly LGTM, thanks! Just a few clarifying questions and suggestions > > This API allows

[PATCH] D59692: [ASTImporter] Fix name conflict handling with different strategies

labath added a comment. In D59692#1646990 , @martong wrote: > Jenkins is not green > http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/743/ > However, the newly failing test is `TestTargetCommand.py`, which seems to be > unrelated. That ought t

r370058 - Speculatively fix the build bots after r370052.

Author: aaronballman Date: Tue Aug 27 06:45:42 2019 New Revision: 370058 URL: http://llvm.org/viewvc/llvm-project?rev=370058&view=rev Log: Speculatively fix the build bots after r370052. Modified: cfe/trunk/test/CodeGenCXX/ms-union-member-ref.cpp Modified: cfe/trunk/test/CodeGenCXX/ms-union-

r370059 - Quote the token being diagnosed for C11 extensions.

Author: aaronballman Date: Tue Aug 27 06:47:51 2019 New Revision: 370059 URL: http://llvm.org/viewvc/llvm-project?rev=370059&view=rev Log: Quote the token being diagnosed for C11 extensions. Modified: cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td cfe/trunk/test/Parser/c1x-alignas.

r370060 - Fix text range end columns in SARIF to be exclusive

Author: jranieri Date: Tue Aug 27 06:49:45 2019 New Revision: 370060 URL: http://llvm.org/viewvc/llvm-project?rev=370060&view=rev Log: Fix text range end columns in SARIF to be exclusive According to the SARIF specification, "a text region does not include the character specified by endColumn".

Re: r363086 - For DR712: store on a DeclRefExpr whether it constitutes an odr-use.

Bisection for https://bugs.llvm.org/show_bug.cgi?id=42861 also points to this revision. On Wed, Jun 12, 2019 at 1:49 AM Richard Smith via cfe-commits wrote: > > Thanks, should be fixed by r363113. > > On Tue, 11 Jun 2019 at 16:21, Reid Kleckner via cfe-commits > wrote: >> >> >> The new assert i

[PATCH] D65206: [analyzer] Fix text range end columns in SARIF to be exclusive

This revision was automatically updated to reflect the committed changes. Closed by commit rG68a6a28ef835: Fix text range end columns in SARIF to be exclusive (authored by jranieri-grammatech). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65206/new/

r370061 - Fix a SARIF exporter crash with macro expansions

Author: jranieri Date: Tue Aug 27 07:20:27 2019 New Revision: 370061 URL: http://llvm.org/viewvc/llvm-project?rev=370061&view=rev Log: Fix a SARIF exporter crash with macro expansions Differential Revision: https://reviews.llvm.org/D65209 Modified: cfe/trunk/lib/StaticAnalyzer/Core/SarifDiag

[PATCH] D66751: [clangd] Add targetDecl(), which determines what declaration an AST node refers to.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:79 + static const Decl *getTemplatePattern(const Decl *D) { +if (const CXXRecordDecl *SD = dyn_cast(D)) { + return SD->getTemplateInstantiationPattern(); kadircet wrote

[PATCH] D66751: [clangd] Add targetDecl(), which determines what declaration an AST node refers to.

sammccall updated this revision to Diff 217392. sammccall marked 11 inline comments as done. sammccall added a comment. review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66751/new/ https://reviews.llvm.org/D66751 Files: clang-tools-e

[PATCH] D65209: [analyzer] Fix a SARIF exporter crash with macro expansions

This revision was automatically updated to reflect the committed changes. Closed by commit rG3385c5cc4dfd: Fix a SARIF exporter crash with macro expansions (authored by jranieri-grammatech). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65209/new/ h

[PATCH] D66743: [clangd] Cleans up the semantic highlighting resources if clangd crashes.

jvikstrom updated this revision to Diff 217396. jvikstrom added a comment. Dispose of all resources when disposing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66743/new/ https://reviews.llvm.org/D66743 Files: clang-tools-extra/clangd/clients/

Re: r363820 - Add a script to help generate expected test output for dumping the AST to JSON.

On Mon, Aug 26, 2019 at 7:53 PM Richard Smith wrote: > > Hi Aaron, > > I tried using this script to update a json dump test, and it seems to not > really work very well: > > 1) it's really inconvenient to invoke; you need to pass in a --clang, copy > some options out from two different places in

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

probinson added a comment. I don't see a test for the __cxx_global_array_dtor case? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66328/new/ https://reviews.llvm.org/D66328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

r370066 - Replace some custom C11 extension warnings with the generic warning.

Author: aaronballman Date: Tue Aug 27 07:41:39 2019 New Revision: 370066 URL: http://llvm.org/viewvc/llvm-project?rev=370066&view=rev Log: Replace some custom C11 extension warnings with the generic warning. Modified: cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td cfe/trunk/lib/Par

r370068 - Update the SARIF exporter to SARIF 2.1

Author: jranieri Date: Tue Aug 27 07:43:54 2019 New Revision: 370068 URL: http://llvm.org/viewvc/llvm-project?rev=370068&view=rev Log: Update the SARIF exporter to SARIF 2.1 This updates the SARIF exporter to produce SARIF 2.1 output. The bulk of the diffs come from two changes to SARIF: * https

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea added a comment. In D66328#1647062 , @probinson wrote: > I don't see a test for the __cxx_global_array_dtor case? It is actually the `arraydestroy.*` loop that is covered (generated by `CodeGenFunction::emitArrayDestroy`), please see `debug-info

[PATCH] D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

TWeaver added a comment. Hi there! thanks so much for this patch, can confirm that with this patch applied my local machine no longer crashes for the loop-widening.cpp test. LGTM for me, but this isn't really my area of expertise so I can't judge one whether these changes are the correct ones

[PATCH] D65211: [analyzer] Update the SARIF exporter to SARIF 2.1

This revision was automatically updated to reflect the committed changes. Closed by commit rL370068: Update the SARIF exporter to SARIF 2.1 (authored by jranieri, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

probinson added a comment. In D66328#1647094 , @aganea wrote: > In D66328#1647062 , @probinson wrote: > > > I don't see a test for the __cxx_global_array_dtor case? > > > It is actually the `arraydestroy.*` loop tha

[PATCH] D66806: [LifetimeAnalysis] Fix some false positives

xazax.hun created this revision. xazax.hun added reviewers: gribozavr, mgehre. xazax.hun added a project: clang. Herald added subscribers: Szelethus, Charusso, gamesh411, dkrupp, rnkovacs. We should never track if a gsl::Pointer is created from an unannotated type. For example the code below is d

[PATCH] D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

lenary updated this revision to Diff 217413. lenary added a comment. Address review feedback: - Add Test for MaxAtomicPromoteWidth Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57450/new/ https://reviews.llvm.org/D57450 Files: clang/lib/Basic/T

[PATCH] D66783: [clang-doc] Use llvm::createStringError and canonicalize error messages

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM -- thank you! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66783/new/ https://reviews.llvm.org/D66783 __

[PATCH] D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57450/new/ https://reviews.llvm.org/D57450

r370073 - [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

Author: lenary Date: Tue Aug 27 08:41:16 2019 New Revision: 370073 URL: http://llvm.org/viewvc/llvm-project?rev=370073&view=rev Log: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics Summary: This ensures that libcalls aren't generated when the target

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62739/new/ https://reviews.llvm.org/D62739 ___ cfe-commits mailing list cfe-commi

[PATCH] D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

This revision was automatically updated to reflect the committed changes. Closed by commit rL370073: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64… (authored by lenary, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D66652: [libTooling] Transformer: refine `SourceLocation` specified as anchor of changes.

ymandel added a comment. I'm having second thoughts about this -- I prefer the approach I ended up taking in https://reviews.llvm.org/D66676, which is subtly different. However, getRuleMatchLoc() will be useful a different purpose: when only reporting a diagnostic, with no corresponding changes

[PATCH] D66290: [clang] Pragma vectorize_width() implies vectorize(enable)

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66290/new/ https://reviews.llvm.org/D66290 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D66796: [clang] Loop pragma vectorize(disable)

Meinersbur added a comment. Therefore, `vectorize(disable)` would also disable interleaving? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66796/new/ https://reviews.llvm.org/D66796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

  1   2   3   >