[PATCH] D66199: [docs] loop pragmas

Meinersbur added a comment. Since this is user documentation, we should only add it here once it is true. Comment at: docs/LanguageExtensions.rst:3068-3069 +There are loop hints that control transformations (e.g. vectorization, loop +unrolling) and there loop hints that set t

r368874 - Document clang-cpp in the release notes for clang

Author: cbieneman Date: Wed Aug 14 09:49:52 2019 New Revision: 368874 URL: http://llvm.org/viewvc/llvm-project?rev=368874&view=rev Log: Document clang-cpp in the release notes for clang This patch adds a line in the release notes about the new clang-cpp library and the CMake option to force clan

r368876 - [NFC] Updated tests after r368875

Author: xbolva00 Date: Wed Aug 14 09:50:34 2019 New Revision: 368876 URL: http://llvm.org/viewvc/llvm-project?rev=368876&view=rev Log: [NFC] Updated tests after r368875 Modified: cfe/trunk/test/CodeGen/tbaa-struct.cpp Modified: cfe/trunk/test/CodeGen/tbaa-struct.cpp URL: http://llvm.org/vie

r368878 - [Sema][ObjC] Fix a -Wformat false positive with localizedStringForKey

Author: epilk Date: Wed Aug 14 09:57:11 2019 New Revision: 368878 URL: http://llvm.org/viewvc/llvm-project?rev=368878&view=rev Log: [Sema][ObjC] Fix a -Wformat false positive with localizedStringForKey Only honour format_arg attributes on -[NSBundle localizedStringForKey] when its argument has a

[PATCH] D27165: Add format_dynamic_key_arg attribute to improve "-Wformat" warnings for functions that load the formatting string dynamically based on a key value

This revision was automatically updated to reflect the committed changes. Closed by commit rL368878: [Sema][ObjC] Fix a -Wformat false positive with localizedStringForKey (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D27165?vs=214977&id=215150#toc Reposi

r368881 - [NFC][clang] Moving argument handling: Driver::BuildActions -> handleArguments

Author: zer0 Date: Wed Aug 14 10:02:21 2019 New Revision: 368881 URL: http://llvm.org/viewvc/llvm-project?rev=368881&view=rev Log: [NFC][clang] Moving argument handling: Driver::BuildActions -> handleArguments This patch simply moves code that already exists into a new function. Specifically I th

[PATCH] D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368881: [NFC][clang] Moving argument handling: Driver::BuildActions -> handleArguments (authored by zer0, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

r368883 - [CFG] Introduce CFGElementRef, a wrapper that knows it's position in a CFGBlock

Author: szelethus Date: Wed Aug 14 10:05:55 2019 New Revision: 368883 URL: http://llvm.org/viewvc/llvm-project?rev=368883&view=rev Log: [CFG] Introduce CFGElementRef, a wrapper that knows it's position in a CFGBlock Previously, collecting CFGElements in a set was practially impossible, because bo

[PATCH] D65196: [CFG] Introduce CFGElementRef, a wrapper that knows it's position in a CFGBlock

This revision was automatically updated to reflect the committed changes. Szelethus marked an inline comment as done. Closed by commit rL368883: [CFG] Introduce CFGElementRef, a wrapper that knows it's position in a CFGBlock (authored by Szelethus, committed by ). Herald added a project: LLVM. Her

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Charusso updated this revision to Diff 215159. Charusso marked 4 inline comments as done. Charusso added a comment. - Rainbow Butterfly Unicorn Kitty CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66042/new/ https://reviews.llvm.org/D66042 F

[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer updated this revision to Diff 215162. SjoerdMeijer added a comment. thanks for the suggestions; comments addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64564/new/ https://reviews.llvm.org/D64564 Files: clang/lib/Parse/ParsePragma.cpp Index: clang/lib/Parse/Pa

[PATCH] D66186: Fix warning on printf('%hd', [char])

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. LGTM thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66186/new/ https://reviews.llvm.org/D66186 ___

[PATCH] D66199: [docs] loop pragmas

SjoerdMeijer marked an inline comment as done. SjoerdMeijer added a comment. > Since this is user documentation, we should only add it here once it is true. Yep, good point, I also wanted to capture our discussions on the list. But yes, let's hold this back until we're ready with the pragmas.

[PATCH] D66198: AMDGPU: Add builtins for is_local/is_private

arsenm updated this revision to Diff 215168. arsenm added a comment. rename CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66198/new/ https://reviews.llvm.org/D66198 Files: include/clang/Basic/BuiltinsAMDGPU.def lib/Basic/Targets/AMDGPU.cpp test/CodeGenOpenCL/builtins-amdgcn-ci.cl

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added a comment. Now that I had ever more time to think about this patch, I see a great potential in it for development use, for example, we could silence a checker before splitting it up to see whether we could disable it altogether or really having to go through the process of split

[PATCH] D66198: AMDGPU: Add builtins for is_local/is_private

b-sumner added a comment. Looks fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66198/new/ https://reviews.llvm.org/D66198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D66198: AMDGPU: Add builtins for is_local/is_private

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66198/new/ https://reviews.llvm.org/D66198 ___ cfe-commits mailing list cfe-commi

[PATCH] D65022: [Sema] Always instantiate the initializer of a variable template with undeduced type (8.0 regression)

erik.pilkington added a comment. Hmm, looks like this patch fails to fix the case where we're referencing the variable in an non-odr use context, since we don't even bother to instantiate the initializer here: template struct S { template static constexpr auto x = 43; }; in

[PATCH] D66198: AMDGPU: Add builtins for is_local/is_private

rampitec added a comment. Didn't you forget to update test/CodeGenOpenCL/amdgpu-features.cl? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66198/new/ https://reviews.llvm.org/D66198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D66149: [BinaryFormat] Teach identify_magic about Tapi files.

cishida abandoned this revision. cishida added a comment. Ran into issue with pushing update to this middle of stack revision. Will create new clean revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66149/new/ https://reviews.llvm.org/D66149

[PATCH] D66149: [BinaryFormat] Teach identify_magic about Tapi files.

cishida updated this revision to Diff 215174. cishida added a comment. Herald added subscribers: openmp-commits, libcxx-commits, lldb-commits, Sanitizers, cfe-commits, jdoerfert, asbirlea, Petar.Avramovic, thopre, jsji, jfb, kadircet, rupprecht, arphaman, atanasyan, jkorous, MaskRay, jrtc27, chr

[PATCH] D66068: cmake: Make building clang-shlib optional

beanz added a reviewer: compnerd. beanz added a comment. In D66068#1628617 , @jvesely wrote: > It duplicates functionality provided by separate/component libraries. The component libraries can't be used the way this can, and this is intended as an insta

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added a comment. I swear this is my last objection :) As soon as this is settled, I'll accept. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegiste

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Charusso marked 2 inline comments as done. Charusso added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimenta

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. You know what, I argued that we should use configs because this flag is incomplete. So I shouldn't be all up and down that it isn't. LGTM! CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D66151: [clang-doc] Fix bitcode writer

DiegoAstiazaran updated this revision to Diff 215193. DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran added a comment. Use getAccess() instead of getAccessUnsafe() for CXXMethodDecl. Add comments in YAML generator to specify that AS_none is used as the default here because it's

[PATCH] D65724: [analyzer] Don't make ConditionBRVisitor events prunable when the condition is an interesting field

Szelethus updated this revision to Diff 215195. Szelethus marked an inline comment as done. Szelethus added a comment. - Make the generic messages in-class, `constexpr` fields. - Provide plenty of test cases for captured lambda variables. In our meeting we had both had a sight of relief, and some

[PATCH] D65724: [analyzer] Don't make ConditionBRVisitor events prunable when the condition is an interesting field

Szelethus marked 4 inline comments as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:192-194 + if (const auto *DRE = dyn_cast(CondVarExpr)) +if (const auto *VD = dyn_cast(DRE->getDecl())) + return State->getSVal(

[PATCH] D65724: [analyzer] Don't make ConditionBRVisitor events prunable when the condition is an interesting field

Szelethus marked 2 inline comments as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:192-194 + if (const auto *DRE = dyn_cast(CondVarExpr)) +if (const auto *VD = dyn_cast(DRE->getDecl())) + return State->getSVal(

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. clang-doc now serializes the inherited attributes and methods, not only the name of the base class.

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

Szelethus added a comment. I have no authority to accept patches in clang-tidy (though please feel free to add me as a reviewer, I can more easily participate in the discussion!), this looks good to me too, thanks! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://revie

r368903 - [OPENMP]Support for non-rectangular loops.

Author: abataev Date: Wed Aug 14 12:30:06 2019 New Revision: 368903 URL: http://llvm.org/viewvc/llvm-project?rev=368903&view=rev Log: [OPENMP]Support for non-rectangular loops. Added basic support for non-rectangular loops. It requires an additional analysis of min/max boundaries for non-rectangu

[PATCH] D66240: Remove LVALUE / RVALUE workarounds

jfb created this revision. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, jkorous. Herald added projects: clang, LLVM. LLVM_HAS_RVALUE_REFERENCE_THIS and LLVM_LVALUE_FUNCTION shouldn't be needed anymore because the minimum compiler versions support them. Repository: rG LLVM

[PATCH] D66049: [analyzer] PR41729: Fix some false positives and improve strlcat and strlcpy modeling

Szelethus added a comment. I agree with @gamesh411 here, would it be much trouble to see how this behaves on a bigger codebase? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66049/new/ https://reviews.llvm.org/D66049 __

[PATCH] D66042: [analyzer] Analysis: Silence checkers

NoQ accepted this revision. NoQ added a comment. Guys, thank you so much for working on establishing consensus on this change. //*bows*// CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66042/new/ https://reviews.llvm.org/D66042 ___ cfe-commi

[PATCH] D66199: [docs] loop pragmas

Meinersbur added inline comments. Comment at: docs/LanguageExtensions.rst:3068-3069 +There are loop hints that control transformations (e.g. vectorization, loop +unrolling) and there loop hints that set transformation options (e.g. +``vectorize_width``, ``unroll_count``). Prag

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Charusso added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D66247: [OpenMP] Fix target map for unused variables

jdenny created this revision. jdenny added reviewers: ABataev, jdoerfert, hfinkel, kkwli0. Herald added a subscriber: guansong. Herald added a project: clang. Without this patch, each of the following `map` clauses doesn't map its variable into the target region because the variable is unused in

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

ABataev updated this revision to Diff 215214. ABataev added a comment. Reworked to keep partial linking to make original host object available for analysis without unbundling. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65819/new/ https://reviews.llvm.org/D658

[clang-tools-extra] r368912 - [clang-doc] Add missing check in tests

Author: diegoastiazaran Date: Wed Aug 14 13:19:33 2019 New Revision: 368912 URL: http://llvm.org/viewvc/llvm-project?rev=368912&view=rev Log: [clang-doc] Add missing check in tests Path is now checked when comparing two Infos in the unit tests. Differential Revision: https://reviews.llvm.org/D66

[PATCH] D66124: [clang-doc] Add missing check in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL368912: [clang-doc] Add missing check in tests (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D65182: [analyzer] Add fix-it hint support.

NoQ marked 3 inline comments as done. NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/PathDiagnostic.h:879 + ArrayRef getFixits() const { return Fixits; } + Szelethus wrote: > Hmm, will this return an immutable conta

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc updated this revision to Diff 215225. mibintc added a comment. I added documentation for the new floating point options into clang/docs Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManua

[PATCH] D66042: [analyzer] Analysis: Silence checkers

NoQ added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D65453: Improve the accuracy of the Clang call graph analysis

NoQ added a comment. For me `ddd()` doesn't call `c::c()`. I can fix it by adding the following code: void VisitCXXConstructExpr(CXXConstructExpr *CE) { addCalledDecl(CE->getConstructor()); VisitChildren(CE); } I don't see why it would work without that code, as `CXXConstructExpr` is

[PATCH] D64564: Loop pragma parsing. NFC.

Meinersbur accepted this revision. Meinersbur added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Parse/ParsePragma.cpp:1010 + StringRef Str = PragmaName.getIdentifierInfo()->getName(); + std::string ClangLoopStr = (Twine("clang loop ")

[PATCH] D66247: [OpenMP] Fix target map for unused variables

ABataev added a comment. Do we really need to map such variables? According to standard, "The map clause specifies how an original list item is mapped from the current task’s data environment to a corresponding list item in the device data environment of the device identified by the construct."

[PATCH] D65453: Improve the accuracy of the Clang call graph analysis

NoQ added inline comments. Comment at: clang/lib/Analysis/CallGraph.cpp:93 void VisitCXXConstructExpr(CXXConstructExpr *E) { CXXConstructorDecl *Ctor = E->getConstructor(); Yes, there it is. Where does it come from? I don't have it in master. Reposito

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Charusso added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D66042: [analyzer] Analysis: Silence checkers

NoQ added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

r368917 - [AMDGPU] Do not assume a default GCN target

Author: rampitec Date: Wed Aug 14 13:55:15 2019 New Revision: 368917 URL: http://llvm.org/viewvc/llvm-project?rev=368917&view=rev Log: [AMDGPU] Do not assume a default GCN target Differential Revision: https://reviews.llvm.org/D66246 Modified: cfe/trunk/lib/Basic/Targets/AMDGPU.cpp cfe/t

[PATCH] D66254: Correct include suggestion when search path includes symlink

puremourning created this revision. puremourning added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, ilya-biryukov. Herald added a project: clang. puremourning added a comment. FYI this fixes the issue in https://github.com/clangd/clangd/issues/124 I haven't added new te

[PATCH] D65724: [analyzer] Don't make ConditionBRVisitor events prunable when the condition is an interesting field

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:192-194 + if (const auto *DRE = dyn_cast(CondVarExpr)) +if (const auto *VD = dyn_cast(DRE->getDecl())) + return State->getSVal(State->getLValue(VD, LCtx)); > Al

[PATCH] D66254: Correct include suggestion when search path includes symlink

puremourning added a comment. FYI this fixes the issue in https://github.com/clangd/clangd/issues/124 I haven't added new tests to HeaderSearchTest.cc because the InMemoryFileSystem doesn't support symlinks and I didn't want to try and implement that for this patch. Let me know thoughts on alte

[PATCH] D65182: [analyzer] Add fix-it hint support.

NoQ updated this revision to Diff 215236. NoQ added a comment. Add a "not implemented yet" assertion for kinds of fixits that are not supported as of that patch (but will definitely need to be supported in the future). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65182/new/ https://r

[PATCH] D66247: [OpenMP] Fix target map for unused variables

jdenny added a comment. In D66247#1630196 , @ABataev wrote: > Do we really need to map such variables? According to standard, "The map > clause specifies how an original list item is mapped from the current task’s > data environment to a corresponding li

[PATCH] D65182: [analyzer] Add fix-it hint support.

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/PathDiagnostic.h:879 + ArrayRef getFixits() const { return Fixits; } + NoQ wrote: > Szelethus wrote: > > Hmm, will this return an immutable container? If not, can

[PATCH] D66247: [OpenMP] Fix target map for unused variables

ABataev added a comment. In D66247#1630245 , @jdenny wrote: > In D66247#1630196 , @ABataev wrote: > > > Do we really need to map such variables? According to standard, "The map > > clause specifies how an original

[PATCH] D65453: Improve the accuracy of the Clang call graph analysis

jcranmer-intel added a comment. Okay, I see the issue now. I originally developed this patch on a fork with a whole lot of extra changes, and that fork included some extra modifications to the callgraph that I had missed: https://github.com/intel/llvm/commit/971fecdc316930c0c1c79283d1094ee4c4ca

[PATCH] D66255: [WebAssembly] Correctly handle va_arg of zero-sized structures

quantum created this revision. quantum added reviewers: dschuff, tlively, sbc100. Herald added subscribers: cfe-commits, sunfish, aheejin, jgravelle-google. Herald added a project: clang. D66168 passes size 0 structs indirectly, while the wasm backend expects it

[PATCH] D66254: Correct include suggestion when search path includes symlink

lebedev.ri added a comment. Tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66254/new/ https://reviews.llvm.org/D66254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D66254: Correct include suggestion when search path includes symlink

puremourning added a comment. In D66254#1630277 , @lebedev.ri wrote: > Tests? Per my comment: I haven't added new tests to HeaderSearchTest.cc because the InMemoryFileSystem doesn't support symlinks and I didn't want to try and implement that for this

[PATCH] D66247: [OpenMP] Fix target map for unused variables

jdenny added a comment. In D66247#1630262 , @ABataev wrote: > In D66247#1630245 , @jdenny wrote: > > > In D66247#1630196 , @ABataev wrote: > > > > > Do we really need to map

[PATCH] D65361: [analyzer] Trust global initializers when analyzing main().

Szelethus added a comment. I really like the high level idea proposed by this patch, and the test files make me believe that its correct as well! I'm really not familiar around this part of the code, so if its okay, I'll take my time to do the usual find references, inserting unreachables/asser

[PATCH] D66254: Correct include suggestion when search path includes symlink

puremourning added a comment. In D66254#1630283 , @puremourning wrote: > In D66254#1630277 , @lebedev.ri > wrote: > > > Tests? > > > Per my comment: I haven't added new tests to HeaderSearchTest.cc because the >

[PATCH] D66255: [WebAssembly] Correctly handle va_arg of zero-sized structures

dschuff added inline comments. Comment at: clang/test/CodeGen/wasm-varargs.c:104 + +struct S test_zero_size_struct(char *fmt, ...) { + va_list va; This should maybe be called "test_empty_struct" since its size is actually 1 and not zero. Comm

[PATCH] D66247: [OpenMP] Fix target map for unused variables

ABataev added a comment. In D66247#1630287 , @jdenny wrote: > In D66247#1630262 , @ABataev wrote: > > > In D66247#1630245 , @jdenny wrote: > > > > > In D66247#1630196

[PATCH] D66247: [OpenMP] Fix target map for unused variables

jdenny added a comment. In D66247#1630321 , @ABataev wrote: > Try `map(a) firstprivate(a) defaultmap(scalar:tofrom)`, where `a` is `int`, > for example. The variable must be mapped as `tofrom` in this case but, most > probably, will be mapped as `to`.

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

Szelethus commandeered this revision. Szelethus edited reviewers, added: rnkovacs; removed: Szelethus. Szelethus added a comment. This revision now requires review to proceed. I'll gladly add the finishing touches :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

RaviNarayanaswamy added inline comments. Comment at: clang/docs/OpenMPSupport.rst:222-226 +| device extension | clause: reverse_offload | :good:`done` | D52780 | ++-

[PATCH] D66247: [OpenMP] Fix target map for unused variables

ABataev added a comment. In D66247#1630333 , @jdenny wrote: > In D66247#1630321 , @ABataev wrote: > > > Try `map(a) firstprivate(a) defaultmap(scalar:tofrom)`, where `a` is `int`, > > for example. The variable must

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

nickdesaulniers accepted this revision. nickdesaulniers added a subscriber: eli.friedman. nickdesaulniers added a comment. This revision is now accepted and ready to land. Great! LGTM and thank you for this patch. Please give 24hrs for @eli.friedman or @kristof.beyls to leave comments before mer

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

Szelethus added a comment. In D63279#1606063 , @baloghadamsoftware wrote: > For me it is all the same whether to continue this patch or taking over > Péter's. Well, there are plenty of comments I'm not sure ever got addressed. We could take an invento

r368929 - [LifetimeAnalysis] Support std::stack::top() and std::optional::value()

Author: mgehre Date: Wed Aug 14 14:55:57 2019 New Revision: 368929 URL: http://llvm.org/viewvc/llvm-project?rev=368929&view=rev Log: [LifetimeAnalysis] Support std::stack::top() and std::optional::value() Summary: Diagnose dangling pointers that come from std::stack::top() and std::optional::val

[PATCH] D66164: [LifetimeAnalysis] Support std::stack::top() and std::optional::value()

This revision was automatically updated to reflect the committed changes. Closed by commit rL368929: [LifetimeAnalysis] Support std::stack::top() and std::optional::value() (authored by mgehre, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D66247: [OpenMP] Fix target map for unused variables

jdenny added a comment. In D66247#1630352 , @ABataev wrote: > Yes, just realized that, defaultmap does not affect explicit firstprivates. > Then just check `map(a) firstprivate(a)` for `int128` type. Check that it > still has `tofrom` mapping. If so, the

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 added a comment. In D65019#1630354 , @nickdesaulniers wrote: > Great! LGTM and thank you for this patch. Please give 24hrs for > @eli.friedman or @kristof.beyls to leave comments before merging. Sounds good! Thanks for all the comments. Repos

[PATCH] D52524: Add -Wno-poison-system-directories flag

denik updated this revision to Diff 215260. denik added a comment. Herald added a subscriber: ormris. Updated the code (removed Diag propagation). Added test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://reviews.llvm.org/D52524 Files: clang/include/clang/Bas

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

aaron.ballman added a comment. There was a request in the linked bug for some code archaeology to see why this behavior exists in the first place. What were the results of that? I'm not opposed to the patch, but I would like to understand why it behaves the way it does. I could imagine "confus

[PATCH] D66240: Remove LVALUE / RVALUE workarounds

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66240/new/ https://reviews.llvm.org/D66240 ___

[PATCH] D66247: [OpenMP] Fix target map for unused variables

ABataev added a comment. In D66247#1630398 , @jdenny wrote: > In D66247#1630352 , @ABataev wrote: > > > Yes, just realized that, defaultmap does not affect explicit firstprivates. > > Then just check `map(a) firstp

[PATCH] D66240: Remove LVALUE / RVALUE workarounds

jfb added a comment. BTW, if this breaks stuff maybe it's better to do it one project at a time, and remove the helper at the very end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66240/new/ https://reviews.llvm.org/D66240 ___

[PATCH] D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

mgehre marked 6 inline comments as done. mgehre added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:102 + dyn_cast_or_null(Record->getDescribedTemplate())) { +if (auto *Def = Record->getDefinition()) + addGslOwnerPointerAttributeIfNotExisting(Context

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

boga95 updated this revision to Diff 215268. boga95 marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59637/new/ https://reviews.llvm.org/D59637 Files: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp test/Analysis/taint-generic.c Index: test/Analysi

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

NoQ added a comment. A quick archaeological dig suggests that i had no concerns with turning on unrolling by default back in 2017: http://lists.llvm.org/pipermail/cfe-dev/2017-August/055221.html - and i don't think i had any new concerns since then. I guess it'll be beneficial to make one more

[PATCH] D52524: Add -Wno-poison-system-directories flag

denik updated this revision to Diff 215271. denik added a comment. Fixed clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://reviews.llvm.org/D52524 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

Szelethus added a comment. In D63279#1630491 , @NoQ wrote: > the only reason it's not enabled by default yet is because we forgot to do > that :( Damn, thats a bummer. It wouldn't be too much trouble to run an analysis and check out whether everythin

[PATCH] D66255: [WebAssembly] Correctly handle va_arg of zero-sized structures

quantum updated this revision to Diff 215272. quantum marked 6 inline comments as done. quantum added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66255/new/ https://reviews.llvm.org/D66255 Files: clang/lib/C

[PATCH] D66255: [WebAssembly] Correctly handle va_arg of zero-sized structures

quantum added inline comments. Comment at: clang/test/CodeGen/wasm-varargs.c:104 + +struct S test_zero_size_struct(char *fmt, ...) { + va_list va; dschuff wrote: > This should maybe be called "test_empty_struct" since its size is actually 1 > and not zero. Done

[PATCH] D65361: [analyzer] Trust global initializers when analyzing main().

NoQ updated this revision to Diff 215274. NoQ marked 3 inline comments as done. NoQ added a comment. Fxd. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65361/new/ https://reviews.llvm.org/D65361 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp clang/test/Analysis/main.c clang

r368939 - Remove LVALUE / RVALUE workarounds

Author: jfb Date: Wed Aug 14 15:48:12 2019 New Revision: 368939 URL: http://llvm.org/viewvc/llvm-project?rev=368939&view=rev Log: Remove LVALUE / RVALUE workarounds Summary: LLVM_HAS_RVALUE_REFERENCE_THIS and LLVM_LVALUE_FUNCTION shouldn't be needed anymore because the minimum compiler versions

[PATCH] D66240: Remove LVALUE / RVALUE workarounds

This revision was automatically updated to reflect the committed changes. Closed by commit rL368939: Remove LVALUE / RVALUE workarounds (authored by jfb, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D66240?vs=215202&id=215275#toc Reposi

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

rnkovacs added a comment. In D60281#1630337 , @Szelethus wrote: > I'll gladly add the finishing touches :) So sorry for leaving this hanging! Thanks Husi, you da best :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6028

[PATCH] D62445: [test] Fix plugin tests

NoQ added a comment. I didn't make much progress so far, but i marked the test as `// UNSUPPORTED: darwin` in rC368765 , so the buildbot is now green starting with http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6519/. Repository: rL LLVM CHA

r368940 - Fix handling of class member access into a vector type.

Author: rsmith Date: Wed Aug 14 15:57:50 2019 New Revision: 368940 URL: http://llvm.org/viewvc/llvm-project?rev=368940&view=rev Log: Fix handling of class member access into a vector type. When handling a member access into a non-class, non-ObjC-object type, we would perform a lookup into the sur

<    1   2   3   >