[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

plotfi marked 4 inline comments as done. plotfi added inline comments. Comment at: clang/include/clang/Driver/Types.h:107 +llvm::opt::DerivedArgList &DAL, ID Id, +llvm::SmallVectorImpl &Phases); compnerd w

r368528 - Properly handle reference initialization when detecting gsl::Pointer initialization chains

Author: xazax Date: Sun Aug 11 01:05:28 2019 New Revision: 368528 URL: http://llvm.org/viewvc/llvm-project?rev=368528&view=rev Log: Properly handle reference initialization when detecting gsl::Pointer initialization chains Modified: cfe/trunk/lib/Sema/SemaInit.cpp cfe/trunk/test/Sema/war

[PATCH] D66059: [clang-format] Expand AllowShortBlocksOnASingleLine for WebKit

MyDeveloperDay added a comment. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66059/new/ https://reviews.llvm.org/D66059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

aheejin added a comment. Thank you! We also have been floating some ideas about supporting reference types as types in another address space, but haven't actually started implementing it AFAIK. I like the general direction. Let's wait for other people's comments too. - Are you planning to land

r368534 - Properly detect temporary gsl::Owners through reference initialization chains.

Author: xazax Date: Sun Aug 11 07:39:42 2019 New Revision: 368534 URL: http://llvm.org/viewvc/llvm-project?rev=368534&view=rev Log: Properly detect temporary gsl::Owners through reference initialization chains. Modified: cfe/trunk/lib/Sema/SemaInit.cpp cfe/trunk/test/Sema/warn-lifetime-an

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

RKSimon added inline comments. Herald added subscribers: llvm-commits, sanjoy.google, bixia. Herald added a project: LLVM. Comment at: cfe/trunk/lib/Sema/SemaDecl.cpp:8416 +// in the CheckFunctionTemplateSpecialization() call below. +if (getLangOpts().CUDA & !isFunctionTe

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

jdenny updated this revision to Diff 214559. jdenny marked 3 inline comments as done. jdenny edited the summary of this revision. jdenny set the repository for this revision to rG LLVM Github Monorepo. jdenny added a comment. In D65835#1624477 , @ABataev wr

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

ABataev added a comment. In D65835#1624610 , @jdenny wrote: > In D65835#1624477 , @ABataev wrote: > > > Try something like `target parallel firstprivate (a) map(a)`. Currently it > > will create a firstprivate copy

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

jdenny added a comment. In D65835#1624615 , @ABataev wrote: > This is wrong. It affects all possible combinations and not only fof scalar > types, all of them are affected. Are you saying the patch isn't sufficient because other types need to be fixed

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

ABataev added a comment. In D65835#1624616 , @jdenny wrote: > In D65835#1624615 , @ABataev wrote: > > > This is wrong. It affects all possible combinations and not only fof scalar > > types, all of them are affecte

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

jdenny added a comment. In D65835#1624617 , @ABataev wrote: > Target teams private map will produce extra private in target context, other > constructs either. Here's what I tried: int a; #pragma omp target teams private(a) map(a) ; The same c

[PATCH] D65149: [Format] Add test demonstrating PR42722

modocache added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5184 + "c++;\n" + "d++\n" + " });\n" MyDeveloperDay wrote: > modocache wrote: > > This is a passing test that demonstrates that t

r368539 - [clang-format] Expand AllowShortBlocksOnASingleLine for WebKit

Author: owenpan Date: Sun Aug 11 10:48:36 2019 New Revision: 368539 URL: http://llvm.org/viewvc/llvm-project?rev=368539&view=rev Log: [clang-format] Expand AllowShortBlocksOnASingleLine for WebKit See PR40840 Differential Revision: https://reviews.llvm.org/D66059 Modified: cfe/trunk/docs/Cl

[PATCH] D66059: [clang-format] Expand AllowShortBlocksOnASingleLine for WebKit

This revision was automatically updated to reflect the committed changes. Closed by commit rL368539: [clang-format] Expand AllowShortBlocksOnASingleLine for WebKit (authored by owenpan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

ABataev added a comment. In D65835#1624619 , @jdenny wrote: > In D65835#1624617 , @ABataev wrote: > > > Target teams private map will produce extra private in target context, > > other constructs either. > > > Here

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

jdenny added a comment. In D65835#1624624 , @ABataev wrote: > In D65835#1624619 , @jdenny wrote: > > > In D65835#1624617 , @ABataev wrote: > > > > > Target teams private map

Re: r368446 - More warnings regarding gsl::Pointer and gsl::Owner attributes

This should be fixed now. On Sat, Aug 10, 2019, 8:08 PM Gábor Horváth wrote: > You are right! > > I will look into this tomorrow. If you think this is urgent feel free to > revert the commits. > > Cheers, > Gabor > > On Sat, Aug 10, 2019, 6:41 PM Nico Weber wrote: > >> Hi Gabor, >> >> this make

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

ABataev added a comment. In D65835#1624629 , @jdenny wrote: > In D65835#1624624 , @ABataev wrote: > > > In D65835#1624619 , @jdenny wrote: > > > > > In D65835#1624617

[PATCH] D65935: [ASTImporter] Import ctor initializers after setting flags.

a_sidorin added a comment. Hello Balazs, Do I understand correctly that it was unset `ToFunction->setLexicalDeclContext(LexicalDC);` that caused lookup problems? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65935/new/ https://reviews.llvm.org/D65

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

Szelethus added reviewers: gamesh411, NoQ. Szelethus added subscribers: gamesh411, NoQ. Szelethus added a comment. + @gamesh411 as he took over this checker before I commited it on his behalf, +@NoQ because he is far more knowledgeable about this part of the analyzer. Comment

[PATCH] D65999: [ASTImporter] Import additional flags for functions.

a_sidorin added a comment. Hello Balazs, The patch looks good in general. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5239 +TEST_P(ASTImporterOptionSpecificTestBase, ImportOfDefaultImplicitFunctions) { + // Test that import of implicit functions works and the functio

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

jdenny added a comment. In D65835#1624659 , @ABataev wrote: > In D65835#1624629 , @jdenny wrote: > > > In D65835#1624624 , @ABataev wrote: > > > > > In D65835#1624619

[PATCH] D65269: [ASTImporter] Fix for import of friend class template with definition.

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65269/new/ https://reviews.llvm.org/D65269 ___

[PATCH] D65373: [clangd] Update features table in the docs with links to LSP extension proposals

nridge added a comment. Review ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65373/new/ https://reviews.llvm.org/D65373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

Re: r368446 - More warnings regarding gsl::Pointer and gsl::Owner attributes

Confirmed, after r368534 the Chromium builds looks good again. (r368528 without r368534 regressed something else, but r368534 fixed things. I'm assuming you don't need a repro for the breakage in r368528 without r368534.) Your warnings even found a bug: https://bugs.chromium.org/p/openscreen/issue

Re: r368446 - More warnings regarding gsl::Pointer and gsl::Owner attributes

Great news! Thanks for all the feedback and patience! :) On Sun, Aug 11, 2019, 4:35 PM Nico Weber wrote: > Confirmed, after r368534 the Chromium builds looks good again. (r368528 > without r368534 regressed something else, but r368534 fixed things. I'm > assuming you don't need a repro for the

r368543 - [X86] Support -march=tigerlake

Author: pengfei Date: Sun Aug 11 18:29:46 2019 New Revision: 368543 URL: http://llvm.org/viewvc/llvm-project?rev=368543&view=rev Log: [X86] Support -march=tigerlake Support -march=tigerlake for x86. Compare with Icelake Client, It include 4 more new features ,they are avx512vp2intersect, movdiri,

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/EnumCastOutOfRangeChecker.cpp:94-98 + // If cast is implicit LValueToRValue, no conversion is taking place, + // and therefore no range check is needed. Don't analyze further. + if (CE->getCastKind() ==

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

NoQ added a comment. My idea here was that this new feature isn't going to be user-facing. We aren't promising to support all combinations of enabled-disabled-silenced-dependent-registercheckerhacks, but instead use the new feature when we know it'll do exactly what we want. It is going to be u

[PATCH] D66067: Push lambda scope earlier when transforming lambda expression

comex created this revision. comex added reviewers: rsmith, faisalv, Mordante. Herald added a project: clang. Herald added a subscriber: cfe-commits. When first parsing a lambda expression, `BuildDeclRefExpr` is called on the parameter declarations with the lambda scope already pushed. But when

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

Charusso added a comment. In D66042#1624684 , @NoQ wrote: > My idea here was that this new feature isn't going to be user-facing. We > aren't promising to support all combinations of > enabled-disabled-silenced-dependent-registercheckerhacks, but instead

[PATCH] D66067: Push lambda scope earlier when transforming lambda expression

comex updated this revision to Diff 214572. comex added a comment. Oops, I forgot to re-run `git diff` after fixing the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66067/new/ https://reviews.llvm.org/D66067 Files: clang/lib/Sema/TreeTransform.h clang/test/SemaTemplate/defa

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

NoQ added a comment. In D66042#1624697 , @Charusso wrote: > `StringRef("osx.cocoa.RetainCountBase").startswith("osx.cocoa.RetainCount")` > is true, so there is no real issue until we manage the prefixes well. I > assume that the user who knows how to dis

[PATCH] D66068: cmake: Make building clang-shlib optional

jvesely created this revision. jvesely added a reviewer: beanz. Herald added a subscriber: mgorny. Herald added a project: clang. It takes ~5min to link, add an option to avoid that. Repository: rC Clang https://reviews.llvm.org/D66068 Files: CMakeLists.txt tools/CMakeLists.txt Index:

[PATCH] D65935: [ASTImporter] Import ctor initializers after setting flags.

balazske added a comment. In this case the problem was that some of the flags of the already created and inserted `ToFunction` are not initialized. During the import of some "ctor initializers" this non-complete ToFunction may be accessed somehow (by structural equivalence or other code) and an