modocache added inline comments.
================ Comment at: clang/unittests/Format/FormatTest.cpp:5184 + " c++;\n" + " d++\n" + " });\n" ---------------- MyDeveloperDay wrote: > modocache wrote: > > This is a passing test that demonstrates that the indentation of `c++` and > > `d++` here is wacky. > in what way do you think its incorrect? change the test to show what it > should be...I think its better to commit a fix and a test at the same time > then its easier for the reviewer and others to understand what you are > driving at. The linked bug report, https://bugs.llvm.org/show_bug.cgi?id=42722, describes what I think the indentation of these two lines should be. I apologize, I should have included the actual code snippet in the commit message here. I am curious if you think the indentation in that bug report is desirable, though, so please let me know! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65149/new/ https://reviews.llvm.org/D65149 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
