[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler

dyung added a comment. In D65974#1623368 , @thakis wrote: > Something like "fix test for out-of-tree targets that don't enable the > internal assembler by default by explicitly passing -fintegrated-as > everywhere" or something like that. Thanks. I had

[PATCH] D65912: [clang-tidy] Add new check for math constants

Eugene.Zelenko added a comment. In D65912#1623375 , @ZaMaZaN4iK wrote: > > ... then I have a script that runs clang-tidy over all the compilation > > units in a compilation database > > Can you share this script please? :) run-clang-tidy.py which is shi

Re: r368459 - Fix a build bot failure and multiple warnings instances for range base for loops

Hmm, strange. Looking into it! If I do not manage to find the root cause in a few minutes I will revert! On Fri, 9 Aug 2019 at 11:32, Jonas Devlieghere wrote: > I think this is causing a stage2 failure: > > http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/124/consoleFull#-95886206949ba46

[PATCH] D65912: [clang-tidy] Add new check for math constants

aaron.ballman added a comment. In D65912#1623393 , @Eugene.Zelenko wrote: > In D65912#1623375 , @ZaMaZaN4iK > wrote: > > > > ... then I have a script that runs clang-tidy over all the compilation > > > units in a

[PATCH] D65987: [clang-doc] Generate HTML links for children namespaces/records

DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:250 + // The resulting path is "../../../A/B/D" instead of a "../D". It is correct + // but it would be better to have the shorter

r368462 - Revert Fix a build bot failure and multiple warnings instances for range base for loops

Author: xazax Date: Fri Aug 9 11:58:09 2019 New Revision: 368462 URL: http://llvm.org/viewvc/llvm-project?rev=368462&view=rev Log: Revert Fix a build bot failure and multiple warnings instances for range base for loops This reverts r368459 (git commit 2bf522aea62e4fb653cacb68072167d25149099e)

r368463 - Revert Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

Author: xazax Date: Fri Aug 9 12:01:23 2019 New Revision: 368463 URL: http://llvm.org/viewvc/llvm-project?rev=368463&view=rev Log: Revert Even more warnings utilizing gsl::Owner/gsl::Pointer annotations This reverts r368454 (git commit 7c3c8ba8daf40534e09f6fe8701b723e25e4e2dc) Modified: cfe

Re: r368459 - Fix a build bot failure and multiple warnings instances for range base for loops

I reverted but I cannot reproduce this locally on a linux box. Is there any way to get more information from the build bot (like preprocessed files?)? On Fri, 9 Aug 2019 at 11:38, Gábor Horváth wrote: > Hmm, strange. Looking into it! If I do not manage to find the root cause > in a few minutes I

r368471 - CodeGen: ensure 8-byte aligned String Swift CF ABI

Author: compnerd Date: Fri Aug 9 12:29:05 2019 New Revision: 368471 URL: http://llvm.org/viewvc/llvm-project?rev=368471&view=rev Log: CodeGen: ensure 8-byte aligned String Swift CF ABI CFStrings should be 8-byte aligned when built for the Swift CF runtime ABI as the atomic CF info field must be

[PATCH] D65974: Update test to explicitly test with -fintegrated-as and -fno-integrated-as and to expect warnings when appropriate.

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lgtm Thanks. I moved your new description into the (previously still stale) revision title and put in a new description. lgtm. Repository: rC Clang CHANGES SINCE LAST ACTION https://rev

Re: r368348 - Fix up fd limit diagnosis code

I'll add std::errc::not_a_directory to the list of ignored errors. On Thu, Aug 8, 2019 at 11:34 PM Martin Storsjö wrote: > This change broke compiling Qt. > > A repro case looks like this: > > mkdir -p fake-qtincl/5.13.1/QtCore/private > touch fake-qtincl/5.13.1/QtCore/private/qglobal_p.h > touc

Re: r368348 - Fix up fd limit diagnosis code

Thanks for taking care of this. I think having a list of "allowed" error codes is more robust long-term than having an explicit list of unexpected error codes, even though if it requires some short-term whack-a-mole. The original change landed after the 9.0 branch, so we have some time for whack-

r368474 - Update test to explicity test with -fintegrated-as and -fno-integrated-as and to expect warnings when appropriate.

Author: dyung Date: Fri Aug 9 12:47:18 2019 New Revision: 368474 URL: http://llvm.org/viewvc/llvm-project?rev=368474&view=rev Log: Update test to explicity test with -fintegrated-as and -fno-integrated-as and to expect warnings when appropriate. Reviewed by: thakis Differential Revision: https

r368475 - Don't diagnose errors when a file matches an include component

Author: rnk Date: Fri Aug 9 12:49:14 2019 New Revision: 368475 URL: http://llvm.org/viewvc/llvm-project?rev=368475&view=rev Log: Don't diagnose errors when a file matches an include component This regressed in r368322, and was reported as PR42948 and on the mailing list. The fix is to ignore the

[PATCH] D65974: Update test to explicitly test with -fintegrated-as and -fno-integrated-as and to expect warnings when appropriate.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368474: Update test to explicity test with -fintegrated-as and -fno-integrated-as and… (authored by dyung, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

Re: r368348 - Fix up fd limit diagnosis code

Let me know if the problem persists after r368475. Someone else filed https://bugs.llvm.org/show_bug.cgi?id=42948 as well. On Thu, Aug 8, 2019 at 11:34 PM Martin Storsjö wrote: > This change broke compiling Qt. > > A repro case looks like this: > > mkdir -p fake-qtincl/5.13.1/QtCore/private > to

[PATCH] D65453: Improve the accuracy of the Clang call graph analysis

NoQ accepted this revision. NoQ edited reviewers, added: NoQ; removed: dergachev.a. NoQ added a comment. This will slightly skew Static Analyzer exploration order, not necessarily in a good way, as default arguments and (sometimes) default initializers are not modeled properly. But this doesn't

[PATCH] D65453: Improve the accuracy of the Clang call graph analysis

NoQ added a comment. Do you have commit access or should i commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65453/new/ https://reviews.llvm.org/D65453 ___ cfe-commits mailing list cfe

[PATCH] D65975: [NewPM][PassInstrumentation] IR printing support from clang driver

fedor.sergeev added a comment. In D65975#1621892 , @twoh wrote: > @fedor.sergeev @yamauchi I saw your discussions over llvm-dev mailing list > regarding IR printing with the new pass manager, and though this might be the > reason why IR printing is not s

Re: r368459 - Fix a build bot failure and multiple warnings instances for range base for loops

The bot is a little special in that it has modules enabled. Maybe that explains it? Let me know if that doesn't work and I can try reproducing locally. On Fri, Aug 9, 2019 at 12:02 PM Gábor Horváth wrote: > > I reverted but I cannot reproduce this locally on a linux box. Is there any > way to ge

[PATCH] D65629: cfi-icall: Allow the jump table to be optionally made non-canonical.

pcc marked 6 inline comments as done. pcc added inline comments. Comment at: clang/test/CodeGen/cfi-icall-canonical-jump-tables.c:15 +// CHECK: define void @g({{.*}} [[ATTR2:#[0-9]+]] +__attribute__((cfi_jump_table_canonical)) void g() {} + eugenis wrote: > would

[PATCH] D65629: cfi-icall: Allow the jump table to be optionally made non-canonical.

pcc updated this revision to Diff 214434. pcc marked 2 inline comments as done. pcc added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65629/new/ https://reviews.llvm.org/D65629 Files: clang/docs/ControlFlow

[PATCH] D66028: [ASTDump] Add is_anonymous to VisitCXXRecordDecl

shafik created this revision. shafik added reviewers: aaron.ballman, aprantl. Adding is_anonymous the ASTDump for `CXXRecordDecl`. This turned out to be useful when debugging some problems with how LLDB creates ASTs from DWARF. https://reviews.llvm.org/D66028 Files: lib/AST/TextNodeDumper.cp

[PATCH] D65180: [analyzer] VirtualCallChecker: Improve warning messages.

NoQ updated this revision to Diff 214441. NoQ added a comment. - Fix checker names for consumers that display them (eg., clang-tidy). Add a test. - Change bug descriptions: "Call to virtual function during construction or destruction" -> "Pure virtual method call" | "Unexpected loss of virtual

[PATCH] D65877: [libTooling] In Transformer, generalize `applyFirst` to admit rules with incompatible matchers.

ymandel updated this revision to Diff 214442. ymandel marked 14 inline comments as done. ymandel added a comment. Rewrote the code and tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65877/new/ https://reviews.llvm.org/D65877 Files: clang/i

[PATCH] D65877: [libTooling] In Transformer, generalize `applyFirst` to admit rules with incompatible matchers.

ymandel marked 2 inline comments as done. ymandel added a comment. Thanks for your detailed and helpful feedback. Comment at: clang/lib/Tooling/Refactoring/Transformer.cpp:129 + Buckets.back().Cases.emplace_back(CaseId, std::move(Case)); } gribozavr wrote:

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

NoQ added a comment. In D64274#1600834 , @Szelethus wrote: > If either checker emits an error, the current implementation would say it > originates from `cplusplus.PureVirtualCall`. Could you please create a new > `ProgramPointTag` with the correct check

[PATCH] D65453: Improve the accuracy of the Clang call graph analysis

jcranmer-intel added a comment. No, I do not have commit access, so if you could commit it, it would be greatly appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65453/new/ https://reviews.llvm.org/D65453 __

[clang-tools-extra] r368482 - [clangd] Give absolute path to clang-tidy and include-fixer. HintPath should always be absolute, some URI schemes care.

Author: sammccall Date: Fri Aug 9 13:45:24 2019 New Revision: 368482 URL: http://llvm.org/viewvc/llvm-project?rev=368482&view=rev Log: [clangd] Give absolute path to clang-tidy and include-fixer. HintPath should always be absolute, some URI schemes care. Modified: clang-tools-extra/trunk/cl

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

JDevlieghere added inline comments. Comment at: clang/include/clang/Driver/Options.td:2012 + HelpText<"Use the virtual file system in 'real' mode, or 'physical' mode. In 'real' mode the working directory is linked to the process' working directory. In 'physical' mode it has it

[clang-tools-extra] r368484 - [clang-doc] Generate an HTML index file

Author: diegoastiazaran Date: Fri Aug 9 13:52:28 2019 New Revision: 368484 URL: http://llvm.org/viewvc/llvm-project?rev=368484&view=rev Log: [clang-doc] Generate an HTML index file clang-doc now generates a file that contains only an index to all the infos that can be used as the landing page fo

[PATCH] D65987: [clang-doc] Generate HTML links for children namespaces/records

DiegoAstiazaran updated this revision to Diff 21. DiegoAstiazaran added a comment. Change the implementation of computeRelativePath CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65987/new/ https://reviews.llvm.org/D65987 Files: clang-tools-extra/clang-doc/HTMLGenerator.cpp clan

[PATCH] D65918: [clang-doc] Generate an HTML index file

This revision was automatically updated to reflect the committed changes. Closed by commit rL368484: [clang-doc] Generate an HTML index file (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D66031: clangd: use -j for background index pool

puremourning created this revision. puremourning added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. clangd supports a -j option to limit the amount of threads to use for parsing TUs. However, when using -bac

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

jfb marked an inline comment as done. jfb added inline comments. Comment at: clang/include/clang/Driver/Options.td:2012 + HelpText<"Use the virtual file system in 'real' mode, or 'physical' mode. In 'real' mode the working directory is linked to the process' working directory.

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

jfb updated this revision to Diff 214448. jfb marked an inline comment as done. jfb added a comment. - Rename option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65986/new/ https://reviews.llvm.org/D65986 Files: clang/include/clang/Driver/Driv

Re: r368348 - Fix up fd limit diagnosis code

Thanks for the fix, Qt does seem to build correctly now again. // Martin On Fri, 9 Aug 2019, Reid Kleckner wrote: Let me know if the problem persists after r368475. Someone else filed  https://bugs.llvm.org/show_bug.cgi?id=42948 as well. On Thu, Aug 8, 2019 at 11:34 PM Martin Storsjö wrote:

[PATCH] D66031: clangd: use -j for background index pool

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Yeah, this is much better than only having `-background-index=no`. I think we should merge this into the 9.0 branch if we still can. Comment at: clang-tools-extra/clan

r368491 - [OpenMP] Add support for close map modifier in Clang

Author: gbercea Date: Fri Aug 9 14:42:13 2019 New Revision: 368491 URL: http://llvm.org/viewvc/llvm-project?rev=368491&view=rev Log: [OpenMP] Add support for close map modifier in Clang Summary: This patch adds support for the close map modifier in Clang. This ensures that the new map type is m

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL368491: [OpenMP] Add support for close map modifier in Clang (authored by gbercea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SIN

[PATCH] D66031: clangd: use -j for background index pool

puremourning added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:152 + std::forward(DBSF), + Opts.AsyncThreadsCount ); +} else { sammccall wrote: > can we use `std::max(Opts.AsyncThreadsCount, 1)` instead? > > Havin

[PATCH] D66031: clangd: use -j for background index pool

puremourning updated this revision to Diff 214454. puremourning marked 3 inline comments as done. puremourning added a comment. When -sync -background-index supplied, use 1 thread for background index. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

kkwli0 added a comment. In D65835#1622042 , @ABataev wrote: > > I want to be sure we're on the same page: For OpenMP 5.0, should we allow > > is_device_ptr with the private clauses? > > Yes, since it is allowed by the standard. Umm ... I probably missed

[PATCH] D66031: clangd: use -j for background index pool

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:152 + std::forward(DBSF), + Opts.AsyncThreadsCount ); +} else { puremourning wrote: > sammccall wrote: > > can we use `std::max(Opts.AsyncThreadsCount, 1)

Re: r368459 - Fix a build bot failure and multiple warnings instances for range base for loops

I tried both with libc++ instead of libstdc++ and modules but none of them reproduced in my local machine I would be glad if you could try it locally as well! Thanks in advance, Gabor On Fri, 9 Aug 2019 at 13:10, Jonas Devlieghere wrote: > The bot is a little special in that it has modules enab

[PATCH] D65629: cfi-icall: Allow the jump table to be optionally made non-canonical.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65629/new/ https://reviews.llvm.org/D65629 _

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. In D65835#1623756 , @kkwli0 wrote: > In D65835#1622042 , @ABataev wrote: > > > > I want to be sure we're on the same page: For OpenMP 5.0, should we allow > > > is_device_ptr with the priva

[PATCH] D65925: [clang-format] Add SpaceInEmptyBlock option for WebKit

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/ClangFormatStyleOptions.rst:2120 +**SpaceInEmptyBlock** (``bool``) + If ``true``, spaces may be inserted into ``{}``. + may

[PATCH] D66031: clangd: use -j for background index pool

puremourning updated this revision to Diff 214460. puremourning marked an inline comment as not done. puremourning added a comment. Herald added subscribers: jfb, javed.absar. Always use physical cores rather than logical cores for best performance. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

xbolva00 added subscribers: hans, xbolva00. xbolva00 added a comment. Maybe this ABI issue should be fixed for 9.0 ? Not sure how important, but @hans maybe should track this one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64672/new/ https://reviews.llvm.org/D64672 ___

[PATCH] D66031: clangd: use -j for background index pool

puremourning marked an inline comment as done. puremourning added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:152 + std::forward(DBSF), + Opts.AsyncThreadsCount ); +} else { sammccall wrote: > puremourning wrote: >

Re: r368459 - Fix a build bot failure and multiple warnings instances for range base for loops

Also, how does this stage2 bot work? I clearly see which revision is being compiled from the logs but it is not apparent to me what is the version of the compiler that is used to compiler it. Is it possible that due to some race condition a compiler before my fix is picked up and that is causing th

[PATCH] D65182: [analyzer] Add fix-it hint support.

NoQ updated this revision to Diff 214462. NoQ retitled this revision from "[analyzer] WIP: Add fix-it hint support." to "[analyzer] Add fix-it hint support.". NoQ added a comment. - Hide all current fixits behind a checker option, have them off by default. They're not tested enough yet. - Suppre

[PATCH] D66031: clangd: use -j for background index pool

puremourning updated this revision to Diff 214463. puremourning added a comment. Rebase on master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66031/new/ https://reviews.llvm.org/D66031 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-t

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

hfinkel added a comment. In D65835#1623772 , @ABataev wrote: > In D65835#1623756 , @kkwli0 wrote: > > > In D65835#1622042 , @ABataev wrote: > > > > > > I want to be sure we'r

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

loladiro updated this revision to Diff 214467. loladiro added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Accidentally only pushed half the changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ https

r368495 - cfi-icall: Allow the jump table to be optionally made non-canonical.

Author: pcc Date: Fri Aug 9 15:31:59 2019 New Revision: 368495 URL: http://llvm.org/viewvc/llvm-project?rev=368495&view=rev Log: cfi-icall: Allow the jump table to be optionally made non-canonical. The default behavior of Clang's indirect function call checker will replace the address of each CF

[PATCH] D65629: cfi-icall: Allow the jump table to be optionally made non-canonical.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368495: cfi-icall: Allow the jump table to be optionally made non-canonical. (authored by pcc, committed by ). Changed prior to commit: https://reviews.llvm.org/D65629?vs=214434&id=214468#toc Repositor

[PATCH] D65182: [analyzer] Add fix-it hint support.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I really like that patch, as no human would rewrite 600 `dyn_cast` and `getAs` to `cast` and `castAs`. Thanks you! Comment at: clang/include/clang/StaticAnalyzer/Checker

[PATCH] D65545: Handle some fs::remove failures

vsapsai accepted this revision. vsapsai added a comment. This revision is now accepted and ready to land. Looks good to me. If in some situations abort on error turns out to be too aggressive, we can change it later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D65043: [Format] Add C++20 standard to style options

sammccall added a comment. Sorry for taking so long here, I've been swamped. Unfortunately there's a couple of pain points still: - this change is (mostly?) about being able to turn off c++20 parsing, so you preserve old desirable formatting of c++17 code. But the tests don't contain any such

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdenny added a comment. In D65835#1623814 , @hfinkel wrote: > In D65835#1623772 , @ABataev wrote: > > > In D65835#1623756 , @kkwli0 wrote: > > > > > In D65835#1622042

[PATCH] D66031: clangd: use -j for background index pool

sammccall accepted this revision. sammccall added a comment. Thanks! Want me to land this for you? Comment at: clang-tools-extra/clangd/ClangdServer.cpp:152 + std::forward(DBSF), + Opts.AsyncThreadsCount ); +} else { puremourning wrote: >

[PATCH] D65361: [analyzer] Trust global initializers when analyzing main().

NoQ updated this revision to Diff 214470. NoQ marked 8 inline comments as done. NoQ added a comment. Fxd! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65361/new/ https://reviews.llvm.org/D65361 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp clang/test/Analysis/main.c clang

[PATCH] D66031: clangd: use -j for background index pool

puremourning added a comment. In D66031#1623855 , @sammccall wrote: > Thanks! Want me to land this for you? yes please! I don't have commit rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66031/new/

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. In D65835#1623854 , @jdenny wrote: > In D65835#1623814 , @hfinkel wrote: > > > In D65835#1623772 , @ABataev wrote: > > > > > In D65835#1623756

[PATCH] D65361: [analyzer] Trust global initializers when analyzing main().

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:630 +(const RegionBindings::TreeTy *)((uintptr_t)store & ~(uintptr_t)1), +RBFactory.getTreeFactory(), (bool)((uintptr_t)store & (uintptr_t)1)); } xazax.hun wro

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdenny added a comment. In D65835#1623858 , @ABataev wrote: > In D65835#1623854 , @jdenny wrote: > > > In D65835#1623814 , @hfinkel wrote: > > > > > In D65835#1623772

[PATCH] D66038: [clangd] Give absolute path to clang-tidy and include-fixer. HintPath should always be absolute, some URI schemes care.

sammccall created this revision. sammccall added reviewers: ilya-biryukov, puremourning. Herald added subscribers: llvm-commits, cfe-commits, jfb, kadircet, arphaman, jkorous, MaskRay, hiraditya. Herald added projects: clang, LLVM. [Support] heavyweight_hardware_concurrency uses affinity when cou

[PATCH] D66038: [clangd] Give absolute path to clang-tidy and include-fixer. HintPath should always be absolute, some URI schemes care.

puremourning added a comment. LGTM :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66038/new/ https://reviews.llvm.org/D66038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

hfinkel added a comment. In D65835#1623814 , @hfinkel wrote: > In D65835#1623772 , @ABataev wrote: > > > In D65835#1623756 , @kkwli0 wrote: > > > > > In D65835#1622042

[clang-tools-extra] r368498 - clangd: use -j for background index pool

Author: sammccall Date: Fri Aug 9 16:03:32 2019 New Revision: 368498 URL: http://llvm.org/viewvc/llvm-project?rev=368498&view=rev Log: clangd: use -j for background index pool Summary: clangd supports a -j option to limit the amount of threads to use for parsing TUs. However, when using -backgro

r368499 - Attempt to reapply "Even more warnings utilizing gsl::Owner/gsl::Pointer annotations"

Author: xazax Date: Fri Aug 9 16:03:50 2019 New Revision: 368499 URL: http://llvm.org/viewvc/llvm-project?rev=368499&view=rev Log: Attempt to reapply "Even more warnings utilizing gsl::Owner/gsl::Pointer annotations" Modified: cfe/trunk/lib/Sema/SemaInit.cpp cfe/trunk/test/Sema/warn-lif

[PATCH] D66038: [Support] heavyweight_hardware_concurrency uses affinity when counting cores fails, and never returns 0

sammccall planned changes to this revision. sammccall added a comment. ugh, I accidentally reused a branch and squashed two patches together. Let me try again... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66038/new/ https://reviews.llvm.org/D66

[PATCH] D66038: [Support] heavyweight_hardware_concurrency uses affinity when counting cores fails, and never returns 0

jfb added a comment. The name of this patch is wrong? Or rather, it's 2 in 1? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66038/new/ https://reviews.llvm.org/D66038 ___ cfe-commits mailing list cfe-c

[PATCH] D66038: [Support] heavyweight_hardware_concurrency uses affinity when counting cores fails, and never returns 0

sammccall updated this revision to Diff 214474. sammccall added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66038/new/ https://reviews.llvm.org/D66038 Files: llvm/include/llvm/Support/Threading.h llvm/lib/Support/Threading.

[PATCH] D66031: clangd: use -j for background index pool

This revision was automatically updated to reflect the committed changes. Closed by commit rL368498: clangd: use -j for background index pool (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D66028: [ASTDump] Add is_anonymous to VisitCXXRecordDecl

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66028/new/ https://reviews.llvm.org/D66028 ___ cfe-commits mailing lis

[PATCH] D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM

dsanders updated this revision to Diff 214476. dsanders added a comment. - Give in on eliding the llvm:: for `using namespace llvm` inside a function They don't appear in the DeclContext and I've been unable to find a way to reasonably detect them Fortunately they don't occur in practice Repos

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

kkwli0 added a comment. In D65835#1623883 , @hfinkel wrote: > In D65835#1623814 , @hfinkel wrote: > > > In D65835#1623772 , @ABataev wrote: > > > > > In D65835#1623756

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. In D65835#1623883 , @hfinkel wrote: > In D65835#1623814 , @hfinkel wrote: > > > In D65835#1623772 , @ABataev wrote: > > > > > In D65835#1623756

[PATCH] D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM

dsanders marked 3 inline comments as done. dsanders added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/PreferRegisterOverUnsignedCheck.cpp:48-51 +for (const auto *UsingDirective: Context->using_directives()) + if (UsingDirective->getNominatedNamespace(

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

jfb updated this revision to Diff 214477. jfb added a comment. - Also update function name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65986/new/ https://reviews.llvm.org/D65986 Files: clang/include/clang/Driver/Driver.h clang/include/clang/

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

jfb abandoned this revision. jfb added a comment. Let's do the better fix that Michael suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65986/new/ https://reviews.llvm.org/D65986 ___ cfe-commit

[PATCH] D65752: [Sema] Refactor LookupVisibleDecls. NFC

sammccall added a comment. This looks reasonable to me, there are a couple of variations you might think about: - also treat QualifiedNameLookup as an option, and override in places with an RAII pattern like `ScopedOverride Unqual(QualifiedNameLookup, false)` (why don't we have a class like th

[PATCH] D65044: [Format] Add option to enable coroutines keywords

sammccall added a comment. Do we have real examples of code that gets formatted incorrectly when parsed as c++20 but lives in a codebase that uses coroutines TS? This seems very niche (and probably short-lived) - do we really need this option? Repository: rG LLVM Github Monorepo CHANGES SIN

[clang-tools-extra] r368500 - [clangd] Disallow extraction of expression-statements.

Author: sammccall Date: Fri Aug 9 16:40:54 2019 New Revision: 368500 URL: http://llvm.org/viewvc/llvm-project?rev=368500&view=rev Log: [clangd] Disallow extraction of expression-statements. Summary: I split out the "extract parent instead of this" logic from the "this isn't worth extracting" log

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

hfinkel added a comment. In D65835#1623903 , @ABataev wrote: > In D65835#1623883 , @hfinkel wrote: > > > In D65835#1623814 , @hfinkel wrote: > > > > > In D65835#1623772

[PATCH] D66031: clangd: use -j for background index pool

sammccall added a subscriber: hans. sammccall added a comment. @hans If you don't mind merging this, it's a nice usability improvement. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66031/new/ https://reviews.llvm.org/D66031

[PATCH] D65337: [clangd] Disallow extraction of expression-statements.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368500: [clangd] Disallow extraction of expression-statements. (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[PATCH] D65925: [clang-format] Add SpaceInEmptyBlock option for WebKit

thakis added a comment. https://webkit.org/code-style-guidelines/ has one instance of `{ }` with a space and one of `{}` without a space, and as far as I can tell no text that says which instance is correct. Are you sure this is the right thing for webkit style? Repository: rC Clang CHANGE

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

rnk created this revision. rnk added a reviewer: rsmith. Herald added a project: clang. Allow implementations to provide complete definitions of std::tuple_size, but to omit the 'value' member to signal that T is not tuple-like. The Microsoft standard library implements std::tuple_size this way.

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. In D65835#1623939 , @hfinkel wrote: > In D65835#1623903 , @ABataev wrote: > > > In D65835#1623883 , @hfinkel wrote: > > > > > In D65835#1623814

Re: r368499 - Attempt to reapply "Even more warnings utilizing gsl::Owner/gsl::Pointer annotations"

http://lab.llvm.org:8011/builders/clang-with-lto-ubuntu/builds/14045 FAILED: tools/clang/lib/Frontend/CMakeFiles/obj.clangFrontend.dir/ASTConsumers.cpp.o /home/buildslave/buildslave1a/clang-with-lto-ubuntu/install/stage1/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MA

Re: r368499 - Attempt to reapply "Even more warnings utilizing gsl::Owner/gsl::Pointer annotations"

Indeed! There pointer is moved later on! Interestingly, I run these warnings on 300+ projects and none of them had this pattern. Will revert or fix the patch soon. On Fri, 9 Aug 2019 at 17:13, Nico Weber wrote: > http://lab.llvm.org:8011/builders/clang-with-lto-ubuntu/builds/14045 > > FAILED: >

r368501 - Fix a false positive warning when initializing members with gsl::Owners.

Author: xazax Date: Fri Aug 9 17:32:29 2019 New Revision: 368501 URL: http://llvm.org/viewvc/llvm-project?rev=368501&view=rev Log: Fix a false positive warning when initializing members with gsl::Owners. Modified: cfe/trunk/lib/Sema/SemaInit.cpp cfe/trunk/test/Sema/warn-lifetime-analysis

Re: r368499 - Attempt to reapply "Even more warnings utilizing gsl::Owner/gsl::Pointer annotations"

It was an easy fix! In case any problem persists I will revert the commit with the fix itself. On Fri, 9 Aug 2019 at 17:16, Gábor Horváth wrote: > Indeed! > > There pointer is moved later on! Interestingly, I run these warnings on > 300+ projects and none of them had this pattern. Will revert or

Re: r368501 - Fix a false positive warning when initializing members with gsl::Owners.

This fixes `+ X(std::unique_ptr up) : pointee(up.get()), pointer(std::move(up)) {}` as well, right? On Fri, Aug 9, 2019 at 8:31 PM Gabor Horvath via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: xazax > Date: Fri Aug 9 17:32:29 2019 > New Revision: 368501 > > URL: http://llvm.org/v

Re: r368501 - Fix a false positive warning when initializing members with gsl::Owners.

It does! Do you want me to commit that test as well? On Fri, 9 Aug 2019 at 17:50, Nico Weber wrote: > This fixes `+ X(std::unique_ptr up) : pointee(up.get()), > pointer(std::move(up)) {}` as well, right? > > On Fri, Aug 9, 2019 at 8:31 PM Gabor Horvath via cfe-commits < > cfe-commits@lists.llvm

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. This patch introduces a new option: `-analyzer-disable-warning`

<    1   2   3   >