Re: r367055 - Revert "Revert "CodeGen: ensure placeholder instruction for cleanup is created""

Merged to release_90 in r367209. On Thu, Jul 25, 2019 at 10:59 PM Saleem Abdulrasool via cfe-commits wrote: > > Author: compnerd > Date: Thu Jul 25 13:59:48 2019 > New Revision: 367055 > > URL: http://llvm.org/viewvc/llvm-project?rev=367055&view=rev > Log: > Revert "Revert "CodeGen: ensure placeh

r367219 - doc: Fix Google C++ Style Guide link.

Author: r.stahl Date: Mon Jul 29 04:00:23 2019 New Revision: 367219 URL: http://llvm.org/viewvc/llvm-project?rev=367219&view=rev Log: doc: Fix Google C++ Style Guide link. Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst URL: http://l

[libunwind] r367223 - Creating release candidate rc1 from release_900 branch

Author: hans Date: Mon Jul 29 06:02:31 2019 New Revision: 367223 URL: http://llvm.org/viewvc/llvm-project?rev=367223&view=rev Log: Creating release candidate rc1 from release_900 branch Added: libunwind/tags/RELEASE_900/ libunwind/tags/RELEASE_900/rc1/ - copied from r367222, libunwi

[libclc] r367223 - Creating release candidate rc1 from release_900 branch

Author: hans Date: Mon Jul 29 06:02:31 2019 New Revision: 367223 URL: http://llvm.org/viewvc/llvm-project?rev=367223&view=rev Log: Creating release candidate rc1 from release_900 branch Added: libclc/tags/RELEASE_900/ libclc/tags/RELEASE_900/rc1/ - copied from r367222, libclc/branch

r367225 - clang-format clang/lib/Format

Author: nico Date: Mon Jul 29 06:26:48 2019 New Revision: 367225 URL: http://llvm.org/viewvc/llvm-project?rev=367225&view=rev Log: clang-format clang/lib/Format Modified: cfe/trunk/lib/Format/BreakableToken.cpp cfe/trunk/lib/Format/Format.cpp cfe/trunk/lib/Format/TokenAnnotator.h

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

chill added a comment. If there are no objections, I'll go ahead with committing that Soon(tm) on the basis of previous acceptance. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64416/new/ https://reviews.llvm.org/D64416 ___ cfe-commits ma

[PATCH] D65387: [clangd] Add a callback mechanism for handling responses from client.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The callback will be invoked in clangd when we receive a reply from the client. unfortunately, we don't have any unittest

[PATCH] D50256: [Analyzer] Basic support for multiplication and division in the constraint manager (for == and != only)

baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added inline comments. Comment at: test/Analysis/multiplicative-folding.c:140-142 +clang_analyzer_eval(n == -1); //expected-warning{{FALSE}} +clang_analyzer_eval(n == 0); //expected-warning{{TRUE}} +

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Thank you! Do you have commit access or would you like me to commit this patch for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64696/new/ https://reviews.llvm.org/D64696

[PATCH] D50256: [Analyzer] Basic support for multiplication and division in the constraint manager (for == and != only)

baloghadamsoftware updated this revision to Diff 212153. baloghadamsoftware added a comment. Fixed error when the result of an integer division is compared to zero. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50256/new/ https://reviews.llvm.org/D50256 Files: include/clang/StaticAna

[PATCH] D65182: [analyzer] WIP: Add fix-it hint support.

baloghadamsoftware added a comment. Hmm, I was thinking on the same for some time but I wonder how many checkers could find the correct fixits? Maybe the removal fixits of double frees or double file closes, but I am afraid that for most of our path-sensitive checks there are no obvious fixits.

[PATCH] D65395: [clangd] Added a skeleton for a semantic highlighting feature to the vscode extension.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. This adds a SemanticHighlighting feature to the vscode extension that does not do anything. It adds the no

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

gribozavr accepted this revision. gribozavr added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:7095 auto *MTE = dyn_cast(L); + if (IsGslPtrInitWithGslTempOwner) { +Diag(DiagLoc, diag::warn_dangling_lifetime_pointer) << DiagRange; I

[PATCH] D49074: [Analyzer] Basic support for multiplication and division in the constraint manager

baloghadamsoftware updated this revision to Diff 212154. baloghadamsoftware added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49074/new/ https://reviews.llvm.org/D49074 Files: include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h lib/Static

[PATCH] D65361: [analyzer] Trust global initializers when analyzing main().

baloghadamsoftware added a comment. Thank you for working on this! I agree, we should trust global initializers in `main()` in C. Can we maybe detect whether GNU global constructors are enabled or better: used? Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:395

[PATCH] D65337: [clangd] Disallow extraction of expression-statements.

SureYeaah added a comment. What was the bug in getCallExpr() ? Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:391 +return false; + Outer->dumpColor(); + // Blacklist the most common places where an expr can appear but be unused.

[PATCH] D65337: [clangd] Disallow extraction of expression-statements.

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:329 while(a < [[1]]) -[[a++]]; +a++; // do while Change to a=[[1]];? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D65349: [analyzer] Be more careful with destructors of non-regions.

baloghadamsoftware added a comment. Yes, it crashes! :-) I tried it because I did not believe it, but it does. Is there any real-world use-case for casting concrete integers to class instances? How did you find this crashing case? Comment at: clang/lib/StaticAnalyzer/Core/Exp

[PATCH] D64488: [Driver] Support -fsanitize=function on Solaris/x86

ro added a comment. Ping^3? Three weeks and counting... Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64488/new/ https://reviews.llvm.org/D64488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

ro added a comment. Ping^2? It's been two weeks now. Who can decide if the LangStandards code can be used from lib/Frontend as is or needs to be moved elsewhere (lib/Basic?) for use by driver code? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64793/new/ https

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65341/new/ https://reviews.llvm.org/D65341 ___ cfe-commits ma

[PATCH] D63954: Add lifetime categories attributes

gribozavr added inline comments. Comment at: cfe/trunk/include/clang/Basic/AttrDocs.td:4252 + +The argument ``T`` is optional and currently ignored. +This attribute may be used by analysis tools and has no effect on code "and is currently ignored" even better:

[PATCH] D65120: More warnings regarding gsl::Pointer and gsl::Owner attributes

gribozavr added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6563 +static bool shouldTrackImplicitObjectArg(const CXXMethodDecl *Callee) { + if (auto *Conv = dyn_cast_or_null(Callee)) This looks like an ad-hoc rule. Is there a way to express it wit

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

Hahnfeld added subscribers: saghir, Hahnfeld. Hahnfeld requested changes to this revision. Hahnfeld added a comment. This revision now requires changes to proceed. There's already D55892 with a better set of tests, including `target enter data` / `target exit dat

[PATCH] D65234: [CodeGen]: don't treat structures returned in registers as memory inputs

glider marked 3 inline comments as done. glider added inline comments. Comment at: clang/test/CodeGen/PR42672.c:50 + struct { +long long int v1, v2, v3, v4; + } str; efriedma wrote: > glider wrote: > > The acceptable size actually depends on the target plat

[PATCH] D65234: [CodeGen]: don't treat structures returned in registers as memory inputs

glider updated this revision to Diff 212164. glider added a comment. Addressed Eli's comments, added a test for a packed struct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65234/new/ https://reviews.llvm.org/D65234 Files: clang/lib/CodeGen/CGS

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

ABataev added a comment. In D65341#1604411 , @Hahnfeld wrote: > There's already D55892 with a better set of > tests, including `target enter data` / `target exit data`. Better to merge those two patches into one. Repo

[PATCH] D62574: Initial draft of target-configurable address spaces.

ebevhan marked 4 inline comments as done. ebevhan added a comment. Sorry for the very late response to this! Comment at: include/clang/AST/ASTContext.h:2598 + /// Returns true if address space A overlaps with B. + bool isAddressSpaceOverlapping(LangAS A, LangAS B) const { +

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

gribozavr added inline comments. Comment at: clang/include/clang/Sema/Sema.h:6097 + + /// Add [[gsl::Owner]] and [[gsl::Pointer]] attributes for std:: types. + void addDefaultGslPointerAttribute(TypedefNameDecl *TD); It seems like this function does not add gsl

r367229 - [OpenCL] Rename builtin definition classes

Author: svenvh Date: Mon Jul 29 07:55:29 2019 New Revision: 367229 URL: http://llvm.org/viewvc/llvm-project?rev=367229&view=rev Log: [OpenCL] Rename builtin definition classes Factor out some of the renames from D63434 and D63442, and generate half type convert_ builtins. Patch by Pierre Gondois

[PATCH] D64849: Add platform guards to PPC vector intrinsics headers.

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64849/new/ https://reviews.llvm.org/D64849 ___ cfe-commits maili

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

gtbercea added a comment. In D65341#1604440 , @ABataev wrote: > In D65341#1604411 , @Hahnfeld wrote: > > > There's already D55892 with a better set > > of tests, including `target

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

eandrews added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61027/new/ https://reviews.llvm.org/D61027 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

kkwli0 added a comment. In D65341#1604561 , @gtbercea wrote: > In D65341#1604440 , @ABataev wrote: > > > In D65341#1604411 , @Hahnfeld > > wrote: > > > > > There's already D

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

gtbercea added a comment. In D65341#1604562 , @kkwli0 wrote: > In D65341#1604561 , @gtbercea wrote: > > > In D65341#1604440 , @ABataev wrote: > > > > > In D65341#1604411

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

kkwli0 added a comment. In D65341#1604562 , @kkwli0 wrote: > In D65341#1604561 , @gtbercea wrote: > > > In D65341#1604440 , @ABataev wrote: > > > > > In D65341#1604411

[PATCH] D65203: [ASTImporter] Do not import FunctionTemplateDecl in record twice.

martong added a comment. @a_sidorin This is a polite Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65203/new/ https://reviews.llvm.org/D65203 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

Mordante added a comment. Thanks for the review. I don't have commit access. So yes please commit the patch for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64696/new/ https://reviews.llvm.org/D64696 ___ cfe-commits mailing list cfe-c

[PATCH] D65130: [clang][OpenMP] Add clang-offload-wrapper tool

sdmitriev added a comment. Any feedback? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65130/new/ https://reviews.llvm.org/D65130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D65403: [COFF, ARM64] Reorder handling of aarch64 MSVC builtins

dmajor created this revision. dmajor added reviewers: mgrang, efriedma, hans. Herald added subscribers: kristina, jfb, kristof.beyls, javed.absar. Herald added a project: clang. In `CodeGenFunction::EmitAArch64BuiltinExpr()`, bulk move of all of the aarch64 MSVC-builtin cases to an earlier point

[PATCH] D65404: [AArch64] Disable __ARM_FEATURE_SVE without ACLE.

sdesmalen created this revision. sdesmalen added reviewers: c-rhodes, chill, rengolin, rovka. Herald added subscribers: kristof.beyls, tschuett, javed.absar. The Arm C Language Extensions for SVE document specifies that __ARM_FEATURE_SVE should be set when the compiler supports SVE and implements

[PATCH] D65405: [Parser] Use special definition for pragma annotations

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall. Herald added a reviewer: jdoerfert. Herald added a project: clang. Previously pragma annotation tokens were described as any other annotations in TokenKinds.def. This change introduces special macro PRAGMA_ANNOTATION for

[PATCH] D64146: [ConstExprPreter][WIP] Initial patch for the constexpr interpreter

nand added a comment. > How do you intend to represent pointers cast to integer types? Allocating 64 > bits of state for a 64-bit integer is insufficient to model that case. Is this ever going to be allowed in constexpr? If that is the case, we'll add a separate type for all integers which are

[PATCH] D65406: [Parser] Change parameter type from int to enum

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall. Herald added a project: clang. Some parser functions accept argument of type unsigned while it is actually of type DeclSpec::TST. No functional changes. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D

[PATCH] D65387: [clangd] Add a callback mechanism for handling responses from client.

ilya-biryukov added a comment. Could you add a bit more context to the description of the change: why do we need the callback and what is the problem with what we have now? I'm sure this was discussed offline and the change is justified, just wanted to make sure we write it down in the change hi

[PATCH] D64932: [Parser] Emit descriptive diagnostic for misplaced pragma

sepavloff updated this revision to Diff 212188. sepavloff added a comment. Updated patch Move logically independent changes to separate patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64932/new/ https://reviews.llvm.org/D64932 Files: cla

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

Nathan-Huckleberry updated this revision to Diff 212189. Nathan-Huckleberry added a comment. - Fix test, formatting and conditional check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64838/new/ https://reviews.llvm.org/D64838 Files: clang/inclu

[PATCH] D64863: [clangd] Ignore diags from builtin files

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Many thanks for fixing this. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:111 -void adjustDiagFromHeader(Diag &D, const clang::Diagnostic &Info,

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

xbolva00 added a comment. Thanks! Better and better:) Change in clang/test/Index/blocks.c seems not ideal, or is it okay? @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64838/new/ https://reviews.llvm.org/D64838 _

[PATCH] D65407: Don't parse elements of extended vectors as template names

ahatanak created this revision. ahatanak added a reviewer: rsmith. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. This patch attempts to fix the bug introduced in r360308, which is causing clang to reject the following piece of code: typedef __attribute__((__ex

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

xbolva00 added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:233 +GNUAttributeLoc = Tok.getLocation(); +MaybeParseGNUAttributes(Attrs); +goto Retry; Since you know that tok is kw_attr, I think you can use 'ParseGNUAttributes'. Repositor

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan marked an inline comment as done. ziangwan added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:11656 + IsListInit = + IsListInit || (isa(OrigE) && S.getLangOpts().CPlusPlus); + aaron.ballman wrote: > Do you want to perform the `isa<>

[PATCH] D65404: [AArch64] Disable __ARM_FEATURE_SVE without ACLE.

rengolin added a comment. I understand (and agree with) the reasoning of this patch, but wouldn't this also make it harder to test the current behaviour? I mean, LLVM doesn't support officially SVE entirely, so there's no point in expecting anything to work for now. What is the coverage of the

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

Nathan-Huckleberry updated this revision to Diff 212198. Nathan-Huckleberry added a comment. - Fix test case spacing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64838/new/ https://reviews.llvm.org/D64838 Files: clang/include/clang/Basic/Attr.t

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/lib/Sema/SemaChecking.cpp:11656 + IsListInit = + IsListInit || (isa(OrigE) && S.getLangOpts().CPlusPlus); + ziangwan wrote: > aaron.ballman wrote: > > Do you want

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

ilya-biryukov added a comment. In D64475#1602195 , @jvikstrom wrote: > In D64475#1593481 , @ilya-biryukov > wrote: > > > The fix for a race condition on remove has landed in rL366577 > >

[PATCH] D64146: [ConstExprPreter][WIP] Initial patch for the constexpr interpreter

jfb added a comment. In D64146#1604717 , @nand wrote: > > How do you intend to represent pointers cast to integer types? Allocating > > 64 bits of state for a 64-bit integer is insufficient to model that case. > > Is this ever going to be allowed in const

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

rnk added a comment. In D64793#1597765 , @ro wrote: > In D64793#1597550 , @jyknight wrote: > > > How about instead just adding "values-xpg6.o" unconditionally, alongside > > the current unconditional "values-Xa.o",

[PATCH] D65343: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs.

tmroeder updated this revision to Diff 212201. tmroeder added a comment. Sync to HEAD to prepare for commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65343/new/ https://reviews.llvm.org/D65343 Files: clang-tools-extra/docs/ReleaseNotes.rst

[PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

echristo created this revision. echristo added reviewers: chandlerc, hfinkel. Herald added subscribers: cfe-commits, jfb, dexonsmith, steven_wu, hiraditya, javed.absar, mcrosier, mehdi_amini. Herald added projects: clang, LLVM. As a follow-up to my initial mail to llvm-dev here's a first pass at

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

jyknight added a comment. > I fear it is necessary: at least it matches documented behaviour of both the > Sun/Oracle Studio compilers and gcc. I will defer to your opinion here. But -- one last attempt at dissuading you. :) Is this really doing something _important_, or is it just legacy cruft

[PATCH] D64146: [ConstExprPreter][WIP] Initial patch for the constexpr interpreter

rsmith added a comment. In D64146#1604717 , @nand wrote: > > How do you intend to represent pointers cast to integer types? Allocating > > 64 bits of state for a 64-bit integer is insufficient to model that case. > > Is this ever going to be allowed in co

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

xazax.hun updated this revision to Diff 212204. xazax.hun marked an inline comment as done. xazax.hun added a comment. - A small refactoring based on an observation from a review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64256/new/ https://reviews.llvm.org/D64256 Files:

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

xazax.hun updated this revision to Diff 212205. xazax.hun marked an inline comment as done. xazax.hun added a comment. - Actually move the code snippet in question. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64256/new/ https://reviews.llvm.org/D64256 Files: clang/include/clang/Bas

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:7095 auto *MTE = dyn_cast(L); + if (IsGslPtrInitWithGslTempOwner) { +Diag(DiagLoc, diag::warn_dangling_lifetime_pointer) << DiagRange; gribozavr wrote: > It is unclear to

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: test/SemaCXX/warn-int-in-bool-context.cpp:96 + + if (f == apple || orange) // expected-warning {{enum constant in boolean context}} +return a; @aaron.ballman : In C (but

[PATCH] D65120: More warnings regarding gsl::Pointer and gsl::Owner attributes

xazax.hun updated this revision to Diff 212206. xazax.hun marked 3 inline comments as done. xazax.hun edited the summary of this revision. xazax.hun added a comment. - Add new line to end of file. - Rebase, calls no longer need special handling. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D65120: More warnings regarding gsl::Pointer and gsl::Owner attributes

xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6563 +static bool shouldTrackImplicitObjectArg(const CXXMethodDecl *Callee) { + if (auto *Conv = dyn_cast_or_null(Callee)) gribozavr wrote: > This looks like an ad-hoc rule. Is there a wa

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6581 +if (!Callee->getIdentifier()) { + auto OO = Callee->getOverloadedOperator(); + return OO == OverloadedOperatorKind::OO_Subscript || ---

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

xazax.hun updated this revision to Diff 212207. xazax.hun edited the summary of this revision. xazax.hun added a comment. - Rebase, add the results of testing on real world projects to the description. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65127/new/ https://reviews.llvm.org/D65

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

xazax.hun added a comment. Thanks for the review! Since I did some refactoring I will wait for an additional accept before committing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64256/new/ https://reviews.llvm.org/D64256 ___ cfe-commits

r367249 - Fix taint-generic.c on Windows, handle case in OS error

Author: rnk Date: Mon Jul 29 11:48:50 2019 New Revision: 367249 URL: http://llvm.org/viewvc/llvm-project?rev=367249&view=rev Log: Fix taint-generic.c on Windows, handle case in OS error Modified: cfe/trunk/test/Analysis/taint-generic.c Modified: cfe/trunk/test/Analysis/taint-generic.c URL:

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

ilya-biryukov added a comment. Mostly final NITs from me, but there is an important one about removing the `erase` call on `didOpen`. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:467 +std::lock_guard Lock(HighlightingsMutex); +FileToHighlightings.erase(File

Re: r367193 - Buildbot fix for r367190

Hello Gabor , It looks like this commit broke tests on couple builders: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/18867/steps/test-check-all/logs/stdio http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast . . . **

Re: r367193 - Buildbot fix for r367190

On Mon, Jul 29, 2019 at 3:03 PM Galina Kistanova via cfe-commits wrote: > > Hello Gabor , > > It looks like this commit broke tests on couple builders: > > http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/18867/steps/test-check-all/logs/stdio > http://lab.llvm.org:80

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dexonsmith. This looks fine to me, but I'd like to have someone else familiar with the Driver/Frontend design sign off too. The implementation is trivial but I'd li

[PATCH] D65403: [COFF, ARM64] Reorder handling of aarch64 MSVC builtins

efriedma added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:8182 switch (BuiltinID) { default: return nullptr; case NEON::BI__builtin_neon_vbsl_v: I'm a little concerned about the overall code structure here; even if moving the code for the MS

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked an inline comment as done. lildmh added a comment. Thanks Alexey! Could you look into the runtime patch D60972 then? Comment at: test/OpenMP/declare_mapper_codegen.cpp:44-48 +// CK0-DAG: store i8* %0, i8** [[HANDLEADDR:%[^,]+]] +

Re: [clang-tools-extra] r367137 - [clang-format] Fix style of css file paths

Hello Diego, This commit added broken test to one of our win builders: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/27202 . . . Failing Tests (4): Extra Tools Unit Tests :: clang-doc/./ClangDocTests.exe/HTMLGeneratorTest.emitRecordHTML . . .

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

leonardchan abandoned this revision. leonardchan added a comment. Replaced with D65110 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63174/new/ https://reviews.llvm.org/D63174 ___

[PATCH] D65403: [COFF, ARM64] Reorder handling of aarch64 MSVC builtins

dmajor marked an inline comment as done. dmajor added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:8182 switch (BuiltinID) { default: return nullptr; case NEON::BI__builtin_neon_vbsl_v: efriedma wrote: > I'm a little concerned about the overall

Re: r367193 - Buildbot fix for r367190

Looks good to me. Thanks for the fix. Aaron Ballman ezt írta (időpont: 2019. júl. 29., H, 21:06): > On Mon, Jul 29, 2019 at 3:03 PM Galina Kistanova via cfe-commits > wrote: > > > > Hello Gabor , > > > > It looks like this commit broke tests on couple builders: > > > > > http://lab.llvm.org:801

[PATCH] D65403: [COFF, ARM64] Reorder handling of aarch64 MSVC builtins

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/CodeGen/CGBuiltin.cpp:8182 switch (BuiltinID) { default: return nullptr; case NEON::BI__builtin_neon_vbsl_v: dmajor wrote:

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

jhibbits requested review of this revision. jhibbits added a comment. Should've marked it as need review earlier. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49754/new/ https://reviews.llvm.org/D49754 ___ cfe-commi

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

xbolva00 added a comment. Some ICC behaviour.. icc -dumpversion 19.0.3.199 printf("%d %d %s", __GNUC__, __GNUC_MINOR__, __VERSION__); ./a.out 7 4 Intel(R) C++ gcc 7.4 mode Should we bump __GNUC__, __GNUC_MINOR__ too? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org

r367253 - [driver][test] Update as-options.s to not write to a readonly tree

Author: rupprecht Date: Mon Jul 29 12:57:31 2019 New Revision: 367253 URL: http://llvm.org/viewvc/llvm-project?rev=367253&view=rev Log: [driver][test] Update as-options.s to not write to a readonly tree The as-options.s test writes to the build tree as of r367165. Some build systems configure th

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: test/OpenMP/declare_mapper_codegen.cpp:44-48 +// CK0-DAG: store i8* %0, i8** [[HANDLEADDR:%[^,]+]] +// CK0-DAG: store i8* %1, i8** [[BPTRADDR:%[^,]+]] +// CK0-DAG: store i8* %2, i8** [[VPTRADDR:%[^,]+]] +// CK0-DAG: store i64 %3, i{{64|3

r367254 - When determining whether a lambda-expression is implicitly constexpr,

Author: rsmith Date: Mon Jul 29 12:59:45 2019 New Revision: 367254 URL: http://llvm.org/viewvc/llvm-project?rev=367254&view=rev Log: When determining whether a lambda-expression is implicitly constexpr, check the formal rules rather than seeing if the normal checks produce a diagnostic. This fixe

r367255 - Give the 'signed/unsigned wchar_t' extension a warning flag, and follow

Author: rsmith Date: Mon Jul 29 13:00:46 2019 New Revision: 367255 URL: http://llvm.org/viewvc/llvm-project?rev=367255&view=rev Log: Give the 'signed/unsigned wchar_t' extension a warning flag, and follow GCC 9 in promoting it to an error by default. Modified: cfe/trunk/include/clang/Basic/Di

[PATCH] D64146: [ConstExprPreter][WIP] Initial patch for the constexpr interpreter

nand marked 10 inline comments as done. nand added a comment. We can add a separate integer type which tracks all the additional information required by `__builtin_constant_p` and compile all integers to it in this context. A later patch added an APInt fallback to the interpreter if an integral

r367256 - [driver][test] Use /dev/null in as-options.s instead

Author: rupprecht Date: Mon Jul 29 13:09:20 2019 New Revision: 367256 URL: http://llvm.org/viewvc/llvm-project?rev=367256&view=rev Log: [driver][test] Use /dev/null in as-options.s instead Modified: cfe/trunk/test/Driver/as-options.s Modified: cfe/trunk/test/Driver/as-options.s URL: http://

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

xbolva00 added a comment. https://bugs.llvm.org/show_bug.cgi?id=42817 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: test/OpenMP/declare_mapper_codegen.cpp:44-48 +// CK0-DAG: store i8* %0, i8** [[HANDLEADDR:%[^,]+]] +// CK0-DAG: store i8* %1, i8** [[BPTRADDR:%[^,]+]] +// CK0-DAG: store i8* %2, i8** [[VPTRADDR:%[^

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: test/OpenMP/declare_mapper_codegen.cpp:44-48 +// CK0-DAG: store i8* %0, i8** [[HANDLEADDR:%[^,]+]] +// CK0-DAG: store i8* %1, i8** [[BPTRADDR:%[^,]+]] +// CK0-DAG: store i8* %2, i8** [[VPTRADDR:%[^,]+]] +// CK0-DAG: store i64 %3, i{{64|3

[PATCH] D65192: [Sema] Disable some enabled-by-default -Wparentheses diagnostics

jyknight added a comment. I'm not sure the history behind why these were added as default-on warningsthey don't really seem appropriate as default warnings to me, either. But I think someone else probably ought to approve the change. Repository: rC Clang CHANGES SINCE LAST ACTION htt

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: test/OpenMP/declare_mapper_codegen.cpp:44-48 +// CK0-DAG: store i8* %0, i8** [[HANDLEADDR:%[^,]+]] +// CK0-DAG: store i8* %1, i8** [[BPTRADDR:%[^,]+]] +// CK0-DAG: store i8* %2, i8** [[VPTRADDR:%[^

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

rnk added a comment. In D63048#1605050 , @xbolva00 wrote: > Should we bump __GNUC__, __GNUC_MINOR__ too? We discussed this two weeks ago: http://lists.llvm.org/pipermail/cfe-dev/2019-July/062890.html It's unlikely that we will make any policy change befo

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: test/OpenMP/declare_mapper_codegen.cpp:44-48 +// CK0-DAG: store i8* %0, i8** [[HANDLEADDR:%[^,]+]] +// CK0-DAG: store i8* %1, i8** [[BPTRADDR:%[^,]+]] +// CK0-DAG: store i8* %2, i8** [[VPTRADDR:%[^,]+]] +// CK0-DAG: store i64 %3, i{{64|3

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

ilya-biryukov added a comment. @rsmith, emitting the typos on pop expression evaluation context resulted in a bunch of failures when trying to transform the resulting errors, see a typical stacktrace below. It seems we can actually pop expression evaluation contexts between producing and corre

[PATCH] D65419: [clang-doc] Fix failing tests on Windows

DiegoAstiazaran created this revision. DiegoAstiazaran added a reviewer: juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Tests on Windows were failing due to path separator differences. Links in HTML should use posix-style paths. https://reviews.llvm.org/D65419 Files: clang-

  1   2   >