Looks good to me. Thanks for the fix. Aaron Ballman <aa...@aaronballman.com> ezt írta (időpont: 2019. júl. 29., H, 21:06):
> On Mon, Jul 29, 2019 at 3:03 PM Galina Kistanova via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > > > Hello Gabor , > > > > It looks like this commit broke tests on couple builders: > > > > > http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/18867/steps/test-check-all/logs/stdio > > > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast > > . . . > > ******************** > > Failing Tests (1): > > Clang :: Analysis/taint-generic.c > > > > > > Please have a look? > > These builders were already red and did not send any notifications. > > I think Reid fixed this in r367249 > (http://llvm.org/viewvc/llvm-project?view=revision&revision=367249). > > ~Aaron > > > > > Thanks > > > > Galina > > > > On Sun, Jul 28, 2019 at 8:00 AM Gabor Borsik via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> > >> Author: boga95 > >> Date: Sun Jul 28 07:57:41 2019 > >> New Revision: 367193 > >> > >> URL: http://llvm.org/viewvc/llvm-project?rev=367193&view=rev > >> Log: > >> Buildbot fix for r367190 > >> > >> Modified: > >> cfe/trunk/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp > >> > >> Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp > >> URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp?rev=367193&r1=367192&r2=367193&view=diff > >> > ============================================================================== > >> --- cfe/trunk/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp > (original) > >> +++ cfe/trunk/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp Sun > Jul 28 07:57:41 2019 > >> @@ -811,7 +811,7 @@ void ento::registerGenericTaintChecker(C > >> llvm::Optional<TaintConfig> Config = > >> getConfiguration<TaintConfig>(Mgr, Checker, Option, ConfigFile); > >> if (Config) > >> - Checker->parseConfiguration(Mgr, Option, > std::move(Config).getValue()); > >> + Checker->parseConfiguration(Mgr, Option, > std::move(Config.getValue())); > >> } > >> > >> bool ento::shouldRegisterGenericTaintChecker(const LangOptions &LO) { > >> > >> > >> _______________________________________________ > >> cfe-commits mailing list > >> cfe-commits@lists.llvm.org > >> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > > > > _______________________________________________ > > cfe-commits mailing list > > cfe-commits@lists.llvm.org > > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
