kkwli0 added a comment. In D65341#1604562 <https://reviews.llvm.org/D65341#1604562>, @kkwli0 wrote:
> In D65341#1604561 <https://reviews.llvm.org/D65341#1604561>, @gtbercea wrote: > > > In D65341#1604440 <https://reviews.llvm.org/D65341#1604440>, @ABataev wrote: > > > > > In D65341#1604411 <https://reviews.llvm.org/D65341#1604411>, @Hahnfeld > > > wrote: > > > > > > > There's already D55892 <https://reviews.llvm.org/D55892> with a better > > > > set of tests, including `target enter data` / `target exit data`. > > > > > > > > > Better to merge those two patches into one. > > > > > > How would you like me to proceed? It looks like the other patch has been > > sitting there approved for many many months. > > > Yes, the patch has been waiting for the runtime implementation first and then > commit. I am not sure if it is easier to rebase D55892 <https://reviews.llvm.org/D55892> and merge this patch to D55892 <https://reviews.llvm.org/D55892>. I am okay to go either way. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65341/new/ https://reviews.llvm.org/D65341 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
