[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

m4tx added a comment. @JonasToth thanks for asking! Yes, since I do not have commit access, I need someone to do the commit for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55793/new/ https://reviews.llvm.org/D55793 ___ cfe-commits ma

[PATCH] D61256: [clang-format][docs] Fix the Google C++ and Chromium style guide URLs

m4tx added a comment. @MyDeveloperDay thanks for accepting the revision! Since I do not have commit access, could you please make the commit for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61256/new/ https://reviews.llvm.org/D61256 __

[PATCH] D62962: Clang implementation of sizeless types

rsandifo-arm marked 4 inline comments as done. rsandifo-arm added a comment. Thanks for the review. In D62962#1534528 , @jfb wrote: > How do these types mangle? At the moment, the mangling is only defined for the Itanium ABI, which uses `str(len(name))

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon updated this revision to Diff 203785. Fznamznon added a comment. Applied comments from @Anastasia - Added link to documentation for `sycl_device` attribute - Removed redundant comment from test @Anastasia, do you have additional comments? Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D63018: [X86] Attempt to make the Intel core CPU inheritance a little more readable and maintainable

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - the goto is unfortunate but more maintainable and less confusing then the current state of things Comment at: clang/lib/Basic/Targets/X86.cpp:157 +setFeatureEna

r362924 - Revert "Revert "[CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods.""

Author: sammccall Date: Mon Jun 10 02:52:09 2019 New Revision: 362924 URL: http://llvm.org/viewvc/llvm-project?rev=362924&view=rev Log: Revert "Revert "[CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods."" This reverts commit r362830, and relands r362785 with th

Re: r362785 - [CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods.

Thanks! Re-landed in r362924. On Fri, Jun 7, 2019 at 9:15 PM Vlad Tsyrklevich via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This change caused LSan failures and has been reverted in r362830: > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/32809 > > On Fri, Jun 7, 2

[PATCH] D63072: [clang] Fixing incorrect implicit deduction guides (PR41549)

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. bug report Before this patch, implicit deduction guides were generated from the first declaration found by lookup. Wit

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

Hahnfeld added a comment. As for D63010 , the new function isn't used anywhere (and hence cannot be tested). What's the advantage of splitting changes at such granularity? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63009/new/

[clang-tools-extra] r362934 - [clangd] Stop marshalling/requiring FormattingOptions. We never did anything with them.

Author: sammccall Date: Mon Jun 10 06:01:49 2019 New Revision: 362934 URL: http://llvm.org/viewvc/llvm-project?rev=362934&view=rev Log: [clangd] Stop marshalling/requiring FormattingOptions. We never did anything with them. Modified: clang-tools-extra/trunk/clangd/Protocol.cpp clang-tool

[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

jdoerfert updated this revision to Diff 203818. jdoerfert added a comment. Use worklist instead of recursion, add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59919/new/ https://reviews.llvm.org/D59919 Files: clang/test/CodeGenOpenCL/as_t

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

sammccall marked 3 inline comments as done. sammccall added a comment. OK, this has been stuck for a while and (as discussed a bit offline) I haven't been able to make the alternative approaches work. In D60605#1495268 , @yvvan wrote: > @ilya-biryukov >

[clang-tools-extra] r362939 - [clangd] Revamp textDocument/onTypeFormatting.

Author: sammccall Date: Mon Jun 10 07:26:21 2019 New Revision: 362939 URL: http://llvm.org/viewvc/llvm-project?rev=362939&view=rev Log: [clangd] Revamp textDocument/onTypeFormatting. Summary: The existing implementation (which triggers on }) is fairly simple and has flaws: - doesn't trigger freq

[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

jdoerfert updated this revision to Diff 203819. jdoerfert marked 2 inline comments as done. jdoerfert added a comment. Fix Typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59919/new/ https://reviews.llvm.org/D59919 Files: clang/test/CodeGenOpe

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rL362939: [clangd] Revamp textDocument/onTypeFormatting. (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-comm

r362944 - Revert "[CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods."

Author: sammccall Date: Mon Jun 10 07:55:57 2019 New Revision: 362944 URL: http://llvm.org/viewvc/llvm-project?rev=362944&view=rev Log: Revert "[CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods." This reverts commit r362924, which causes a double-free of Shadow

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62739/new/ https://reviews.llvm.org/D62739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r362950 - Re-land "[CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods."

Author: sammccall Date: Mon Jun 10 08:17:52 2019 New Revision: 362950 URL: http://llvm.org/viewvc/llvm-project?rev=362950&view=rev Log: Re-land "[CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods." ShadowMapEntry is now really, truly a normal class. Modified:

[PATCH] D63080: [analyzer] Track indices of arrays

Szelethus created this revision. Szelethus added reviewers: NoQ, dcoughlin, xazax.hun, rnkovacs, baloghadamsoftware, Charusso. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Observe the test

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

AlexEichenberger added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:610 + // size_t sizeof_shareds, kmp_routine_entry_t *task_entry, + // size_t device_id); + OMPRTL__kmpc_omp_target_task_alloc, device_id is int64_t Comment a

[PATCH] D63072: [clang] Fixing incorrect implicit deduction guides (PR41549)

rsmith added inline comments. Comment at: clang/test/SemaCXX/cxx1z-class-template-argument-deduction.cpp:503 + +umm<> m(1); + Should this be using CTAD? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63072/new/ https://reviews.ll

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

Manikishan updated this revision to Diff 203833. Manikishan added a subscriber: mgorny. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63062/new/ https://reviews.llvm.org/D63062 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8729 +/// \code +/// void .omp_mapper...(void *rt_mapper_handle, +/// void *base, void *begin, This function looks like the universal one, regardl

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

ABataev added a comment. This patches does not add any functionality. I thought, it was published by an accident. The patch should be abandoned or reworked to add a functional part of the code. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63009/new/ https://re

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

mgorny requested changes to this revision. mgorny added inline comments. This revision now requires changes to proceed. Comment at: docs/ClangFormatStyleOptions.rst:195 +**BitFieldDeclsOnSeparateLines** (``bool``) + If ``true``, Align Bitfield Declarations on seperate lines. + -

[PATCH] D63081: [WebAssembly] Cleanup toolchain test files. NFC.

sbc100 created this revision. Herald added subscribers: cfe-commits, jfb, sunfish, aheejin, jgravelle-google, dschuff. Herald added a project: clang. sbc100 added a reviewer: dschuff. Herald added a subscriber: ormris. Split up long lines to improve test readability. Repository: rG LLVM Githu

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 created this revision. xbolva00 added reviewers: rsmith, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. I consider -Wint-in-bool-context as quite useful warning so I ported it to Clang. -Wint-in-bool-context is on by default, it is part of GCC's -Wall so I m

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 added a subscriber: RKSimon. xbolva00 added a comment. Adding @RKSimon as a reviewer since he recently fixed some bugs which GCC's -Wint-in-bool-context caught. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63082/new/ https://reviews.llvm.org/D63082

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

Manikishan updated this revision to Diff 203838. Manikishan marked 4 inline comments as done. Manikishan added a comment. Added unittests and made the changes suggested by @mgorny Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63062/new/ https://reviews.llvm.org/D

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 updated this revision to Diff 203839. xbolva00 added a comment. Removed unrelated change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63082/new/ https://reviews.llvm.org/D63082 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib

[PATCH] D62244: [AMDGPU] Enable the implicit arguments for HIP (CLANG)

hliao added inline comments. Comment at: test/CodeGenCUDA/amdgpu-hip-implicit-kernarg.cu:7 + +// CHECK-DAG: attributes #0 = { noinline nounwind optnone "amdgpu-implicitarg-num-bytes"="48" For a single check, you don't need CHECK-DAG. CHANGES SINCE LAST ACTION

r362959 - [WebAssembly] Cleanup toolchain test files. NFC.

Author: sbc Date: Mon Jun 10 09:18:04 2019 New Revision: 362959 URL: http://llvm.org/viewvc/llvm-project?rev=362959&view=rev Log: [WebAssembly] Cleanup toolchain test files. NFC. Summary: Split up long lines to improve test readability. Subscribers: dschuff, jgravelle-google, aheejin, sunfish, j

[PATCH] D62363: [X86] Enable intrinsics that convert float and bf16 data to each other

craig.topper accepted this revision. craig.topper added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62363/new/ https://reviews.llvm.org/D62363 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

Manikishan updated this revision to Diff 203841. Manikishan added a comment. Made some missing style modifications in the last revision Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63062/new/ https://reviews.llvm.org/D63062 Files: docs/ClangFormatStyleOptions

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8729 +/// \code +/// void .omp_mapper...(void *rt_mapper_handle, +/// void *base, void *begin, ABataev wro

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

yaxunl added a comment. My concern is that this essentially forcing user to add amdgpu_flat_work_group_size attribute to all kernels that are executed outside of (128,256). Potentially this can cause lots of regressions for existing OpenCL apps. I am not sure if it is feasible to force all Open

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

b-sumner added a comment. We need to communicate with anyone generating IR to ensure this is being generated before we change the default. clang is only one of those generators. This change will also need to be documented in the usage document. CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8729 +/// \code +/// void .omp_mapper...(void *rt_mapper_handle, +/// void *base, void *begin, lildmh wrote: > ABataev wrote: > > This function lo

[PATCH] D63081: [WebAssembly] Cleanup toolchain test files. NFC.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL362959: [WebAssembly] Cleanup toolchain test files. NFC. (authored by sbc, committed by ). Herald added a project: LLVM. H

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8729 +/// \code +/// void .omp_mapper...(void *rt_mapper_handle, +/// void *base, void *begin, ABataev wro

r362965 - [X86] Attempt to make the Intel core CPU inheritance a little more readable and maintainable

Author: ctopper Date: Mon Jun 10 09:59:28 2019 New Revision: 362965 URL: http://llvm.org/viewvc/llvm-project?rev=362965&view=rev Log: [X86] Attempt to make the Intel core CPU inheritance a little more readable and maintainable The recently added cooperlake CPU has made our already ugly switch st

[PATCH] D63018: [X86] Attempt to make the Intel core CPU inheritance a little more readable and maintainable

This revision was automatically updated to reflect the committed changes. Closed by commit rL362965: [X86] Attempt to make the Intel core CPU inheritance a little more readable and… (authored by ctopper, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8729 +/// \code +/// void .omp_mapper...(void *rt_mapper_handle, +/// void *base, void *begin, lildmh wrote: > ABataev wrote: > > lildmh wrote: >

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

eandrews updated this revision to Diff 203854. eandrews edited the summary of this revision. eandrews added a reviewer: rsmith. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61027/new/ https://reviews.llvm.org/D61027 Files: lib/AST/Expr.cpp lib/Sema/SemaChecking.cpp test/SemaTempla

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8729 +/// \code +/// void .omp_mapper...(void *rt_mapper_handle, +/// void *base, void *begin, ABataev wro

[PATCH] D62962: Clang implementation of sizeless types

jfb added inline comments. Comment at: test/Sema/sizeless-1.c:66 + _Static_assert(__atomic_always_lock_free(1, &local_int8) == __atomic_always_lock_free(1, incomplete_ptr), ""); + _Static_assert(__atomic_always_lock_free(2, &local_int8) == __atomic_always_lock_free(2, incompl

[PATCH] D62960: SVE opaque type for C intrinsics demo

jfb added subscribers: rjmccall, jfb. jfb added a comment. Tests? Comment at: lib/AST/ItaniumMangle.cpp:2680 +break; +#include "clang/Basic/AArch64SVEACLETypes.def" } @rjmccall you probably should review this part. Repository: rC Clang CHANGES SINCE

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8729 +/// \code +/// void .omp_mapper...(void *rt_mapper_handle, +/// void *base, void *begin, lildmh wrote: > ABataev wrote: > > lildmh wrote: >

[PATCH] D63041: [PlistSupport] Produce a newline to end plist output files

xingxue accepted this revision. xingxue added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63041/new/ https://reviews.llvm.org/D63041 ___ cfe-commits

[PATCH] D62960: SVE opaque type for C intrinsics demo

erik.pilkington added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:2680 +break; +#include "clang/Basic/AArch64SVEACLETypes.def" } jfb wrote: > @rjmccall you probably should review this part. Sorry for the drive by comment, but: All of these mangl

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8729 +/// \code +/// void .omp_mapper...(void *rt_mapper_handle, +/// void *base, void *begin, ABataev wro

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

beanz added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:812 +# llvm::PassPluginLibraryInfo ${entry_point}(); +add_custom_target(LLVM_PLUGINS) # target used to hold global properties referencable from generator-expression +function(register_llvm_extension

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

Manikishan updated this revision to Diff 203860. Manikishan marked 4 inline comments as done. Manikishan added a comment. Updated unittest Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63062/new/ https://reviews.llvm.org/D63062 Files: docs/ClangFormatStyleOpti

[PATCH] D62962: Clang implementation of sizeless types

rsandifo-arm marked 2 inline comments as done. rsandifo-arm added inline comments. Comment at: test/Sema/sizeless-1.c:66 + _Static_assert(__atomic_always_lock_free(1, &local_int8) == __atomic_always_lock_free(1, incomplete_ptr), ""); + _Static_assert(__atomic_always_lock_free(

[PATCH] D63072: [clang] Fixing incorrect implicit deduction guides (PR41549)

Tyker updated this revision to Diff 203862. Tyker added a comment. fixed the issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63072/new/ https://reviews.llvm.org/D63072 Files: clang/lib/Sema/SemaTemplate.cpp clang/test/SemaCXX/cxx1z-class-template-argument-deduction.cpp Index

[PATCH] D62962: Clang implementation of sizeless types

jfb added inline comments. Comment at: test/Sema/sizeless-1.c:66 + _Static_assert(__atomic_always_lock_free(1, &local_int8) == __atomic_always_lock_free(1, incomplete_ptr), ""); + _Static_assert(__atomic_always_lock_free(2, &local_int8) == __atomic_always_lock_free(2, incompl

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

rnk added a subscriber: dexonsmith. rnk added a comment. Personally, I think it's safe to do this. I believe this "4.2.1" compat thing was something Apple added as part of their switch from GCC, and then llvm-gcc, over to Clang, and I think most of the code they care about probably doesn't rely

[PATCH] D63085: Provide a fix-it hint for -Wswitch, which adds missing cases. If there are >3 cases, the inserted text will contain newlines so it will not be shown in console output (but will be appl

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Lifted the helper for spelling one scope from another from SemaCodeComplete -> AST, to reuse it. It should be usef

[PATCH] D61749: [clang-tidy] initial version of readability-static-const-method

mgehre added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61749/new/ https://reviews.llvm.org/D61749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D63086: [analyzer][NoStoreFuncVisitor][NFC] Move methods out-of-line, turn some to static functions

Szelethus created this revision. Szelethus added reviewers: NoQ, dcoughlin, xazax.hun, rnkovacs, Charusso, baloghadamsoftware. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. I personally foun

[PATCH] D63088: [clang-tidy] misc-unused-parameters: don't comment out parameter name for C code

mgehre created this revision. mgehre added reviewers: klimek, ilya-biryukov, lebedev.ri, aaron.ballman. Herald added a subscriber: xazax.hun. Herald added a project: clang. The fixit `int square(int /*num*/)` yields `error: parameter name omitted` for C code. Enable it only for C++ code. Reposi

[PATCH] D63088: [clang-tidy] misc-unused-parameters: don't comment out parameter name for C code

mgehre updated this revision to Diff 203873. mgehre added a comment. Fix rewrapped comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63088/new/ https://reviews.llvm.org/D63088 Files: clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cp

[PATCH] D63089: [clang] Warn on implicit boolean casts in more contexts (PR34180)

m4tx created this revision. m4tx added reviewers: lebedev.ri, rsmith, klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. int x; return x = 5; For a code like above, GCC produces a warning suggesting using parentheses about the assignment. This change makes clang p

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Meinersbur requested changes to this revision. Meinersbur added a comment. This revision now requires changes to proceed. In D61446#1533076 , @serge-sans-paille wrote: > That's what I tried to do when always adding Polly.cpp to PollyCore, but it > doesn'

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

Charusso updated this revision to Diff 203874. Charusso retitled this revision from "[analyzer] ReturnVisitor: Bypass constructing objects to see inlined calls" to "[analyzer] ReturnVisitor: Bypass everything to see inlined calls". Charusso added a comment. - The most generic approach. CHANGES

[PATCH] D63089: [clang] Warn on implicit boolean casts in more contexts (PR34180)

xbolva00 added a comment. Thanks ! You can check and take tests from my older patch https://reviews.llvm.org/D58878 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63089/new/ https://reviews.llvm.org/D63089 ___

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

Charusso marked 2 inline comments as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:842-849 + if (Optional CEE = Node->getLocationAs()) if (CEE->getCalleeContext()->getCallSite() == S) break; -

[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

jdoerfert added a comment. In D59919#1535643 , @nicholas wrote: > > CHANGED: build-libcalls NumNoUnwind > > 4526 -> 3382 ( -25.276%) > > Why did the number of nounwinds drop? I rerun the experiment with

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: docs/ClangFormatStyleOptions.rst:194 +**BitFieldDeclsOnSeparateLines** (``bool``) + If ``true``, Align Bitfield Declarations on s

[PATCH] D62978: [analyzer] ReturnVisitor: Handle unknown ReturnStmts better

Charusso updated this revision to Diff 203876. Charusso retitled this revision from "[analyzer] ReturnVisitor: Handle non-null ReturnStmts" to "[analyzer] ReturnVisitor: Handle unknown ReturnStmts better". Charusso edited the summary of this revision. Charusso added a comment. - The report was to

[PATCH] D63091: [clangd] Add a capability to enable completions with fixes.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D63091 Files: clangd/ClangdLSPServer.cpp clang

[PATCH] D62978: [analyzer] ReturnVisitor: Handle unknown ReturnStmts better

Charusso added a comment. In D62978#1533558 , @NoQ wrote: > Ah, that positive! Positive == true positive, not false positive, I got it. > No, i don't think this is a valid way to suppress it. Bought me, they are worth to report. The misleading reports

[PATCH] D63041: [PlistSupport] Produce a newline to end plist output files

NoQ accepted this revision. NoQ added a comment. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63041/new/ https://reviews.llvm.org/D63041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D63092: [Frontend] Use executable path when creating invocation from cmdline

phosek created this revision. phosek added reviewers: ilya-biryukov, sammccall, bkramer, echristo. Herald added subscribers: cfe-commits, kadircet. Herald added a project: clang. Args[0] isn't necessarily a correct path, it may not even be the path to the compiler, for example when using tools lik

[PATCH] D63093: [analyzer] WIP: MallocChecker: Release temporary CXXNewExpr

Charusso created this revision. Charusso added reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet. - Repository: rC Clang https://re

[PATCH] D63093: [analyzer] WIP: MallocChecker: Release temporary CXXNewExpr

Charusso planned changes to this revision. Charusso added a comment. This is heavily WIP as sometimes we have to release a `new` after we return it or a constructor did something with that. The direction is okay? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6309

[PATCH] D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database

arphaman updated this revision to Diff 203887. arphaman marked 3 inline comments as done. arphaman added a comment. - Add test for `-j2` to exercise multi threading. - Add `InitLLVM`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60233/new/ https://reviews.llvm.org/D60233 Files: clan

[PATCH] D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database

arphaman added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/regular_cdb.json:4 + "directory": "DIR", + "command": "clang -c DIR/regular_cdb.cpp -IInputs -MD -MF DIR/regular_cdb.d", + "file": "DIR/regular_cdb.cpp" aganea wrote: > Is `-MD -MF` re

[PATCH] D63092: [Frontend] Use executable path when creating invocation from cmdline

sammccall added a comment. Herald added a subscriber: ormris. `argv[0]` does carry important information though, I think this will break a lot of things. It's... concerning that no tests broke. For example, if it's `clang` or `g++` or `clang-cl` then that affects how command lines are parsed (r

[clang-tools-extra] r362978 - [clangd] Remove old hidden -use-dex-index flag

Author: sammccall Date: Mon Jun 10 13:38:16 2019 New Revision: 362978 URL: http://llvm.org/viewvc/llvm-project?rev=362978&view=rev Log: [clangd] Remove old hidden -use-dex-index flag Modified: clang-tools-extra/trunk/clangd/ClangdServer.h clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp

[PATCH] D62888: [NewPM] Port Sancov

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62888/new/ https://reviews.llvm.org/D62888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D63098: [CodeComplete] Allow completing enum values within case statements, and insert 'case' as a fixit.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added a project: clang. Herald added a subscriber: cfe-commits. There are a few alternative ways to expose this. The most obvious is a RK_Pattern, but it seems to have some triggering problems. Consider a completion

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Szelethus added a comment. I implemented the fixes you commented on, but during evaluation it turned out that my visitor eats ram for breakfast, and then goes for seconds. I mean, like 5-30x the normal memory consumption, and the same for analysis speed. I counted the number of concurrent insta

[PATCH] D63092: [Frontend] Use executable path when creating invocation from cmdline

phosek added a comment. In D63092#1536774 , @sammccall wrote: > `argv[0]` does carry important information though, I think this will break a > lot of things. It's... concerning that no tests broke. > > For example, if it's `clang` or `g++` or `clang-cl` t

[PATCH] D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database

aganea accepted this revision. aganea added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/ClangScanDeps/Inputs/regular_cdb.json:4 + "directory": "DIR", + "command": "clang -c DIR/regular_cdb.cpp -IInputs -MD -MF DIR/regular_cdb.d", +

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

mclow.lists added a comment. In D44865#1051228 , @EricWF wrote: > This LGTM. > > Also I would like @mclow.lists input about applying this DR early since LWG > hasn't commented on it yet. Even though LWG didn't vote it out as a DR; that's what it is, and

[PATCH] D63092: [Frontend] Use executable path when creating invocation from cmdline

phosek added a comment. One more thing, do you think it's reasonable to use `llvm::sys::findProgramByName(Args[0])`instead of `Args[0]` when creating the driver instance? One of the failure modes I ran into is the case where the generated compilation database would contain just the executable n

[PATCH] D62156: [Sema][PR41730] Diagnose addr space mismatch while constructing objects

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, LGTM. Comment at: test/SemaCXX/address-space-ctor.cpp:11 +//expected-note@-6{{candidate constructor (the implicit move constructor) not viable: no known conversion

r362991 - [CUDA] Fix grep pattern in cuda-types.cu

Author: hubert.reinterpretcast Date: Mon Jun 10 15:28:20 2019 New Revision: 362991 URL: http://llvm.org/viewvc/llvm-project?rev=362991&view=rev Log: [CUDA] Fix grep pattern in cuda-types.cu Summary: vertical-line is not a BRE special character. POSIX.1-2017 XBD Section 9.3.2 indicates that the i

[PATCH] D63029: [CUDA] Fix grep pattern in cuda-types.cu

This revision was automatically updated to reflect the committed changes. hubert.reinterpretcast marked an inline comment as done. Closed by commit rL362991: [CUDA] Fix grep pattern in cuda-types.cu (authored by hubert.reinterpretcast, committed by ). Herald added a project: LLVM. Herald added a s

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

mclow.lists added a comment. The patch looks fine to me, but I think you should consider making a couple of `T.fail.cpp` tests, and check to make sure you get the "right error". Comment at: test/std/utilities/variant/variant.variant/variant.assign/T.pass.cpp:130 { usi

r362992 - [PlistSupport] Produce a newline to end plist output files

Author: hubert.reinterpretcast Date: Mon Jun 10 15:30:57 2019 New Revision: 362992 URL: http://llvm.org/viewvc/llvm-project?rev=362992&view=rev Log: [PlistSupport] Produce a newline to end plist output files Summary: As suggested in the review of D62949, this patch updates the plist output to hav

[PATCH] D63041: [PlistSupport] Produce a newline to end plist output files

This revision was automatically updated to reflect the committed changes. Closed by commit rL362992: [PlistSupport] Produce a newline to end plist output files (authored by hubert.reinterpretcast, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

r362994 - [analyzer][tests] Add normalize_plist to replace diff_plist

Author: hubert.reinterpretcast Date: Mon Jun 10 15:33:34 2019 New Revision: 362994 URL: http://llvm.org/viewvc/llvm-project?rev=362994&view=rev Log: [analyzer][tests] Add normalize_plist to replace diff_plist Summary: The `%diff_plist` lit substitution invokes `diff` with a non-portable `-I` opti

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

This revision was automatically updated to reflect the committed changes. Closed by commit rL362994: [analyzer][tests] Add normalize_plist to replace diff_plist (authored by hubert.reinterpretcast, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[PATCH] D63101: [Frontend] SetUpDiagnosticLog should handle unowned diagnostic consumer in the compiler

arphaman added a subscriber: cfe-commits. arphaman added a comment. + cue-commits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63101/new/ https://reviews.llvm.org/D63101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D63101: [Frontend] SetUpDiagnosticLog should handle unowned diagnostic consumer in the compiler

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63101/new/ https://reviews.llvm.org/D63101 ___ cfe-commits mailing list cfe-com

r362996 - [analyzer][tests] Use normalize_plist in place of diff_plist (`cat` cases)

Author: hubert.reinterpretcast Date: Mon Jun 10 15:37:31 2019 New Revision: 362996 URL: http://llvm.org/viewvc/llvm-project?rev=362996&view=rev Log: [analyzer][tests] Use normalize_plist in place of diff_plist (`cat` cases) Summary: The `%diff_plist` lit substitution invokes `diff` with a non-por

[PATCH] D62950: [analyzer][tests] Use normalize_plist in place of diff_plist (`cat` cases)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL362996: [analyzer][tests] Use normalize_plist in place of diff_plist (`cat` cases) (authored by hubert.reinterpretcast, co

r362998 - [analyzer][tests] Use normalize_plist in place of diff_plist (`tail` cases)

Author: hubert.reinterpretcast Date: Mon Jun 10 15:40:35 2019 New Revision: 362998 URL: http://llvm.org/viewvc/llvm-project?rev=362998&view=rev Log: [analyzer][tests] Use normalize_plist in place of diff_plist (`tail` cases) Summary: The `%diff_plist` lit substitution invokes `diff` with a non-po

  1   2   >