RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land.
LGTM - the goto is unfortunate but more maintainable and less confusing then the current state of things ================ Comment at: clang/lib/Basic/Targets/X86.cpp:157 + setFeatureEnabledImpl(Features, "pku", true); + goto SkylakeCommon; + ---------------- Worth adding a comment explaining the AVX512 ISA divergence? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63018/new/ https://reviews.llvm.org/D63018 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
