lildmh marked an inline comment as done. lildmh added inline comments.
================ Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8729 +/// \code +/// void .omp_mapper.<type_name>.<mapper_id>.(void *rt_mapper_handle, +/// void *base, void *begin, ---------------- ABataev wrote: > lildmh wrote: > > ABataev wrote: > > > This function looks like the universal one, regardless of the type > > > `<type_name>` specifics. Do we really need to generate it for each > > > particular type and mapper? Or we could use the same function for all > > > types/mappers? > > I think we need a particular mapper function for each type and mapper, > > because the code generated within the mapper function depends on what type > > and what mapper it is. > Hmm, maybe I'm wrong but I don't see significant mapper or type-specific > dependencies in this mapper function. It uses the pointer to type and size of > the type, but this information can be generalized, I think. Could you point > the lines of code that are type and mapper specific? Code between line 8857-8965 is type and mapper specific. For instance, `generateAllInforForMapper` depends on the map clauses associated with the mapper and the internal structure of struct/class type, and generates difference code as a result. `BasePointers.size()` also depends on the above things. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59474/new/ https://reviews.llvm.org/D59474 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
