[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker reclaimed this revision. Tyker added a comment. I closed it originally because it was inactive and i was working on other reviews. but i learned this is not how it is supposed to be done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467

[clang-tools-extra] r362469 - [clangd] Fix a crash when clang-tidy is disabled

Author: ibiryukov Date: Tue Jun 4 00:19:11 2019 New Revision: 362469 URL: http://llvm.org/viewvc/llvm-project?rev=362469&view=rev Log: [clangd] Fix a crash when clang-tidy is disabled Added: clang-tools-extra/trunk/clangd/test/diagnostics-no-tidy.test Modified: clang-tools-extra/trunk/cl

[PATCH] D62623: Reduce memory consumption of coverage dumps

kwk added a comment. In D62623#1524666 , @kwk wrote: > In D62623#1522575 , > @serge-sans-paille wrote: > > > @kwk: looks like you're still compiling with clang-7, this patch is to be > > applied on the master vers

[PATCH] D62621: [LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s.

ilya-biryukov added a comment. Are there any corner cases with handling whitespace that we might want to handle or document them if we don't handle them? E.g. if the range ends up being a name of an expanded macro , it's probably very easy to glue the macro name with whatever you're inserting.

[PATCH] D62621: [LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s.

ilya-biryukov added a comment. I guess the question also applies to `change`, although it did not occur to me before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62621/new/ https://reviews.llvm.org/D62621 _

[PATCH] D62282: [X86] Add ENQCMD intrinsics.

RKSimon accepted this revision. RKSimon added a comment. In D62282#1528631 , @tianqing wrote: > Added doxygen comments of intrinsics in enqcmdintrin.h. Thanks, LGTM as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62282/new/ https://revi

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet updated this revision to Diff 202870. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments - Handle pointer/reference types to lambdas Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62814/new/ https://revi

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet added a comment. Nice catch! I think it makes sense to show signature in those cases as well. Updating according to that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62814/new/ https://reviews.llvm.org/D62814 _

[PATCH] D62839: [WIP] [clangd] Index API and implementations for relations

kadircet added a comment. In D62839#1528597 , @nridge wrote: > For relations, should we include a copy in both the file containing the > definition of the subject, and (if different) the file containing the > definition of the object? The point of shar

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. In D62814#1528736 , @kadircet wrote: > Nice catch! I think it makes sense to show signature in those cases as well. > Updating according

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:657 + auto ToFunctionDecl = [](const Decl *D) -> const FunctionDecl * { +// Extract lambda from variables. can this be a separate function rat

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

gribozavr accepted this revision. gribozavr added inline comments. Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe.cpp:14 +int pipe(int pipefd[2]); +void noWarning() { + int pipefd[2]; noWarningForPipeInNamespace ? Comment a

[PATCH] D62845: [clang-tidy] Fix make-unique tests on C++2a.

hokein created this revision. hokein added a reviewer: gribozavr. Herald added a subscriber: xazax.hun. Herald added a project: clang. These test cases are illgal in C++2a ("new Foo{}" needs to see the default constructor), so move them to the C++14-only tests. Repository: rG LLVM Github Monor

[PATCH] D62845: [clang-tidy] Fix make-unique tests on C++2a.

gribozavr added a comment. I'm also not sure what the intent behind these tests is. Maybe the right fix is to add a constructor that can be called? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62845/new/ https://reviews.llvm.org/D62845 __

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

gribozavr added inline comments. Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe2.cpp:20 + pipe2(pipefd, O_NONBLOCK); + // CHECK-MESSAGES: :[[@LINE-1]]:27: warning: 'pipe2' should use O_CLOEXEC where possible [android-cloexec-pipe2] + // CHECK-FIXES: pipe2(

[PATCH] D62845: [clang-tidy] Fix make-unique tests on C++2a.

gribozavr added a comment. I'd suggest to add a separate file that covers the exact language modes needed. The C++14 test that we have right now is about C++14-or-later, testing the availability of std::make_unique. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

gribozavr added a comment. Sorry for jumping in late, but renaming the declaration is not enough -- usages should also be updated; otherwise the developer is better off using a refactoring in their IDE or even a textual search and replace. Repository: rL LLVM CHANGES SINCE LAST ACTION htt

[PATCH] D62476: [clangd] Support offsets for parameters in signatureHelp

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. nice, looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62476/new/ https://reviews.llvm.org/D62476 ___

r362479 - [CodeComplete] Include more text into typed chunks of pattern completions

Author: ibiryukov Date: Tue Jun 4 02:26:08 2019 New Revision: 362479 URL: http://llvm.org/viewvc/llvm-project?rev=362479&view=rev Log: [CodeComplete] Include more text into typed chunks of pattern completions Summary: To allow filtering on any of the words in the editors. In particular, the foll

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Pierre added a comment. In D60763#1527870 , @thakis wrote: > From what I can tell, the only client of OpenCLBuiltins.td is currently > lib/Sema. Do you expect that to change? If not, does it make more sense to > move the .td file to there? > > Do you exp

[PATCH] D62615: [CodeComplete] Include more text into typed chunks of pattern completions

This revision was automatically updated to reflect the committed changes. Closed by commit rL362479: [CodeComplete] Include more text into typed chunks of pattern completions (authored by ibiryukov, committed by ). Herald added subscribers: llvm-commits, arphaman. Herald added a project: LLVM. Ch

[clang-tools-extra] r362481 - [clangd] Support offsets for parameters in signatureHelp

Author: ibiryukov Date: Tue Jun 4 02:36:59 2019 New Revision: 362481 URL: http://llvm.org/viewvc/llvm-project?rev=362481&view=rev Log: [clangd] Support offsets for parameters in signatureHelp Summary: Added to LSP in version 3.14 Reviewers: hokein Reviewed By: hokein Subscribers: MaskRay, jko

[PATCH] D62476: [clangd] Support offsets for parameters in signatureHelp

This revision was automatically updated to reflect the committed changes. Closed by commit rL362481: [clangd] Support offsets for parameters in signatureHelp (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D54258: [Clang] Fix pretty printing of CUDA address spaces

richardmembarth added a comment. Merging in two weeks is fine for me. My assumption was that accepted patches are merged into upstream in a timely manner. Maybe this is not how it works? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54258/new/ https://reviews.l

[PATCH] D62845: [clang-tidy] Fix make-unique tests on C++2a.

hokein added a comment. In D62845#1528791 , @gribozavr wrote: > I'd suggest to add a separate file that covers the exact language modes > needed. > > The C++14 test that we have right now is about C++14-or-later, testing the > availability of std::make_u

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet updated this revision to Diff 202888. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62814/new/ https://reviews.llvm.org/D62814 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra/cl

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48116/new/ https://reviews.llvm.org/D48116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet marked 4 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:819 )cpp", [](HoverInfo &HI) { HI.NamespaceScope = ""; sammccall wrote: > I'm slightly nervous abou

[PATCH] D60691: [ARM] Replace fp-only-sp and d16 with fp64 and d32.

simon_tatham marked an inline comment as done. simon_tatham added a comment. Hmm, yes, I see what you mean. It //looks// to me as if the problem is that `llvm::ARM::getFPUFeatures` is setting up a feature list including `+vfp4`, `-fp64` and `-d32` just as you'd expect, but when it's called from

[PATCH] D62845: [clang-tidy] Fix make-unique tests on C++2a.

gribozavr added a comment. In D62845#1528887 , @hokein wrote: > In D62845#1528791 , @gribozavr wrote: > > > I'd suggest to add a separate file that covers the exact language modes > > needed. > > > > The C++14 test

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed. Please add a check for the type of variable being not null before landing. The other comment is not very important Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:628 +auto QT = VD->getType(); +while (!QT->getPointeeType().isNull()) + QT = QT->getPointeeType(); We need a check for `!QT.isNull` here Comment at

[PATCH] D62623: Reduce memory consumption of coverage dumps

serge-sans-paille updated this revision to Diff 202896. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Update comment + force reduced memory consumption. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62623/new

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

russell.gallop created this revision. russell.gallop added reviewers: craig.topper, cfe-commits. russell.gallop added a project: clang. Some of these test cases were using a variable instead of a literal so were not generating the immediate form of the corresponding instruction. Repository: r

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

lebedev.ri added a comment. .. or? Is this fixing a current test failure? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62850/new/ https://reviews.llvm.org/D62850 ___ cfe-commits mailing list cfe-commi

[clang-tools-extra] r362489 - Fix Wshadow warning

Author: rksimon Date: Tue Jun 4 04:11:51 2019 New Revision: 362489 URL: http://llvm.org/viewvc/llvm-project?rev=362489&view=rev Log: Fix Wshadow warning Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp URL: http://llv

[clang-tools-extra] r362491 - Fix -Wparentheses warning. NFCI.

Author: rksimon Date: Tue Jun 4 04:31:45 2019 New Revision: 362491 URL: http://llvm.org/viewvc/llvm-project?rev=362491&view=rev Log: Fix -Wparentheses warning. NFCI. Modified: clang-tools-extra/trunk/clangd/Protocol.cpp Modified: clang-tools-extra/trunk/clangd/Protocol.cpp URL: http://llvm

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 202908. serge-sans-paille added a comment. - reorder registration to make sure options are correctly taken into account - make LINK_POLLY_INTO_TOOLS obsolete in favor of just using LLVM_LINK_POLLY_INTO_TOOLS Repository: rG LLVM Github Monorepo

Re: [clang-tools-extra] r362491 - Fix -Wparentheses warning. NFCI.

Thanks! And sorry about this in the first place, I did not have this warning enabled locally. On Tue, Jun 4, 2019 at 1:28 PM Simon Pilgrim via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rksimon > Date: Tue Jun 4 04:31:45 2019 > New Revision: 362491 > > URL: http://llvm.org/viewvc

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

steakhal marked 8 inline comments as done. steakhal added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/IncorrectPointerCastCheck.cpp:69-70 + "cast from %0 to %1 may lead to access memory based on invalid " + "memory layout; pointed to type i

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille added a comment. @philip.pfaffe : NewPM integeration actually works thanks to ``Register${Name}Passes(llvm::PassBuilder &PB)``. It's already used by Polly for NewPM integration and we mimic that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille added a comment. @beanz turns out the depdendency problem was just a matter of moving the `register_llvm_extension` call at the top of the file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61446/new/ https://reviews.llvm.org/D6

[PATCH] D62591: [OpenCL][PR42031] Prevent deducing addr space in type alias.

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62591/new/ https://reviews.llvm.org/D62591 ___ cfe-commits mailing list cfe-c

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

steakhal updated this revision to Diff 202913. steakhal marked 4 inline comments as done. steakhal added a comment. - Removed different signess related parts. - Don't warn for the casts which are already covered by '-Wcast-align' check. - Improved the diagnostic messages: - Now adds notes for th

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

russell.gallop added a comment. > .. or? I'm not sure what you mean. > Is this fixing a current test failure? No. The test is not failing, but it is not doing what was intended as these builtins are for generating the immediate form of the corresponding instruction and they were generating ac

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

probinson added a comment. Is the compiler missing a check that these parameters are immediates? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62850/new/ https://reviews.llvm.org/D62850 ___ cfe-commits

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

steakhal added a comment. In D48866#1527540 , @lebedev.ri wrote: > In D48866#1527506 , @steakhal wrote: > > > The problem with the `-Wcast-align` is that it will only fire for C-style > > bitcast expressions, not f

[PATCH] D62855: Implementation of auto type expansion.

kuhnel created this revision. kuhnel added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62855 Files: clang-tools-extra/clangd/AST.cpp clang-too

[PATCH] D62845: [clang-tidy] Fix make-unique tests on C++2a.

hokein updated this revision to Diff 202922. hokein added a comment. Tests for C++2a. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62845/new/ https://reviews.llvm.org/D62845 Files: clang-tools-extra/test/clang-tidy/modernize-make-unique-cxx14.c

[PATCH] D62856: [clangd] Also apply adjustArguments when returning fallback commands

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62856 Files: clang-tools-extra/clangd/GlobalCompilationDat

[PATCH] D62845: [clang-tidy] Fix make-unique tests on C++2a.

hokein added a comment. > I think we should be looking at the intent of the test rather than its name. > > The intent looks like testing how the check works when `std::make_unique` is > available from the standard library (as opposed to some kind of replacement > like `absl::make_unique`). See

[PATCH] D62856: [clangd] Also apply adjustArguments when returning fallback commands

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62856/new/ https://reviews.llvm.org/D62856 _

[clang-tools-extra] r362496 - [clangd] Also apply adjustArguments when returning fallback commands

Author: kadircet Date: Tue Jun 4 06:38:36 2019 New Revision: 362496 URL: http://llvm.org/viewvc/llvm-project?rev=362496&view=rev Log: [clangd] Also apply adjustArguments when returning fallback commands Reviewers: ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, cfe-commits Tags: #clang

[PATCH] D62856: [clangd] Also apply adjustArguments when returning fallback commands

This revision was automatically updated to reflect the committed changes. Closed by commit rL362496: [clangd] Also apply adjustArguments when returning fallback commands (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

krytarowski added a comment. This commit breaks the NetBSD buildbot node. http://lab.llvm.org:8011/builders/netbsd-amd64/builds/20359 The problem is that this patch hardcodes python specific binary name, while it has to be detected dynamically or ideally passed from CMake. Afair lit has a know

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh updated this revision to Diff 202926. lildmh added a comment. Address Alexey's comment about mapping between function and user-defined mappers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59474/new/ https://reviews.llvm.org/D59474 Files: include/clang/AST/GlobalDecl.h lib/A

[PATCH] D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation

thakis added a comment. Any reason this isn't tested via lit instead? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55463/new/ https://reviews.llvm.org/D55463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D59744: Fix i386 ABI "__m64" type bug

krytarowski added subscribers: mgorny, joerg. krytarowski added a comment. In D59744#1527412 , @wxiao3 wrote: > Consider other Systems (e.g Darwin, PS4 and FreeBSD) don't want to spend any > effort dealing with the ramifications of ABI breaks (as discusse

[PATCH] D62845: [clang-tidy] Fix make-unique tests on C++2a.

gribozavr added a comment. In D62845#1529149 , @hokein wrote: > > I think we should be looking at the intent of the test rather than its name. > > > > The intent looks like testing how the check works when `std::make_unique` > > is available from the sta

[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

jsji added inline comments. /cfe/trunk/lib/Driver/ToolChains/PPCLinux.cpp:26 yes, it is currently Linux only. I think we can extend it to include other OS like AIX later if needed. https://reviews.llvm.org/rL358949 ___ cfe-commits mailing list cfe-

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

russell.gallop added a comment. > Is the compiler missing a check that these parameters are immediates? I don't think that there can be a check, or this would have been noticed. I don't know whether this is possible and/or desirable. Do users use one version of the builtin and want the compiler

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

lebedev.ri added a comment. In D62850#1529081 , @russell.gallop wrote: > > .. or? > > I'm not sure what you mean. > > > Is this fixing a current test failure? > > No. The test is not failing, but it is not doing what was intended as these > builtins are

[PATCH] D59744: Fix i386 ABI "__m64" type bug

mgorny added a comment. In D59744#1529182 , @krytarowski wrote: > In D59744#1527412 , @wxiao3 wrote: > > > Consider other Systems (e.g Darwin, PS4 and FreeBSD) don't want to spend > > any effort dealing with the ra

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet updated this revision to Diff 202933. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62814/new/ https://reviews.llvm.org/D62814 Files: clang-tools-ex

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:831 + }; return HI; }}, ilya-biryukov wrote: > kadircet wrote: > > ilya-biryukov wrote: > > > Could you add another test with even weirder type

[PATCH] D60697: [ARM] Allow "-march=foo+fp" to vary with foo.

SjoerdMeijer updated this revision to Diff 202934. SjoerdMeijer added a comment. Hi Oliver, thanks for your comments! This was the easy one, they have been added: > I also don't see any tests for the negated forms of either feature. The trouble begun with this: > +fp.dp, but the FPU is already

Re: [PATCH] D54258: [Clang] Fix pretty printing of CUDA address spaces

On Tue, Jun 4, 2019 at 5:37 AM Richard Membarth via Phabricator wrote: > > richardmembarth added a comment. > > Merging in two weeks is fine for me. > > My assumption was that accepted patches are merged into upstream in a timely > manner. > Maybe this is not how it works? Your assumption is cor

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 202938. dgoldman added a comment. - Remove unused State variable Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExprCXX.cpp test/Sema/typo-correction-recursi

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Nicola added a comment. A bit late to the review, but I've noticed a couple of issues with some of the implemented builtins: - The fmin/fmax builtins are defined twice for scalar types, does this create problems in overload resolution when using them? - The convert_ builtins don't have support

[PATCH] D62845: [clang-tidy] Fix make-unique tests on C++2a.

hokein updated this revision to Diff 202940. hokein marked 2 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62845/new/ https://reviews.llvm.org/D62845 Files: clang-tools-ex

[PATCH] D62845: [clang-tidy] Fix make-unique tests on C++2a.

hokein added a comment. In D62845#1529190 , @gribozavr wrote: > In D62845#1529149 , @hokein wrote: > > > > I think we should be looking at the intent of the test rather than its > > > name. > > > > > > The intent

[clang-tools-extra] r362352 - [clangd] Add RelationSlab

Author: nridge Date: Sun Jun 2 21:55:46 2019 New Revision: 362352 URL: http://llvm.org/viewvc/llvm-project?rev=362352&view=rev Log: [clangd] Add RelationSlab Summary: RelationSlab is a new index data structure that stores relations between symbols. Reviewers: kadircet Subscribers: ilya-biryuko

[clang-tools-extra] r362353 - [clangd] Serialization support for RelationSlab

Author: nridge Date: Sun Jun 2 22:07:52 2019 New Revision: 362353 URL: http://llvm.org/viewvc/llvm-project?rev=362353&view=rev Log: [clangd] Serialization support for RelationSlab Summary: This builds on D59407 to provide YAML and RIFF serialization support. Reviewers: kadircet Subscribers: il

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 closed this revision. jyu2 added a comment. jyu2 committed rGb8fee677bf8e : Re-check in clang support gun asm goto after fixing tests. (authored by jyu2). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/

[clang-tools-extra] r362467 - [clangd] SymbolCollector support for relations

Author: nridge Date: Mon Jun 3 21:25:44 2019 New Revision: 362467 URL: http://llvm.org/viewvc/llvm-project?rev=362467&view=rev Log: [clangd] SymbolCollector support for relations Summary: The only relation currently collected is RelationBaseOf, because this is all we need for type hierarchy subt

[PATCH] D62782: Fix -Wdouble-promotion warnings.

brucem added a comment. I'd modified `CMakeLists.txt` to add `-Wdouble-promotion` and removed this line: `-Wno-double-promotion # FIXME: remove me` ... Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62782/new/ https://reviews.llvm.org/D62782 ___

[PATCH] D62845: [clang-tidy] Fix make-unique tests on C++2a.

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Looks great, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62845/new/ https://reviews.llvm.org/D62845 __

Re: [PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

AST dump doesn't traverse into typelocs, which is where x is. That said, this particular case is not worth any complexity at all. Even pointer-to-lambda is vanishingly rare. Regarding dropping ref/pointer info: one option here is keeping the old "class (lambda)&", and simply making sure we now po

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:831 + }; return HI; }}, kadircet wrote: > ilya-biryukov wrote: > > kadircet wrote: > > > ilya-biryukov wrote: > > > > Could you add anothe

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 202950. serge-sans-paille added a comment. Take into account @philip.pfaffe remarks and improve support for new PM. - harmonize static/dynamic loading, although two functions are still needed, one for dynamic loading and one for static loading (new

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

ilya-biryukov added a comment. @jkorous, could you take a look or suggest someone who can review the libclang changes? As mentioned before, I've reviewed the clang bits (which are now gone), but don't have much experience in `libclang` parts. Repository: rC Clang CHANGES SINCE LAST ACTION

[clang-tools-extra] r362517 - [clangd] Minor cleanup. NFC

Author: ibiryukov Date: Tue Jun 4 09:19:11 2019 New Revision: 362517 URL: http://llvm.org/viewvc/llvm-project?rev=362517&view=rev Log: [clangd] Minor cleanup. NFC Removed unused using declaration from TweakTests.cpp Modified: clang-tools-extra/trunk/clangd/unittests/TweakTests.cpp Modified

r362521 - [CodeGen][ObjC] Convert '[self alloc]' in a class method to a call to

Author: ahatanak Date: Tue Jun 4 09:29:58 2019 New Revision: 362521 URL: http://llvm.org/viewvc/llvm-project?rev=362521&view=rev Log: [CodeGen][ObjC] Convert '[self alloc]' in a class method to a call to 'objc_alloc(self)' Also convert '[[self alloc] init]' in a class method to a call to 'objc_a

[PATCH] D62643: [CodeGen][ObjC] Convert '[self alloc]' in a class method to 'objc_alloc(self)'

This revision was automatically updated to reflect the committed changes. ahatanak marked 2 inline comments as done. Closed by commit rL362521: [CodeGen][ObjC] Convert '[self alloc]' in a class method to a call to (authored by ahatanak, committed by ). Herald added a project: LLVM. Herald added a

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

russell.gallop added a comment. > Then the test should be failing? Or is the current form also legal? Hmm, __builtin_ia32_insertps128() errors if you pass a variable, but these don't (e.g.): mytest.c:122:13: error: argument to '__builtin_ia32_insertps128' must be a constant integer tmp_V4f =

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

craig.topper added a comment. We support non immediate on these because gcc does. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62850/new/ https://reviews.llvm.org/D62850 ___ cfe-commits mailing list c

r362530 - [Syntax] Do not depend on llvm targets for Syntax tests. NFC

Author: ibiryukov Date: Tue Jun 4 10:15:48 2019 New Revision: 362530 URL: http://llvm.org/viewvc/llvm-project?rev=362530&view=rev Log: [Syntax] Do not depend on llvm targets for Syntax tests. NFC They are not required and only slow down the build. Modified: cfe/trunk/unittests/Tooling/Synta

r362531 - PR42104: Support instantiations of lambdas that implicitly capture

Author: rsmith Date: Tue Jun 4 10:17:20 2019 New Revision: 362531 URL: http://llvm.org/viewvc/llvm-project?rev=362531&view=rev Log: PR42104: Support instantiations of lambdas that implicitly capture packs. Two changes: * Track odr-use via FunctionParmPackExprs to properly handle dependent od

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 202976. plotfi added a comment. Adding a test for inheritance and constructors/destroctors. Also addressing feedback from @alexshap Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

jcai19 marked an inline comment as done. jcai19 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe2.cpp:20 + pipe2(pipefd, O_NONBLOCK); + // CHECK-MESSAGES: :[[@LINE-1]]:27: warning: 'pipe2' should use O_CLOEXEC where possible [android-cl

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

Charusso added inline comments. Comment at: cfe/trunk/utils/analyzer/exploded-graph-rewriter.py:1 +#!/usr/bin/env python + ``` # something else then # #==- exploded-graph-rewriter.py - Simplifies the ExplodedGraph -*- python -*-==# # # Part of the LLVM Project, u

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

russell.gallop added a comment. > I'll have a look and see if there is a reason why these don't fail in the > same way (which would make the test fail in it's current form). These do not have the "I" prefix (// I -> Required to constant fold to an integer constant expression.) in BuiltinsX86

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

russell.gallop added a comment. > We support non immediate on these because gcc does. Thanks. Your comment crossed in mid-air. Okay, so is this test worth changing, or should it have both versions (immediate and non-immediate)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

jcai19 updated this revision to Diff 202984. jcai19 added a comment. Update test function names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61967/new/ https://reviews.llvm.org/D61967 Files: clang-tools-extra/clang-tidy/android/AndroidTidyModu

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

lebedev.ri added a comment. In D62850#1529588 , @russell.gallop wrote: > > We support non immediate on these because gcc does. > > Thanks. Your comment crossed in mid-air. Okay, so is this test worth > changing, or should it have both versions (immediate

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ added a comment. Thanks!! Will fix as soon as i get to my desktop. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn updated this revision to Diff 202987. kpn added a comment. Address the rest of the review comments, hopefully. I've lifted from mibintc's D62730 the enums for the exception behavior and rounding modes. The rest of that set of changes is better left to a sep

[PATCH] D62363: [X86] Enable intrinsics that convert float and bf16 data to each other

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62363/new/ https://reviews.llvm.org/D62363 ___ cfe-commits mailing list c

[PATCH] D62363: [X86] Enable intrinsics that convert float and bf16 data to each other

RKSimon accepted this revision. RKSimon added a comment. Yup, doxygen LGTM - cheers Comment at: lib/Headers/avx512bf16intrin.h:33 + +/// Convert One BF16 Data to One Single Data. +/// Single Float Data CHANGES SINCE LAST ACTION https://reviews.llvm.org/D623

r362537 - Factor out repeated code to build a DeclRefExpr and mark it referenced.

Author: rsmith Date: Tue Jun 4 11:30:46 2019 New Revision: 362537 URL: http://llvm.org/viewvc/llvm-project?rev=362537&view=rev Log: Factor out repeated code to build a DeclRefExpr and mark it referenced. Modified: cfe/trunk/include/clang/Sema/Sema.h cfe/trunk/lib/Sema/SemaDeclCXX.cpp

  1   2   >