Nicola added a comment.

A bit late to the review, but I've noticed a couple of issues with some of the 
implemented builtins:

- The fmin/fmax builtins are defined twice for scalar types, does this create 
problems in overload resolution when using them?
- The convert_ builtins don't have support for half types (which is present in 
the opencl-c.h header. Is that intended?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60763/new/

https://reviews.llvm.org/D60763



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to