[PATCH] D62616: [CodeComplete] Add a bit more whitespace to completed patterns

ilya-biryukov added a comment. In D62616#1522284 , @gribozavr wrote: > I totally agree about the space before the opening curly, but the space > before the opening paren is a matter of style. Certainly it does match LLVM > style better, but it does not

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe.cpp:5 + +void f() { + int pipefd[2]; Please give the tests informative names in

[PATCH] D62736: [clang-tidy] Fix make-unique check to work in C++17 mode.

hokein marked 2 inline comments as done. hokein added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp:311 + } +} +if (CEArg->isStdInitListInitialization()) gribozavr wrote: > So `Foo(Bar{1, 2})` i

[PATCH] D62736: [clang-tidy] Fix make-unique check to work in C++17 mode.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rL362361: [clang-tidy] Fix make-unique check to work in C++17 mode. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm

[clang-tools-extra] r362361 - [clang-tidy] Fix make-unique check to work in C++17 mode.

Author: hokein Date: Mon Jun 3 01:14:15 2019 New Revision: 362361 URL: http://llvm.org/viewvc/llvm-project?rev=362361&view=rev Log: [clang-tidy] Fix make-unique check to work in C++17 mode. Summary: Previously, we intended to omit the check fix to the case when constructor has any braced-init-li

r362363 - [CodeComplete] Add a bit more whitespace to completed patterns

Author: ibiryukov Date: Mon Jun 3 01:34:25 2019 New Revision: 362363 URL: http://llvm.org/viewvc/llvm-project?rev=362363&view=rev Log: [CodeComplete] Add a bit more whitespace to completed patterns Summary: E.g. we now turn `while(<#cond#>){` into `while (<#cond#>) {` This slightly improves the

[clang-tools-extra] r362363 - [CodeComplete] Add a bit more whitespace to completed patterns

Author: ibiryukov Date: Mon Jun 3 01:34:25 2019 New Revision: 362363 URL: http://llvm.org/viewvc/llvm-project?rev=362363&view=rev Log: [CodeComplete] Add a bit more whitespace to completed patterns Summary: E.g. we now turn `while(<#cond#>){` into `while (<#cond#>) {` This slightly improves the

[PATCH] D62616: [CodeComplete] Add a bit more whitespace to completed patterns

This revision was automatically updated to reflect the committed changes. Closed by commit rL362363: [CodeComplete] Add a bit more whitespace to completed patterns (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D62471: [clangd] SymbolCollector support for relations

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! I suppose there are only two patches left now? - Exposing relations in `SymbolIndex`. - Implementing children resolution using that information. Repository: rG LLVM Githu

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Some custom toolchains come with their own header files and compiler drivers. Those compiler drivers implicitly kn

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

gribozavr added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:472 if (Info.hasSourceManager()) checkFilters(Info.getLocation(), Info.getSourceManager()); } nik wrote: > gribozavr wrote: > > It seems like the `checkFilters` call

[PATCH] D62582: [CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Sema/SemaCodeComplete.cpp:1314 + Result &Incumbent = Results[Entry.second]; + Method->dumpColor(); + Incumbent.D

[PATCH] D62729: [ARM] Fix recent breakage of -mfpu=none.

simon_tatham marked an inline comment as done. simon_tatham added inline comments. Comment at: clang/test/CodeGen/arm-mfpu-none.c:2 +// REQUIRES: arm-registered-target +// RUN: %clang -target arm-none-eabi -mcpu=cortex-m4 -mfpu=none -S -o - %s | FileCheck %s + d

[PATCH] D62574: Initial draft of target-configurable address spaces.

ebevhan added a comment. In D62574#1523835 , @Anastasia wrote: > > This patch does not address the issue with the accessors > > on Qualifiers (isAddressSpaceSupersetOf, compatiblyIncludes), > > because I don't know how to solve it without breaking a ton

r362371 - [OpenCL] Declare builtin functions using TableGen

Author: svenvh Date: Mon Jun 3 02:39:11 2019 New Revision: 362371 URL: http://llvm.org/viewvc/llvm-project?rev=362371&view=rev Log: [OpenCL] Declare builtin functions using TableGen This patch adds a `-fdeclare-opencl-builtins` command line option to the clang frontend. This enables clang to ve

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

This revision was automatically updated to reflect the committed changes. Closed by commit rL362371: [OpenCL] Declare builtin functions using TableGen (authored by svenvh, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62580/new/ https://reviews.llvm.org/D62580 ___ cfe-commits mailing list cfe-comm

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Anastasia added inline comments. Comment at: clang/test/CodeGenSYCL/device-functions.cpp:24 +} +// CHECK: define spir_func void @{{.*}}foo +// CHECK: define linkonce_odr spir_func i32 @{{.*}}bar Fznamznon wrote: > Anastasia wrote: > > I can't see where the SPIR c

r362375 - Revert rL362358 : PR42104: Support instantiations of lambdas that implicitly capture packs.

Author: rksimon Date: Mon Jun 3 02:56:09 2019 New Revision: 362375 URL: http://llvm.org/viewvc/llvm-project?rev=362375&view=rev Log: Revert rL362358 : PR42104: Support instantiations of lambdas that implicitly capture packs. Two changes: * Track odr-use via FunctionParmPackExprs to properly ha

[PATCH] D60697: [ARM] Allow "-march=foo+fp" to vary with foo.

ostannard added inline comments. Comment at: llvm/lib/Support/ARMTargetParser.cpp:551 + + // If the default FPU already supports double-precision, or if + // there is no double-prec FPU that extends it, then "fp.dp" Could you also add tests for the erro

[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins

Ka-Ka added inline comments. Comment at: clang/test/CodeGen/builtins-x86.c:127-128 - tmp_V2LLi = __builtin_ia32_undef128(); - tmp_V4LLi = __builtin_ia32_undef256(); + tmp_V2LLi = (V2LLi)__builtin_ia32_undef128(); + tmp_V4LLi = (V4LLi)__builtin_ia32_undef256(); ---

[PATCH] D62729: [ARM] Fix recent breakage of -mfpu=none.

simon_tatham updated this revision to Diff 202681. simon_tatham added a comment. Added the extra checks in `arm-mfpu.c`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62729/new/ https://reviews.llvm.org/D62729 Files: clang/lib/Driver/ToolChains/

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon added inline comments. Comment at: clang/test/CodeGenSYCL/device-functions.cpp:24 +} +// CHECK: define spir_func void @{{.*}}foo +// CHECK: define linkonce_odr spir_func i32 @{{.*}}bar Anastasia wrote: > Fznamznon wrote: > > Anastasia wrote: > > > I can

[PATCH] D59934: Compare SourceLocations from different TUs by FileID

balazske added a comment. The problem has not necessarily do something with macro expansion. If a function is imported in CTU mode and for any reason source locations inside it are compared against source locations in the original TU these locations are (from `SourceManager` point of view) in d

[PATCH] D59934: Compare SourceLocations from different TUs by FileID

balazske added a comment. The following ASTImporterTest reproduces the assert: TEST_P(ASTImporterOptionSpecificTestBase, SourceLocationDifferentTU) { TranslationUnitDecl *ToTU = getToTuDecl("void f1();", Lang_CXX11); Decl *FromTU = getTuDecl("void f2();", Lang_CXX11, "input.cc"); au

r362379 - Fix compilation warning about unused variable [NFC]

Author: uabelho Date: Mon Jun 3 03:50:41 2019 New Revision: 362379 URL: http://llvm.org/viewvc/llvm-project?rev=362379&view=rev Log: Fix compilation warning about unused variable [NFC] Modified: cfe/trunk/lib/Driver/Driver.cpp Modified: cfe/trunk/lib/Driver/Driver.cpp URL: http://llvm.org/

[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins

Ka-Ka accepted this revision. Ka-Ka added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62580/new/ https://reviews.llvm.org/D62580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins

alexbatashev marked 6 inline comments as done. alexbatashev added a comment. @Ka-Ka done CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62580/new/ https://reviews.llvm.org/D62580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D62729: [ARM] Fix recent breakage of -mfpu=none.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. LGTM. Thanks for adding the new test. I agree with keeping both tests ( I wasn't very clear). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62

r362380 - [ARM] Fix recent breakage of -mfpu=none.

Author: statham Date: Mon Jun 3 04:02:53 2019 New Revision: 362380 URL: http://llvm.org/viewvc/llvm-project?rev=362380&view=rev Log: [ARM] Fix recent breakage of -mfpu=none. The recent change D60691 introduced a bug in clang when handling option combinations such as `-mcpu=cortex-m4 -mfpu=none`.

[PATCH] D62729: [ARM] Fix recent breakage of -mfpu=none.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362380: [ARM] Fix recent breakage of -mfpu=none. (authored by statham, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D62729?vs=202681&id=202688#t

[PATCH] D62156: [Sema][PR41730] Diagnose addr space mismatch while constructing objects

Anastasia updated this revision to Diff 202690. Anastasia marked an inline comment as done. Anastasia added a comment. Changed FIXME to a regular comment, modified wording. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62156/new/ https://reviews.llvm.org/D62156 Files: include/clang/B

[PATCH] D62156: [Sema][PR41730] Diagnose addr space mismatch while constructing objects

Anastasia marked 2 inline comments as done. Anastasia added inline comments. Comment at: lib/Sema/SemaOverload.cpp:6095 +// Check that addr space of an object being constructed is convertible to +// the one ctor qualified with. +if (!Qualifiers::isAddressSpaceSuperset

[PATCH] D62808: [clangd] Print the ignored variant symbols

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. so that we can better track those symbols. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62808 Files

r362398 - [OpenCL] Undefine cl_intel_planar_yuv extension

Author: asavonic Date: Mon Jun 3 06:02:43 2019 New Revision: 362398 URL: http://llvm.org/viewvc/llvm-project?rev=362398&view=rev Log: [OpenCL] Undefine cl_intel_planar_yuv extension Summary: Remove unnecessary definition (otherwise the extension will be defined where it's not supposed to be def

[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

This revision was automatically updated to reflect the committed changes. Closed by commit rL362398: [OpenCL] Undefine cl_intel_planar_yuv extension (authored by asavonic, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D62445: [test] Fix plugin tests

davezarzycki added a comment. This broke non-PIC builds. Fixed: r362399 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62445/new/ https://reviews.llvm.org/D62445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62413: [OpenCL][PR41727] Prevent ICE on global dtors

Anastasia updated this revision to Diff 202708. Anastasia added a comment. - Guard OpenCL specific IR generation under OpenCL lang mode CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62413/new/ https://reviews.llvm.org/D62413 Files: lib/CodeGen/CGDeclCXX.cpp lib/CodeGen/CodeGenModul

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7885 +// By default, restrict the maximum size to 256. +F->addFnAttr("amdgpu-flat-work-group-size", "128,256"); } yaxunl wrote: > arsenm wrote

[PATCH] D62413: [OpenCL][PR41727] Prevent ICE on global dtors

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/CodeGen/CGDeclCXX.cpp:132 + Argument = CGM.getTargetCodeGenInfo().performAddrSpaceCast( + CGM, Addr.getPointer(), SrcAS, LangAS::opencl_global, DestTy); r

[PATCH] D62782: Fix -Wdouble-promotion warnings.

mclow.lists added a comment. This looks fine to me; but where were you getting these warnings? Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62782/new/ https://reviews.llvm.org/D62782 ___ cfe-commits mailing list

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 added a comment. Consider other Systems (e.g Darwin, PS4 and FreeBSD) don't want to spend any effort dealing with the ramifications of ABI breaks (as discussed in https://reviews.llvm.org/D60748) at present, I only fix the bug for Linux. If other system wants the fix, the only thing need

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

steakhal commandeered this revision. steakhal added a reviewer: hgabii. steakhal added a comment. If you don't mind I will finish the leftover work. This will still be committed under your name. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48866/ne

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

steakhal updated this revision to Diff 202717. steakhal added a comment. Unfortunately the changes that I've made are not available in a diff because I've moved to the monorepo version. Although, you can see the changes in detail on my llvm-project github fork

[PATCH] D62591: [OpenCL][PR42031] Prevent deducing addr space in type alias.

Anastasia updated this revision to Diff 202721. Anastasia added a comment. - Exclude pointee from early return in addr space deduction - Improved testing: added FileCheck and avoid testing unnecessary bits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62591/new/ https://reviews.llvm.org

[PATCH] D62591: [OpenCL][PR42031] Prevent deducing addr space in type alias.

Anastasia added a comment. @mantognini Good spot! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62591/new/ https://reviews.llvm.org/D62591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

lebedev.ri added a comment. Some basic thoughts Comment at: clang-tools-extra/clang-tidy/bugprone/IncorrectPointerCastCheck.cpp:63 + "cast from %0 to %1 may lead to access memory based on invalid memory " + "layout; pointed to type is wider than the allocated

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert marked an inline comment as done. aaronpuchert added a comment. In D59673#1521413 , @dblaikie wrote: > Might be easier as a few patches - renaming the existing option, adding the > new one, then removing the single split dwarf flag handling i

[PATCH] D50989: Remove Darwin support from POWER backend.

kbarton closed this revision. kbarton added a comment. Herald added a subscriber: jsji. This landed in https://reviews.llvm.org/rL340770. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50989/new/ https://reviews.llvm.org/D50989 ___ cfe-commi

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Anastasia added inline comments. Comment at: clang/test/CodeGenSYCL/device-functions.cpp:24 +} +// CHECK: define spir_func void @{{.*}}foo +// CHECK: define linkonce_odr spir_func i32 @{{.*}}bar Fznamznon wrote: > Anastasia wrote: > > Fznamznon wrote: > > > Anast

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

lebedev.ri added a comment. Also, this kinda feels like this shouldn't be a single check. 1. I'm very much looking forward the alignment part of this, the `reinterpret_cast<>()` specifically. It would be good to have a switch to also diagnose casts from `void*` here. But indeed, if it comes fro

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

steakhal added a comment. The problem with the `-Wcast-align` is that it will only fire for C-style bitcast expressions, not for `reinterpret_cast` ones. example Does anyone know why is that behavior? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48866/ne

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

lebedev.ri added a comment. In D48866#1527506 , @steakhal wrote: > The problem with the `-Wcast-align` is that it will only fire for C-style > bitcast expressions, not for `reinterpret_cast` ones. example > > Does anyone k

[PATCH] D62445: [test] Fix plugin tests

hintonda added a comment. In D62445#1527368 , @davezarzycki wrote: > This broke non-PIC builds. Fixed: r362399 Sorry for the breakage, and thanks for the fix! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62445/new/ htt

r362409 - [PR41567][Sema] Fixed cast kind in addr space conversions

Author: stulova Date: Mon Jun 3 08:42:36 2019 New Revision: 362409 URL: http://llvm.org/viewvc/llvm-project?rev=362409&view=rev Log: [PR41567][Sema] Fixed cast kind in addr space conversions This change sets missing cast kind correctly in the address space conversion case. Differential Revision

[PATCH] D62299: [PR41567][Sema] Fixed cast kind in addr space conversions

This revision was automatically updated to reflect the committed changes. Closed by commit rL362409: [PR41567][Sema] Fixed cast kind in addr space conversions (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM with minor comment. Comment at: libcxx/test/std/depr/depr.c.headers/stdint_h.sh.cpp:21 +// Test that limits macros are available when is included with +// or without macro _XOPEN_SOUECE

r362410 - Re-check in clang support gun asm goto after fixing tests.

Author: jyu2 Date: Mon Jun 3 08:57:25 2019 New Revision: 362410 URL: http://llvm.org/viewvc/llvm-project?rev=362410&view=rev Log: Re-check in clang support gun asm goto after fixing tests. Added: cfe/trunk/test/Analysis/asm-goto.cpp cfe/trunk/test/CodeGen/asm-goto.c cfe/trunk/test/Pa

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

xingxue marked 2 inline comments as done. xingxue added inline comments. Comment at: libcxx/test/std/depr/depr.c.headers/stdint_h.sh.cpp:21 +// Test that limits macros are available when is included with +// or without macro _XOPEN_SOUECE=700. + hubert.reinterpr

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

xingxue updated this revision to Diff 202734. xingxue added a comment. Addressed comments: - Fixed typo _XOPEN_SOUECE->_XOPEN_SOURCE Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59253/new/ https://reviews.llvm.org/D59253 Files: clang/lib/Heade

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet created this revision. kadircet added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62814 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet updated this revision to Diff 202739. kadircet added a comment. - Get rid of wrong check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62814/new/ https://reviews.llvm.org/D62814 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-ex

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov updated this revision to Diff 202745. ilya-biryukov marked 24 inline comments as done. ilya-biryukov added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov added a comment. I've addressed most of the comments, except the naming ones. We need a convention for naming the language nodes and names for composite and leaf structural nodes. For "language" nodes, I suggest we use `CompoundStatement`, `Recovery`, `TopLevelDeclaration`, `Temp

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Syntax/BuildTree.h:11 +// +// The code is divided in the following way: +// - 'Tree/Cascade.h' defines the basic structure of the syntax tree, This needs an update, will do in the next

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

ilya-biryukov added a comment. Do we care about pointers or references to lambda types? Comment at: clang-tools-extra/clangd/XRefs.cpp:662 + if (const DecltypeType *DT = + llvm::dyn_cast(VD->getType().getTypePtr())) +if (!DT->getUnderlyingType().isNull

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia updated this revision to Diff 202753. Anastasia retitled this revision from "[OpenCL][PR42033] Deducing addr space of pointer/reference with template parameter types" to "[OpenCL][PR42033] Deducing addr space with template parameter types". Anastasia edited the summary of this revision.

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia added a comment. In D62584#1522438 , @rjmccall wrote: > I think the right approach here is probably to make sure you're applying > deduction during instantiation as well. I agree I think we might need to extend the template instantiation logic

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/TreeTransform.h:5363 +if (ResultType.getAddressSpace() != LangAS::Default && +(ResultType.getAddressSpace() != LangAS::opencl_private)) { SemaRef.Diag(TL.getReturn

[PATCH] D62440: [analyzer] NFC: Change evalCall() to provide a CallEvent.

Szelethus accepted this revision. Szelethus added a comment. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62440/new/ https://reviews.llvm.org/D62440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

Re: r356569 - [NFC][clang][astdump] Some baseline tests for OpenMP

On Fri, 31 May 2019 at 16:20, Roman Lebedev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Sat, Jun 1, 2019 at 2:00 AM Richard Smith > wrote: > > > > These are change detector tests ( > https://testing.googleblog.com/2015/01/testing-on-toilet-change-detector-tests.html) > and create a

[PATCH] D62730: [RFC] Alternate implementation of D53157 IRBuilder for Constrained FP using enumeration vs MDNode and add support for fp-model and fp-speculation language options

mibintc abandoned this revision. mibintc added a comment. I'm abandoning this patch in deference to @kpn 's patch under review D53157 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62730/new/ https://reviews.llvm.org/D62730 ___

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

thakis added a comment. From what I can tell, the only client of OpenCLBuiltins.td is currently lib/Sema. Do you expect that to change? If not, does it make more sense to move the .td file to there? Do you expect OpenCLBuiltins.td to include other files in the future? At the moment, the `-I ${

[PATCH] D62623: Reduce memory consumption of coverage dumps

vsk added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1393 + size_t CoverageMappingSize = 0; + for (auto &S : CoverageMappings) { +CoverageMappingSize += S.size(); It doesn't look like the CoverageMappings std::vector is needed at

[PATCH] D62574: Initial draft of target-configurable address spaces.

Anastasia added a comment. In D62574#1527126 , @ebevhan wrote: > In D62574#1523835 , @Anastasia wrote: > > > > This patch does not address the issue with the accessors > > > on Qualifiers (isAddressSpaceSupersetOf,

r362434 - Permit Exception Spec mismatch with NoThrow on inherited Virtual

Author: erichkeane Date: Mon Jun 3 11:36:26 2019 New Revision: 362434 URL: http://llvm.org/viewvc/llvm-project?rev=362434&view=rev Log: Permit Exception Spec mismatch with NoThrow on inherited Virtual As reported here: https://bugs.llvm.org/show_bug.cgi?id=42100 This fairly common pattern ends

r362435 - Make NoThrow FunctionLike, make FunctionLike include references, fix

Author: erichkeane Date: Mon Jun 3 11:36:33 2019 New Revision: 362435 URL: http://llvm.org/viewvc/llvm-project?rev=362435&view=rev Log: Make NoThrow FunctionLike, make FunctionLike include references, fix prettyprint __declspec(nothrow) should work on function pointers as well as function refere

[PATCH] D62780: msabi: Fix exponential mangling time for even more contrived inputs

rnk added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:819-823 ArgBackRefMap::iterator Found = TemplateArgBackReferences.find(ND); if (Found == TemplateArgBackReferences.end()) { - // Mangle full template name into temporary buffer. - llvm::S

Re: [PATCH] D62133: test/CodeGen/builtin-stackaddress.c duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c

Will do. On Sun, Jun 2, 2019 at 5:43 AM A. Skrobov via Phabricator wrote: > > t.yomitch added a comment. > > Thanks Eric! > I don't have commit access; could someone please commit this for me? > > > Repository: > rC Clang > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D62133/new/ >

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 202772. dgoldman added a comment. - Fix diagnostics for ignored TypoExprs Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExprCXX.cpp test/Sema/typo-correctio

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:7713-7714 + // Add the newly created typos to the TypoExprs list, even if they + // failed to apply. This allows them to be reaped although they won't

Re: r362005 - Fix an unused-variable error.

If this is the only use of 'S', might be better/good to roll the expression into the assertion? On Wed, May 29, 2019 at 11:33 AM Haojian Wu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: hokein > Date: Wed May 29 11:36:54 2019 > New Revision: 362005 > > URL: http://llvm.org/viewvc

[PATCH] D59424: [OpenMP][NVPTX] Replace void** buffer by byte-wise buffer

gtbercea added a comment. Could you check if there is any change in the number of registers new scheme vs. old scheme? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59424/new/ https://reviews.llvm.org/D59424

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 202775. dgoldman marked an inline comment as done. dgoldman added a comment. - Fix discarded correction test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExp

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

gtbercea added a comment. Could you add some tests for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59319/new/ https://reviews.llvm.org/D59319 ___ cfe-commits mailing list cfe-commits@lists.llvm

r362443 - Fix test failure from r362435

Author: erichkeane Date: Mon Jun 3 12:57:52 2019 New Revision: 362443 URL: http://llvm.org/viewvc/llvm-project?rev=362443&view=rev Log: Fix test failure from r362435 Apparently I forgot to do an open brace in a namespace, so we get an error about an extra closing brace. Modified: cfe/trunk/

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

gtbercea added a comment. Could you check what the difference is between the same kernel in today's SPMD mode vs the SPMD mode produced via this method? Number of registers, instructions, checking everything gets optimized out as expected. The LLVM-IR should be almost identical. Repository:

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

rsmith added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:7762-7787 // Ensure none of the TypoExprs have multiple typo correction candidates // with the same edit length that pass all the checks and filters. // TODO: Properly handle various permutations of

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ added a comment. I disabled tests on Windows for now (rC362343 -> rC362347 ), but other than that the tests are working well, there was nothing to worry about. Repository: rL LLVM CHANGES SINCE LAST ACTION https:/

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh updated this revision to Diff 202790. lildmh edited the summary of this revision. lildmh added a comment. Implement the new mapper codegen scheme CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59474/new/ https://reviews.llvm.org/D59474 Files: include/clang/AST/GlobalDecl.h li

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 202795. serge-sans-paille added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - provide minimal documentation - fix testing configuration - validate locally with both shared and static libraries, using monorepo or

[PATCH] D60974: Clang IFSO driver action.

alexshap added inline comments. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:30 +uint8_t Binding; +MangledSymbol() = delete; +MangledSymbol(const std::string &Name, const std::string &ParentName, would be nice to have a newline be

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

philip.pfaffe added a subscriber: beanz. philip.pfaffe added a comment. I fear you'll need to plan at least for new pm right now. Otherwise your change will be obsolete in half a year. What is it really that LINK_X_INTO_TOOLS is supposed to do? Effectively bake in something that's consumable by

[PATCH] D60691: [ARM] Replace fp-only-sp and d16 with fp64 and d32.

JamesNagurne added a comment. Hi Simon et. al., I'm working on a downstream ARM toolchain and have downstreamed this change into our codebase. We saw that you've fixed the -mfpu=none issue and have taken that as well, but are still running into some issues. Prior to your change, the optionset "

[PATCH] D62556: [analyzer] NFC: CallDescription: Implement describing C library functions.

a_sidorin added a comment. Hi Artem, Looks mostly good, but I have some comments inline. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1064 // e.g. "{a, b}" represent the qualified names, like "a::b". std::vector QualifiedName; unsigned

[PATCH] D62557: [analyzer] Modernize CStringChecker to use CallDescriptions.

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62557/new/ https://reviews.llvm.org/D62557 ___ cfe-com

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Meinersbur requested changes to this revision. Meinersbur added a comment. This revision now requires changes to proceed. It still fails with the same error. `LINK_POLLY_INTO_TOOLS` is only set after the polly subdirectory is processed. Because it is an `option`, the ON value will be stored in t

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, jfb, rjmccall. Herald added subscribers: llvm-commits, kristina, arphaman, dexonsmith, jkorous, hiraditya. Herald added projects: clang, LLVM. http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0476r2.html This

[PATCH] D62780: msabi: Fix exponential mangling time for even more contrived inputs

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:819-823 ArgBackRefMap::iterator Found = TemplateArgBackReferences.find(ND); if (Found == TemplateArgBackReferences.end()) { - // Mangle full templat

r362459 - Add clang source minimizer that reduces source to directives

Author: arphaman Date: Mon Jun 3 15:59:17 2019 New Revision: 362459 URL: http://llvm.org/viewvc/llvm-project?rev=362459&view=rev Log: Add clang source minimizer that reduces source to directives that might affect the dependency list for a compilation This commit introduces a dependency directive

  1   2   >