hokein marked 2 inline comments as done.
hokein added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp:311
+ }
+ }
+ if (CEArg->isStdInitListInitialization())
----------------
gribozavr wrote:
> So `Foo(Bar{1, 2})` is not problematic, it is just that we can't tell it
> apart from `Foo({1,2})`?
Yes, the `Foo(Bar{1, 2})` is not problematic, we should ignore this case, as
discussed, I'll change it in a follow-up patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62736/new/
https://reviews.llvm.org/D62736
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
