[PATCH] D58429: [CodeGen] Enable the complex-math test for arm

phosek created this revision. phosek added a reviewer: peter.smith. Herald added subscribers: cfe-commits, jdoerfert, kristof.beyls. Herald added a project: clang. This test wasn't running due to a missing : after the RUN statement. Enabling this test revealed that it's actually broken. Reposito

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

kadircet updated this revision to Diff 187528. kadircet marked 2 inline comments as done. kadircet added a comment. - Move `handleDecl` call to top of the loop Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58293/new/ https://reviews.llvm.org/D58293 Files: incl

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

Szelethus added a comment. In D50488#1403197 , @mgrang wrote: > > It's because it invokes CodeChecker, which by default enables > > valist.Uninitialized, but not ValistBase. Do you have assert failures after > > my hotfix? > > @Szelethus Thanks. I run in

[PATCH] D58236: Make address space conversions a bit stricter.

ebevhan updated this revision to Diff 187531. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58236/new/ https://reviews.llvm.org/D58236 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/SemaCast.cpp lib/Sema/SemaExpr.cpp test/CodeGenOpenCL/numb

[clang-tools-extra] r354442 - [clangd] Testcase for bug 39811

Author: kadircet Date: Wed Feb 20 01:41:26 2019 New Revision: 354442 URL: http://llvm.org/viewvc/llvm-project?rev=354442&view=rev Log: [clangd] Testcase for bug 39811 Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, jdoerfert, cfe-commits Tags: #clang Differential Revision: http

[PATCH] D58133: [clangd] Testcase for bug 39811

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL354442: [clangd] Testcase for bug 39811 (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added

[PATCH] D58236: Make address space conversions a bit stricter.

ebevhan marked 2 inline comments as done. ebevhan added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6996 + "|%diff{casting $ to type $|casting between types}0,1}2" + " changes address space of nested pointer">; def err_typecheck_incompatible_ownersh

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

baloghadamsoftware added a comment. Thank you for working this. I totally agree with you: whenever the checker spawns a new node in the exploded graph there is no point to leave it unmarked and then revers engineer it. `BugReporterVisitor`s should only care for nodes which are not spawned by th

[PATCH] D58429: [CodeGen] Enable the complex-math test for arm

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the fix. My apologies for missing that at the time, it looks like a cut and paste error on my part. Repository: rC Clang CHANGES SINCE LAST ACTION https://revi

[clang-tools-extra] r354444 - [clangd] Try to fix windows build bots

Author: kadircet Date: Wed Feb 20 02:32:04 2019 New Revision: 35 URL: http://llvm.org/viewvc/llvm-project?rev=35&view=rev Log: [clangd] Try to fix windows build bots Modified: clang-tools-extra/trunk/unittests/clangd/XRefsTests.cpp Modified: clang-tools-extra/trunk/unittests/clangd/X

[PATCH] D58388: [OpenCL] Simplify LLVM IR generated for OpenCL blocks

Anastasia added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:1275 +// We *can* call the block directly unless it is a function argument. +if (!isa(E->getCalleeDecl())) + Func = CGM.getOpenCLRuntime().getInvokeFunction(E->getCallee()); I thin

[PATCH] D58278: Prepare ground for re-lexing modular headers.

alexfh added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58278/new/ https://reviews.llvm.org/D58278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D58236: Make address space conversions a bit stricter.

Anastasia added inline comments. Comment at: lib/Sema/SemaExpr.cpp:7795 +if (lhq.getAddressSpace() != rhq.getAddressSpace()) + return Sema::IncompatibleNestedPointerDiscardsQualifiers; + I am wondering since the behavior is so specialized for the

[PATCH] D57523: Fix uninitialized value in ABIArgInfo

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jdoerfert. Herald added a project: clang. I've been staring at this, trying to figure out if the code somehow ends up using the uninitialized values, but I can't find it.

[PATCH] D58436: [clang-format] Do not emit replacements if Java imports are OK

krasimir created this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. Currently clang-format would always emit a replacement for a block of Java imports even if it is correctly formatted: % cat /tmp/Aggregator.java import X; % clang-format /tmp/Ag

r354452 - [clang-format] Do not emit replacements if Java imports are OK

Author: krasimir Date: Wed Feb 20 03:44:21 2019 New Revision: 354452 URL: http://llvm.org/viewvc/llvm-project?rev=354452&view=rev Log: [clang-format] Do not emit replacements if Java imports are OK Summary: Currently clang-format would always emit a replacement for a block of Java imports even i

[PATCH] D58436: [clang-format] Do not emit replacements if Java imports are OK

This revision was automatically updated to reflect the committed changes. Closed by commit rL354452: [clang-format] Do not emit replacements if Java imports are OK (authored by krasimir, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[clang-tools-extra] r354453 - [clangd] Revert r354442 and r354444

Author: kadircet Date: Wed Feb 20 03:45:20 2019 New Revision: 354453 URL: http://llvm.org/viewvc/llvm-project?rev=354453&view=rev Log: [clangd] Revert r354442 and r35 Looks like sysroot is only working on linux. Modified: clang-tools-extra/trunk/unittests/clangd/XRefsTests.cpp Modified:

[PATCH] D57108: [clang-tidy] diagnose possibiltiy to add 'noexcept' in modernize-use-noexcept

baloghadamsoftware added a comment. Great! However, I would rename the test files: `modernize-use-noexcept-opt.cpp` is inaccurate since there are multiple options, it could be e.g. `modernize-use-noexcept-dont-use-noexcept-false.cpp`. `modernize-use-noexcept-new-noexcept.cpp` is a bit misleadin

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. Please, no more patches without context. This one was actually easy to review without context and the comments are minor, so I'm fine with these being addressed on the commit. =

[clang-tools-extra] r354456 - [clangd] Fix a typo. NFC

Author: ibiryukov Date: Wed Feb 20 04:31:44 2019 New Revision: 354456 URL: http://llvm.org/viewvc/llvm-project?rev=354456&view=rev Log: [clangd] Fix a typo. NFC The documentation for -index-file mentioned clang-index instead of clangd-indexer. Modified: clang-tools-extra/trunk/clangd/tool/Cl

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

nemanjai added a comment. In D49754#1402790 , @vit9696 wrote: > This is a series of patches, which I believe should merged altogether. > Currently the following patches are relevant: No, please don't merge them together. It is much more manageable for r

[PATCH] D57577: Make predefined FLT16 macros conditional on support for the type

nemanjai marked an inline comment as done. nemanjai added a comment. Herald added a subscriber: jdoerfert. Since I haven't seen any further objections to this, I'll commit this later today. Comment at: test/Preprocessor/init.c:9169 // WEBASSEMBLY-NEXT:#define __FLOAT128__ 1 -

[PATCH] D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'

ilya-biryukov created this revision. ilya-biryukov added reviewers: kadircet, sammccall. Herald added subscribers: arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. To take up the .clangd folder for other potential uses in the future. Repository: rG LLVM Github Monorepo https

Re: r354351 - Remove extraneous space in MSVC-style diagnostic output

Merged to release_80 in r354459. On Tue, Feb 19, 2019 at 5:57 PM Hans Wennborg via cfe-commits wrote: > > Author: hans > Date: Tue Feb 19 08:58:25 2019 > New Revision: 354351 > > URL: http://llvm.org/viewvc/llvm-project?rev=354351&view=rev > Log: > Remove extraneous space in MSVC-style diagnostic

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

ebevhan added inline comments. Comment at: lib/Sema/SemaCast.cpp:2224 + } else if (IsLValueCast) { Kind = CK_LValueBitCast; } else if (DestType->isObjCObjectPointerType()) { Anastasia wrote: > ebevhan wrote: > > Anastasia wrote: > > > ebevhan wrote: > >

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau updated this revision to Diff 187553. pgousseau added a comment. Applied suggested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 Files: include/clang/Basic/Attr.td include/clang/Basic/Sanitizers.def include/clang/Basic

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau marked 7 inline comments as done. pgousseau added inline comments. Comment at: include/clang/Basic/Sanitizers.h:96 +return false; +} +return true; riccibruno wrote: > Is that vectorized by gcc/clang, or is that a sequence of branches ? c

[PATCH] D53701: [Analyzer] Record and process comparison of symbols instead of iterator positions in interator checkers

baloghadamsoftware added a comment. Herald added a subscriber: jdoerfert. In D53701#1322255 , @NoQ wrote: > Well, i mean, whenever you are inlining a method, you //are// exposing > details of the "internals" of the inlined API to the user. The only > di

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/SemaCast.cpp:2224 + } else if (IsLValueCast) { Kind = CK_LValueBitCast; } else if (DestType->isObjCObjectPointerType()) { Anastasia wrote: > ebevhan wrote:

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/SemaCast.cpp:2224 + } else if (IsLValueCast) { Kind = CK_LValueBitCast; } else if (DestType->isObjCObjectPointerType()) { ebevhan wrote: > Anastasia wrote:

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. @nemanjai, sorry, under merging I meant committing into llvm upstream. Comment at: lib/Basic/Targets/PPC.cpp:318 + Features["spe"] = llvm::StringSwitch(CPU) +.Case("e500", true) +.Case("8548", true) -

[PATCH] D50256: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager (for == and != only)

baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added inline comments. Herald added a subscriber: jdoerfert. Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:576-597 + RangeSet New = getRange(St, Sym); + for (llvm::APSInt I = AdjustmentType

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

ebevhan added inline comments. Comment at: lib/Sema/SemaCast.cpp:2224 + } else if (IsLValueCast) { Kind = CK_LValueBitCast; } else if (DestType->isObjCObjectPointerType()) { Anastasia wrote: > ebevhan wrote: > > Anastasia wrote: > > > Anastasia wrote: >

[PATCH] D58446: [CodeComplete] Collect visited contexts when scope specifier is invalid.

ioeric created this revision. ioeric added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. This will allow completion consumers to guess the specified scope by putting together scopes in the context with the specified scope (e.g. when the

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

riccibruno accepted this revision. riccibruno marked an inline comment as done. riccibruno added a comment. This revision is now accepted and ready to land. LGTM with an additional comment. Comment at: include/clang/Basic/Sanitizers.h:81 + + explicit operator bool() { +for

[PATCH] D58448: [clangd] Improve global code completion when scope specifier is unresolved.

ioeric created this revision. ioeric added reviewers: ilya-biryukov, sammccall. Herald added subscribers: cfe-commits, jdoerfert, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Suppose `clangd::` is unresolved in the following example. Currently, we simply use "clangd::" as

[PATCH] D58447: [clangd] Fix a crash in Selection

ilya-biryukov created this revision. ilya-biryukov added reviewers: kadircet, sammccall. Herald added subscribers: arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. The assertion checking that the range of the node is a token range does not hold in case of "split" tokens, e.g. bet

[PATCH] D58447: [clangd] Fix a crash in Selection

ilya-biryukov updated this revision to Diff 187569. ilya-biryukov added a comment. - Fix a syntax error in the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58447/new/ https://reviews.llvm.org/D58447 Files: clang-tools-extra/clangd/Selectio

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

riccibruno requested changes to this revision. riccibruno added a comment. This revision now requires changes to proceed. Wait no, can you really define the `SanitizerMask`s in the header ? Isn't that an odr violation ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://r

[PATCH] D58447: [clangd] Fix a crash in Selection

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58447/new/ https://reviews.llvm.org/D58447 ___

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

Anastasia updated this revision to Diff 187573. Anastasia added a comment. Added a CodeGen test to cover address space of reference in `reinterpret_cast`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58346/new/ https://reviews.llvm.org/D58346 Files: include/clang/Basic/DiagnosticSem

[PATCH] D58388: [OpenCL] Simplify LLVM IR generated for OpenCL blocks

AlexeySotkin updated this revision to Diff 187575. AlexeySotkin added a comment. Fix resolving of block invoke function in case of sequence of assignments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58388/new/ https://reviews.llvm.org/D58388 Files: lib/CodeGen/CGBlocks.cpp lib/C

[PATCH] D58388: [OpenCL] Simplify LLVM IR generated for OpenCL blocks

AlexeySotkin marked an inline comment as done. AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:131 +static const BlockExpr *getBlockExpr(const Expr *E) { + if (auto Cast = dyn_cast(E)) { +E = Cast->getSubExpr(); Anastasia wrot

[PATCH] D58091: Customize warnings for missing built-in type

bcain accepted this revision. bcain added a comment. This revision is now accepted and ready to land. I can confirm that this fix is effective at addressing the problem we experienced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58091/new/ https

[PATCH] D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`

rdwampler added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58186/new/ https://reviews.llvm.org/D58186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau added a comment. In D57914#1404053 , @riccibruno wrote: > Wait no, can you really define the `SanitizerMask`s in the header ? Isn't > that an odr violation ? A yes I better move the definitions, thanks! CHANGES SINCE LAST ACTION https://re

[PATCH] D58449: Junk: Add assert to find GCCBuiltins with constant arguments missing

arsenm created this revision. arsenm added a reviewer: atanasyan. Herald added subscribers: jdoerfert, fedor.sergeev, aheejin, wdng, dschuff. Don't bother reviewing this, I have no intention of committing this hack to find builtins missing immarg https://reviews.llvm.org/D58449 Files: lib/Se

[PATCH] D58388: [OpenCL] Simplify LLVM IR generated for OpenCL blocks

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Great! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58388/new/ https://reviews.llvm.org/D58388 ___ cfe-commits mail

[PATCH] D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/index/BackgroundIndexStorage.cpp:75 llvm::SmallString<128> CDBDirectory(Directory); -llvm::sys::path::append(CDBDire

r354481 - [CodeGen] Enable the complex-math test for arm

Author: phosek Date: Wed Feb 20 08:53:08 2019 New Revision: 354481 URL: http://llvm.org/viewvc/llvm-project?rev=354481&view=rev Log: [CodeGen] Enable the complex-math test for arm This test wasn't running due to a missing : after the RUN statement. Enabling this test revealed that it's actually b

[PATCH] D58429: [CodeGen] Enable the complex-math test for arm

This revision was automatically updated to reflect the committed changes. Closed by commit rL354481: [CodeGen] Enable the complex-math test for arm (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

r354482 - Fix compile error with Intel's compiler (-Werror=pedantic)

Author: martong Date: Wed Feb 20 08:57:41 2019 New Revision: 354482 URL: http://llvm.org/viewvc/llvm-project?rev=354482&view=rev Log: Fix compile error with Intel's compiler (-Werror=pedantic) An extra semicolon at the end of macro invocations caused a build bot failure for Intel's compiler when

[clang-tools-extra] r354485 - Update property prefix regex to allow numbers.

Author: wizard Date: Wed Feb 20 09:32:41 2019 New Revision: 354485 URL: http://llvm.org/viewvc/llvm-project?rev=354485&view=rev Log: Update property prefix regex to allow numbers. Subscribers: jfb, cfe-commits Differential Revision: https://reviews.llvm.org/D56896 Modified: clang-tools-extr

[PATCH] D56896: Update property prefix regex to allow numbers.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354485: Update property prefix regex to allow numbers. (authored by Wizard, committed by ). Herald added a subscriber: jdoerfert. Herald added a project: clang. Changed prior to commit: https://review

r354486 - [OPENMP] Delay emission of the asm target-specific error messages.

Author: abataev Date: Wed Feb 20 09:42:57 2019 New Revision: 354486 URL: http://llvm.org/viewvc/llvm-project?rev=354486&view=rev Log: [OPENMP] Delay emission of the asm target-specific error messages. Summary: Added the ability to emit target-specific builtin assembler error messages only in case

[PATCH] D58243: [OPENMP] Delay emission of the asm target-specific error messages.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL354486: [OPENMP] Delay emission of the asm target-specific error messages. (authored by ABataev, committed by ). Herald ad

[PATCH] D58095: [clang-tidy] Make google-objc-function-naming ignore implicit functions 🙈

aaron.ballman added a comment. Still LGTM, thanks for adding the license snippet! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58095/new/ https://reviews.llvm.org/D58095 ___ cfe-commits mailing list c

[PATCH] D53701: [Analyzer] Record and process comparison of symbols instead of iterator positions in interator checkers

baloghadamsoftware updated this revision to Diff 187611. baloghadamsoftware added a comment. Instead of recording comparisons do an eager state split if the result is a symbolic value. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53701/new/ https://reviews.llvm.org/D53701 Files: li

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

aaron.ballman added inline comments. Comment at: lib/AST/ASTImporter.cpp:6140 +ExpectedStmt ASTNodeImporter::VisitChooseExpr(ChooseExpr *E) { + auto Imp = importSeq(E->getCond(), E->getLHS(), E->getRHS(), + E->getBuiltinLoc(), E->getRParenLoc(), E->getType(

[PATCH] D58365: [attributes] Add a MIG server routine attribute.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8702 +def warn_mig_server_routine_does_not_return_kern_return_t : Warning< + "'%0' attribute only applies to functions that return a kernel return code">, + InGroup; --

[PATCH] D58463: [CUDA]Delayed diagnostics for the asm instructions.

ABataev created this revision. ABataev added reviewers: tra, jlebar. Herald added a subscriber: jdoerfert. Herald added a project: clang. Adapted targetDiag for the CUDA and used for the delayed diagnostics in asm constructs. Works for both host and device compilation sides. Repository: rC Cla

[PATCH] D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'

ilya-biryukov updated this revision to Diff 187622. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Remove trailing slash from the path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58440/new/ https://reviews.llvm.o

[PATCH] D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/BackgroundIndexStorage.cpp:75 llvm::SmallString<128> CDBDirectory(Directory); -llvm::sys::path::append(CDBDirectory, ".clangd-index/"); +llvm::sys::path::append(CDBDirectory, ".clangd", "

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 187623. jkorous added a comment. [DirectoryWatcher] Fix detection of FSEvents for iOS [DirectoryWatcher][NFC] Doxygen CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 Files: clang/include/clang/DirectoryWat

[PATCH] D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'

ilya-biryukov updated this revision to Diff 187627. ilya-biryukov added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - Update .gitignore Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58440/new/ https://reviews.l

r354502 - [Clang Driver] Add support for "-static-pie" argument to the Clang driver.

Author: sivachandra Date: Wed Feb 20 11:07:04 2019 New Revision: 354502 URL: http://llvm.org/viewvc/llvm-project?rev=354502&view=rev Log: [Clang Driver] Add support for "-static-pie" argument to the Clang driver. Summary: This change mimics GCC's support for the "-static-pie" argument. Subscribe

r354503 - Fix remaining semicolon pedantic errors for intel

Author: martong Date: Wed Feb 20 11:07:36 2019 New Revision: 354503 URL: http://llvm.org/viewvc/llvm-project?rev=354503&view=rev Log: Fix remaining semicolon pedantic errors for intel Modified: cfe/trunk/unittests/AST/ASTImporterTest.cpp Modified: cfe/trunk/unittests/AST/ASTImporterTest.cpp

[clang-tools-extra] r354505 - [clangd] Store index in '.clangd/index' instead of '.clangd-index'

Author: ibiryukov Date: Wed Feb 20 11:08:06 2019 New Revision: 354505 URL: http://llvm.org/viewvc/llvm-project?rev=354505&view=rev Log: [clangd] Store index in '.clangd/index' instead of '.clangd-index' Summary: To take up the .clangd folder for other potential uses in the future. Reviewers: kad

[PATCH] D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'

This revision was automatically updated to reflect the committed changes. Closed by commit rL354505: [clangd] Store index in '.clangd/index' instead of '.clangd-index' (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D58440?vs=187627&id=187629#toc Repos

[PATCH] D58307: [Clang Driver] Add support for "-static-pie" argument to the Clang driver.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354502: [Clang Driver] Add support for "-static-pie" argument to the Clang driver. (authored by sivachandra, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein marked 2 inline comments as done. hokein added inline comments. Comment at: clangd/index/CanonicalIncludes.cpp:47 + // headers (e.g. std::move from and ), using + // qualified name can not disambiguate headers. Instead we should return all + // headers and do the disam

[PATCH] D58320: [Darwin] Introduce a new flag, -flink-builtins-rt that forces linking of the builtins library.

aemerson abandoned this revision. aemerson added a comment. After discussion on the thread, we can implement this requirement with -nolibc -nostdlib++ -nostartfiles Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58320/new/ https://reviews.llvm.org/

[clang-tools-extra] r354507 - [clangd] Fix a crash in Selection

Author: ibiryukov Date: Wed Feb 20 11:26:39 2019 New Revision: 354507 URL: http://llvm.org/viewvc/llvm-project?rev=354507&view=rev Log: [clangd] Fix a crash in Selection Summary: The assertion checking that a range of a node is a token range does not hold in case of "split" tokens, e.g. between t

[PATCH] D58447: [clangd] Fix a crash in Selection

This revision was automatically updated to reflect the committed changes. Closed by commit rL354507: [clangd] Fix a crash in Selection (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

mgorny added a comment. Also, don't forget that `inotify()` is not 100% reliable on Linux, and it can miss events under high loads. So technically you should probably include periodic directory scans if you are going to rely on this actually reporting every file added. Comme

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

JonasToth updated this revision to Diff 187634. JonasToth marked 2 inline comments as done. JonasToth added a comment. - [Refactor] move support classes into the analyzer - [Refactor] move bigger methods into implementation file - minor adjustments Repository: rCTE Clang Tools Extra CHANGES S

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

JonasToth marked 3 inline comments as done. JonasToth added a comment. all comments resolved. I will land this now. Comment at: clang-tidy/utils/ExceptionAnalyzer.h:26-31 + enum class State : std::int8_t { +Throwing,///< The function can definitly throw given an AST. +

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

JonasToth updated this revision to Diff 187635. JonasToth marked an inline comment as done. JonasToth added a comment. - be explicit about the State enumerator values Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57883/new/ https://reviews.llvm.org/

r354509 - [OPENMP] Use targetDiag for diagnostics of unsupported exceptions, NFC.

Author: abataev Date: Wed Feb 20 11:37:17 2019 New Revision: 354509 URL: http://llvm.org/viewvc/llvm-project?rev=354509&view=rev Log: [OPENMP] Use targetDiag for diagnostics of unsupported exceptions, NFC. Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp cfe/trunk/lib/Sema/SemaStmt.cpp Modif

[PATCH] D57577: Make predefined FLT16 macros conditional on support for the type

This revision was automatically updated to reflect the committed changes. Closed by commit rL354512: Make predefined FLT16 macros conditional on support for the type (authored by nemanjai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

r354512 - Make predefined FLT16 macros conditional on support for the type

Author: nemanjai Date: Wed Feb 20 12:27:33 2019 New Revision: 354512 URL: http://llvm.org/viewvc/llvm-project?rev=354512&view=rev Log: Make predefined FLT16 macros conditional on support for the type We unconditionally predefine these macros. However, they may be used to determine if the type is

[PATCH] D58365: [attributes] Add a MIG server routine attribute.

NoQ updated this revision to Diff 187656. NoQ marked 5 inline comments as done. NoQ added a comment. Fxd. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58365/new/ https://reviews.llvm.org/D58365 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/

[PATCH] D58365: [attributes] Add a MIG server routine attribute.

NoQ added inline comments. Comment at: clang/test/Sema/attr-mig.c:6 + +__attribute__((mig_server_routine)) kern_return_t var = KERN_SUCCESS; // expected-warning-re{{'mig_server_routine' attribute only applies to functions, Objective-C methods, and blocks{{$ + --

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

Charusso requested changes to this revision. Charusso added a comment. This revision now requires changes to proceed. First of all, thanks you for working on this, as I wanted to do the same, but I did not know how to. I did not know also that 15 of the checkers already implements `BugReporterVi

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

Charusso added a reviewer: Charusso. Charusso requested changes to this revision. Charusso added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp:113 + }); + C.addTransition(C.getState()->set(true), T);

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354517: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer (authored by JonasToth, committed by ). Changed prior to commit: https://reviews.llvm.org/D57883?vs=187635&id=187662#toc

[clang-tools-extra] r354517 - [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

Author: jonastoth Date: Wed Feb 20 13:04:36 2019 New Revision: 354517 URL: http://llvm.org/viewvc/llvm-project?rev=354517&view=rev Log: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer Summary: The analsis on the throwing behvaiour on functions and statements gave only a bin

[PATCH] D53076: [analyzer] Enhance ConditionBRVisitor to write out more information

Charusso added a comment. In D53076#1403436 , @NoQ wrote: > I'll take a closer look in a few days, sorry for the delays! The progress > you're making is fantastic and i really appreciate your work, but i have an > urgent piece of work of my own to deal w

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp:47 REGISTER_TRAIT_WITH_PROGRAMSTATE(ReleasedParameter, bool); `;` is not necessary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58368/new/ https://revie

[PATCH] D58314: [Driver] Sync ARM behavior between clang-as and gas.

danalbert updated this revision to Diff 187670. danalbert marked 6 inline comments as done. danalbert added a comment. Updated to address some review comments: - Additional tests for gnueabi/gnueabihf - Fixed behavior for `-mfpu=neon -mfloat-abi=soft`, added test. Repository: rG LLVM Github M

[PATCH] D58314: [Driver] Sync ARM behavior between clang-as and gas.

danalbert added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:277 + } + return ""; +} peter.smith wrote: > I'm a bit worried that we've changed the default behaviour for gnueabi[hf] > targets here. > For example with: > ``` > .text > v

[PATCH] D58463: [CUDA]Delayed diagnostics for the asm instructions.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Thank you. Comment at: lib/Sema/Sema.cpp:1494-1496 +if (getLangOpts().CUDAIsDevice) + return CUDADiagIfDeviceCode(Loc, DiagID); +return CUDADiagIfHostCode(Loc, DiagID)

[PATCH] D58477: [Driver] Fix float ABI default for Android ARMv8.

danalbert created this revision. danalbert added reviewers: srhines, pirama. Herald added subscribers: kristof.beyls, javed.absar. Herald added a project: clang. Android doesn't regress back to soft float after ARMv7 :) Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58477 File

[PATCH] D58478: [index-while-building] FileIndexRecord

jkorous created this revision. jkorous added reviewers: dexonsmith, nathawes, akyrtzi, arphaman, ioeric, malaperle. Herald added subscribers: cfe-commits, jdoerfert, mgorny. Herald added a project: clang. Basic data structures for index Tests are missing from this patch - will be covered properl

[PATCH] D58480: [clang] Add CMake target for installing clang's CMake exports

smeenai created this revision. smeenai added reviewers: beanz, phosek. Herald added a subscriber: mgorny. Herald added a project: clang. smeenai retitled this revision from "[clang] Add CMake target for clang's CMake exports" to "[clang] Add CMake target for installing clang's CMake exports". Thi

[PATCH] D58480: [clang] Add CMake target for installing clang's CMake exports

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58480/new/ https://reviews.llvm.org/D58480 ___

r354525 - [clang] Switch to LLVM_ENABLE_IDE

Author: smeenai Date: Wed Feb 20 15:08:43 2019 New Revision: 354525 URL: http://llvm.org/viewvc/llvm-project?rev=354525&view=rev Log: [clang] Switch to LLVM_ENABLE_IDE r344555 switched LLVM to guarding install targets with LLVM_ENABLE_IDE instead of CMAKE_CONFIGURATION_TYPES, which expresses the

[PATCH] D58284: [clang] Switch to LLVM_ENABLE_IDE

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58284/new/ https://reviews.llvm.org/D58284 ___

[PATCH] D58284: [clang] Switch to LLVM_ENABLE_IDE

This revision was automatically updated to reflect the committed changes. Closed by commit rL354525: [clang] Switch to LLVM_ENABLE_IDE (authored by smeenai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

  1   2   >