riccibruno accepted this revision. riccibruno marked an inline comment as done. riccibruno added a comment. This revision is now accepted and ready to land.
LGTM with an additional comment. ================ Comment at: include/clang/Basic/Sanitizers.h:81 + + explicit operator bool() { + for (const auto &Val : maskLoToHigh) ---------------- This operator should be const-qualified. ================ Comment at: include/clang/Basic/Sanitizers.h:96 + + SanitizerMask &operator&=(const SanitizerMask &RHS) { + for (unsigned k = 0; k < kNumElem; k++) ---------------- Nice, a round of applause for clang 8 I guess then. Thanks for looking! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits