baloghadamsoftware added a comment.

Great! However, I would rename the test files: `modernize-use-noexcept-opt.cpp` 
is inaccurate since there are multiple options, it could be e.g. 
`modernize-use-noexcept-dont-use-noexcept-false.cpp`. 
`modernize-use-noexcept-new-noexcept.cpp` is a bit misleading because of the 
`new` which is a valid C++ keyword. 
`modernize-use-noexcept-add-missing-noexcept.cpp` sounds better for me.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57108/new/

https://reviews.llvm.org/D57108



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to