[PATCH] D50616: [Fixed Point Arithmetic] FixedPointCast

2018-10-10 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan added a comment. I agree with John, after that I think it's fine for me. Repository: rC Clang https://reviews.llvm.org/D50616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

r344117 - [X86] Remove FeatureRTM from Skylake processor list

2018-10-10 Thread Craig Topper via cfe-commits
Author: ctopper Date: Wed Oct 10 00:43:45 2018 New Revision: 344117 URL: http://llvm.org/viewvc/llvm-project?rev=344117&view=rev Log: [X86] Remove FeatureRTM from Skylake processor list Summary: There are a LOT of Skylakes and later without TSX-NI. Examples: - SKL: https://ark.intel.com/products

[clang-tools-extra] r344118 - [clangd] Make FSProvider const-correct. NFC

2018-10-10 Thread Sam McCall via cfe-commits
Author: sammccall Date: Wed Oct 10 00:46:15 2018 New Revision: 344118 URL: http://llvm.org/viewvc/llvm-project?rev=344118&view=rev Log: [clangd] Make FSProvider const-correct. NFC Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp clang-tools-extra/trunk/clangd/ClangdServer.h c

[PATCH] D53042: [X86] Remove FeatureRTM from Skylake processor list

2018-10-10 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL344117: [X86] Remove FeatureRTM from Skylake processor list (authored by ctopper, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53042?vs=168

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

2018-10-10 Thread David CARLIER via Phabricator via cfe-commits
devnexen added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:323 Opts.ToolType = EfficiencySanitizerOptions::ESAN_CacheFrag; - else if (LangOpts.Sanitize.has(SanitizerKind::EfficiencyWorkingSet)) + else if (T.getOS() == Triple::Linux && +LangOpts.Sanitize.ha

[PATCH] D52654: [OpenCL][NFC] Unify ZeroToOCL* cast types

2018-10-10 Thread Alexey Sachkov via Phabricator via cfe-commits
AlexeySachkov updated this revision to Diff 168947. AlexeySachkov added a comment. Applied comments from Anastasia. Updated patch with more code unified https://reviews.llvm.org/D52654 Files: include/clang/AST/OperationKinds.def include/clang/Sema/Initialization.h lib/AST/Expr.cpp lib/A

[PATCH] D52654: [OpenCL][NFC] Unify ZeroToOCL* cast types

2018-10-10 Thread Alexey Sachkov via Phabricator via cfe-commits
AlexeySachkov marked an inline comment as done. AlexeySachkov added inline comments. Comment at: lib/Sema/SemaInit.cpp:5291 - Sequence.AddOCLZeroQueueStep(DestType); - return true; +Sequence.AddOCLZeroQueueStep(DestType); +return true; Anastasia wrote

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

2018-10-10 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:323 Opts.ToolType = EfficiencySanitizerOptions::ESAN_CacheFrag; - else if (LangOpts.Sanitize.has(SanitizerKind::EfficiencyWorkingSet)) + else if (T.getOS() == Triple::Linux && +LangOpts.Sanitize

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

2018-10-10 Thread David CARLIER via Phabricator via cfe-commits
devnexen added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:323 Opts.ToolType = EfficiencySanitizerOptions::ESAN_CacheFrag; - else if (LangOpts.Sanitize.has(SanitizerKind::EfficiencyWorkingSet)) + else if (T.getOS() == Triple::Linux && +LangOpts.Sanitize.ha

[PATCH] D52296: [Clang] - Add -gsingle-file-split-dwarf option.

2018-10-10 Thread George Rimar via Phabricator via cfe-commits
grimar added a comment. In https://reviews.llvm.org/D52296#1258677, @alexshap wrote: > @grimar, this is an interesting observation which I've had on my mind for > quite some time as well; a couple of things which I have not double-checked > yet - just in case - do both gold and lld completely i

r344125 - [MinGW] Fix passing a sanitizer lib name as dependent lib

2018-10-10 Thread Martin Storsjo via cfe-commits
Author: mstorsjo Date: Wed Oct 10 02:01:00 2018 New Revision: 344125 URL: http://llvm.org/viewvc/llvm-project?rev=344125&view=rev Log: [MinGW] Fix passing a sanitizer lib name as dependent lib Differential Revision: https://reviews.llvm.org/D52990 Modified: cfe/trunk/lib/CodeGen/TargetInfo.c

[PATCH] D52990: [MinGW] Fix passing a sanitizer lib name as dependent lib

2018-10-10 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC344125: [MinGW] Fix passing a sanitizer lib name as dependent lib (authored by mstorsjo, committed by ). Repository: rC Clang https://reviews.llvm.org/D52990 Files: lib/CodeGen/TargetInfo.cpp test

[PATCH] D53013: [MinGW] Support MinGW style library names for default library pragmas

2018-10-10 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo abandoned this revision. mstorsjo added a comment. Not needed as we placed this logic in lld, in https://reviews.llvm.org/D53017, for now. Repository: rC Clang https://reviews.llvm.org/D53013 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D53066: [RFC] [MinGW] Print paths with forward slashes in commands printed with -v

2018-10-10 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo created this revision. mstorsjo added reviewers: rnk, smeenai, compnerd, phosek, rupprecht. libtool inspects the output of `$CC -v` to detect what object files and libraries are linked in by default. When clang is built as a native windows executable, all paths are formatted with backsl

[PATCH] D53069: [analyzer][www] Update avaible_checks.html

2018-10-10 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, MTC, xazax.hun. Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, JDevlieghere, rnkovacs, szepet, whisperity. Title says it all. I never ever used ObjC, so I couldn't really add examples on many o

[PATCH] D53069: [analyzer][www] Update avaible_checks.html

2018-10-10 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus updated this revision to Diff 168966. Szelethus edited the summary of this revision. Szelethus added a reviewer: rnkovacs. https://reviews.llvm.org/D53069 Files: www/analyzer/available_checks.html Index: www/analyzer/available_checks.html =

[PATCH] D53069: [analyzer][www] Update avaible_checks.html

2018-10-10 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus added inline comments. Comment at: www/analyzer/available_checks.html:376-393 + +cplusplus.InnerPointer +(C++) +Check for inner pointers of C++ containers used after re/deallocation. + + + @rnkovacs Is this a good description of your checker? https://

[PATCH] D53069: [analyzer][www] Update avaible_checks.html

2018-10-10 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. I am not sure what to do about implcit checks. Those are probably should never be turned on or off by the user, but they should be on or off by default based on the set of checks the user enabled and the platform she is using. Thus, I am perfectly ok with the implicit

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

2018-10-10 Thread Firat Kasmis via Phabricator via cfe-commits
firolino added a comment. In https://reviews.llvm.org/D27621#1248849, @JonasToth wrote: > Hi @firolino, > I implemented a less general version of you check > https://reviews.llvm.org/D51949 as I wanted to achieve a slightly different > goal (and this revision seems to be abonded). My aim is to

[PATCH] D52806: [python] Support overriding library path via environment

2018-10-10 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a reviewer: steveire. mgorny added a comment. Gentle ping. https://reviews.llvm.org/D52806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53070: [CodeComplete] Fix crash when completing params function declarations.

2018-10-10 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: cfe-commits. In a decl like `int AA(BB cc)` where BB isn't defined, we end up trying to parse `BB cc` as an expression (vexing parse) and end up triggering the parser's "recovery-in-function" completi

[PATCH] D42242: Make libc++abi work with gcc's ARM unwind library

2018-10-10 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. @bebuch, I agree with @mclow.lists here that the new errors are completely unrelated to the problem solved by this patch, and the fix to it belongs in a separate changeset. Can we get the original problem fixed first then? https://reviews.llvm.org/D42242

[PATCH] D42242: Make libc++abi work with gcc's ARM unwind library

2018-10-10 Thread Benjamin Buch via Phabricator via cfe-commits
bebuch accepted this revision. bebuch added a comment. This revision is now accepted and ready to land. Okay, sorry for the blockage! https://reviews.llvm.org/D42242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

2018-10-10 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added a comment. In https://reviews.llvm.org/D51949#1257430, @JonasToth wrote: > @kbobyrev is it ok for you if I stick with the `Optional<>` style in the > check? Yes, I think it's fine. Thank you very much for working on the patch, I am indeed very excited about this check. Unfortu

[PATCH] D52967: Extend shelf-life by 70 years

2018-10-10 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon resigned from this revision. RKSimon added reviewers: rsmith, bruno, rtrieu. RKSimon added a comment. Sorry I'm not the right person to review this - adding some other potentials Repository: rC Clang https://reviews.llvm.org/D52967 ___ cf

[PATCH] D53070: [CodeComplete] Fix crash when completing params function declarations.

2018-10-10 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang https://reviews.llvm.org/D53070 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D53070: [CodeComplete] Fix crash when completing params function declarations.

2018-10-10 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC344133: [CodeComplete] Fix crash when completing params function declarations. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D53070?vs=168967&id=168974#toc R

r344133 - [CodeComplete] Fix crash when completing params function declarations.

2018-10-10 Thread Sam McCall via cfe-commits
Author: sammccall Date: Wed Oct 10 03:51:48 2018 New Revision: 344133 URL: http://llvm.org/viewvc/llvm-project?rev=344133&view=rev Log: [CodeComplete] Fix crash when completing params function declarations. Summary: In a decl like `int AA(BB cc)` where BB isn't defined, we end up trying to parse

[PATCH] D53069: [analyzer][www] Update avaible_checks.html

2018-10-10 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus added a comment. Thats a great idea. About implicit checks, they are so well hidden, I didn't even find them until I wanted to update the website (although, this is at least in part my fault, but why would anyone carefully read through a website that hasn't been touched for years?).

[PATCH] D51340: Add /Zc:DllexportInlines option to clang-cl

2018-10-10 Thread Takuto Ikuta via Phabricator via cfe-commits
takuto.ikuta updated this revision to Diff 168979. takuto.ikuta added a comment. address comment https://reviews.llvm.org/D51340 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/LangOptions.h clang/include/clang/Driver/CC1Options.td clang/include/clang/Driver/CLCompatO

[PATCH] D51340: Add /Zc:DllexportInlines option to clang-cl

2018-10-10 Thread Takuto Ikuta via Phabricator via cfe-commits
takuto.ikuta added a comment. Thank you for review! Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5599 +bool Sema::isInlineFunctionDLLExportable(const CXXMethodDecl *MD) { + assert(MD->isInlined()); hans wrote: > Okay, breaking out this logic is a little better

[PATCH] D53072: [clang-format] Introduce the flag which allows not to shrink lines

2018-10-10 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan created this revision. yvvan added reviewers: klimek, djasper, krasimir. Currently there's no way to prevent to lines optimization even if you have intentionally put to split the line. In general case it's fine. So I would prefer to have such option which you can enable in special cases

[PATCH] D53069: [analyzer][www] Update avaible_checks.html

2018-10-10 Thread Reka Kovacs via Phabricator via cfe-commits
rnkovacs added inline comments. Comment at: www/analyzer/available_checks.html:376-393 + +cplusplus.InnerPointer +(C++) +Check for inner pointers of C++ containers used after re/deallocation. + + + Szelethus wrote: > @rnkovacs Is this a good description of your c

[PATCH] D52727: [clang-tidy] White List Option for performance-unnecessary-value-param, performance-unnecessary-copy-initialization and performance-for-range-copy

2018-10-10 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware updated this revision to Diff 168993. baloghadamsoftware added a comment. Matching of allowed types happens now on the top-level type, not the canonical one. https://reviews.llvm.org/D52727 Files: clang-tidy/performance/ForRangeCopyCheck.cpp clang-tidy/performance/ForRan

[clang-tools-extra] r344140 - Lift VFS from clang to llvm (NFC)

2018-10-10 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Wed Oct 10 06:27:25 2018 New Revision: 344140 URL: http://llvm.org/viewvc/llvm-project?rev=344140&view=rev Log: Lift VFS from clang to llvm (NFC) This patch moves the virtual file system form clang to llvm so it can be used by more projects. Concretely the patch: - Mo

[PATCH] D52949: [Diagnostics] Implement -Wsizeof-pointer-div

2018-10-10 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. In https://reviews.llvm.org/D52949#1259947, @jfb wrote: > Can you add tests with arrays? Yes :) > The error message doesn't really say what to do instead. What's wrong? What's > correct instead? What do you suggest? "division produces the incorrect number of array e

[PATCH] D52773: clang-cl: Add /showFilenames option (PR31957)

2018-10-10 Thread Hans Wennborg via Phabricator via cfe-commits
hans updated this revision to Diff 168999. hans added a comment. Here's a version now using cc1 flags, but printing directly from the driver. Please take a look. https://reviews.llvm.org/D52773 Files: include/clang/Driver/CLCompatOptions.td include/clang/Driver/Job.h lib/Driver/Job.cpp

[PATCH] D51340: Add /Zc:DllexportInlines option to clang-cl

2018-10-10 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. Thanks! I think this is getting close now. Comment at: clang/lib/Sema/SemaDecl.cpp:11976 + +while (FD && !getDLLAttr(FD) && + !FD->hasAttr() && Why does this need to be a loop? I don't think FunctionDecl's can be nested? ==

[PATCH] D52727: [clang-tidy] White List Option for performance-unnecessary-value-param, performance-unnecessary-copy-initialization and performance-for-range-copy

2018-10-10 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a reviewer: JonasToth. lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LG unless @JonasToth or @aaron.ballman has any further comments. https://reviews.llvm.org/D52727

[PATCH] D53079: [OPENMP] Add 'dynamic_allocators' clause to OMP5.0 'requires' directive

2018-10-10 Thread Patrick Lyster via Phabricator via cfe-commits
patricklyster created this revision. patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice, kkwli0, hfinkel, gtbercea. patricklyster added a project: clang. Herald added subscribers: cfe-commits, arphaman, guansong. Added new `dynamic_allocators` clause to existing OMP5.0

[PATCH] D53079: [OPENMP] Add 'dynamic_allocators' clause to OMP5.0 'requires' directive

2018-10-10 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang https://reviews.llvm.org/D53079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D52857: Deprecate 'set output foo' API of clang-query

2018-10-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In https://reviews.llvm.org/D52857#1259522, @steveire wrote: > > What's more, given that clang-output has no real documentation to speak of, > > how will users even *know* to update their scripts? > > The release notes will tell them. That's not user friendly. >

[PATCH] D52857: Deprecate 'set output foo' API of clang-query

2018-10-10 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. > you have to find the right place to stick the `set dump-output true` in > order to enable it. What do you mean "the right place"? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52857 ___ cfe-commits m

[PATCH] D52857: Deprecate 'set output foo' API of clang-query

2018-10-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In https://reviews.llvm.org/D52857#1260455, @steveire wrote: > > you have to find the right place to stick the `set dump-output true` in > > order to enable it. > > What do you mean "the right place"? The point from which they want to enable dump outputting.

[PATCH] D53081: [clang-doc] Add unit tests for serialization

2018-10-10 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett created this revision. juliehockett added reviewers: leonardchan, jakehehrlich, lebedev.ri. juliehockett added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, mgorny. This is part of a move to convert clang-doc's tests to a more maintainable unit test fram

[PATCH] D53084: [clang-doc] Add unit tests for YAML

2018-10-10 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett created this revision. juliehockett added reviewers: leonardchan, jakehehrlich, lebedev.ri. juliehockett added a project: clang-tools-extra. Herald added a subscriber: mgorny. This is part of a move to convert clang-doc's tests to a more maintainable unit test framework, with a small

[PATCH] D53085: [clang-doc] Add unit tests for Markdown

2018-10-10 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett created this revision. juliehockett added reviewers: leonardchan, jakehehrlich, lebedev.ri. juliehockett added a project: clang-tools-extra. Herald added a subscriber: mgorny. This is part of a move to convert clang-doc's tests to a more maintainable unit test framework, with a small

[PATCH] D53076: [analyzer] WIP: Enhance ConditionBRVisitor to write out more information

2018-10-10 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus added a comment. I'm sadly not that knowledgeable on visitors to help you, but the idea is awesome, thank you for working on this! https://reviews.llvm.org/D53076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D53046: [Sema] Fix an error-on-valid with friends and templates

2018-10-10 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D53046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

r344146 - [clang] Properly apply attributes on explicit instantiations of static data members

2018-10-10 Thread Louis Dionne via cfe-commits
Author: ldionne Date: Wed Oct 10 08:32:29 2018 New Revision: 344146 URL: http://llvm.org/viewvc/llvm-project?rev=344146&view=rev Log: [clang] Properly apply attributes on explicit instantiations of static data members Summary: https://llvm.org/PR39118 Reviewers: aaron.ballman, rnk Subscribers:

[PATCH] D52675: [clang] Properly apply attributes on explicit instantiations of static data members

2018-10-10 Thread Louis Dionne via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL344146: [clang] Properly apply attributes on explicit instantiations of static data… (authored by ldionne, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D53038: [Hexagon] Use GetLinkerPath method instead of hard-coded linker name.

2018-10-10 Thread Sid Manning via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC344147: [Hexagon] Use GetLinkerPath instead of hard-coded string. (authored by sidneym, committed by ). Repository: rC Clang https://reviews.llvm.org/D53038 Files: lib/Driver/ToolChains/Hexagon.cpp

r344147 - [Hexagon] Use GetLinkerPath instead of hard-coded string.

2018-10-10 Thread Sid Manning via cfe-commits
Author: sidneym Date: Wed Oct 10 08:37:03 2018 New Revision: 344147 URL: http://llvm.org/viewvc/llvm-project?rev=344147&view=rev Log: [Hexagon] Use GetLinkerPath instead of hard-coded string. Add GetLinkerPath and set the default to "hexagon-link". Use GetLinkerPath instead of the hard-coded stri

[PATCH] D52857: Deprecate 'set output foo' API of clang-query

2018-10-10 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. > I don't see this functionality being so critical that we need to deprecate > the existing spelling when there are backwards compatible options available, > which is why I'm opposed to this patch going in with the proposed syntax. I don't think we're going to go anywh

[PATCH] D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected

2018-10-10 Thread Simon Atanasyan via Phabricator via cfe-commits
atanasyan added a comment. In https://reviews.llvm.org/D52418#1256189, @brad wrote: > Simon, and what about lib/Target/Mips/MCTargetDesc/MipsMCAsmInfo.cpp? Good point. In fact, integrated assembler for GNUABIN32 was enabled in the `MipsMCAsmInfo` ctor by me and by mistake. I have another patch

[PATCH] D51464: clang: fix MIPS/N32 triple and paths

2018-10-10 Thread Simon Atanasyan via Phabricator via cfe-commits
atanasyan added a comment. I'm going to test current MIPS N32 ABI implementation. Maybe we are ready to enable integrated assembler for it. In that case both `Generic_GCC::IsIntegratedAssemblerDefault()` and `MipsMCAsmInfo` ctor can be simplified. https://reviews.llvm.org/D51464 __

r344148 - [OpenCL] Fixed address space cast in C style cast of C++ parsing

2018-10-10 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Wed Oct 10 09:05:22 2018 New Revision: 344148 URL: http://llvm.org/viewvc/llvm-project?rev=344148&view=rev Log: [OpenCL] Fixed address space cast in C style cast of C++ parsing C style cast in OpenCL C++ was ignoring the address space conversions from OpenCL C and as a resul

[PATCH] D52598: [OpenCL] Fixed address space cast in C style cast of C++ parsing

2018-10-10 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia closed this revision. Anastasia added a comment. Committed in r344148. The review link was forgotten and therefore didn't get closed automatically. https://reviews.llvm.org/D52598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D52891: [AMDGPU] Add -fvisibility-amdgpu-non-kernel-functions

2018-10-10 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In https://reviews.llvm.org/D52891#1258070, @scott.linder wrote: > I will update the patch to modify the HIP toolchain and to add tests for > global variables. > > As far as the semantics are concerned, are we OK with this being AMDGPU only? > I do not see a means of det

[PATCH] D46441: [clang][CodeGenCXX] Noalias attr for 'this' parameter

2018-10-10 Thread Anton Bikineev via Phabricator via cfe-commits
AntonBikineev added a comment. @rsmith, thanks. Le'ts see if there is a need for the command-line option down the road. Repository: rL LLVM https://reviews.llvm.org/D46441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D42242: Make libc++abi work with gcc's ARM unwind library

2018-10-10 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists closed this revision. mclow.lists added a comment. Committed as revision 344152 https://reviews.llvm.org/D42242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected

2018-10-10 Thread Brad Smith via Phabricator via cfe-commits
brad added a comment. IMHO it would be best to try and deal with as many known / exposed issues with the N32 support and then just enable IAS across the board. Then tackle any remaining issues as they come up. Repository: rC Clang https://reviews.llvm.org/D52418 _

[PATCH] D52784: [ARM][AArch64] Pass through endianness flags to the GNU assembler

2018-10-10 Thread Peter Smith via Phabricator via cfe-commits
peter.smith added a comment. Ping. Does anyone have any changes they'd like me to make? https://reviews.llvm.org/D52784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r344157 - [Sema] Fix a multiple definition bug with friends and templates

2018-10-10 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Wed Oct 10 10:17:51 2018 New Revision: 344157 URL: http://llvm.org/viewvc/llvm-project?rev=344157&view=rev Log: [Sema] Fix a multiple definition bug with friends and templates The problem was that MergeFunctionDecl sometimes needs the injected template arguments of a FunctionT

[PATCH] D53046: [Sema] Fix an error-on-valid with friends and templates

2018-10-10 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL344157: [Sema] Fix a multiple definition bug with friends and templates (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53

[PATCH] D53076: [analyzer] WIP: Enhance ConditionBRVisitor to write out more information

2018-10-10 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov added a comment. The change makes sense to me, but: 1. Note that "Assuming X" directives are useful for the analyzer developers, since they know that's where the checker makes arbitrary assumptions, but to end users that mostly feels like noise ("Taking true branch" is there al

[PATCH] D52857: Deprecate 'set output foo' API of clang-query

2018-10-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. @steveire and I chatted over IRC and I wanted to capture another alternate proposal idea as part of the review (we did not reach agreement on this proposal, however). I've provided it side-by-side with the other proposals for comparison purposes. # Original pro

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

2018-10-10 Thread Oleg Smolsky via Phabricator via cfe-commits
oleg.smolsky added a comment. @djasper @klimek could you chime in please? This patch strives to cleanup a quirk in lambda formatting which pushes code too far to the right. Here is the problematic case: void f() { something.something.something.Method(some_arg,

r344159 - [clang] Fix failing attribute test on Windows

2018-10-10 Thread Louis Dionne via cfe-commits
Author: ldionne Date: Wed Oct 10 10:37:37 2018 New Revision: 344159 URL: http://llvm.org/viewvc/llvm-project?rev=344159&view=rev Log: [clang] Fix failing attribute test on Windows The test added in r344146 was failing because the ABI on Windows is different, and that test includes ABI-specific de

[PATCH] D53069: [analyzer][www] Update avaible_checks.html

2018-10-10 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov requested changes to this revision. george.karpenkov added a comment. This revision now requires changes to proceed. Herald added a subscriber: donat.nagy. Great idea, thanks! Should be good to go once examples are added, and implicit checks are removed. Comme

[PATCH] D53069: [analyzer][www] Update avaible_checks.html

2018-10-10 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus added a comment. Well, the reason why I didn't add tests for these, is that I know so little of ObjC, I am not even sure when a test case begins and ends. I could go ahead and google something about the language, but for a site that advertises to find bugs, maybe someone with more exp

[PATCH] D52984: [analyzer] Checker reviewer's checklist

2018-10-10 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov added a comment. Herald added a subscriber: donat.nagy. @Szelethus @xazax.hun Since you guys are looking into the website, do you know why the top bar has disappeared from all pages? (E.g. http://clang-analyzer.llvm.org/available_checks.html ) https://reviews.llvm.org/D52984

[PATCH] D46027: [clang-tidy] Fix PR35824

2018-10-10 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. In https://reviews.llvm.org/D46027#1259989, @ZaMaZaN4iK wrote: > What is the status of the PR? I believe xazax doesnt have time to work further, you can commandeer if you want :) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46027 _

[PATCH] D52984: [analyzer] Checker reviewer's checklist

2018-10-10 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus added a comment. I noticed it too, it's already on my TODO list. Didn't look into the causes just yet though. https://reviews.llvm.org/D52984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D52784: [ARM][AArch64] Pass through endianness flags to the GNU assembler

2018-10-10 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. I think we should pass these flags along to the linker, too. Not just the assembler. Maybe within tools::gnutools::Linker::ConstructJob() within lib/Driver/ToolChains/Gnu.cpp? https://reviews.llvm.org/D52784 ___ c

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

2018-10-10 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a comment. Updated tests again. This time I've closed all applications, all unused services, and tried to have a "clean" machine. New timings without the child `clang-cl.exe` being invoked (hacked from https://reviews.llvm.org/D52411). The test consists in building Clang+LLVM+LLD

[PATCH] D53100: clang: Add ARCTargetInfo

2018-10-10 Thread Tatyana Krasnukha via Phabricator via cfe-commits
tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: petecoup, rjmccall, rsmith. tatyana-krasnukha added a project: clang. Herald added subscribers: cfe-commits, mgorny. This patch is an updated version of https://reviews.llvm.org/D43089 with changes in arguments classifyin

[PATCH] D53076: [analyzer] WIP: Enhance ConditionBRVisitor to write out more information

2018-10-10 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso added subscribers: baloghadamsoftware, whisperity. Charusso added a comment. In https://reviews.llvm.org/D53076#1260663, @george.karpenkov wrote: > The change makes sense to me, but: > > 1. Note that "Assuming X" directives are useful for the analyzer developers, > since they know that'

Re: [PATCH] D52193: RFC: [clang] Multithreaded compilation support

2018-10-10 Thread Zachary Turner via cfe-commits
I can try to get some timings from my machine. How do we handle crash recovery in the case where we don't spawn a child process? I thought the whole reason for spawning the cc1 driver as a separate process was so that we could collect and report crash information in a nice way. Not having that s

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

2018-10-10 Thread Zachary Turner via Phabricator via cfe-commits
zturner added a comment. I can try to get some timings from my machine. How do we handle crash recovery in the case where we don't spawn a child process? I thought the whole reason for spawning the cc1 driver as a separate process was so that we could collect and report crash information in a ni

[PATCH] D53101: [ARC] Add option for enabling reduced register file mode

2018-10-10 Thread Tatyana Krasnukha via Phabricator via cfe-commits
tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: petecoup. tatyana-krasnukha added a project: clang. Herald added subscribers: cfe-commits, mgorny. tatyana-krasnukha added a dependency: D53100: clang: Add ARCTargetInfo. This option affects registers count for passing ar

[PATCH] D53102: Support for the mno-tls-direct-seg-refs flag

2018-10-10 Thread Ruslan Nikolaev via Phabricator via cfe-commits
nruslan created this revision. nruslan added reviewers: hans, craig.topper. Herald added a subscriber: cfe-commits. Allows to disable direct TLS segment access (%fs or %gs). GCC supports a similar flag, it can be useful in some circumstances, e.g. when a thread context block needs to be updated

[PATCH] D52784: [ARM][AArch64] Pass through endianness flags to the GNU assembler

2018-10-10 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: lib/Driver/ToolChains/Gnu.cpp:543-549 +static const char* GetEndianArg(bool IsBigEndian, const ArgList &Args) { + if (Arg *A = Args.getLastArg(options::OPT_mlittle_endian, + options::OPT_mbig_endian

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

2018-10-10 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a comment. In https://reviews.llvm.org/D52193#1260862, @zturner wrote: > I can try to get some timings from my machine. How do we handle crash > recovery in the case where we don't spawn a child process? I thought the > whole reason for spawning the cc1 driver as a separate proce

[PATCH] D52973: Add type_info predefined decl

2018-10-10 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In https://reviews.llvm.org/D52973#1259992, @mwasplund wrote: > In https://reviews.llvm.org/D52973#1259909, @rsmith wrote: > > > Generally this looks good, but it needs an accompanying test. > > > I was looking into that and trying to read up on the documentation for addin

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

2018-10-10 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. In https://reviews.llvm.org/D52193#1260933, @aganea wrote: > I wrote a fully fledged crash reporting system which does that, so I know > that's possible. The tricky thing is to ensure > `Driver::generateCompilationDiagnostics()` doesn't touch potentially invalid > structur

[PATCH] D52773: clang-cl: Add /showFilenames option (PR31957)

2018-10-10 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. lgtm Comment at: lib/Driver/Job.cpp:319 + if (PrintInputFilenames) { +for (const char *Arg : InputFilenames) + llvm::outs() << llvm::sys::path::filename(Arg) << "\n"; Huh, a -cc1 action can have multipl

Re: [clang-tools-extra] r280840 - Add a clang-tidy visual studio extension.

2018-10-10 Thread Aaron Ballman via cfe-commits
On Wed, Sep 7, 2016 at 2:37 PM Zachary Turner via cfe-commits wrote: > > Author: zturner > Date: Wed Sep 7 13:28:55 2016 > New Revision: 280840 > > URL: http://llvm.org/viewvc/llvm-project?rev=280840&view=rev > Log: > Add a clang-tidy visual studio extension. > > For now this only adds the UI nec

Re: [clang-tools-extra] r280840 - Add a clang-tidy visual studio extension.

2018-10-10 Thread Zachary Turner via cfe-commits
Honestly I hadn’t thought about this ever since the patch. Out of curiosity, have you tried the clang power tools extension? I think it’s more actively maintained and at this point probably even is good enough that this one could just go away On Wed, Oct 10, 2018 at 1:52 PM Aaron Ballman wrote: >

Re: [clang-tools-extra] r280840 - Add a clang-tidy visual studio extension.

2018-10-10 Thread Aaron Ballman via cfe-commits
On Wed, Oct 10, 2018 at 4:54 PM Zachary Turner wrote: > > Honestly I hadn’t thought about this ever since the patch. Out of curiosity, > have you tried the clang power tools extension? I think it’s more actively > maintained and at this point probably even is good enough that this one could > j

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

2018-10-10 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. Herald added a subscriber: arphaman. This looks great, thanks! In https://reviews.llvm.org/D36527#892395, @hamzasood wrote: > Could you expand on your first point a bit more? Do you have an example that > shows the issue? You have very little test coverage for the case

Re: [clang-tools-extra] r280840 - Add a clang-tidy visual studio extension.

2018-10-10 Thread Zachary Turner via cfe-commits
Yea, that’s actually another reason I suggest trying the Clang Power Tools extension. It seems to have “won” in this area, and few people ever used the LLVM one to begin with. On Wed, Oct 10, 2018 at 2:09 PM Aaron Ballman wrote: > On Wed, Oct 10, 2018 at 4:54 PM Zachary Turner wrote: > > > > Hon

Re: [clang-tools-extra] r280840 - Add a clang-tidy visual studio extension.

2018-10-10 Thread Aaron Ballman via cfe-commits
On Wed, Oct 10, 2018 at 5:11 PM Zachary Turner wrote: > > Yea, that’s actually another reason I suggest trying the Clang Power Tools > extension. It seems to have “won” in this area, and few people ever used the > LLVM one to begin with. Given that this isn't being updated and it may not work,

[PATCH] D53109: [Driver] Default Android toolchains to libc++.

2018-10-10 Thread Dan Albert via Phabricator via cfe-commits
danalbert created this revision. danalbert added reviewers: srhines, pirama. Herald added a reviewer: EricWF. Repository: rC Clang https://reviews.llvm.org/D53109 Files: lib/Driver/ToolChains/Linux.cpp lib/Driver/ToolChains/Linux.h test/Driver/android-ndk-standalone.cpp Index: test/Driv

[PATCH] D50766: Fix false positive unsequenced access and modification warning in array subscript expression.

2018-10-10 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete added a comment. Sorry, for some reason I didn't see your updates. Can you add a test for C++17? Then your patch is good to go! :) https://reviews.llvm.org/D50766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D53109: [Driver] Default Android toolchains to libc++.

2018-10-10 Thread Dan Albert via Phabricator via cfe-commits
danalbert planned changes to this revision. danalbert added a comment. Oops, ignore this for a moment. Accidentally ran `check-cxx` instead of `check-clang`. Repository: rC Clang https://reviews.llvm.org/D53109 ___ cfe-commits mailing list cfe-c

[PATCH] D53109: [Driver] Default Android toolchains to libc++.

2018-10-10 Thread Dan Albert via Phabricator via cfe-commits
danalbert updated this revision to Diff 169097. danalbert added a comment. Fixed bad merge conflict resolution. Repository: rC Clang https://reviews.llvm.org/D53109 Files: lib/Driver/ToolChains/Linux.cpp lib/Driver/ToolChains/Linux.h test/Driver/android-ndk-standalone.cpp Index: test/

[PATCH] D53076: [analyzer] WIP: Enhance ConditionBRVisitor to write out more information

2018-10-10 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In https://reviews.llvm.org/D53076#1260663, @george.karpenkov wrote: > 1. Note that "Assuming X" directives are useful for the analyzer developers, > since they know that's where the checker makes arbitrary assumptions, but to > end users that mostly feels like noise ("Taki

[PATCH] D53052: [AST] Use -fvisibility value when ignoring -fv-i-h* inline static locals

2018-10-10 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC344190: [AST] Use -fvisibility value when ignoring -fv-i-h* inline static locals (authored by rnk, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.o

r344190 - [AST] Use -fvisibility value when ignoring -fv-i-h* inline static locals

2018-10-10 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Oct 10 14:59:56 2018 New Revision: 344190 URL: http://llvm.org/viewvc/llvm-project?rev=344190&view=rev Log: [AST] Use -fvisibility value when ignoring -fv-i-h* inline static locals Summary: In r340386 we added code to give static locals in inline functions default visibility

  1   2   >