george.karpenkov added a comment.

The change makes sense to me, but:

1. Note that "Assuming X" directives are useful for the analyzer developers, 
since they know that's where the checker makes arbitrary assumptions, but to 
end users that mostly feels like noise ("Taking true branch" is there already, 
why there should be "Assuming 'i' is > 0" as well?)

2. @NoQ do you know why the GDM comparison was there in the first place? The 
commit was made by Ted in 2011, maybe constraint changes had to be reflected in 
the GDM at that point (?)


https://reviews.llvm.org/D53076



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to