[PATCH] D52296: [Clang] - Add -gsingle-file-split-dwarf option.

grimar added a comment. Ping. https://reviews.llvm.org/D52296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52419: [clangd] Cache FS stat() calls when building preamble.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry for dropping this. Comment at: clangd/ClangdUnit.h:58 IncludeStructure Includes; + std::unique_ptr StatCache; }; This deserves a comment, ev

[PATCH] D50179: [AArch64][ARM] Context sensitive meaning of option "crypto"

SjoerdMeijer added a comment. @efriedma : apologies for the ping, but does this look reasonable? https://reviews.llvm.org/D50179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52722: [analyzer] Move StdCLibraryFunctions to apiModeling

donat.nagy added a subscriber: martong. donat.nagy added a comment. I don't have commit rights, please commit for me @NoQ or @martong Repository: rC Clang https://reviews.llvm.org/D52722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D52554: [WIP] [clangd] Tests for special methods code-completion

sammccall added a comment. The assertions themselves all look good to me. I don't think these should be new tests, they have substantial overlap with TestAfterDotCompletion and should be incorporated there or those tests split up to reduce the duplication. (It's hard to avoid overlap/redundancy

[PATCH] D52549: [VFS] Add a VFS wrapper which avoids opening nonexistent files by reading dirs.

sammccall planned changes to this revision. sammccall marked an inline comment as done. sammccall added a comment. Hmm, after fixing the stat issue, this still doesn't seem to make a big difference on real FSes. Putting this on hold for now. We do have VFSes where I think this might be a win, but

[PATCH] D52549: [VFS] Add a VFS wrapper which avoids opening nonexistent files by reading dirs.

sammccall updated this revision to Diff 167888. sammccall added a comment. latest snapshot Repository: rC Clang https://reviews.llvm.org/D52549 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/AvoidStatsVFS.cpp lib/Basic/CMakeLists.txt lib/Basic/VirtualFileSystem.cpp unitte

Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

On 28/09/2018 03:16, Richard Smith via cfe-commits wrote: Author: rsmith Date: Thu Sep 27 18:16:43 2018 New Revision: 343285 URL: http://llvm.org/viewvc/llvm-project?rev=343285&view=rev Log: [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only render the function deleted instead o

[PATCH] D52647: [CodeComplete] Re-fix accessibilty of protected members from base class.

ioeric added a comment. Herald added a subscriber: arphaman. ping Repository: rC Clang https://reviews.llvm.org/D52647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52742: [analyzer][WIP] Add macro expansions to the plist output

whisperity added a subscriber: gamesh411. whisperity added a comment. Your code looks good, just minor comments going on inline. Trying to think of more cases to test for, in case someone generously misuses FLMs, as seen here in an example if you scroll down a bit: https://gcc.gnu.org/onlinedocs

[PATCH] D52773: clang-cl: Add /showFilenames option (PR31957)

hans created this revision. hans added reviewers: rnk, thakis, zturner, steveire. Add a /showFilenames option for users who want clang to echo the currently compiled filename. MSVC does this echoing by default, and it's useful for showing progress in build systems that doesn't otherwise provide

[PATCH] D52715: [clangd] Dex iterator printer shows query structure, not iterator state.

ioeric accepted this revision. ioeric added inline comments. This revision is now accepted and ready to land. Comment at: unittests/clangd/DexTests.cpp:239 + auto Tree = createLimit(createAnd(move(I1), move(I2)), 10); + EXPECT_EQ(llvm::to_string(*Tree), "(LIMIT 10 (& [1 3 5] T=

[clang-tools-extra] r343564 - [clang-tidy] NFC use CHECK-NOTES in tests for cppcoreguidelines-owning-memory

Author: jonastoth Date: Tue Oct 2 02:38:20 2018 New Revision: 343564 URL: http://llvm.org/viewvc/llvm-project?rev=343564&view=rev Log: [clang-tidy] NFC use CHECK-NOTES in tests for cppcoreguidelines-owning-memory Reviewers: alexfh, aaron.ballman, hokein Reviewed By: alexfh Subscribers: nemanja

r343566 - [AArch64][v8.5A] Test clang option for the Memory Tagging Extension

Author: olista01 Date: Tue Oct 2 02:38:59 2018 New Revision: 343566 URL: http://llvm.org/viewvc/llvm-project?rev=343566&view=rev Log: [AArch64][v8.5A] Test clang option for the Memory Tagging Extension The implementation of this is in TargetParser, so we only need to add a test for it in clang.

[clang-tools-extra] r343565 - [clang-tidy] NFC use CHECK-NOTES in test for cppgoreguidelines-avoid-goto

Author: jonastoth Date: Tue Oct 2 02:38:26 2018 New Revision: 343565 URL: http://llvm.org/viewvc/llvm-project?rev=343565&view=rev Log: [clang-tidy] NFC use CHECK-NOTES in test for cppgoreguidelines-avoid-goto Reviewers: alexfh, aaron.ballman, hokein Reviewed By: alexfh Subscribers: nemanjai, x

[PATCH] D52493: [AArch64][v8.5A] Test clang option for the Memory Tagging Extension

This revision was automatically updated to reflect the committed changes. Closed by commit rC343566: [AArch64][v8.5A] Test clang option for the Memory Tagging Extension (authored by olista01, committed by ). Changed prior to commit: https://reviews.llvm.org/D52493?vs=166910&id=167900#toc Repos

[PATCH] D52687: [clang-tidy] NFC use CHECK-NOTES in tests for cppcoreguidelines-owning-memory

This revision was automatically updated to reflect the committed changes. Closed by commit rL343564: [clang-tidy] NFC use CHECK-NOTES in tests for cppcoreguidelines-owning-memory (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://review

[PATCH] D52686: [clang-tidy] NFC use CHECK-NOTES in test for cppgoreguidelines-avoid-goto

This revision was automatically updated to reflect the committed changes. Closed by commit rL343565: [clang-tidy] NFC use CHECK-NOTES in test for cppgoreguidelines-avoid-goto (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.ll

r343568 - [clang] Implement Override Suggestions in Sema.

Author: kadircet Date: Tue Oct 2 02:42:31 2018 New Revision: 343568 URL: http://llvm.org/viewvc/llvm-project?rev=343568&view=rev Log: [clang] Implement Override Suggestions in Sema. Summary: In clangd we had a new type of completion suggestions for cpp class/struct/unions that will show override

[clang-tools-extra] r343567 - [clangd] Remove override result handling logic from clangd

Author: kadircet Date: Tue Oct 2 02:42:17 2018 New Revision: 343567 URL: http://llvm.org/viewvc/llvm-project?rev=343567&view=rev Log: [clangd] Remove override result handling logic from clangd Summary: Since we plan to move handling of override suggestions to Sema with D52225 this patch just mak

[PATCH] D52226: [clangd] Remove override result handling logic from clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE343567: [clangd] Remove override result handling logic from clangd (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D52226?vs=167075&id=167901#toc Repository:

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

This revision was automatically updated to reflect the committed changes. Closed by commit rC343568: [clang] Implement Override Suggestions in Sema. (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D52225?vs=167717&id=167902#toc Repository: rC Clang h

[PATCH] D52727: [clang-tidy] White List Option for performance-unnecessary-value-param, performance-unnecessary-copy-initialization and performance-for-range-copy

JonasToth added inline comments. Comment at: clang-tidy/performance/ForRangeCopyCheck.cpp:49 + // Skip whitelisted types + const auto VarType = Var->getType(); + if (std::find_if(WhiteListTypes.begin(), WhiteListTypes.end(), lebedev.ri wrote: > I'm not sure wh

[PATCH] D52774: [Preprocessor] Fix an assertion failure trigged in clangd #include completion.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. - Fix an assertion, the Filename should fallback to the written name in the code if the correct typo heuristic fails. - Fix an inconsistent is

[PATCH] D52775: [clangd] Add a #include completion test that triggers an assertion.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Test for https://reviews.llvm.org/D52774. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52775 Files: unittests/clangd/Cod

Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

I'm confused about what implicitly deleted means. In this code for example: struct S { S(const S&) = default; S& operator=(const S&) = default; const int x; }; void f(S &s) { S t = s; } Clang will warn that operator= is implicitly deleted. But it seems the code still works fine, whereas

[PATCH] D52774: [Preprocessor] Fix an assertion failure trigged in clangd #include completion.

hokein added a comment. For reference, the crash stack is like: ClangdTests: ../include/llvm/ADT/StringSet.h:39: std::pair llvm::StringSet::insert(llvm::StringRef) [AllocatorTy = llvm::MallocAllocator]: Assertion `!Key.empty()' failed. #0 0x0061e5ff llvm::sys::PrintStackTrace(llvm::

Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

On Tue, Oct 2, 2018 at 12:02 PM, Hans Wennborg wrote: > I'm confused about what implicitly deleted means. In this code for example: > > struct S { > S(const S&) = default; > S& operator=(const S&) = default; > const int x; > }; > > void f(S &s) { > S t = s; > } > > Clang will warn that ope

[PATCH] D52647: [CodeComplete] Re-fix accessibilty of protected members from base class.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D52647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D52711: [clangd] Dex: add Corpus factory for iterators, rename, fold constant. NFC

ioeric accepted this revision. ioeric added inline comments. This revision is now accepted and ready to land. Comment at: clangd/index/dex/Iterator.h:131 +struct Corpus { + DocID Size; + Maybe make this a constant and initialize it via a constructor? Repositor

[PATCH] D52774: [Preprocessor] Fix an assertion failure trigged in clangd #include completion.

kristina added a reviewer: kristina. kristina added a comment. Could you add a regression test please? Thank you. Repository: rC Clang https://reviews.llvm.org/D52774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D52730: [analyzer] ConversionChecker: handle floating point

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:175 + + if (RepresentsUntilExp >= sizeof(unsigned long long)*8) { return false; NoQ wrote: > Szelethus wrote: > > Szelethus wrote: > > > How about `AC.getSizeType

r343574 - Revert untintentionally commited changes

Author: ioeric Date: Tue Oct 2 03:28:54 2018 New Revision: 343574 URL: http://llvm.org/viewvc/llvm-project?rev=343574&view=rev Log: Revert untintentionally commited changes Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h Modified: cfe/trunk/lib/St

r343573 - [Lex] TokenConcatenation now takes const Preprocessor

Author: ioeric Date: Tue Oct 2 03:28:50 2018 New Revision: 343573 URL: http://llvm.org/viewvc/llvm-project?rev=343573&view=rev Log: [Lex] TokenConcatenation now takes const Preprocessor Differential Revision: https://reviews.llvm.org/D52502 Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/U

r343575 - [CodeComplete] Re-fix accessibilty of protected members from base class.

Author: ioeric Date: Tue Oct 2 03:29:00 2018 New Revision: 343575 URL: http://llvm.org/viewvc/llvm-project?rev=343575&view=rev Log: [CodeComplete] Re-fix accessibilty of protected members from base class. Summary: The initial fix (r337453) had bug and was partially reverted (r338255). This simpl

Re: r343573 - [Lex] TokenConcatenation now takes const Preprocessor

Sorry, I messed up my svn rebase somehow and committed and reverted this again (r343574) when landing r343575. On Tue, Oct 2, 2018 at 12:30 PM Eric Liu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ioeric > Date: Tue Oct 2 03:28:50 2018 > New Revision: 343573 > > URL: http://llv

[PATCH] D52647: [CodeComplete] Re-fix accessibilty of protected members from base class.

This revision was automatically updated to reflect the committed changes. Closed by commit rL343575: [CodeComplete] Re-fix accessibilty of protected members from base class. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.o

[PATCH] D52419: [clangd] Cache FS stat() calls when building preamble.

ioeric updated this revision to Diff 167913. ioeric added a comment. - add comment for StatCache in PreambleData Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52419 Files: clangd/CMakeLists.txt clangd/ClangdServer.cpp clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/

[PATCH] D52419: [clangd] Cache FS stat() calls when building preamble.

ioeric updated this revision to Diff 167914. ioeric added a comment. - Rebase Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52419 Files: clangd/CMakeLists.txt clangd/ClangdServer.cpp clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/CodeComplete.cpp clangd/CodeCompl

[PATCH] D52419: [clangd] Cache FS stat() calls when building preamble.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE343576: [clangd] Cache FS stat() calls when building preamble. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D52419?vs=167914&id=167915#toc Repository: rCTE

[clang-tools-extra] r343576 - [clangd] Cache FS stat() calls when building preamble.

Author: ioeric Date: Tue Oct 2 03:43:55 2018 New Revision: 343576 URL: http://llvm.org/viewvc/llvm-project?rev=343576&view=rev Log: [clangd] Cache FS stat() calls when building preamble. Summary: The file stats can be reused when preamble is reused (e.g. code completion). It's safe to assume tha

[PATCH] D52419: [clangd] Cache FS stat() calls when building preamble.

This revision was automatically updated to reflect the committed changes. Closed by commit rL343576: [clangd] Cache FS stat() calls when building preamble. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52419 Files:

[PATCH] D52691: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init

JonasToth updated this revision to Diff 167917. JonasToth added a comment. - adjust regex in check_clang_tidy Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52691 Files: test/clang-tidy/check_clang_tidy.py test/clang-tidy/performance-move-constructor-init.cpp Index: test/

[PATCH] D52691: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init

JonasToth marked 2 inline comments as done. JonasToth added a comment. check_clang_tidy now ignores `note: FIX-IT`, so only diagnostics directly emitted from the check are tested Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52691 ___

[PATCH] D52691: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init

JonasToth updated this revision to Diff 167918. JonasToth added a comment. - fix spurious change Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52691 Files: test/clang-tidy/check_clang_tidy.py test/clang-tidy/performance-move-constructor-init.cpp Index: test/clang-tidy/pe

[PATCH] D52691: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init

lebedev.ri added inline comments. Comment at: test/clang-tidy/check_clang_tidy.py:172 '-check-prefix=' + check_notes_prefix, - '-implicit-check-not={{note|warning|error}}:'], + '-implicit-check-not=warning|error}}:|note: (?!FIX-IT)}}'],

[PATCH] D52690: [clang-tidy] NFC use CHECK-NOTES in tests for misc-misplaced-const

JonasToth updated this revision to Diff 167919. JonasToth added a comment. - use absolute line number for note Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52690 Files: test/clang-tidy/misc-misplaced-const.c test/clang-tidy/misc-misplaced-const.cpp Index: test/clang-tid

[PATCH] D52750: [Diagnostics] Check for integer overflow in array size expressions

xbolva00 added inline comments. Comment at: lib/Sema/SemaType.cpp:2231 } + + if (isa(ArraySize)) @rsmith what about this place for check? https://reviews.llvm.org/D52750 ___ cfe-commits mailing list cfe

[clang-tools-extra] r343578 - [clang-tidy] Ignore singe bit bitfield -> bool conversion in readability-implicit-bool-conversion

Author: alexfh Date: Tue Oct 2 04:38:41 2018 New Revision: 343578 URL: http://llvm.org/viewvc/llvm-project?rev=343578&view=rev Log: [clang-tidy] Ignore singe bit bitfield -> bool conversion in readability-implicit-bool-conversion Modified: clang-tools-extra/trunk/clang-tidy/readability/Imp

[PATCH] D52738: [AST] Pack the bit-fields of FunctionProtoType into Type.

This revision was automatically updated to reflect the committed changes. Closed by commit rL343579: [AST] Pack the bit-fields of FunctionProtoType into Type. (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D527

r343579 - [AST] Pack the bit-fields of FunctionProtoType into Type.

Author: brunoricci Date: Tue Oct 2 04:46:38 2018 New Revision: 343579 URL: http://llvm.org/viewvc/llvm-project?rev=343579&view=rev Log: [AST] Pack the bit-fields of FunctionProtoType into Type. Move the bit-fields of FunctionProtoType into FunctionTypeBitfields. This cuts the size of FunctionPro

[clang-tools-extra] r343580 - [clangd] Dex iterator printer shows query structure, not iterator state.

Author: sammccall Date: Tue Oct 2 04:51:36 2018 New Revision: 343580 URL: http://llvm.org/viewvc/llvm-project?rev=343580&view=rev Log: [clangd] Dex iterator printer shows query structure, not iterator state. Summary: This makes it suitable for logging (which immediately found a bug, to be fixed

[PATCH] D52715: [clangd] Dex iterator printer shows query structure, not iterator state.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rCTE343580: [clangd] Dex iterator printer shows query structure, not iterator state. (authored by sammccall, committed by ). Changed prior to commit: https://re

[PATCH] D52742: [analyzer][WIP] Add macro expansions to the plist output

Szelethus updated this revision to Diff 167924. Szelethus added a comment. - Fixes according to @whisperity's comments - New test cases for - commas in brackets, - commas in braces, - macro arguments left empty. > (The whole thing, however, is generally disgusting. I'd've expected the > Pr

[PATCH] D52742: [analyzer][WIP] Add macro expansions to the plist output

Szelethus marked 13 inline comments as done. Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:292 + + // Output the location. + FullSourceLoc L = P.getLocation().asLocation(); whisperity wrote: > the location of what? Th

[PATCH] D52773: clang-cl: Add /showFilenames option (PR31957)

steveire added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:792 Opts.MainFileName = Args.getLastArgValue(OPT_main_file_name); + if (Args.hasArg(OPT_echo_main_file_name)) +llvm::outs() << Opts.MainFileName << "\n"; I'll have to keep a p

[PATCH] D52773: clang-cl: Add /showFilenames option (PR31957)

zturner added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:792 Opts.MainFileName = Args.getLastArgValue(OPT_main_file_name); + if (Args.hasArg(OPT_echo_main_file_name)) +llvm::outs() << Opts.MainFileName << "\n"; steveire wrote: > I'll

[PATCH] D52730: [analyzer] ConversionChecker: handle floating point

donat.nagy updated this revision to Diff 167929. donat.nagy added a comment. Fix formatting in tests; add a comment. Repository: rC Clang https://reviews.llvm.org/D52730 Files: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp test/Analysis/conversion.c Index: test/Analysis/conversion.c

[PATCH] D52730: [analyzer] ConversionChecker: handle floating point

donat.nagy marked 6 inline comments as done. donat.nagy added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:175 + + if (RepresentsUntilExp >= sizeof(unsigned long long)*8) { return false; NoQ wrote: > Szelethus wrote: > > Sz

r343581 - [analyzer] Improvements to the SMT API

Author: mramalho Date: Tue Oct 2 05:55:48 2018 New Revision: 343581 URL: http://llvm.org/viewvc/llvm-project?rev=343581&view=rev Log: [analyzer] Improvements to the SMT API Summary: Several improvements in preparation for the new backends. Refactoring: - Removed duplicated methods `fromBoolean

r343582 - Revert r326937 "[OpenCL] Remove block invoke function from emitted block literal struct"

Author: svenvh Date: Tue Oct 2 06:02:24 2018 New Revision: 343582 URL: http://llvm.org/viewvc/llvm-project?rev=343582&view=rev Log: Revert r326937 "[OpenCL] Remove block invoke function from emitted block literal struct" This reverts r326937 as it broke block argument handling in OpenCL. See th

r343583 - [OpenCL] Add block argument CodeGen test

Author: svenvh Date: Tue Oct 2 06:02:27 2018 New Revision: 343583 URL: http://llvm.org/viewvc/llvm-project?rev=343583&view=rev Log: [OpenCL] Add block argument CodeGen test r326937 ("[OpenCL] Remove block invoke function from emitted block literal struct", 2018-03-07) broke block argument handli

[PATCH] D52778: [Preprocessor] Hide include typo correction behind SpellChecking.

hokein created this revision. hokein added a reviewer: sammccall. Similar to Sema typo correction, the Preprocessor typo correction should also be hidden behind the SpellChecking flag. Repository: rC Clang https://reviews.llvm.org/D52778 Files: lib/Lex/PPDirectives.cpp Index: lib/Lex/PPD

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

svenvh added a comment. Reverted in r343582, test added in r343583. Repository: rC Clang https://reviews.llvm.org/D43783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52691: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init

JonasToth updated this revision to Diff 167933. JonasToth added a comment. -note remove spurious reordering Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52691 Files: test/clang-tidy/check_clang_tidy.py test/clang-tidy/performance-move-constructor-init.cpp Index: test/

[PATCH] D52691: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init

JonasToth updated this revision to Diff 167932. JonasToth added a comment. - filter with builtin python before passing to FileCheck Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52691 Files: test/clang-tidy/check_clang_tidy.py test/clang-tidy/performance-move-constructor-i

[PATCH] D52691: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init

JonasToth added inline comments. Comment at: test/clang-tidy/check_clang_tidy.py:172 '-check-prefix=' + check_notes_prefix, - '-implicit-check-not={{note|warning|error}}:'], + '-implicit-check-not=warning|error}}:|note: (?!FIX-IT)}}'],

[PATCH] D52691: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init

JonasToth updated this revision to Diff 167934. JonasToth marked 2 inline comments as done. JonasToth added a comment. - finally remove spurious change Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52691 Files: test/clang-tidy/check_clang_tidy.py test/clang-tidy/performanc

[PATCH] D52773: clang-cl: Add /showFilenames option (PR31957)

hans added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:792 Opts.MainFileName = Args.getLastArgValue(OPT_main_file_name); + if (Args.hasArg(OPT_echo_main_file_name)) +llvm::outs() << Opts.MainFileName << "\n"; zturner wrote: > steveire

[PATCH] D52774: [Preprocessor] Fix an assertion failure trigged in clangd #include completion.

hokein updated this revision to Diff 167935. hokein added a comment. Rescope the patch. Repository: rC Clang https://reviews.llvm.org/D52774 Files: lib/Lex/PPDirectives.cpp Index: lib/Lex/PPDirectives.cpp === --- lib/Lex/PPD

[PATCH] D52774: [PProcesssor] Filename should fall back to the written name when typo correction fails.

hokein added a comment. In https://reviews.llvm.org/D52774#1252294, @kristina wrote: > Could you add a regression test please? Also could you run this through a > debugger and get a backtrace from a debugger instead of the crash report, it > seems to be missing a few things likely from optimiza

[PATCH] D52773: clang-cl: Add /showFilenames option (PR31957)

steveire added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:792 Opts.MainFileName = Args.getLastArgValue(OPT_main_file_name); + if (Args.hasArg(OPT_echo_main_file_name)) +llvm::outs() << Opts.MainFileName << "\n"; hans wrote: > zturner

[PATCH] D52742: [analyzer][WIP] Add macro expansions to the plist output

donat.nagy added a comment. Does this checker handle the expansion of variadic macros introduced in C++11 (see syntax (3) and (4) here ) and the `#` and `##` preprocessor operators? Comment at: lib/StaticAnalyzer/Core/P

[PATCH] D52773: clang-cl: Add /showFilenames option (PR31957)

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Looks good. If this is passed and we invoke lld-link, should we give that a similar flag and pass that to lld-link as well? I think link.exe also prints its outputs. Commen

[PATCH] D52778: [Preprocessor] Hide include typo correction behind SpellChecking.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: lib/Lex/PPDirectives.cpp:1891 StringRef OriginalFilename = Filename; - if (!File) { -// A heuristic to correct a typo file name by r

[PATCH] D52746: [clang-query] Add single-letter 'q' alias for 'quit'

steveire added a comment. @Szelethus You can approve it and then you will get the feature :). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[clang-tools-extra] r343589 - [clangd] Dex: add Corpus factory for iterators, rename, fold constant. NFC

Author: sammccall Date: Tue Oct 2 06:44:26 2018 New Revision: 343589 URL: http://llvm.org/viewvc/llvm-project?rev=343589&view=rev Log: [clangd] Dex: add Corpus factory for iterators, rename, fold constant. NFC Summary: - Corpus avoids having to pass size to the true iterator, and (soon) any it

[PATCH] D52711: [clangd] Dex: add Corpus factory for iterators, rename, fold constant. NFC

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rL343589: [clangd] Dex: add Corpus factory for iterators, rename, fold constant. NFC (authored by sammccall, committed by ). Herald added a subscriber: llvm-commit

[PATCH] D52746: [clang-query] Add single-letter 'q' alias for 'quit'

aaron.ballman added a comment. Please update `HelpQuery::run()` to print out the new mnemonic (it's the *only* form of public documentation we have for clang-query currently). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52746 __

[clang-tools-extra] r343590 - [clangd] Zap TODONEs

Author: sammccall Date: Tue Oct 2 06:51:43 2018 New Revision: 343590 URL: http://llvm.org/viewvc/llvm-project?rev=343590&view=rev Log: [clangd] Zap TODONEs Modified: clang-tools-extra/trunk/clangd/index/dex/Iterator.h Modified: clang-tools-extra/trunk/clangd/index/dex/Iterator.h URL: http:

[PATCH] D52751: Allow comments with '#' in dynamic AST Matchers

aaron.ballman added inline comments. Comment at: unittests/ASTMatchers/Dynamic/ParserTest.cpp:188-190 + for (size_t i = 0, e = Sema.Errors.size(); i != e; ++i) { +EXPECT_EQ("", Sema.Errors[i]); + } Why are empty errors created? I would have expected this to

r343591 - [Preprocessor] Hide include typo correction behind SpellChecking.

Author: hokein Date: Tue Oct 2 06:59:49 2018 New Revision: 343591 URL: http://llvm.org/viewvc/llvm-project?rev=343591&view=rev Log: [Preprocessor] Hide include typo correction behind SpellChecking. Summary: Similar to Sema typo correction, the Preprocessor typo correction should also be hidden b

[PATCH] D52778: [Preprocessor] Hide include typo correction behind SpellChecking.

hokein updated this revision to Diff 167939. hokein added a comment. Fix review comment. Repository: rC Clang https://reviews.llvm.org/D52778 Files: lib/Lex/PPDirectives.cpp Index: lib/Lex/PPDirectives.cpp === --- lib/Lex/PP

[PATCH] D52778: [Preprocessor] Hide include typo correction behind SpellChecking.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rC343591: [Preprocessor] Hide include typo correction behind SpellChecking. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D52774: [PProcesssor] Filename should fall back to the written name when typo correction fails.

hokein updated this revision to Diff 167942. hokein retitled this revision from " [PProcesssor] Filename should fall back to the written name when typo correction fails. " to "[PProcesssor] Filename should fall back to the written name when typo correction fails.". hokein added a comment. Reba

[PATCH] D52727: [clang-tidy] White List Option for performance-unnecessary-value-param, performance-unnecessary-copy-initialization and performance-for-range-copy

baloghadamsoftware added inline comments. Comment at: clang-tidy/performance/ForRangeCopyCheck.cpp:50 + const auto VarType = Var->getType(); + if (std::find_if(WhiteListTypes.begin(), WhiteListTypes.end(), + [&](llvm::StringRef WhiteListType) { ---

[PATCH] D52780: [OPENMP] Add 'reverse_offload' clause to OMP5.0 'requires' directive

patricklyster created this revision. patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice, kkwli0, hfinkel, gtbercea. patricklyster added projects: clang, OpenMP. Herald added subscribers: cfe-commits, arphaman, guansong. Added new `reverse_offload` clause to existing OMP

[PATCH] D52781: [clangd] Don't make check-clangd as a dependency in check-clang-tools

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, mgorny. check-clang-tools will run check-clangd first, and then run the rest tests. If clangd tests fails, check-clang-tools would be stopped.

[PATCH] D52780: [OPENMP] Add 'reverse_offload' clause to OMP5.0 'requires' directive

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang https://reviews.llvm.org/D52780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D52782: [clang-tidy] Sequence statements with multiple parents correctly (PR39149)

mboehme created this revision. Herald added subscribers: cfe-commits, xazax.hun. Before this fix, the bugprone-use-after-move check could incorrectly conclude that a use and move in a function template were not sequenced. For details, see https://bugs.llvm.org/show_bug.cgi?id=39149 Repository:

r343592 - [Preprocesssor] Filename should fall back to the written name when typo correction fails.

Author: hokein Date: Tue Oct 2 07:42:51 2018 New Revision: 343592 URL: http://llvm.org/viewvc/llvm-project?rev=343592&view=rev Log: [Preprocesssor] Filename should fall back to the written name when typo correction fails. Summary: The test is added in Testcase is at https://reviews.llvm.org/D5

[PATCH] D52774: [PProcesssor] Filename should fall back to the written name when typo correction fails.

This revision was automatically updated to reflect the committed changes. Closed by commit rC343592: [Preprocesssor] Filename should fall back to the written name when typo… (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D52774?vs=167942&id=167948#toc Re

[clang-tools-extra] r343593 - [clangd] Add a #include completion test that triggers an assertion.

Author: hokein Date: Tue Oct 2 07:46:08 2018 New Revision: 343593 URL: http://llvm.org/viewvc/llvm-project?rev=343593&view=rev Log: [clangd] Add a #include completion test that triggers an assertion. Summary: Test for https://reviews.llvm.org/D52774. Reviewers: sammccall Reviewed By: sammccall

[PATCH] D52775: [clangd] Add a #include completion test that triggers an assertion.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE343593: [clangd] Add a #include completion test that triggers an assertion. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D52775?vs=167908&id=167949#toc Repos

[PATCH] D52781: [clangd] Don't make check-clangd as a dependency in check-clang-tools

JonasToth added a comment. Verified that it does not block other clang-extra tools if clangd tests fail. Thank you very much for fixing! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52781 ___ cfe-commits mailing list cfe-commits@

Re: [PATCH] D52781: [clangd] Don't make check-clangd as a dependency in check-clang-tools

On Tue, Oct 2, 2018 at 5:54 PM Jonas Toth via Phabricator via cfe-commits wrote: > > JonasToth added a comment. > > Verified that it does not block other clang-extra tools if clangd tests fail. > Thank you very much for fixing! Would be great to get check-clang-tidy target 'while there'. > > Repo

[PATCH] D52377: [HIP] Support early finalization of device code for -fno-gpu-rdc

yaxunl updated this revision to Diff 167952. yaxunl edited the summary of this revision. yaxunl added a comment. Added -f{no}-cuda-rdc as alias to -f{no}-gpu-rdc. https://reviews.llvm.org/D52377 Files: include/clang/Basic/LangOptions.def include/clang/Driver/Options.td include/clang/Drive

[PATCH] D52784: [ARM][AArch64] Pass through endianness flags to the GNU assembler

peter.smith created this revision. peter.smith added reviewers: rengolin, compnerd, olista01. Herald added subscribers: chrib, kristof.beyls, srhines. Herald added a reviewer: javed.absar. The big-endian arm32 Linux builds are currently failing when the -mbig-endian and -fno-use-integrated-as fla

[PATCH] D52784: [ARM][AArch64] Pass through endianness flags to the GNU assembler

rengolin added a comment. Hi Peter, Looks ok. Why did you need to change all cmdlines to have -EL? I imagine you just need one for each case, everything else remains the default (which should still work). Also, it would be interesting to know what happens on cases like "aarch64_be -EL" et al,

[PATCH] D52784: [ARM][AArch64] Pass through endianness flags to the GNU assembler

peter.smith added a comment. In https://reviews.llvm.org/D52784#1252569, @rengolin wrote: > Hi Peter, > > Looks ok. Why did you need to change all cmdlines to have -EL? I imagine you > just need one for each case, everything else remains the default (which > should still work). I thought that

  1   2   3   >