Sorry, I messed up my svn rebase somehow and committed and reverted this again (r343574) when landing r343575.
On Tue, Oct 2, 2018 at 12:30 PM Eric Liu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ioeric > Date: Tue Oct 2 03:28:50 2018 > New Revision: 343573 > > URL: http://llvm.org/viewvc/llvm-project?rev=343573&view=rev > Log: > [Lex] TokenConcatenation now takes const Preprocessor > > Differential Revision: https://reviews.llvm.org/D52502 > > Modified: > > cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h > > Modified: > cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h?rev=343573&r1=343572&r2=343573&view=diff > > ============================================================================== > --- > cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h > (original) > +++ > cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h > Tue Oct 2 03:28:50 2018 > @@ -79,9 +79,9 @@ class FieldNode { > protected: > const FieldRegion *FR; > > - /// FieldNodes are never meant to be created on the heap, see > - /// FindUninitializedFields::addFieldToUninits(). > - /* non-virtual */ ~FieldNode() = default; > + // TODO: This destructor shouldn't be virtual, but breaks buildbots with > + // -Werror -Wnon-virtual-dtor. > + virtual ~FieldNode() = default; > > public: > FieldNode(const FieldRegion *FR) : FR(FR) {} > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
