[PATCH] D51221: [clangd] Some nitpicking around the new split (preamble/main) dynamic index

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric, javed.absar. - DynamicIndex doesn't implement ParsingCallbacks, to make its role clearer. ParsingCallbacks is a separate object owned b

[PATCH] D51061: [clang-tidy] abseil-str-cat-append

aaron.ballman added inline comments. Comment at: clang-tidy/abseil/StrCatAppendCheck.cpp:91-92 + diag(Op->getBeginLoc(), + "please use absl::StrAppend instead of absl::StrCat when appending to " + "an existing string") + << FixItHint::CreateReplacement(

[PATCH] D51221: [clangd] Some nitpicking around the new split (preamble/main) dynamic index

sammccall updated this revision to Diff 162401. sammccall added a comment. Add note about the overlap between preamble index across files. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51221 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp cla

[PATCH] D51200: Introduce per-callsite inline intrinsics

Quuxplusone added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8236 +def err_argument_to_inline_intrinsic_builtin_call : Error< + "argument to %0 must not be a builtin call">; +def err_argument_to_inline_intrinsic_pdotr_call : Error< I

[PATCH] D51061: [clang-tidy] abseil-str-cat-append

hugoeg updated this revision to Diff 162403. hugoeg marked an inline comment as done. https://reviews.llvm.org/D51061 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/StrCatAppendCheck.cpp clang-tidy/abseil/StrCatAppendCheck.h docs/Release

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg updated this revision to Diff 162405. hugoeg marked an inline comment as done. hugoeg added a comment. minor updates https://reviews.llvm.org/D51132 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/RedundantStrcatCallsCheck.cpp clan

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

JonasToth added a comment. LG from my side, but please let @aaron.ballman or @alexfh approve first Am 24.08.2018 um 18:08 schrieb Andi via Phabricator: > Abpostelnicu added a comment. > > I can confirm tested on: > 2.7.15 > 3.7.0 > > On both it worked. > > - https://reviews.llvm.org/F704765

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

lebedev.ri added a comment. Have you seen https://reviews.llvm.org/D36624 / https://reviews.llvm.org/D38289 ? Please test how it behaves with both the python2 and python3 when the clang-tidy output contains non-ASCII symbols. https://reviews.llvm.org/D51220 _

[PATCH] D51223: Update tests for new YAMLIO polymorphic traits

scott.linder created this revision. scott.linder added a reviewer: klimek. Herald added a subscriber: cfe-commits. See https://reviews.llvm.org/D48144 for the LLVM patch. Repository: rC Clang https://reviews.llvm.org/D51223 Files: unittests/Tooling/DiagnosticsYamlTest.cpp unittests/Tooli

r340622 - [Hexagon] Remove unneeded strings from builtin definitions, NFC

Author: kparzysz Date: Fri Aug 24 10:13:42 2018 New Revision: 340622 URL: http://llvm.org/viewvc/llvm-project?rev=340622&view=rev Log: [Hexagon] Remove unneeded strings from builtin definitions, NFC Modified: cfe/trunk/include/clang/Basic/BuiltinsHexagon.def Modified: cfe/trunk/include/clang

r340623 - [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

Author: jonastoth Date: Fri Aug 24 10:14:31 2018 New Revision: 340623 URL: http://llvm.org/viewvc/llvm-project?rev=340623&view=rev Log: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All Summary: See bug report https://bugs.llvm.org/show

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

This revision was automatically updated to reflect the committed changes. Closed by commit rC340623: [clang-format] fix PR38525 - Extraneous continuation indent spaces with… (authored by JonasToth, committed by ). Repository: rC Clang https://reviews.llvm.org/D50699 Files: lib/Format/Contin

[PATCH] D51061: [clang-tidy] abseil-str-cat-append

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D51061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

r340624 - [clang-format] fix PR38557 - comments between "default" and ':' causes the case label to be treated as an identifier

Author: jonastoth Date: Fri Aug 24 10:25:06 2018 New Revision: 340624 URL: http://llvm.org/viewvc/llvm-project?rev=340624&view=rev Log: [clang-format] fix PR38557 - comments between "default" and ':' causes the case label to be treated as an identifier Summary: The Bug was reported and fixed by

[PATCH] D50697: [clang-format] fix PR38557 - comments between "default" and ':' causes the case label to be treated as an identifier

This revision was automatically updated to reflect the committed changes. Closed by commit rC340624: [clang-format] fix PR38557 - comments between "default" and ':' causes the case… (authored by JonasToth, committed by ). Repository: rC Clang https://reviews.llvm.org/D50697 Files: lib/Form

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from the formatting and one small documentation nit, LGTM! Comment at: docs/clang-tidy/checks/abseil-redundant-strcat-calls.rst:7 + Suggests removal of un

[PATCH] D51214: [clangd] Add options to enable/disable fixits and function argument snippets.

ilya-biryukov added inline comments. Comment at: clangd/tool/ClangdMain.cpp:197 +static llvm::cl::opt IncludeFixIts( +"include-fixits", sammccall wrote: > ilya-biryukov wrote: > > I wonder if we should make the `IncludeFixIts` option hidden? > > It currentl

[PATCH] D51189: [Sema][ObjC] Infer availability of +new from availability of -init

arphaman added a comment. That's probably the best solution then, I don't think declaring implicit `new` just for availability attribute is sound. Does this work with `self new` as well? Comment at: clang/lib/AST/DeclObjC.cpp:833 +bool ObjCMethodDecl::definedInNSObject(const

[PATCH] D50845: [CUDA/OpenMP] Define only some host macros during device compilation

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Please keep an eye on CUDA buildbot http://lab.llvm.org:8011/builders/clang-cuda-build. It runs fair amount of tests with libc++ and handful of libstdc++ versions and may a canary if these changes b

[PATCH] D50580: [clang-tidy] Abseil: no namespace check

deannagarcia updated this revision to Diff 162417. deannagarcia added a comment. Rebased the patch https://reviews.llvm.org/D50580 Files: clang-tidy/abseil/AbseilMatcher.h clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoNamespaceCheck.cpp cl

[PATCH] D50580: [clang-tidy] Abseil: no namespace check

deannagarcia added inline comments. Comment at: test/clang-tidy/abseil-no-namespace.cpp:10 +#include "absl/external-file.h" +// CHECK: absl/external-file.h:1:11: warning: namespace 'absl' is reserved +// for implementation of the Abseil library and should not be opened in user --

r340627 - [ASTImporter] Add test for PackExpansionExpr

Author: teemperor Date: Fri Aug 24 11:01:56 2018 New Revision: 340627 URL: http://llvm.org/viewvc/llvm-project?rev=340627&view=rev Log: [ASTImporter] Add test for PackExpansionExpr Reviewers: a.sidorin, a_sidorin Reviewed By: a_sidorin Subscribers: martong, cfe-commits Differential Revision: h

[PATCH] D51142: [ASTImporter] Add test for PackExpansionExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL340627: [ASTImporter] Add test for PackExpansionExpr (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51142?vs=162104&i

[PATCH] D51204: [COFF, ARM64] Add MS intrinsics: __getReg, _ReadStatusReg, _WriteStatusReg

mgrang updated this revision to Diff 162431. mgrang edited the summary of this revision. https://reviews.llvm.org/D51204 Files: lib/Headers/intrin.h test/Headers/arm64-ms-intrin.cpp Index: test/Headers/arm64-ms-intrin.cpp === -

[PATCH] D51204: [COFF, ARM64] Add MS intrinsics: __getReg, _ReadStatusReg, _WriteStatusReg

mgrang added a comment. Thanks @mstorsjo. I have addressed your comments. https://reviews.llvm.org/D51204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51204: [COFF, ARM64] Add MS intrinsics: __getReg, _ReadStatusReg, _WriteStatusReg

rnk added a comment. This just adds declarations. Are these functions provided by some Windows runtime library? Don't you need to implement the intrinsics somewhere in order for the apps that use them to run or link? Ideally, they should be implemented as builtins. https://reviews.llvm.org/D5

r340636 - Thread safety analysis no longer hands when analyzing a self-referencing initializer.

Author: aaronballman Date: Fri Aug 24 11:48:35 2018 New Revision: 340636 URL: http://llvm.org/viewvc/llvm-project?rev=340636&view=rev Log: Thread safety analysis no longer hands when analyzing a self-referencing initializer. This fixes PR38640. Modified: cfe/trunk/lib/Analysis/ThreadSafety.

[PATCH] D51229: [Sema/Attribute] Make types declared with address_space an AttributedType

leonardchan created this revision. leonardchan added reviewers: rjmccall, rsmith, phosek, mcgrathr, ebevhan, theraven. leonardchan added a project: clang. Currently an address_space is stored in a qualifier. This makes any type declared with an address_space attribute in the form `__attribute__

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg updated this revision to Diff 162438. hugoeg marked 2 inline comments as done. hugoeg added a comment. added corrections https://reviews.llvm.org/D51132 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/RedundantStrcatCallsCheck.cpp

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan added a comment. @rsmith ping Repository: rC Clang https://reviews.llvm.org/D49511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50564: Add support for SEH unwinding on Windows.

cdavis5x updated this revision to Diff 162441. cdavis5x marked 8 inline comments as done. cdavis5x added a comment. - Remove case we'll never realistically hit. - Add back include I removed earlier. - Add a comment clarifying that some environments use SEH without Windows runtime support. Repos

r340640 - [LTO] Fix -save-temps with LTO and unnamed globals.

Author: efriedma Date: Fri Aug 24 12:31:52 2018 New Revision: 340640 URL: http://llvm.org/viewvc/llvm-project?rev=340640&view=rev Log: [LTO] Fix -save-temps with LTO and unnamed globals. If all LLVM passes are disabled, we can't emit a summary because there could be unnamed globals in the IR. Di

[PATCH] D51198: [LTO] Fix -save-temps with LTO and unnamed globals.

This revision was automatically updated to reflect the committed changes. Closed by commit rC340640: [LTO] Fix -save-temps with LTO and unnamed globals. (authored by efriedma, committed by ). Repository: rC Clang https://reviews.llvm.org/D51198 Files: lib/CodeGen/BackendUtil.cpp test/Code

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

JonasToth updated this revision to Diff 162448. JonasToth added a comment. - Merge branch 'master' into fix_exception Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48714 Files: clang-tidy/hicpp/ExceptionBaseclassCheck.cpp test/clang-tidy/hicpp-exception-baseclass.cpp Inde

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 162449. JonasToth added a comment. - get up to date Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp clang-tidy/cppcoregui

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

JonasToth updated this revision to Diff 162450. JonasToth added a comment. - Merge branch 'master' into check_macros_usage Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41648 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesT

[PATCH] D40854: [clang-tidy] WIP implement cppcoreguidelines check for mixed integer arithmetic

JonasToth updated this revision to Diff 162451. JonasToth added a comment. - Merge branch 'master' into check_mixed_arithmetic Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40854 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuideli

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

Eugene.Zelenko added a comment. Example in documentation was not fixed. Comment at: docs/clang-tidy/checks/abseil-redundant-strcat-calls.rst:16 + + std::string s = absl::StrCat("A", absl::StrCat("B", absll::StrCat("C", "D"))); + std::string s = absl::StrCat("A",

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg updated this revision to Diff 162454. hugoeg marked an inline comment as done. https://reviews.llvm.org/D51132 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/RedundantStrcatCallsCheck.cpp clang-tidy/abseil/RedundantStrcatCallsCheck.

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg updated this revision to Diff 162455. https://reviews.llvm.org/D51132 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/RedundantStrcatCallsCheck.cpp clang-tidy/abseil/RedundantStrcatCallsCheck.h docs/ReleaseNotes.rst docs/clang-ti

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

Eugene.Zelenko added a comment. Indentation of example in documentation is still fixed. https://reviews.llvm.org/D51132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r340644 - Add REQUIRES: x86-registered-target to test.

Author: efriedma Date: Fri Aug 24 13:18:34 2018 New Revision: 340644 URL: http://llvm.org/viewvc/llvm-project?rev=340644&view=rev Log: Add REQUIRES: x86-registered-target to test. (This isn't really x86-specific, but we have to pick some non-Apple triple to exercise the right codepath.) Modifie

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg updated this revision to Diff 162462. https://reviews.llvm.org/D51132 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/RedundantStrcatCallsCheck.cpp clang-tidy/abseil/RedundantStrcatCallsCheck.h docs/ReleaseNotes.rst docs/clang-ti

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg added a comment. In https://reviews.llvm.org/D51132#1212903, @Eugene.Zelenko wrote: > Indentation of example in documentation is still fixed. yea sorry about that, I caught that after i updated the diff and corrected and re updated https://reviews.llvm.org/D51132 __

r340649 - Reland r340552, "Driver: Enable address-significance tables by default when targeting COFF." which was reverted in r340579.

Author: pcc Date: Fri Aug 24 13:38:15 2018 New Revision: 340649 URL: http://llvm.org/viewvc/llvm-project?rev=340649&view=rev Log: Reland r340552, "Driver: Enable address-significance tables by default when targeting COFF." which was reverted in r340579. The underlying problem that caused the rev

[PATCH] D51049: Driver: Enable address-significance tables by default when targeting COFF.

This revision was automatically updated to reflect the committed changes. Closed by commit rC340649: Reland r340552, "Driver: Enable address-significance tables by default when… (authored by pcc, committed by ). Repository: rC Clang https://reviews.llvm.org/D51049 Files: lib/Driver/ToolChai

[PATCH] D51109: [cc1][cc1as] Call OptTable::PrintHelp with explicit " [options] "

MaskRay updated this revision to Diff 162478. MaskRay added a comment. Herald added subscribers: atanasyan, jrtc27, sdardis. [Driver] Change MipsLinux default linker from "lld" to "ld.lld" Repository: rC Clang https://reviews.llvm.org/D51109 Files: lib/Driver/ToolChains/MipsLinux.h lib/F

[PATCH] D51234: [Driver] Change MipsLinux default linker from "lld" to "ld.lld"

MaskRay created this revision. MaskRay added a reviewer: kzhuravl. Herald added subscribers: cfe-commits, atanasyan, jrtc27, arichardson, sdardis. Repository: rC Clang https://reviews.llvm.org/D51234 Files: lib/Driver/ToolChains/MipsLinux.h Index: lib/Driver/ToolChains/MipsLinux.h

[PATCH] D51084: Implement -Watomic-implicit-seq-cst

jfb updated this revision to Diff 162484. jfb marked 2 inline comments as done. jfb added a comment. - Address John's comments: diagnose at beginning, and don't check isIgnored manually. Repository: rC Clang https://reviews.llvm.org/D51084 Files: include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D51084: Implement -Watomic-implicit-seq-cst

jfb added a comment. Updated. Repository: rC Clang https://reviews.llvm.org/D51084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51229: [Sema/Attribute] Make types declared with address_space an AttributedType

rsmith added inline comments. Comment at: lib/AST/TypePrinter.cpp:1430-1431 + if (T->getAttrKind() == attr::AddressSpace) +return; + Please justify why this is appropriate with a comment. Comment at: lib/AST/TypePrinter.cpp:1501-1502 + +

[libcxx] r340662 - Merging r340544:

Author: hans Date: Fri Aug 24 15:16:24 2018 New Revision: 340662 URL: http://llvm.org/viewvc/llvm-project?rev=340662&view=rev Log: Merging r340544: r340544 | epilk | 2018-08-23 19:08:02 +0200 (Thu, 23 Aug 2018) | 3 lines Com

[PATCH] D51229: [Sema/Attribute] Make types declared with address_space an AttributedType

leonardchan updated this revision to Diff 162487. leonardchan marked 3 inline comments as done. Repository: rC Clang https://reviews.llvm.org/D51229 Files: include/clang/Basic/Attr.td lib/AST/TypePrinter.cpp lib/Sema/SemaType.cpp Index: lib/Sema/SemaType.cpp ===

Re: [libcxx] r340544 - Comment out #define __cpp_lib_node_extract, we only support half of that functionality

Merged to 7.0 in r340662. On Thu, Aug 23, 2018 at 10:08 AM, Erik Pilkington via cfe-commits wrote: > Author: epilk > Date: Thu Aug 23 10:08:02 2018 > New Revision: 340544 > > URL: http://llvm.org/viewvc/llvm-project?rev=340544&view=rev > Log: > Comment out #define __cpp_lib_node_extract, we only

[PATCH] D51172: [libcxx] Comment out #define __cpp_lib_node_extract, we only support half of that functionality

hans added a comment. In https://reviews.llvm.org/D51172#1211156, @erik.pilkington wrote: > Landed as r340544. @hans: Can you cherry-pick? Merged in r340662. Thanks! Repository: rCXX libc++ https://reviews.llvm.org/D51172 ___ cfe-commits maili

[PATCH] D51109: [cc1][cc1as] Call OptTable::PrintHelp with explicit " [options] "

MaskRay updated this revision to Diff 162488. MaskRay added a comment. Sorry I messed up with my branches :( I shall create https://reviews.llvm.org/D51234 but arc diff'ed to a different one Repository: rC Clang https://reviews.llvm.org/D51109 Files: lib/FrontendTool/ExecuteCompilerInvoca

[PATCH] D51187: Thread safety analysis: Warn on double (un-)lock of scoped capability

aaronpuchert added a comment. Sure. As I wrote in the commit message, I'm not sure about it myself, but I think it's worth a discussion. Maybe I should have tagged it as RFC. Releasable scopes need a way of knowing whether the lock is currently held to prevent double unlocking in the destructor

[PATCH] D51177: [DEBUGINFO] Add support for emission of the debug directives only.

echristo added a comment. Should we just have them mean the same thing and change it based on target? Repository: rC Clang https://reviews.llvm.org/D51177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

r340666 - Revert r323281 "Adjust MaxAtomicInlineWidth for i386/i486 targets."

Author: hans Date: Fri Aug 24 15:46:33 2018 New Revision: 340666 URL: http://llvm.org/viewvc/llvm-project?rev=340666&view=rev Log: Revert r323281 "Adjust MaxAtomicInlineWidth for i386/i486 targets." As reported on http://lists.llvm.org/pipermail/cfe-dev/2018-August/058760.html, this broke i386-fr

[PATCH] D51239: [ubsan] Enable -fsanitize=vptr on Apple devices and simulators

vsk created this revision. vsk added a reviewer: delcypher. It seems like an oversight that this check was not always enabled for on-device or device simulator targets. https://reviews.llvm.org/D51239 Files: clang/lib/Driver/ToolChains/Darwin.cpp clang/test/Driver/fsanitize.c Index: clang

[PATCH] D51229: [Sema/Attribute] Make types declared with address_space an AttributedType

rsmith added inline comments. Comment at: lib/Sema/SemaType.cpp:5816 +if (!T.isNull()) { + if (!T->getAs()) { +ASTContext &Ctx = S.Context; We should also create the AttributedType to track the source syntax in the dependent case. If we don't, t

[PATCH] D51200: Introduce per-callsite inline intrinsics

kuhar updated this revision to Diff 162495. kuhar marked an inline comment as done. kuhar added a comment. Fix naming and add more tests. Repository: rC Clang https://reviews.llvm.org/D51200 Files: include/clang/Basic/Builtins.def include/clang/Basic/DiagnosticSemaKinds.td include/clan

[PATCH] D51200: Introduce per-callsite inline intrinsics

kuhar added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8236 +def err_argument_to_inline_intrinsic_builtin_call : Error< + "argument to %0 must not be a builtin call">; +def err_argument_to_inline_intrinsic_pdotr_call : Error< Quuxplu

[PATCH] D50892: [analyzer][UninitializedObjectChecker] Correct dynamic type is acquired for record pointees

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp:187-191 // If FR is a pointer pointing to a non-primitive type. if (Optional RecordV

[libcxxabi] r340671 - Port my recent changes from LLVM copy of the demangler:

Author: rsmith Date: Fri Aug 24 16:30:26 2018 New Revision: 340671 URL: http://llvm.org/viewvc/llvm-project?rev=340671&view=rev Log: Port my recent changes from LLVM copy of the demangler: r340663 - Allow Allocator::make to make a node of a different type than that requested. r340664 -

[PATCH] D51240: Add a flag to remap manglings when reading profile data information.

rsmith created this revision. rsmith added reviewers: davidxl, tejohnson, dlj, erik.pilkington. Herald added subscribers: dexonsmith, steven_wu, mgorny, mehdi_amini. This can be used to preserve profiling information across codebase changes that have widespread impact on mangled names, but across

[PATCH] D51240: Add a flag to remap manglings when reading profile data information.

rsmith updated this revision to Diff 162505. rsmith added a comment. Herald added a subscriber: hiraditya. (Tweak diff so phabricator shows clang/ and llvm/ prefixes on filenames and add more context.) https://reviews.llvm.org/D51240 Files: clang/docs/ReleaseNotes.rst clang/docs/UsersManua

[PATCH] D50564: Add support for SEH unwinding on Windows.

cdavis5x updated this revision to Diff 162509. cdavis5x added a comment. - Move `DISPATCHER_CONTEXT` definition into UnwindCursor.hpp. Repository: rUNW libunwind https://reviews.llvm.org/D50564 Files: include/__libunwind_config.h include/unwind.h src/AddressSpace.hpp src/CMakeLists.t

[PATCH] D51240: Add a flag to remap manglings when reading profile data information.

davidxl added a comment. thanks for working on this. Can you split the patch into two? One for sample PGO and one for instrumentation. In particular, I don't see much need to do this for instrumentation based PGO, but we can defer discussion on that once the patch is split. https://reviews.l

[PATCH] D51229: [Sema/Attribute] Make types declared with address_space an AttributedType

leonardchan updated this revision to Diff 162515. leonardchan marked an inline comment as done. Repository: rC Clang https://reviews.llvm.org/D51229 Files: include/clang/Basic/Attr.td lib/AST/TypePrinter.cpp lib/Sema/SemaType.cpp Index: lib/Sema/SemaType.cpp ===

[PATCH] D51084: Implement -Watomic-implicit-seq-cst

rjmccall added inline comments. Comment at: lib/Sema/SemaChecking.cpp:10668 + if (Source->isAtomicType() || Target->isAtomicType()) +S.Diag(E->getBeginLoc(), diag::warn_atomic_implicit_seq_cst); + Why would the target be an atomic type? And if it is an atom

[PATCH] D51200: Introduce per-callsite inline intrinsics

kuhar updated this revision to Diff 162519. kuhar added a comment. Rename missed CallInlineKind parameters to CIK https://reviews.llvm.org/D51200 Files: include/clang/Basic/Builtins.def include/clang/Basic/DiagnosticSemaKinds.td include/clang/CodeGen/CGFunctionInfo.h lib/CodeGen/CGBuilt

[PATCH] D51200: Introduce per-callsite inline intrinsics

kuhar updated this revision to Diff 162520. https://reviews.llvm.org/D51200 Files: include/clang/Basic/Builtins.def include/clang/Basic/DiagnosticSemaKinds.td include/clang/CodeGen/CGFunctionInfo.h lib/CodeGen/CGBuiltin.cpp lib/CodeGen/CGCall.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/C

[PATCH] D51240: Add a flag to remap manglings when reading profile data information.

dexonsmith added a reviewer: vsk. dexonsmith added a comment. In https://reviews.llvm.org/D51240#1213179, @davidxl wrote: > In particular, I don't see much need to do this for instrumentation based PGO > [...] Why not? https://reviews.llvm.org/D51240 __

[PATCH] D51240: Add a flag to remap manglings when reading profile data information.

rsmith added a comment. In https://reviews.llvm.org/D51240#1213179, @davidxl wrote: > Can you split the patch into two? One for sample PGO and one for > instrumentation. I've split the patch up thusly: https://reviews.llvm.org/D51246 is the common infrastructure shared by sample PGO and inst

[PATCH] D51229: [Sema/Attribute] Make types declared with address_space an AttributedType

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaType.cpp:5600-5605 if (DependentAddressSpaceTypeLoc DASTL = CurrTL.getAs()) { fillDependentAddressSpaceTypeLoc(DASTL, D.getT

[PATCH] D51240: Add a flag to remap manglings when reading profile data information.

davidxl added a comment. Re "Why not": The common use model of instrumentation based PGO and SamplePGO are quite different. The former usually uses 'fresh' profile that matches the source. If there are massive code refactoring or ABI changes, the user can simply regenerate the profile. For t

<    1   2