Author: pcc Date: Fri Aug 24 13:38:15 2018 New Revision: 340649 URL: http://llvm.org/viewvc/llvm-project?rev=340649&view=rev Log: Reland r340552, "Driver: Enable address-significance tables by default when targeting COFF." which was reverted in r340579.
The underlying problem that caused the revert was fixed in r340648. Differential Revision: https://reviews.llvm.org/D51049 Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp cfe/trunk/test/Driver/addrsig.c Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/Clang.cpp?rev=340649&r1=340648&r2=340649&view=diff ============================================================================== --- cfe/trunk/lib/Driver/ToolChains/Clang.cpp (original) +++ cfe/trunk/lib/Driver/ToolChains/Clang.cpp Fri Aug 24 13:38:15 2018 @@ -4857,7 +4857,8 @@ void Clang::ConstructJob(Compilation &C, } if (Args.hasFlag(options::OPT_faddrsig, options::OPT_fno_addrsig, - getToolChain().getTriple().isOSBinFormatELF() && + (getToolChain().getTriple().isOSBinFormatELF() || + getToolChain().getTriple().isOSBinFormatCOFF()) && getToolChain().useIntegratedAs())) CmdArgs.push_back("-faddrsig"); Modified: cfe/trunk/test/Driver/addrsig.c URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/addrsig.c?rev=340649&r1=340648&r2=340649&view=diff ============================================================================== --- cfe/trunk/test/Driver/addrsig.c (original) +++ cfe/trunk/test/Driver/addrsig.c Fri Aug 24 13:38:15 2018 @@ -1,4 +1,5 @@ // RUN: %clang -### -target x86_64-unknown-linux -c %s 2>&1 | FileCheck -check-prefix=ADDRSIG %s +// RUN: %clang -### -target x86_64-pc-win32 -c %s 2>&1 | FileCheck -check-prefix=ADDRSIG %s // RUN: %clang -### -target x86_64-unknown-linux -fno-integrated-as -c %s 2>&1 | FileCheck -check-prefix=NO-ADDRSIG %s // RUN: %clang -### -target x86_64-unknown-linux -fno-integrated-as -faddrsig -c %s 2>&1 | FileCheck -check-prefix=ADDRSIG %s // RUN: %clang -### -target x86_64-unknown-linux -fno-addrsig -c %s 2>&1 | FileCheck -check-prefix=NO-ADDRSIG %s _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits