ilya-biryukov added inline comments.

================
Comment at: clangd/tool/ClangdMain.cpp:197
 
+static llvm::cl::opt<bool> IncludeFixIts(
+    "include-fixits",
----------------
sammccall wrote:
> ilya-biryukov wrote:
> > I wonder if we should make the `IncludeFixIts` option hidden?
> > It currently only works for our YCM integration, VSCode and other clients 
> > break.
> why would a user want to turn this on or off?
Ideally, we want to have it always on.
However, all editors interpret the results we return in different ways. This is 
a temporary option until we can define how text edits are handled by LSP.
We filed the bugs, will dig them up on Monday.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D51214



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to