jolesiak added a comment.
Thanks!
https://reviews.llvm.org/D49580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yroux created this revision.
yroux added reviewers: mclow.lists, hans.
Herald added a reviewer: EricWF.
Herald added a reviewer: javed.absar.
Herald added subscribers: ldionne, chrib, kristof.beyls.
Check _LIBCXXABI_ARM_EHABI macro instead of libunwind version
Repository:
rCXXA libc++abi
http
mgorny created this revision.
mgorny added reviewers: ilya-biryukov, arphaman, bkramer, gribozavr.
Update expected completions to match output generated by clang-7.0.
Disclaimer: I have no clue if the results are correct. I'm kinda wondering why
the '::' part is no longer included immediately.
svenvh accepted this revision.
svenvh added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D50104
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
baloghadamsoftware updated this revision to Diff 158701.
baloghadamsoftware added a comment.
Copying iterator position for the `this` pointer of C++ operators from the
caller's context to the callee's context is no longer needed.
https://reviews.llvm.org/D32747
Files:
include/clang/StaticAna
baloghadamsoftware added a comment.
Yes, it is working now without the hack.
https://reviews.llvm.org/D32747
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Merged to 6.0 in r338687.
On Wed, Aug 1, 2018 at 3:41 PM, Filipe Cabecinhas via cfe-commits
wrote:
> Author: filcab
> Date: Wed Aug 1 06:41:11 2018
> New Revision: 338552
>
> URL: http://llvm.org/viewvc/llvm-project?rev=338552&view=rev
> Log:
> Add REQUIRES: native to a test that assumes it
>
>
Merged to 7.0 in r338688.
On Wed, Aug 1, 2018 at 3:41 PM, Filipe Cabecinhas via cfe-commits
wrote:
> Author: filcab
> Date: Wed Aug 1 06:41:42 2018
> New Revision: 338553
>
> URL: http://llvm.org/viewvc/llvm-project?rev=338553&view=rev
> Log:
> Use a dummy target so the test passes when default
ioeric added a comment.
Is it possible for clangd to always capitalize diagnostics if
`-capitialize-diagnostic-text` is found in the compile comand?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50154
___
cfe-commits mailing list
Author: ioeric
Date: Thu Aug 2 03:30:56 2018
New Revision: 338696
URL: http://llvm.org/viewvc/llvm-project?rev=338696&view=rev
Log:
Replace hardcoded format styles in a few tools with the default style in
libFormat.
Modified:
clang-tools-extra/trunk/change-namespace/ChangeNamespace.cpp
SjoerdMeijer created this revision.
SjoerdMeijer added reviewers: olista01, ab.
Herald added a reviewer: javed.absar.
Herald added a subscriber: kristof.beyls.
In https://reviews.llvm.org/D50068, @ab noticed that it would be better to
match aarch64-{{.*}} for
tests that use "-target aarch64_be -m
ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/test/clang-doc/bc-linkage.cpp:106
+// CHECK-0-NEXT:
+// CHECK-0-NEXT:
+// CHECK-0-NEXT:blob data = 'InnerClass'
jul
mprobst created this revision.
mprobst added a reviewer: krasimir.
Previously, clang-format would crash if it tried to wrap an overlong
single line comment, because two parts of the code inserted a break in
the same location.
/** heregoesalongcommentwithnospace */
This wasn't previously notice
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Great! Thank you!
Repository:
rC Clang
https://reviews.llvm.org/D50177
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
Author: mwu
Date: Thu Aug 2 00:28:11 2018
New Revision: 338675
URL: http://llvm.org/viewvc/llvm-project?rev=338675&view=rev
Log:
Test commit access
Modified:
cfe/trunk/include/clang-c/Index.h
Modified: cfe/trunk/include/clang-c/Index.h
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/inc
SjoerdMeijer created this revision.
SjoerdMeijer added reviewers: olista01, samparker, john.brawn, ab,
t.p.northover.
Herald added a reviewer: javed.absar.
Herald added subscribers: chrib, kristof.beyls.
For AArch64:
1. Crypto means sm4 + sha3 + sha2 + aes for Armv8.4-A and up,
2. and sha2 + aes
ilya-biryukov added subscribers: simark, malaperle.
ilya-biryukov added a comment.
Maybe we could simply always capitalize the messages? Any cons to capitalizing
error messages?
@simark, @malaperle, @ioeric, @hokein, WDYT?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50154
aaron.ballman updated this revision to Diff 158731.
aaron.ballman added a comment.
Updating based on review feedback.
https://reviews.llvm.org/D50055
Files:
docs/CodingStandards.rst
docs/DeveloperPolicy.rst
docs/Lexicon.rst
Index: docs/Lexicon.rst
===
ioeric added a comment.
In https://reviews.llvm.org/D50154#1185545, @ilya-biryukov wrote:
> Maybe we could simply always capitalize the messages? Any cons to
> capitalizing error messages?
> @simark, @malaperle, @ioeric, @hokein, WDYT?
Oh sorry, I thought `-capitialize-diagnostic-text` was an
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338706: clang-format: fix a crash in comment wraps.
(authored by mprobst, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50177
Files:
cfe/trun
Author: mprobst
Date: Thu Aug 2 04:52:08 2018
New Revision: 338706
URL: http://llvm.org/viewvc/llvm-project?rev=338706&view=rev
Log:
clang-format: fix a crash in comment wraps.
Summary:
Previously, clang-format would crash if it tried to wrap an overlong
single line comment, because two parts of
aaron.ballman marked 2 inline comments as done.
aaron.ballman added inline comments.
Comment at: docs/CodingStandards.rst:512
+Do not commit changes that include trailing whitespace. Some common editors
will
+automatically remove trailing whitespace when saving a file which ca
Author: arsenm
Date: Thu Aug 2 05:14:28 2018
New Revision: 338707
URL: http://llvm.org/viewvc/llvm-project?rev=338707&view=rev
Log:
Try to make builtin address space declarations not useless
The way address space declarations for builtins currently work
is nearly useless. The code assumes the ad
arsenm closed this revision.
arsenm added a comment.
r338707
https://reviews.llvm.org/D47154
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
simark added a comment.
That's fine with me. I'll try it and time will tell if I like it or not :).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50154
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
ank updated this revision to Diff 158737.
ank added a comment.
fix space in if (
Repository:
rC Clang
https://reviews.llvm.org/D45719
Files:
lib/Format/ContinuationIndenter.cpp
lib/Format/FormatToken.h
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
===
yaxunl added inline comments.
Comment at: lib/Sema/SemaCast.cpp:1050
+ SrcType->getAs()->getPointeeType().getAddressSpace() !=
+
DestType->getAs()->getPointeeType().getAddressSpace();
+}
rjmccall wrote:
> yaxunl wrote:
> > rjmccall wrote:
> >
sammccall added a comment.
Capitalizing sounds nice. +1 to just do it without an option.
My favorite essay on this is
http://neugierig.org/software/blog/2018/07/options.html
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50154
___
mstorsjo added a comment.
This change made clang to start trigger failed asserts for me (although they
seem to not be reproducible with all compilers building clang), see
https://bugs.llvm.org/show_bug.cgi?id=38421 for full description.
Repository:
rC Clang
https://reviews.llvm.org/D49922
erichkeane added a comment.
In https://reviews.llvm.org/D48100#1185189, @hfinkel wrote:
> Assuming that @aaron.ballman is still okay with this, I think that we should
> move forward. @erichkeane, I suspect that fixing the ordering problems, which
> were often arbitrary before and are still so,
Thanks Vlad for the removal! This warning didn’t show up in my environment
when committing this, I really need get a newer GCC :/
I suspect the patch author should extract that assert to the bitfield area with
the rest.
From: David Jones [mailto:d...@google.com]
Sent: Wednesday, August 1, 201
erichkeane added a comment.
@bricci : This likely needs to be moved into the bitfield section I think. We
had a couple of other static-asserts that moved, so this is likely one of them.
Repository:
rC Clang
https://reviews.llvm.org/D50163
___
c
yaxunl added a comment.
In https://reviews.llvm.org/D50104#1184362, @scott.linder wrote:
> Address feedback; I hope I understood correctly what debug info to check for.
>
> I don't see where in CreateMemTemp and friends EmitLifetimeStart gets called,
> and I don't see any lifetime intrinsics in
simark added a comment.
In https://reviews.llvm.org/D50154#1185605, @sammccall wrote:
> Capitalizing sounds nice. +1 to just do it without an option.
>
> My favorite essay on this is
> http://neugierig.org/software/blog/2018/07/options.html
Agreed.
Repository:
rCTE Clang Tools Extra
https
Can't you omit '-o -' now too?
On Wed, Aug 1, 2018 at 5:21 PM Roman Lebedev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: lebedevri
> Date: Wed Aug 1 14:20:58 2018
> New Revision: 338640
>
> URL: http://llvm.org/viewvc/llvm-project?rev=338640&view=rev
> Log:
> [NFC][CodeGenCXX]
ilya-biryukov added a comment.
Seems we have consensus here.
Let's remove the option and just always capitalize the messages.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50154
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
asb added a comment.
Could you add a test for this please?
Repository:
rC Clang
https://reviews.llvm.org/D50043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Szelethus updated this revision to Diff 158749.
Szelethus edited the summary of this revision.
Szelethus added a comment.
Dereferencing is disabled by default. I think there's a great value in this
part of the checker, but I do concede to the fact that it still needs to mature
even for alpha. I'
Szelethus marked an inline comment as done.
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:715
void ento::registerUninitializedObjectChecker(CheckerManager &Mgr) {
auto Chk = Mgr.registerChecker();
Chk->IsPedantic =
Szelethus added a comment.
In https://reviews.llvm.org/D49438#1184688, @george.karpenkov wrote:
> @Szelethus Hi, do you plan to finish this patch soon-ish? I would like to
> evaluate it on a few codebases, but the pointer chasing is currently way too
> fragile / generates too many FPs.
What d
ioeric created this revision.
ioeric added reviewers: ilya-biryukov, hokein.
Herald added a subscriber: cfe-commits.
For example, when renaming `a::b::x::foo` to `y::foo` below, replacing
`x::foo()` with `y::foo()` can cause ambiguity. In such cases, we simply fully
qualify the name with leading `
ioeric updated this revision to Diff 158761.
ioeric added a comment.
- minor update to comment.
Repository:
rC Clang
https://reviews.llvm.org/D50189
Files:
lib/Tooling/Core/Lookup.cpp
unittests/Tooling/LookupTest.cpp
Index: unittests/Tooling/LookupTest.cpp
==
Szelethus updated this revision to Diff 158760.
Szelethus added a comment.
Forgot `git add` and `-U`.
https://reviews.llvm.org/D49438
Files:
lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp
test/Analysis/cxx-uninitialized-object-inheritance.cpp
test/Analysis/cxx-uninitialize
bricci added a comment.
The static_assert itself cannot be in the bitfield since the whole point is to
avoid including Basic/IdentifierTable.h just for this.
I originally put the static_assert in ObjCMethodDecl and everything worked fine
when tested with GCC but I then saw just
after you commit
ilya-biryukov added inline comments.
Comment at: lib/Tooling/Core/Lookup.cpp:137
+ StringRef TrimmedQName = QName.substr(2);
+ for (auto I = UseNamespaces.begin(), E = UseNamespaces.end(); I != E; ++I) {
+const NamespaceDecl *NS = *I;
maybe use range-based-
ahatanak updated this revision to Diff 158774.
ahatanak marked 3 inline comments as done.
ahatanak added a comment.
Address review comments.
Repository:
rC Clang
https://reviews.llvm.org/D50152
Files:
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGBlocks.h
lib/CodeGen/CGNonTrivialStruct.cpp
ahatanak added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1638
+switch (E.Kind) {
+case BlockCaptureEntityKind::CXXRecord: {
+ Name += "c";
rjmccall wrote:
> I forget whether this case has already filtered out trivial
> copy-constructors,
Author: maskray
Date: Thu Aug 2 09:29:36 2018
New Revision: 338732
URL: http://llvm.org/viewvc/llvm-project?rev=338732&view=rev
Log:
[analyzer] Make RegionVector use const reference
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp
Modified: cfe/trunk/lib/StaticAnalyzer/Co
scott.linder added a comment.
I still don't quite see what you describe; with that change all of the
lifetime.end calls pile up just before the enclosing function returns, not
after each call to enqueue_kernel. Looking at
https://clang.llvm.org/doxygen/EHScopeStack_8h_source.html#l00078 I don't
kadircet created this revision.
kadircet added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, arphaman, jkorous, ioeric.
Added functionality to suggest FixIts for conversion of '->' to '.' and vice
versa.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50193
emmettneyman created this revision.
emmettneyman added reviewers: kcc, morehouse.
Herald added subscribers: cfe-commits, mgorny.
Added corpus of arrays to use as inputs for the functions. Check that the two
functions modify the inputted arrays in the same way.
Repository:
rC Clang
https://rev
yaxunl added a comment.
In https://reviews.llvm.org/D50104#1185920, @scott.linder wrote:
> I still don't quite see what you describe; with that change all of the
> lifetime.end calls pile up just before the enclosing function returns, not
> after each call to enqueue_kernel. Looking at
> https
juliehockett marked 2 inline comments as done.
juliehockett added inline comments.
Comment at: clang-tools-extra/test/clang-doc/bc-linkage.cpp:106
+// CHECK-0-NEXT:
+// CHECK-0-NEXT:
+// CHECK-0-NEXT:blob data = 'InnerClass'
ioeric wrote:
> juliehockett w
mclow.lists added a comment.
That certainly ***looks*** more correct to me.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D50170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
On Thu, 2 Aug 2018, 06:10 Martin Storsjö via Phabricator via cfe-commits, <
cfe-commits@lists.llvm.org> wrote:
> mstorsjo added a comment.
>
> This change made clang to start trigger failed asserts for me (although
> they seem to not be reproducible with all compilers building clang), see
> https:
Author: vsapsai
Date: Thu Aug 2 10:29:53 2018
New Revision: 338741
URL: http://llvm.org/viewvc/llvm-project?rev=338741&view=rev
Log:
[c-index-test] Use correct executable path to discover resource directory.
Driver builds resource directory path based on provided executable path.
Instead of stri
This revision was automatically updated to reflect the committed changes.
vsapsai marked an inline comment as done.
Closed by commit rL338741: [c-index-test] Use correct executable path to
discover resource directory. (authored by vsapsai, committed by ).
Herald added a subscriber: llvm-commits.
vsapsai added a comment.
Thanks for the review!
Repository:
rL LLVM
https://reviews.llvm.org/D50160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
morehouse added inline comments.
Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:173
+ int s = getSize((char *) func_ptr);
+ memcpy(mem, func_ptr, s);
+}
Why do we need to copy the function somewhere else? Looks very error-prone and
unnecessa
Author: jfb
Date: Thu Aug 2 10:35:46 2018
New Revision: 338743
URL: http://llvm.org/viewvc/llvm-project?rev=338743&view=rev
Log:
__c11_atomic_load's _Atomic can be const
Summary:
C++11 onwards specs the non-member functions atomic_load and
atomic_load_explicit as taking the atomic by const (pot
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338743: __c11_atomic_load's _Atomic can be const
(authored by jfb, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47618
Files:
cfe/trunk/lib/S
Author: epilk
Date: Thu Aug 2 10:45:01 2018
New Revision: 338747
URL: http://llvm.org/viewvc/llvm-project?rev=338747&view=rev
Log:
[itanium demangler] Support dot suffixes on block invocation functions
rdar://32378759
Modified:
libcxxabi/trunk/src/cxa_demangle.cpp
libcxxabi/trunk/test/t
xazax.hun accepted this revision.
xazax.hun added a comment.
We could also print something about the ReturnStmt, like source location or
pretty print of its expressions so we can check that we picked the right one in
case we have multiple.
But consider this as an optional task if you have nothin
NoQ accepted this revision.
NoQ added a comment.
All this stuff looks great! Please commit.
https://reviews.llvm.org/D49361
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
emmettneyman added inline comments.
Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:173
+ int s = getSize((char *) func_ptr);
+ memcpy(mem, func_ptr, s);
+}
morehouse wrote:
> Why do we need to copy the function somewhere else? Looks very erro
emmettneyman updated this revision to Diff 158800.
emmettneyman added a comment.
Replaced hardcoded numbers with variables
Repository:
rC Clang
https://reviews.llvm.org/D50194
Files:
clang/tools/clang-fuzzer/CMakeLists.txt
clang/tools/clang-fuzzer/ExampleClangLLVMProtoFuzzer.cpp
clang/
On Mon, Jul 30, 2018 at 5:44 PM Reka Kovacs via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rkovacs
> Date: Mon Jul 30 08:43:45 2018
> New Revision: 338259
>
> URL: http://llvm.org/viewvc/llvm-project?rev=338259&view=rev
> Log:
> [analyzer] Add support for more invalidating function
Author: mstorsjo
Date: Thu Aug 2 11:12:08 2018
New Revision: 338749
URL: http://llvm.org/viewvc/llvm-project?rev=338749&view=rev
Log:
Work around more GCC miscompiles exposed by r338464.
This is the same fix as in r338478, for another occurrance of the
same pattern from r338464.
See gcc.gnu.org
Author: george.karpenkov
Date: Thu Aug 2 11:17:01 2018
New Revision: 338753
URL: http://llvm.org/viewvc/llvm-project?rev=338753&view=rev
Log:
[analyzer] Forward arguments in registerChecker to avoid accidental copies
Differential Revision: https://reviews.llvm.org/D50108
Modified:
cfe/trunk
morehouse added inline comments.
Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:173
+ int s = getSize((char *) func_ptr);
+ memcpy(mem, func_ptr, s);
+}
emmettneyman wrote:
> morehouse wrote:
> > Why do we need to copy the function somewhere e
efriedma added inline comments.
Comment at: lib/Driver/ToolChains/Arch/AArch64.cpp:200
+ //
+ // TODO: implement this logic in TargetParser.
+
Yes, this logic should be in TargetParser, not here. Trying to rewrite the
target features afterwards is messy at be
Author: arsenm
Date: Thu Aug 2 11:24:55 2018
New Revision: 338754
URL: http://llvm.org/viewvc/llvm-project?rev=338754&view=rev
Log:
AMDGPU: Fix missing declaration of queue ptr builtin
Modified:
cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def
cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn
Hans,
I think this commit should be merged to the 7.0 release branch; the first
half of the GCC workaround made it in before the branch happened, but
there was another identical case missing.
// Martin
On Thu, 2 Aug 2018, Martin Storsjo via cfe-commits wrote:
Author: mstorsjo
Date: Thu Aug
Author: george.karpenkov
Date: Thu Aug 2 11:41:25 2018
New Revision: 338756
URL: http://llvm.org/viewvc/llvm-project?rev=338756&view=rev
Log:
[analyzer] Fix tests.
Modified:
cfe/trunk/test/Analysis/analyzer-config.c
cfe/trunk/test/Analysis/analyzer-config.cpp
Modified: cfe/trunk/test/An
On Thu, 2 Aug 2018, Richard Smith via cfe-commits wrote:
On Thu, 2 Aug 2018, 06:10 Martin Storsjö via Phabricator via cfe-commits,
wrote:
mstorsjo added a comment.
This change made clang to start trigger failed asserts for me
(although they seem to not be reproducible with al
andrew.w.kaylor added a comment.
I hope I'm not coming across as too argumentative here. I don't really have
strong feelings about this function pointer type patch and ultimately I see
that you are right, but the objections you are raising here would equally apply
to what I'm working on with th
scott.linder updated this revision to Diff 158816.
scott.linder added a comment.
Emit lifetime intrinsics for the sizes temp, and update test
https://reviews.llvm.org/D50104
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGenOpenCL/cl20-device-side-enqueue.cl
test/CodeGenOpenCL/enqueue-kernel-n
mstorsjo created this revision.
mstorsjo added reviewers: rnk, compnerd, pcc, pirama.
Repository:
rC Clang
https://reviews.llvm.org/D50199
Files:
include/clang/Basic/LangOptions.def
include/clang/Driver/Options.td
lib/Basic/Targets.cpp
lib/Driver/ToolChains/Clang.cpp
lib/Frontend/Com
rnk added a comment.
Does this do anything other than -DUNICODE? Maybe just translate it at the
driver level and skip the -cc1 flag?
Repository:
rC Clang
https://reviews.llvm.org/D50199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
Quuxplusone updated this revision to Diff 158822.
Quuxplusone marked 20 inline comments as done.
Quuxplusone added a comment.
Further removal of dead code based on @Rakete's feedback.
Repository:
rC Clang
https://reviews.llvm.org/D50119
Files:
docs/LanguageExtensions.rst
include/clan
Quuxplusone added inline comments.
Comment at: compiler-explorer-llvm-commit.sh:1
+# This is the commit of LLVM that we're currently based on.
+git reset --hard 1fa19f68007cd126a04448093c171f40e556087e
Rakete wrote:
> What's this file? A mistake?
Yeah, it's p
Rakete added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:6187
+Record->dropAttr();
+ } else if (Record->needsImplicitMoveConstructor() &&
+ Record->defaultedMoveConstructorIsDeleted()) {
Quuxplusone wrote:
> Rakete w
dblaikie added a comment.
Hi - sorry about the stalled opaque pointer types effort.
For my money - ideally - if someone comes across a bug caused by incorrect
pointee types, ideally that would be fixed by adjusting whatever piece of code
was depending on that pointee type being correct to not d
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
The attribute itself is looking reasonable aside from some minor nits, but this
should not be committed until the clang-tidy functionality is approved (since
it has no utility be
mstorsjo added a comment.
In https://reviews.llvm.org/D50199#1186164, @rnk wrote:
> Does this do anything other than -DUNICODE? Maybe just translate it at the
> driver level and skip the -cc1 flag?
Yes, that also works. Initially I looked at where to place that in
lib/Driver/ToolChains/MinGW.
mstorsjo updated this revision to Diff 158827.
mstorsjo added a comment.
Simplified the patch to just handle the flag within the driver, without making
it a flag to cc1.
https://reviews.llvm.org/D50199
Files:
lib/Driver/ToolChains/Clang.cpp
test/Driver/mingw.cpp
Index: test/Driver/mingw.
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:3489
+
+``noderef`` is currently only supported for C style pointers and arrays and
not usable for
+references or Objective-C pointers.
I would drop the "C style" and just say it's
phosek added inline comments.
Comment at: CMakeLists.txt:363
-add_subdirectory(test)
+if (EXISTS ${LLVM_CMAKE_PATH})
+ add_subdirectory(test)
libcxx seems to be using a different condition: `IS_DIRECTORY
"${CMAKE_CURRENT_SOURCE_DIR}/test"`, should this be uni
aaron.ballman accepted this revision.
aaron.ballman added a comment.
I am still okay with this, and agree that the ordering issues are a separate
thing to tackle.
Repository:
rC Clang
https://reviews.llvm.org/D48100
___
cfe-commits mailing list
Author: rsmith
Date: Thu Aug 2 13:30:52 2018
New Revision: 338766
URL: http://llvm.org/viewvc/llvm-project?rev=338766&view=rev
Log:
Fix assertion failure when emitting code for a merged lambda.
Modified:
cfe/trunk/lib/AST/DeclCXX.cpp
cfe/trunk/test/Modules/merge-lambdas.cpp
Modified: cf
aaron.ballman added inline comments.
Comment at: test/SemaCXX/warn-thread-safety-analysis.cpp:4081-4085
+ void unlockExclusive() EXCLUSIVE_UNLOCK_FUNCTION(mu_) {
+mu_.Unlock();
+ }
+
+ void unlockShared() SHARED_UNLOCK_FUNCTION(mu_) {
Nothing calls either
mstorsjo added inline comments.
Comment at: CMakeLists.txt:363
-add_subdirectory(test)
+if (EXISTS ${LLVM_CMAKE_PATH})
+ add_subdirectory(test)
phosek wrote:
> libcxx seems to be using a different condition: `IS_DIRECTORY
> "${CMAKE_CURRENT_SOURCE_DIR}/test"`
(+Hans) +1
On Thu, 2 Aug 2018 at 11:37, Martin Storsjö via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hans,
>
> I think this commit should be merged to the 7.0 release branch; the first
> half of the GCC workaround made it in before the branch happened, but
> there was another identical c
simoncook added a comment.
It seems the ability to link objects has been broken by this change. As an
example from our nightly tests:
Executing on host: riscv32-unknown-elf-clang
/data/jenkins/workspace/riscv32-llvm-gcc/gcc-tests/gcc/testsuite/gcc.c-torture/execute/20080502-1.c
-march=rv32g
pirama added a comment.
In https://reviews.llvm.org/D50199#1186164, @rnk wrote:
> Does this do anything other than -DUNICODE? Maybe just translate it at the
> driver level and skip the -cc1 flag?
It seems odd to include predefined macros at the driver, which AFAIK is just a
bridge to the fron
george.karpenkov added a comment.
> Dereferencing is disabled by default
Great! Thank you!
> but I haven't seen the current version of the checker crash due to pointer
> chasing.
@NoQ saw quite a few crashes during evaluation, right?
> This might be a little nit-picking, but I don't think the
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Great! The comment should be updated though.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:32
+// `-analyzer-config \
cdavis5x added a comment.
Are you sure this shouldn't also define `_UNICODE`? //looks// Hmm... GCC
doesn't define it. I wonder if we should anyway. A user who set `-municode` may
also be using ``, and thus may want those macros set to their Unicode
counterparts.
I actually believe this is supp
Rakete added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:6187
+Record->dropAttr();
+ } else if (Record->needsImplicitMoveConstructor() &&
+ Record->defaultedMoveConstructorIsDeleted()) {
Rakete wrote:
> Quuxplusone w
mstorsjo added a comment.
In https://reviews.llvm.org/D50199#1186282, @cdavis5x wrote:
> I actually believe this is supposed to have one other effect: it sets the
> entry point to `wmainCRTStartup()`/`wWinMainCRTStartup()`, making the user
> entry point `wmain()`/`wWinMain()`, which take wide a
1 - 100 of 178 matches
Mail list logo
