r336640 - Test commit

Author: steveire Date: Mon Jul 9 23:55:12 2018 New Revision: 336640 URL: http://llvm.org/viewvc/llvm-project?rev=336640&view=rev Log: Test commit Add redundant doc. Modified: cfe/trunk/include/clang/AST/ExprCXX.h Modified: cfe/trunk/include/clang/AST/ExprCXX.h URL: http://llvm.org/viewvc/

[PATCH] D49114: Add a clang-tidy check for "magic numbers"

JonasToth added a comment. Related to this check: https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es45-avoid-magic-constants-use-symbolic-constants Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49114 _

[PATCH] D49114: Add a clang-tidy check for "magic numbers"

JonasToth added a comment. I think some of the logic you have in your check code could be done via matchers. That is usually better for performance, because you analyze less code. Comment at: clang-tidy/readability/MagicNumbersCheck.cpp:44 +for (const auto &Parent : Parent

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

ilya-biryukov added inline comments. Comment at: lib/Basic/FileManager.cpp:320 + SmallString<128> RealPathName; + if (FS->getRealPath(InterndFileName, RealPathName) == std::error_code()) +UFE.RealPathName = RealPathName.str(); NIT: replace replace equality

[PATCH] D48712: [X86] Lowering integer truncation intrinsics to native IR

This revision was automatically updated to reflect the committed changes. Closed by commit rC336643: [X86] Lowering integer truncation intrinsics to native IR (authored by mike.dvoretsky, committed by ). Changed prior to commit: https://reviews.llvm.org/D48712?vs=153471&id=154765#toc Repositor

[PATCH] D49058: [analyzer] Move DanglingInternalBufferChecker out of alpha

rnkovacs updated this revision to Diff 154760. rnkovacs added a comment. Fix test run line. https://reviews.llvm.org/D49058 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td test/Analysis/dangling-internal-buffer.cpp Index: test/Analysis/dangling-internal-buffer.cpp ===

[PATCH] D48523: [clang-tidy] Update run-clang-tidy.py with vfsoverlay arg

jdemeule added a comment. kindly ping reviewers. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47946: [ASTImporter] Fix infinite recursion on function import with struct definition in parameters

martong added a comment. Ping. https://reviews.llvm.org/D47946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D44100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D10480: Implement shared_mutex re: N4508

theraven added a comment. I missed this when it went in and coming across the code now I'm quite surprised that it did. Why is `shared_mutex` not implemented as a wrapper around rwlocks (pthreads and Windows both provide this abstraction)? The current implementation looks a lot less efficient

r336655 - [MinGW] Skip adding default win32 api libraries if -lwindowsapp is specified

Author: mstorsjo Date: Tue Jul 10 03:46:51 2018 New Revision: 336655 URL: http://llvm.org/viewvc/llvm-project?rev=336655&view=rev Log: [MinGW] Skip adding default win32 api libraries if -lwindowsapp is specified In this setup, skip adding all the default windows import libraries, if linking to wi

[PATCH] D49054: [MinGW] Treat any -lucrt* as replacing -lmsvcrt

This revision was automatically updated to reflect the committed changes. Closed by commit rL336654: [MinGW] Treat any -lucrt* as replacing -lmsvcrt (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49054?vs=154502

r336654 - [MinGW] Treat any -lucrt* as replacing -lmsvcrt

Author: mstorsjo Date: Tue Jul 10 03:46:45 2018 New Revision: 336654 URL: http://llvm.org/viewvc/llvm-project?rev=336654&view=rev Log: [MinGW] Treat any -lucrt* as replacing -lmsvcrt Since SVN r314138, we check if the user has specified any particular alternative msvcrt/ucrt version, and skip the

[PATCH] D49059: [MinGW] Skip adding default win32 api libraries if -lwindowsapp is specified

This revision was automatically updated to reflect the committed changes. Closed by commit rC336655: [MinGW] Skip adding default win32 api libraries if -lwindowsapp is specified (authored by mstorsjo, committed by ). Changed prior to commit: https://reviews.llvm.org/D49059?vs=154524&id=154773#t

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

0x8000- added a comment. In https://reviews.llvm.org/D49114#1156987, @JonasToth wrote: > I think some of the logic you have in your check code could be done via > matchers. That is usually better for performance, because you analyze less > code. I have considered that approach, but had to

[PATCH] D48958: [clang][ubsan] Implicit Cast Sanitizer - integer truncation - clang part

lebedev.ri added a comment. Finished running it on a normal testset of my pet project . - It fired ~18 times. - There were no obvious false-positives (e.g. when an explicit cast was involved). - At least 3 of those appear to be a true bugs. - 4-5 more

r336643 - [X86] Lowering integer truncation intrinsics to native IR

Author: mike.dvoretsky Date: Tue Jul 10 01:22:44 2018 New Revision: 336643 URL: http://llvm.org/viewvc/llvm-project?rev=336643&view=rev Log: [X86] Lowering integer truncation intrinsics to native IR This patch lowers the _mm[256|512]_cvtepi{64|32|16}_epi{32|16|8} intrinsics to native IR in cases

[PATCH] D49068: Fixing builtin __atomic_fetch_min definition

This revision was automatically updated to reflect the committed changes. Closed by commit rL336658: Fixing builtin __atomic_fetch_min declaration (authored by opaparo, committed by ). Changed prior to commit: https://reviews.llvm.org/D49068?vs=154567&id=154776#toc Repository: rC Clang http

[PATCH] D49068: Fixing builtin __atomic_fetch_min definition

This revision was automatically updated to reflect the committed changes. Closed by commit rC336658: Fixing builtin __atomic_fetch_min declaration (authored by opaparo, committed by ). Repository: rC Clang https://reviews.llvm.org/D49068 Files: include/clang/Basic/Builtins.def Index: incl

r336658 - Fixing builtin __atomic_fetch_min declaration

Author: opaparo Date: Tue Jul 10 05:04:04 2018 New Revision: 336658 URL: http://llvm.org/viewvc/llvm-project?rev=336658&view=rev Log: Fixing builtin __atomic_fetch_min declaration Differential Revision: http://reviews.llvm.org/D49068 Modified: cfe/trunk/include/clang/Basic/Builtins.def Modi

Re: r336658 - Fixing builtin __atomic_fetch_min declaration

On Tue, Jul 10, 2018 at 8:04 AM, Omer Paparo Bivas via cfe-commits wrote: > Author: opaparo > Date: Tue Jul 10 05:04:04 2018 > New Revision: 336658 > > URL: http://llvm.org/viewvc/llvm-project?rev=336658&view=rev > Log: > Fixing builtin __atomic_fetch_min declaration Can a test case also be commi

[PATCH] D48367: [modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts

This revision was automatically updated to reflect the committed changes. Closed by commit rL336660: [modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts (authored by yamaguchi, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

r336660 - [modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts

Author: yamaguchi Date: Tue Jul 10 05:17:34 2018 New Revision: 336660 URL: http://llvm.org/viewvc/llvm-project?rev=336660&view=rev Log: [modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts Summary: Reproducer and errors: https://bugs.llvm.org/show_bug.cgi?id=37878 lookupM

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

simark updated this revision to Diff 154782. simark marked 5 inline comments as done. simark added a comment. - Make InMemoryNode::Stat private again, add protected accessor. - Change condition formatting. Repository: rC Clang https://reviews.llvm.org/D48903 Files: lib/Basic/FileManager.cp

[PATCH] D49099: Remove qualtype qualifier in coroutine error to prevent assert in debug

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Excellent, thanks! Repository: rC Clang https://reviews.llvm.org/D49099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[libcxx] r336665 - [libc++] Declare operators with the proper visibility attribute

Author: ldionne Date: Tue Jul 10 06:21:03 2018 New Revision: 336665 URL: http://llvm.org/viewvc/llvm-project?rev=336665&view=rev Log: [libc++] Declare operators with the proper visibility attribute Summary: Many operators in were _defined_ with the proper visibility attribute, but they were _de

[libcxx] r336666 - Remove BUILD file from google-benchmark

Author: ericwf Date: Tue Jul 10 06:25:26 2018 New Revision: 33 URL: http://llvm.org/viewvc/llvm-project?rev=33&view=rev Log: Remove BUILD file from google-benchmark Removed: libcxx/trunk/utils/google-benchmark/test/BUILD Removed: libcxx/trunk/utils/google-benchmark/test/BUILD URL: h

[PATCH] D49099: Remove qualtype qualifier in coroutine error to prevent assert in debug

modocache added a comment. If you don't have commit access, let me know here if you'd like me to commit this on your behalf. Repository: rC Clang https://reviews.llvm.org/D49099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D49127: [libclang] Add support for ObjC attributes without args

michaelwu created this revision. This adds support to libclang for identifying ObjC related attributes that don't take arguments. All attributes but NSObject and NSConsumed are tested. Repository: rC Clang https://reviews.llvm.org/D49127 Files: include/clang-c/Index.h test/Index/index-

[PATCH] D49120: [libc++] P0898R3 2 of 12: Implement header

CaseyCarter updated this revision to Diff 154787. CaseyCarter added a comment. Qualify call to `__invoke_constexpr` in the definition of the `Invocable` concept. https://reviews.llvm.org/D49120 Files: CMakeLists.txt include/CMakeLists.txt include/__config include/concepts include/mod

r336671 - [analyzer] Add option to set maximum symbol complexity threshold

Author: mramalho Date: Tue Jul 10 06:46:05 2018 New Revision: 336671 URL: http://llvm.org/viewvc/llvm-project?rev=336671&view=rev Log: [analyzer] Add option to set maximum symbol complexity threshold Summary: This adds an option, max-symbol-complexity, so an user can set the maximum symbol compl

[PATCH] D49093: [analyzer] Add option to set maximum symbol complexity threshold

This revision was automatically updated to reflect the committed changes. Closed by commit rC336671: [analyzer] Add option to set maximum symbol complexity threshold (authored by mramalho, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D49

[PATCH] D49099: Remove qualtype qualifier in coroutine error to prevent assert in debug

tks2103 added a comment. @modocache please commit on my behalf please =) Repository: rC Clang https://reviews.llvm.org/D49099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r336676 - Update test for backend error message change

Author: arsenm Date: Tue Jul 10 07:03:50 2018 New Revision: 336676 URL: http://llvm.org/viewvc/llvm-project?rev=336676&view=rev Log: Update test for backend error message change Modified: cfe/trunk/test/CodeGen/backend-unsupported-error.ll Modified: cfe/trunk/test/CodeGen/backend-unsupported

[PATCH] D47196: [Time-report ](2): Recursive timers in Clang

avt77 added a comment. In https://reviews.llvm.org/D47196#1134185, @efriedma wrote: > Can you give an example of what the output looks like? First of all excuse me for such delay with my answer: I was on my vacations. During bootstrap we could see something like here: [ 84%] Building CXX objec

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM if that does not introduce any regressions in clang and clang-tools. Comment at: lib/Basic/VirtualFileSystem.cpp:770 +if (I != E) { + SmallString<

[PATCH] D47196: [Time-report ](2): Recursive timers in Clang

avt77 updated this revision to Diff 154802. avt77 added a comment. I fixed all issues raised by efriedma: GlobalDecl(FD), function body, class names, etc. Many tnx for your help. https://reviews.llvm.org/D47196 Files: include/clang/Frontend/Utils.h lib/CodeGen/CodeGenAction.cpp lib/CodeG

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray updated this revision to Diff 154804. lichray marked an inline comment as done. lichray added a comment. Respond to the 2nd round review Repository: rCXX libc++ https://reviews.llvm.org/D41458 Files: include/CMakeLists.txt include/charconv include/module.modulemap src/charcon

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray marked 3 inline comments as done. lichray added inline comments. Comment at: include/charconv:89 +_LIBCPP_BEGIN_NAMESPACE_STD + +enum class _LIBCPP_ENUM_VIS chars_format mclow.lists wrote: > Quuxplusone wrote: > > lichray wrote: > > > mclow.lists wrote: >

r336681 - AMDGPU: Try to fix test again

Author: arsenm Date: Tue Jul 10 07:47:31 2018 New Revision: 336681 URL: http://llvm.org/viewvc/llvm-project?rev=336681&view=rev Log: AMDGPU: Try to fix test again Modified: cfe/trunk/test/CodeGen/backend-unsupported-error.ll Modified: cfe/trunk/test/CodeGen/backend-unsupported-error.ll URL:

[PATCH] D47172: [FileCheck] Add -allow-deprecated-dag-overlap to failing clang tests

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D47172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

r336685 - Support -fdebug-prefix-map for assembler source (pass to cc1as). This

Author: probinson Date: Tue Jul 10 08:15:24 2018 New Revision: 336685 URL: http://llvm.org/viewvc/llvm-project?rev=336685&view=rev Log: Support -fdebug-prefix-map for assembler source (pass to cc1as). This is useful to omit the debug compilation dir when compiling assembly files with -g. Part of

[PATCH] D48989: -fdebug-prefix-map option for cc1as

This revision was automatically updated to reflect the committed changes. Closed by commit rC336685: Support -fdebug-prefix-map for assembler source (pass to cc1as). This (authored by probinson, committed by ). Changed prior to commit: https://reviews.llvm.org/D48989?vs=154669&id=154811#toc R

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray updated this revision to Diff 154816. lichray added a comment. Less trailing return types Repository: rCXX libc++ https://reviews.llvm.org/D41458 Files: include/CMakeLists.txt include/charconv include/module.modulemap src/charconv.cpp test/libcxx/double_include.sh.cpp tes

[PATCH] D49118: [libc++] P0898R3 1 of 12: changes to common_type; implement common_reference

mclow.lists added a comment. > I've conservatively hidden everything behind _LIBCPP_STD_VER > 17, although > it could be made available in C++11 mode with some edits. If we have a use for this in pre c++2a code, the libc++ convention would be to implement `__common_reference` that works most

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray marked an inline comment as done. lichray added inline comments. Comment at: include/charconv:234 +to_chars(char* __first, char* __last, _Tp __value, int __base) +-> to_chars_result +{ mclow.lists wrote: > lichray wrote: > > mclow.lists wrote: > > > W

[PATCH] D49142: [clangd] Extract FileSystemProvider into a separate header. NFC

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: jkorous, MaskRay, ioeric, mgorny. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49142 Files: clangd/CMakeLists.txt clangd/ClangdServer.cpp clangd/ClangdServer.h clan

[PATCH] D49143: Fix a typo/regression in r335495.

bsdjhb created this revision. bsdjhb added a reviewer: arichardson. Herald added subscribers: atanasyan, krytarowski, sdardis, emaste. Use getTriple.isMIPS64() to detect 64-bit MIPS ABIs in FreeBSD::getSupportedSanitizers() instead of getTriple.isMIPS32(). Repository: rC Clang https://reviews

[PATCH] D49143: Fix a typo/regression in r335495.

atanasyan added a comment. It would be nice to have a test for this regression. Repository: rC Clang https://reviews.llvm.org/D49143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D48721: Patch to fix pragma metadata for do-while loops

bjope accepted this revision. bjope added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D48721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D48862: Fix lib paths for OpenEmbedded targets

mgrang added a comment. Ping for reviews, please. https://reviews.llvm.org/D48862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49143: Fix a typo/regression in r335495.

bsdjhb added a comment. AFAICT, I don't see a way to ask clang "which sanitizers are supported by this target". Hmm, the CHECK-SANL-MIPS test in tests/Driver/fsanitize.c seems like the closest match. Repository: rC Clang https://reviews.llvm.org/D49143 __

[PATCH] D49083: [HIP] Register/unregister device fat binary only once

tra added a comment. > HIP generates one fat binary for all devices after linking. However, for each > compilation > unit a ctor function is emitted which register the same fat binary. > Measures need to be taken to make sure the fat binary is only registered > once. Are you saying that for

[PATCH] D48721: Patch to fix pragma metadata for do-while loops

deepak2427 marked an inline comment as done. deepak2427 added a comment. @Bjorn, Thanks for reviewing and accepting the patch. Could you please advise on the next steps? Would someone else commit this on my behalf or should I request for commit access? Thanks, Deepak Panickal https://reviews.

[PATCH] D48982: [mips] Add '-mvirt', '-mno-virt', '-mginv', '-mno-ginv' options

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D48982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D49083: [HIP] Register/unregister device fat binary only once

yaxunl added a comment. In https://reviews.llvm.org/D49083#1157568, @tra wrote: > > HIP generates one fat binary for all devices after linking. However, for > > each compilation > > unit a ctor function is emitted which register the same fat binary. > > Measures need to be taken to make sure

[PATCH] D49112: [Sema] Implement -Wmemset-transposed-args

erik.pilkington updated this revision to Diff 154833. erik.pilkington added a comment. Address @Quuxplusone comments. https://reviews.llvm.org/D49112 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaChecking.cpp cla

[PATCH] D49112: [Sema] Implement -Wmemset-transposed-args

erik.pilkington added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:662 +def note_suspicious_sizeof_memset_silence : Note< + "%select{parenthesize the third argument|cast the second argument to 'int'}0 to silence">; + Quuxplusone

[PATCH] D46845: [libcxx][c++17] P0083R5: Splicing Maps and Sets

erik.pilkington added a reviewer: ldionne. erik.pilkington added a comment. Ping! https://reviews.llvm.org/D46845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

simark marked an inline comment as done. simark added a comment. In https://reviews.llvm.org/D48903#1157330, @ilya-biryukov wrote: > LGTM if that does not introduce any regressions in clang and clang-tools. Thanks. I have seen no failures in `check-clang` and `check-clang-tools`, so I will pu

[PATCH] D22391: [Sema] Add warning for implicitly casting a null constant to a non null pointer type

jordan_rose added a subscriber: dergachev.a. jordan_rose added a comment. Sorry for the delay. I think this is mostly good, but I do still have a concern about the diagnostics change. Comment at: lib/Sema/SemaExpr.cpp:7117 +if (E && S.checkNonNullExpr(E)) + return Nul

[PATCH] D46845: [libcxx][c++17] P0083R5: Splicing Maps and Sets

EricWF added a comment. I'm working on this! I'll be taking what is hopefully a final pass at the tests today. https://reviews.llvm.org/D46845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

simark updated this revision to Diff 154835. simark added a comment. Bump SmallString size from 32 to 256 Repository: rC Clang https://reviews.llvm.org/D48903 Files: lib/Basic/FileManager.cpp lib/Basic/VirtualFileSystem.cpp unittests/Basic/VirtualFileSystemTest.cpp unittests/Driver/T

[PATCH] D49143: Fix a typo/regression in r335495.

bsdjhb updated this revision to Diff 154840. bsdjhb added a comment. Add tests. Repository: rC Clang https://reviews.llvm.org/D49143 Files: lib/Driver/ToolChains/FreeBSD.cpp test/Driver/fsanitize.c Index: test/Driver/fsanitize.c =

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray updated this revision to Diff 154842. lichray added a comment. Dropping C++11 support. Repository: rCXX libc++ https://reviews.llvm.org/D41458 Files: include/CMakeLists.txt include/charconv include/module.modulemap src/charconv.cpp test/libcxx/double_include.sh.cpp test/s

[PATCH] D49143: Fix a typo/regression in r335495.

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D49143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray marked an inline comment as done. lichray added inline comments. Comment at: include/charconv:89 +_LIBCPP_BEGIN_NAMESPACE_STD + +enum class _LIBCPP_ENUM_VIS chars_format lichray wrote: > mclow.lists wrote: > > Quuxplusone wrote: > > > lichray wrote: > > >

[libcxx] r336709 - [libc++] Declare noop_coroutine() with _LIBCPP_INLINE_VISIBILITY

Author: ldionne Date: Tue Jul 10 10:38:30 2018 New Revision: 336709 URL: http://llvm.org/viewvc/llvm-project?rev=336709&view=rev Log: [libc++] Declare noop_coroutine() with _LIBCPP_INLINE_VISIBILITY Summary: It was defined with the right visibility, but declared without any visibility. This funct

[PATCH] D49143: Fix a typo/regression in r335495.

This revision was automatically updated to reflect the committed changes. Closed by commit rC336710: Fix a typo/regression in r335495. (authored by jhb, committed by ). Changed prior to commit: https://reviews.llvm.org/D49143?vs=154840&id=154845#toc Repository: rC Clang https://reviews.llvm

r336710 - Fix a typo/regression in r335495.

Author: jhb Date: Tue Jul 10 10:44:08 2018 New Revision: 336710 URL: http://llvm.org/viewvc/llvm-project?rev=336710&view=rev Log: Fix a typo/regression in r335495. Use getTriple.isMIPS64() to detect 64-bit MIPS ABIs in FreeBSD::getSupportedSanitizers() instead of getTriple.isMIPS32(). Reviewed B

[PATCH] D49118: [libc++] P0898R3 1 of 12: changes to common_type; implement common_reference

CaseyCarter added a comment. In https://reviews.llvm.org/D49118#1157438, @mclow.lists wrote: > > I've conservatively hidden everything behind _LIBCPP_STD_VER > 17, > > although it could be made available in C++11 mode with some edits. > > If we have a use for this in pre c++2a code, the libc++

[PATCH] D48753: [libcxx] Use custom allocator's `construct` in C++03 when available.

EricWF added a comment. Why are we doing this? I can't find the language in the C++03 specification that requires us to call an allocators `construct` method if it's present. https://reviews.llvm.org/D48753 ___ cfe-commits mailing list cfe-commits

[PATCH] D49057: [analyzer] Track multiple raw pointer symbols in DanglingInternalBufferChecker

NoQ accepted this revision. NoQ added a comment. Looks great, thanks! https://reviews.llvm.org/D49057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22391: [Sema] Add warning for implicitly casting a null constant to a non null pointer type

NoQ edited subscribers, added: NoQ; removed: dergachev.a. NoQ added inline comments. Comment at: test/Analysis/nullability_nullonly.mm:103 void testObjCARCExplicitZeroInitialization() { - TestObject * _Nonnull explicitlyZeroInitialized = nil; // expected-warning {{nil assigned

[PATCH] D49148: [DEBUGINFO] Disable unsupported debug info options for NVPTX target.

ABataev created this revision. ABataev added a reviewer: echristo. Herald added subscribers: JDevlieghere, aprantl. Some targets support only default set of the debug options and do not support additional debug options, like NVPTX target. Patch introduced virtual function supportsNonDefaultDebugOp

[libcxx] r336713 - [CMake] Set per-runtime library directory suffix in runtimes build

Author: phosek Date: Tue Jul 10 12:13:33 2018 New Revision: 336713 URL: http://llvm.org/viewvc/llvm-project?rev=336713&view=rev Log: [CMake] Set per-runtime library directory suffix in runtimes build Do not use LLVM_RUNTIMES_LIBDIR_SUFFIX variable which is an internal variable used by the runtime

[libcxxabi] r336713 - [CMake] Set per-runtime library directory suffix in runtimes build

Author: phosek Date: Tue Jul 10 12:13:33 2018 New Revision: 336713 URL: http://llvm.org/viewvc/llvm-project?rev=336713&view=rev Log: [CMake] Set per-runtime library directory suffix in runtimes build Do not use LLVM_RUNTIMES_LIBDIR_SUFFIX variable which is an internal variable used by the runtime

[libunwind] r336713 - [CMake] Set per-runtime library directory suffix in runtimes build

Author: phosek Date: Tue Jul 10 12:13:33 2018 New Revision: 336713 URL: http://llvm.org/viewvc/llvm-project?rev=336713&view=rev Log: [CMake] Set per-runtime library directory suffix in runtimes build Do not use LLVM_RUNTIMES_LIBDIR_SUFFIX variable which is an internal variable used by the runtime

[PATCH] D48721: Patch to fix pragma metadata for do-while loops

bjope added a comment. In https://reviews.llvm.org/D48721#1157571, @deepak2427 wrote: > @Bjorn, Thanks for reviewing and accepting the patch. > > Could you please advise on the next steps? > Would someone else commit this on my behalf or should I request for commit > access? > > Thanks, > Deep

r336715 - Revert r336591 "[libclang] NFC, simplify clang_Cursor_Evaluate"

Author: eugenis Date: Tue Jul 10 12:48:53 2018 New Revision: 336715 URL: http://llvm.org/viewvc/llvm-project?rev=336715&view=rev Log: Revert r336591 "[libclang] NFC, simplify clang_Cursor_Evaluate" This change is blocking r336590 which is being reverted due to memory leaks. Modified: cfe/tru

Re: r336590 - [libclang] evalute compound statement cursors before trying to evaluate

Reverting... On Mon, Jul 9, 2018 at 8:18 PM, Vlad Tsyrklevich wrote: > The ASan bot is failing with a LeakSanitizer failure that appears related to > one of your libclang changes: > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/6282/steps/check-clang%20asan/logs/stdio

r336716 - Revert r336590 "[libclang] evalute compound statement cursors before trying to evaluate"

Author: eugenis Date: Tue Jul 10 12:49:07 2018 New Revision: 336716 URL: http://llvm.org/viewvc/llvm-project?rev=336716&view=rev Log: Revert r336590 "[libclang] evalute compound statement cursors before trying to evaluate" New memory leaks in LibclangParseTest_EvaluateChildExpression_Test::TestB

r336717 - Patch to fix pragma metadata for do-while loops

Author: bjope Date: Tue Jul 10 12:55:02 2018 New Revision: 336717 URL: http://llvm.org/viewvc/llvm-project?rev=336717&view=rev Log: Patch to fix pragma metadata for do-while loops Summary: Make sure that loop metadata only is put on the backedge when expanding a do-while loop. Previously we added

[PATCH] D48721: Patch to fix pragma metadata for do-while loops

This revision was automatically updated to reflect the committed changes. Closed by commit rL336717: Patch to fix pragma metadata for do-while loops (authored by bjope, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48721?vs=154244&id

[PATCH] D48958: [clang][ubsan] Implicit Cast Sanitizer - integer truncation - clang part

lebedev.ri updated this revision to Diff 154863. lebedev.ri added a comment. - Check that sanitizer is actually enabled before doing the AST upwalk. I didn't measure, but it would be logical for this to be better. Repository: rC Clang https://reviews.llvm.org/D48958 Files: docs/ReleaseNot

[PATCH] D48687: [clangd] Avoid duplicates in findDefinitions response

simark added a comment. Herald added a subscriber: omtcyfz. I took a look at `SymbolCollector`'s `toURI`, and I am not sure what to get from it. It seems like a lot of it could be replaced with a call to `FileSystem::getRealPath`. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/

r336726 - [NFC] Switch CodeGenFunction to use value init instead of member init lists

Author: erichkeane Date: Tue Jul 10 13:46:46 2018 New Revision: 336726 URL: http://llvm.org/viewvc/llvm-project?rev=336726&view=rev Log: [NFC] Switch CodeGenFunction to use value init instead of member init lists The member init list for the sole constructor for CodeGenFunction has gotten out of

[PATCH] D48753: [libcxx] Use custom allocator's `construct` in C++03 when available.

vsapsai added a comment. In https://reviews.llvm.org/D48753#1157695, @EricWF wrote: > Why are we doing this? > > I can't find the language in the C++03 specification that requires us to call > an allocators `construct` method if it's present. The main reason I've ended up doing this because I

r336727 - Revert -r336726, which included more files than intended.

Author: erichkeane Date: Tue Jul 10 13:51:41 2018 New Revision: 336727 URL: http://llvm.org/viewvc/llvm-project?rev=336727&view=rev Log: Revert -r336726, which included more files than intended. Modified: cfe/trunk/include/clang/AST/ASTContext.h cfe/trunk/include/clang/AST/RecursiveASTVis

RE: r336726 - [NFC] Switch CodeGenFunction to use value init instead of member init lists

Sorry everyone, I didn't police my subversion directory correctly. I noticed when I got the email that the 'commit' list was too large! Reverted in 336727. -Original Message- From: Erich Keane via cfe-commits [mailto:cfe-commits@lists.llvm.org] Sent: Tuesday, July 10, 2018 1:47 PM To:

[PATCH] D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list

Rakete updated this revision to Diff 154875. Rakete added a comment. Rebased + friendly ping :) https://reviews.llvm.org/D39679 Files: lib/Sema/SemaInit.cpp test/SemaCXX/references.cpp Index: test/SemaCXX/references.cpp ==

[PATCH] D48753: [libcxx] Use custom allocator's `construct` in C++03 when available.

Quuxplusone added a comment. In https://reviews.llvm.org/D48753#1157695, @EricWF wrote: > Why are we doing this? > > I can't find the language in the C++03 specification that requires us to call > an allocators `construct` method if it's present. I think it's being proposed under "quality of i

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

Eugene.Zelenko added a comment. It's highly likely that this part of coding guidelines. Comment at: clang-tidy/readability/MagicNumbersCheck.cpp:42 + +const auto &Parents = Result.Context->getParents(*MatchedDecl); +for (const auto &Parent : Parents) {

r336729 - [NFC] Switch CodeGenFunction to use value init instead of member init lists

Author: erichkeane Date: Tue Jul 10 14:07:50 2018 New Revision: 336729 URL: http://llvm.org/viewvc/llvm-project?rev=336729&view=rev Log: [NFC] Switch CodeGenFunction to use value init instead of member init lists The member init list for the sole constructor for CodeGenFunction has gotten out of

[PATCH] D37442: [C++17] Disallow lambdas in template parameters (PR33696).

Rakete updated this revision to Diff 154880. Rakete added a comment. Rebased + friendly ping https://reviews.llvm.org/D37442 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Parse/ParseDecl.cpp lib/Parse/ParseDeclCXX.cpp lib/Parse/ParseStmt.cpp

[PATCH] D10480: Implement shared_mutex re: N4508

kjcamann added a comment. I have recently benchmarked this (platform was RHEL 7 and Haswell), and the libc++ version has about twice the latency of a pthread_rwlock for both classes of locking. libc++ is also about twice the latency of the libstdc++ implementation, because it is just a lightwei

[PATCH] D48854: Use ExprMutationAnalyzer in performance-for-range-copy

shuaiwang marked an inline comment as done. shuaiwang added inline comments. Comment at: test/clang-tidy/performance-for-range-copy.cpp:120 +struct Point { + ~Point() {} JonasToth wrote: > I feel that `const` methods should be added as a test as well. const me

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

Rakete updated this revision to Diff 154882. Rakete added a comment. Rebased + friendly ping :) https://reviews.llvm.org/D36357 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseExprCXX.cpp test/Parser/cxx0x-lambda-expressions.cpp test/SemaCXX/new-delete-0x.cpp

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

rsmith added a comment. Thanks! Comment at: lib/Parse/ParseExprCXX.cpp:2956 +const Token Next = GetLookAheadToken(2); +const auto GetAfter = [this] { return GetLookAheadToken(3); }; + I don't think this lambda is useful: since you're not caching the res

[PATCH] D37442: [C++17] Disallow lambdas in template parameters (PR33696).

rsmith accepted this revision. rsmith added inline comments. Comment at: include/clang/Sema/Sema.h:4000-4004 + ExpressionEvaluationContextRecord::ExpressionKind Type = ExpressionEvaluationContextRecord::EK_Other); enum ReuseLambdaContextDecl_t { ReuseLambdaContextDecl };

  1   2   >