Author: ldionne Date: Tue Jul 10 10:38:30 2018 New Revision: 336709 URL: http://llvm.org/viewvc/llvm-project?rev=336709&view=rev Log: [libc++] Declare noop_coroutine() with _LIBCPP_INLINE_VISIBILITY
Summary: It was defined with the right visibility, but declared without any visibility. This function was left out of a prior revision that did the same to several functions in <compare> (r336665) because the compiler I used didn't support coroutines. This reinforces the need for automated checks -- there might still be several cases of this throughout the library. Reviewers: EricWF Subscribers: modocache, christof, dexonsmith, llvm-commits Differential Revision: https://reviews.llvm.org/D49145 Modified: libcxx/trunk/include/experimental/coroutine Modified: libcxx/trunk/include/experimental/coroutine URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/experimental/coroutine?rev=336709&r1=336708&r2=336709&view=diff ============================================================================== --- libcxx/trunk/include/experimental/coroutine (original) +++ libcxx/trunk/include/experimental/coroutine Tue Jul 10 10:38:30 2018 @@ -283,6 +283,7 @@ public: _LIBCPP_CONSTEXPR_AFTER_CXX17 void destroy() const _NOEXCEPT {} private: + _LIBCPP_INLINE_VISIBILITY friend coroutine_handle<noop_coroutine_promise> noop_coroutine() _NOEXCEPT; _LIBCPP_INLINE_VISIBILITY coroutine_handle() _NOEXCEPT { _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
