lichray marked an inline comment as done.
lichray added inline comments.
================
Comment at: include/charconv:234
+to_chars(char* __first, char* __last, _Tp __value, int __base)
+ -> to_chars_result
+{
----------------
mclow.lists wrote:
> lichray wrote:
> > mclow.lists wrote:
> > > Why use the trailing return type here?
> > > I don't see any advantage - it doesn't depend on the parameters (template
> > > or runtime).
> > >
> > >
> > Because clang-format doesn't distinguish storage specifiers and
> > simple-type-specifiers, and I want to format return types along with
> > function signatures rather than letting hanging somewhere.
> That's an argument for fixing clang-format, not for writing the code this way.
>
Yes... I did some research on ClangFormat, until... Anyway, I moved most of the
trailing return types to the front, leaving two which are too complex in the
header, and a few necessary ones in the tests.
Repository:
rCXX libc++
https://reviews.llvm.org/D41458
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
