[PATCH] D48928: [ms] Fix mangling of string literals used to initialize arrays larger or smaller than the literal

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Nice! Comment at: lib/AST/MicrosoftMangle.cpp:3198 + ->getSize() + .getZExtValue(); + nit: Also do

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

simark updated this revision to Diff 154321. simark marked 4 inline comments as done. simark added a comment. - Add RequestedName to InMemoryNode::getStatus. - Also fix the directory_iterator code path. Repository: rC Clang https://reviews.llvm.org/D48903 Files: lib/Basic/VirtualFileSystem

[PATCH] D48412: [RISCV] Add support for interrupt attribute

apazos updated this revision to Diff 154322. apazos added a comment. Made the check/warning for prototype explicit. https://reviews.llvm.org/D48412 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/TargetInfo.cpp

[PATCH] D48989: -fdebug-prefix-map option for cc1as

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. This seems reasonable if you need the support in the assembler. However, please add a test to ensure that the paths are mapped when invoking the assembler rather than the compiler. Repo

[PATCH] D48753: [libcxx] Use custom allocator's `construct` in C++03 when available.

vsapsai updated this revision to Diff 154326. vsapsai added a comment. - Use a better way to detect presence of `construct` with required signature. Clean up tests. Don't know how other compilers will handle this but Clang accepts this C++11-looking-but-accepted-in-C++03 code. https://reviews.

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

vsapsai updated this revision to Diff 154327. vsapsai added a comment. - Clean up tests according to review. We don't need a new test for custom allocators, parent patch covers that. https://reviews.llvm.org/D48342 Files: libcxx/include/memory libcxx/test/std/containers/sequences/vector/v

r336396 - [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %tu/%td on Darwin

Author: arphaman Date: Thu Jul 5 15:51:11 2018 New Revision: 336396 URL: http://llvm.org/viewvc/llvm-project?rev=336396&view=rev Log: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %tu/%td on Darwin The '%tu'/'%td' as formatting specifiers have been used to print out the NSInteger/NSUInt

[PATCH] D48852: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %tu/%td on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rC336396: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %tu/%td on Darwin (authored by arphaman, committed by ). Repository: rC Clang https://reviews.llvm.org/D48852 Files: include/clang/Anal

[PATCH] D48862: Fix lib paths for OpenEmbedded targets

mgrang added a comment. The prerequisite llvm patch has been committed: r336401 https://reviews.llvm.org/D48862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49002: [Index] Add index::IndexingOptions::IndexImplicitInstantiation

MaskRay created this revision. MaskRay added reviewers: akyrtzi, arphaman. Herald added a subscriber: cfe-commits. With IndexImplicitInstantiation=true, the following case records an occurrence of B::bar in A::foo, which will benefit cross reference tools. template struct B { void bar() {}}; te

[PATCH] D48753: [libcxx] Use custom allocator's `construct` in C++03 when available.

Quuxplusone added inline comments. Comment at: libcxx/include/memory:1470 +decltype(_VSTD::declval<_Alloc>().construct(_VSTD::declval<_Pointer>(), +_VSTD::declval<_Args>())), +void I think you sh

[PATCH] D48989: -fdebug-prefix-map option for cc1as

starsid updated this revision to Diff 154354. starsid added a comment. add a test for the Driver passing the new flag Repository: rC Clang https://reviews.llvm.org/D48989 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Clang.cpp test/Driver/debug-prefix-map.S tools/drive

[PATCH] D48989: -fdebug-prefix-map option for cc1as

starsid added a comment. In https://reviews.llvm.org/D48989#1153773, @compnerd wrote: > However, please add a test to ensure that the paths are mapped when invoking > the assembler I added the tests to check the mapping logic through llvm-mc in https://reviews.llvm.org/D48988. In this revisio

[PATCH] D32747: [Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy) assignments

baloghadamsoftware updated this revision to Diff 154357. baloghadamsoftware added a comment. Updated according to the comments. https://reviews.llvm.org/D32747 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/IteratorChecker.cpp test/Analysis/Inputs/sys

[PATCH] D48831: alpha.unix.cstring.OutOfBounds checker enable/disable fix

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. This revision is now accepted and ready to land. LGTM! But wait for Artem's acceptance before submitting. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:311 +if (!Filter.CheckCStringO

[PATCH] D32747: [Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy) assignments

baloghadamsoftware updated this revision to Diff 154358. baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added a comment. Re-upload because of a mistake. https://reviews.llvm.org/D32747 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Check

[PATCH] D32747: [Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy) assignments

baloghadamsoftware marked an inline comment as not done. baloghadamsoftware added inline comments. Comment at: test/Analysis/invalidated-iterator.cpp:32 + *i0; // expected-warning{{Invalidated iterator accessed}} +} whisperity wrote: > This might not be applicab

[PATCH] D48928: [ms] Fix mangling of string literals used to initialize arrays larger or smaller than the literal

hans marked 3 inline comments as done. hans added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:3198 + ->getSize() + .getZExtValue(); + thakis wrote: > nit: Also do `unsigned StingByteLength = S

[PATCH] D48827: [clang-format ]Extend IncludeCategories regex documentation

WimLeflere added a comment. Who can merge these changes? Or does this happen automatically? Repository: rC Clang https://reviews.llvm.org/D48827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

r336415 - [ms] Fix mangling of string literals used to initialize arrays larger or smaller than the literal

Author: hans Date: Thu Jul 5 23:54:16 2018 New Revision: 336415 URL: http://llvm.org/viewvc/llvm-project?rev=336415&view=rev Log: [ms] Fix mangling of string literals used to initialize arrays larger or smaller than the literal A Chromium developer reported a bug which turned out to be a mangli

[PATCH] D48928: [ms] Fix mangling of string literals used to initialize arrays larger or smaller than the literal

This revision was automatically updated to reflect the committed changes. hans marked 2 inline comments as done. Closed by commit rC336415: [ms] Fix mangling of string literals used to initialize arrays larger or… (authored by hans, committed by ). Changed prior to commit: https://reviews.llvm.

<    1   2