baloghadamsoftware marked an inline comment as not done. baloghadamsoftware added inline comments.
================ Comment at: test/Analysis/invalidated-iterator.cpp:32 + *i0; // expected-warning{{Invalidated iterator accessed}} +} ---------------- whisperity wrote: > This might not be applicable here, but isn't there a test case for copy > operations where the iterator isn't invalidated? Something of a positive test > to be added here. My only idea is something with weird reference-to-pointer > magic. Might not worth the hassle. Accoring to the rules (on STL containers) if a container is overwritten using a copy assignment, all its iterators become invalidated. So I cannot imagine a positive test case here. https://reviews.llvm.org/D32747 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits