chandlerc edited subscribers, added: brooksmoses, chandlerc; removed: rnk.
chandlerc edited reviewers, added: echristo, timshen, dlj; removed: kcc.
chandlerc added a comment.
Ok folks, I know this is a blast from the past, but can we actually review
this? I'm willing to commandeer it, rebase it,
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Author: rksimon
Date: Thu Jun 21 00:54:47 2018
New Revision: 335209
URL: http://llvm.org/viewvc/llvm-project?rev=335209&view=rev
Log:
Fix double-float constant truncation warnings. NFCI.
Modified:
clang-tools-extra/trunk/unittests/clangd/QualityTests.cpp
Modified: clang-tools-extra/trunk/uni
ioeric added inline comments.
Comment at: clang-tools-extra/clang-doc/Representation.h:173
bool mergeable(const Info &Other);
+ llvm::Expected getEnclosingScope();
};
Comment? What is an enclong scope?
Comment at: clang-tools-extra/clang-d
Author: yvvan
Date: Thu Jun 21 01:34:50 2018
New Revision: 335211
URL: http://llvm.org/viewvc/llvm-project?rev=335211&view=rev
Log:
[Sema] Fix overloaded static functions for templates
Apply almost the same fix as https://reviews.llvm.org/D36390 but for templates.
Differential Revision: https://
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335211: [Sema] Fix overloaded static functions for templates
(authored by yvvan, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D43453
Files:
l
yamaguchi updated this revision to Diff 152240.
yamaguchi added a comment.
Add a test case
https://reviews.llvm.org/D48367
Files:
clang/include/clang/Lex/ModuleMap.h
clang/lib/Lex/HeaderSearch.cpp
clang/test/Modules/Inputs/autoload-subdirectory/a.h
clang/test/Modules/Inputs/autoload-sub
yvvan added a comment.
@ilya-biryukov what do you think?
Repository:
rC Clang
https://reviews.llvm.org/D48116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yamaguchi added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:285
// directory.
-loadSubdirectoryModuleMaps(SearchDirs[Idx]);
+if (ModMap.getLangOpts().ObjC1 || ModMap.getLangOpts().ObjC2)
+ loadSubdirectoryModuleMaps(SearchDirs[Idx]);
simoncook added a comment.
I think this should also cover mismatched arguments if the attribute appears
several times, and reject/warn about the attribute combination in these cases.
For example, `__attribute__((interrupt("machine")))
__attribute__((interrupt("user"))) void foo() {}` is accepte
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48418
Files:
clangd/index/SymbolCollector.cpp
clangd/index/SymbolCollector.h
Index: clangd
Author: ioeric
Date: Thu Jun 21 02:51:28 2018
New Revision: 335212
URL: http://llvm.org/viewvc/llvm-project?rev=335212&view=rev
Log:
[clangd] Fix proximity signal output format. NFC
Modified:
clang-tools-extra/trunk/clangd/Quality.cpp
Modified: clang-tools-extra/trunk/clangd/Quality.cpp
URL:
sammccall added a comment.
Can you motivate this change a bit, and add tests?
Comment at: clangd/index/SymbolCollector.h:61
+ /// AST matchers require non-const ASTContext.
+ static bool shouldCollectSymbol(const NamedDecl &ND, ASTContext &ASTCtx);
+
in princ
Anastasia created this revision.
Anastasia added a reviewer: yaxunl.
Due to missing handling of address space tokens in parsing code of C++ we were
unable to parse declarations that start from an address space keyword. For
example we would get an error:
test.cl:2:1: error: expected expression
ioeric updated this revision to Diff 152249.
ioeric marked an inline comment as done.
ioeric added a comment.
- added tests.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48418
Files:
clangd/index/SymbolCollector.cpp
clangd/index/SymbolCollector.h
unittests/clangd/Symbol
ioeric added a comment.
In https://reviews.llvm.org/D48418#1138984, @sammccall wrote:
> Can you motivate this change a bit, and add tests?
Done.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48418
___
cfe-commits mailing list
cf
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM (with suitable IR fast-isel tests in llvm)
https://reviews.llvm.org/D48346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
Author: ioeric
Date: Thu Jun 21 05:12:26 2018
New Revision: 335218
URL: http://llvm.org/viewvc/llvm-project?rev=335218&view=rev
Log:
[clangd] Expose 'shouldCollectSymbol' helper from SymbolCollector.
Summary: This allows tools to examine symbols that would be collected in a
symbol index. For exa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335218: [clangd] Expose 'shouldCollectSymbol'
helper from SymbolCollector. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org
ro created this revision.
ro added a reviewer: rsmith.
Herald added a subscriber: fedor.sergeev.
libclang.so fails to link on Solaris:
Undefined first referenced
symbol in file
clang_getCompletionFixIt
/var/gcc/llvm/obj/local/tools/cla
martong updated this revision to Diff 152262.
martong marked 15 inline comments as done.
martong added a comment.
- Addressing Alexei's comments.
Repository:
rC Clang
https://reviews.llvm.org/D47532
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
lib/AST/DeclBase.cpp
t
martong added inline comments.
Comment at: lib/AST/ASTImporter.cpp:79
+for (auto R : D->getFirstDecl()->redecls()) {
+ if (R != D->getFirstDecl())
+Redecls.push_back(R);
a.sidorin wrote:
> Does this code mean that we can get R == getFirstDecl() i
yvvan accepted this revision.
yvvan added a comment.
This revision is now accepted and ready to land.
Thanks! I probably forgot to check line endings for this file before committing
which I do for source files and headers...
Repository:
rC Clang
https://reviews.llvm.org/D48423
___
Author: yvvan
Date: Thu Jun 21 05:39:24 2018
New Revision: 335220
URL: http://llvm.org/viewvc/llvm-project?rev=335220&view=rev
Log:
Fix line endings in recently updated test file
Modified:
cfe/trunk/test/Index/complete-call.cpp
Modified: cfe/trunk/test/Index/complete-call.cpp
URL:
http://ll
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov.
The qualified name can be used to match a completion item to its corresponding
symbol. This can be useful for tools that measure code completion quality.
Qualif
ioeric updated this revision to Diff 152265.
ioeric added a comment.
- Fix build
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48425
Files:
clangd/CodeComplete.cpp
clangd/Protocol.h
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clangd/CodeCompleteTests.cpp
==
hans created this revision.
hans added reviewers: thakis, rnk, rsmith.
With MSVC, PCH files are created along with an object file that needs to be
linked into the final library or executable. That object file contains the code
generated when building the headers. In particular, it will include d
baloghadamsoftware created this revision.
baloghadamsoftware added reviewers: NoQ, rnkovacs.
Herald added subscribers: mikhail.ramalho, a.sidorin, dkrupp, szepet,
xazax.hun, whisperity.
Herald added a reviewer: george.karpenkov.
https://reviews.llvm.org/D47417 is a fix for an accidentally missing
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Thanks for explaining, makes sense to me.
https://reviews.llvm.org/D47956
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335234: [liblang] Remove DOS line endings in
libclang.exports (authored by ro, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48423
Files:
tools/libclang/libclang.exports
Index: to
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Looks like pretty straightforward plumbing. I can't think of a better place
than ASTContext either. I think this is fine with your two XXXs just removed.
Exciting build time wins!
=
hfinkel added inline comments.
Comment at: lib/Basic/TargetInfo.cpp:277
+LongDoubleWidth = 64;
+LongDoubleAlign = 32;
+LongDoubleFormat = &llvm::APFloat::IEEEdouble;
This seems wrong for targets in general. Maybe this should be, instead of 32
always,
klimek added inline comments.
Comment at: lib/Format/WhitespaceManager.cpp:678
// Indent with tabs only when there's at least one full tab.
-if (FirstTabWidth + Style.TabWidth <= Spaces) {
+if (Style.TabWidth <= Spaces) {
Spaces -= FirstTabWidth;
-
hans added a comment.
I think you revved the PCH version last. Did you have to do anything special,
e.g. will it break vendors who ship PCH files as part of SDKs and such? Or are
things generally set up to handle this?
https://reviews.llvm.org/D48426
chill added a comment.
Ping?
https://reviews.llvm.org/D46013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jolesiak created this revision.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D48432
Files:
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestObjC.cpp
===
--- unittes
thakis added a comment.
PCHs aren't compatible with themselves if only the compiler revision changes,
so I'm not sure changing that field should be worse than a regular compiler
revision update (which happens at every commit). But I don't know what this
field is for. I don't remember any troubl
Author: ro
Date: Thu Jun 21 06:40:50 2018
New Revision: 335234
URL: http://llvm.org/viewvc/llvm-project?rev=335234&view=rev
Log:
[liblang] Remove DOS line endings in libclang.exports
Undefined first referenced
symbol in file
clang_getCompletionFi
sammccall added inline comments.
Comment at: clangd/CodeComplete.cpp:246
assert(bool(SemaResult) == bool(SemaCCS));
+assert(bool(SemaResult) || bool(IndexResult));
+
can skip the bool() here if you like
Comment at: clangd/Protocol.h:74
Szelethus created this revision.
Szelethus added reviewers: george.karpenkov, NoQ, xazax.hun, rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet,
whisperity.
As of now, all constructor calls are ignored that are being called by a
constructor. The point of this wa
hans added a comment.
In https://reviews.llvm.org/D48426#1139318, @thakis wrote:
> PCHs aren't compatible with themselves if only the compiler revision changes,
> so I'm not sure changing that field should be worse than a regular compiler
> revision update (which happens at every commit). But I
Anastasia created this revision.
Anastasia added a reviewer: yaxunl.
This allows to reuse the same diagnostic for OpenCL or CUDA.
For OpenCL this will be tested in
`test/SemaOpenCL/address-spaces-conversions-cl2.0.cl` that I plan to enable
with `-cl-std=c++` after fixing other issues.
https:/
alexfh updated this revision to Diff 152317.
alexfh added a comment.
Herald added subscribers: mikhail.ramalho, mgorny.
- Added a test.
Repository:
rC Clang
https://reviews.llvm.org/D45718
Files:
include/clang/StaticAnalyzer/Frontend/AnalysisConsumer.h
include/clang/StaticAnalyzer/Fronte
alexfh added a comment.
Please take another look.
Repository:
rC Clang
https://reviews.llvm.org/D45718
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: alexfh
Date: Thu Jun 21 09:14:27 2018
New Revision: 335252
URL: http://llvm.org/viewvc/llvm-project?rev=335252&view=rev
Log:
[clang-tidy] Remove the google-readability-redundant-smartptr-get alias
I don't remember why I added it, but it's definitely not needed, since the check
doesn't hav
jmorse added a comment.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D48072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
craig.topper added a comment.
Ping
https://reviews.llvm.org/D48187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov, mgorny.
We now compute a distance from the main file to the symbol header, which
is a weighted count of:
- some number of #include traversals from source fi
sammccall updated this revision to Diff 152326.
sammccall added a comment.
Document some more stuff, and clang-format
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48441
Files:
clangd/CMakeLists.txt
clangd/ClangdServer.cpp
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
cl
bruno added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:285
// directory.
-loadSubdirectoryModuleMaps(SearchDirs[Idx]);
+if (ModMap.getLangOpts().ObjC1 || ModMap.getLangOpts().ObjC2)
+ loadSubdirectoryModuleMaps(SearchDirs[Idx]);
Author: ctopper
Date: Thu Jun 21 09:41:28 2018
New Revision: 335253
URL: http://llvm.org/viewvc/llvm-project?rev=335253&view=rev
Log:
[X86] Rewrite the add/mul/or/and reduction intrinsics to make better use of
other intrinsics and remove undef shuffle indices.
Similar to what was done to max/min
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335253: [X86] Rewrite the add/mul/or/and reduction
intrinsics to make better use of… (authored by ctopper, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48346
Files:
lib/Headers/avx
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D45718
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
ioeric added inline comments.
Comment at: clangd/Protocol.h:743
+ /// FIXME: find a more precise way to identify a completion item.
+ std::string QualifiedSymbolName;
};
sammccall wrote:
> So this is always set to scope + filterText (except for non-decl comple
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D48187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric updated this revision to Diff 152331.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- store scope in completion item. Add splitQualifiedName for NamedDecl.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48425
Files:
clangd/CodeComplete.cpp
clangd/P
Author: gramanas
Date: Thu Jun 21 09:53:48 2018
New Revision: 335255
URL: http://llvm.org/viewvc/llvm-project?rev=335255&view=rev
Log:
[DebugInfo] Inline for without DebugLocation
Summary:
This test is a strip down version of a function inside the
amalgamated sqlite source. When converted to IR c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335255: [DebugInfo] Inline for without DebugLocation
(authored by gramanas, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47720
Files:
cfe/tr
sbc100 created this revision.
Herald added subscribers: cfe-commits, sunfish, aheejin, dschuff.
The WebAssembly backend in particular benefits from being
able to distinguish between varargs functions (...) and prototype-less
C functions.
Repository:
rC Clang
https://reviews.llvm.org/D48443
F
sbc100 updated this revision to Diff 152335.
sbc100 added a comment.
wrong test
Repository:
rC Clang
https://reviews.llvm.org/D48443
Files:
lib/CodeGen/CGCall.cpp
test/CodeGen/no-prototype.c
Index: test/CodeGen/no-prototype.c
Author: ctopper
Date: Thu Jun 21 10:07:04 2018
New Revision: 335259
URL: http://llvm.org/viewvc/llvm-project?rev=335259&view=rev
Log:
[Intrinsics] Add/move some builtin declarations in intrin.h to get
ms-intrinsics.c to not issue warnings
ud2 and int2c were missing declarations entirely. And the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335259: [Intrinsics] Add/move some builtin declarations in
intrin.h to get ms… (authored by ctopper, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llv
thakis added inline comments.
Comment at: lib/AST/ASTContext.cpp:9563
+if (getExternalSource()->DeclIsFromPCHWithObjectFile(D))
+ return false;
+ }
It'd be good to add a comment (and a test) explaining why / how _referenced_
inline functions still get
Szelethus updated this revision to Diff 152343.
Szelethus added a comment.
Moved `LC = LC ->getParent()` to the `while` statement's argument to avoid a
potential infinite loop. Whoops :)
https://reviews.llvm.org/D48436
Files:
lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp
test/
jgravelle-google added a comment.
Looks very reasonable and straightforward. LGTM in spirit, but I'll wait for
someone who knows Clang better.
Repository:
rC Clang
https://reviews.llvm.org/D48443
___
cfe-commits mailing list
cfe-commits@lists.ll
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
https://reviews.llvm.org/D48438
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
yaxunl added a comment.
Did you notice the bug that C++ silently allows implicit casting of a pointer
to a pointer type with different address space?
Do you have a fix for that?
https://reviews.llvm.org/D48419
___
cfe-commits mailing list
cfe-comm
craig.topper created this revision.
craig.topper added reviewers: rnk, echristo.
The inline assembly for these didn't mark that edi, esi, ecx are modified by
movs/stos instruction. It also didn't mark that memory is modified.
This issue was reported to llvm-dev last year
http://lists.llvm.org/p
Author: ctopper
Date: Thu Jun 21 11:56:30 2018
New Revision: 335270
URL: http://llvm.org/viewvc/llvm-project?rev=335270&view=rev
Log:
[X86] Correct the inline assembly implementations of __movsb/w/d/q and
__stosw/d/q to mark registers/memory as modified
The inline assembly for these didn't mark
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335270: [X86] Correct the inline assembly implementations of
__movsb/w/d/q and… (authored by ctopper, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.ll
Anastasia added a comment.
In https://reviews.llvm.org/D48419#1139601, @yaxunl wrote:
> Did you notice the bug that C++ silently allows implicit casting of a pointer
> to a pointer type with different address space?
>
> Do you have a fix for that?
I didn't think it did because if I run
`test
jbcoe added a comment.
Would you like me to commit this for you?
Repository:
rC Clang
https://reviews.llvm.org/D47864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ethanhs added a comment.
In https://reviews.llvm.org/D47864#1139750, @jbcoe wrote:
> Would you like me to commit this for you?
Sure, that would be great! I don't have commit rights so I was waiting for
someone to do it. Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D47864
_
Author: jvesely
Date: Thu Jun 21 12:27:23 2018
New Revision: 335277
URL: http://llvm.org/viewvc/llvm-project?rev=335277&view=rev
Log:
atom: Consolidate cl_khr_int64_{base,extended}_atomics declarations
Reviewed-By: Aaron Watry
Tested-By: Aaron Watry
Signed-off-by: Jan Vesely
Added:
libclc
Author: jvesely
Date: Thu Jun 21 12:27:12 2018
New Revision: 335275
URL: http://llvm.org/viewvc/llvm-project?rev=335275&view=rev
Log:
atomic: Cleanup atomic_cmpxchg header
It's easier to just list the four function declarations
Reviewed-By: Aaron Watry
Tested-By: Aaron Watry
Signed-off-by: Jan
Author: jvesely
Date: Thu Jun 21 12:27:18 2018
New Revision: 335276
URL: http://llvm.org/viewvc/llvm-project?rev=335276&view=rev
Log:
atom: Consolidate cl_khr_{local,global}_int32_{base,extended}_atomics
declarations
Reviewed-By: Aaron Watry
Tested-By: Aaron Watry
Signed-off-by: Jan Vesely
A
Author: jvesely
Date: Thu Jun 21 12:27:26 2018
New Revision: 335278
URL: http://llvm.org/viewvc/llvm-project?rev=335278&view=rev
Log:
atomic: Provide function implementation of atomic_{dec,inc}
Reviewed-By: Aaron Watry
Tested-By: Aaron Watry
Signed-off-by: Jan Vesely
Added:
libclc/trunk/g
Author: jvesely
Date: Thu Jun 21 12:27:07 2018
New Revision: 335274
URL: http://llvm.org/viewvc/llvm-project?rev=335274&view=rev
Log:
atomic: Move define cleanup to shared include
Reviewed-By: Aaron Watry
Tested-By: Aaron Watry
Signed-off-by: Jan Vesely
Modified:
libclc/trunk/generic/incl
Author: jvesely
Date: Thu Jun 21 12:27:33 2018
New Revision: 335279
URL: http://llvm.org/viewvc/llvm-project?rev=335279&view=rev
Log:
atom: Consolidate cl_khr_{local,global}_int32_{base,extended}_atomics
implementation
These are just atomic_* wrappers.
Switch inc, dec to use atomic_* wrappers as
Author: jvesely
Date: Thu Jun 21 12:27:39 2018
New Revision: 335280
URL: http://llvm.org/viewvc/llvm-project?rev=335280&view=rev
Log:
atom: Use volatile pointers for
cl_khr_{global,local}_int32_{base,extended}_atomics
int64 versions were switched to volatile pointers in cl1.1
cl1.1 also renamed
rnk added a comment.
Yikes.
Repository:
rL LLVM
https://reviews.llvm.org/D48448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dblaikie added a comment.
Yeah, I know nothing about this dump feature or what's being fixed here - test
cases would be great to help motivate/explain.
Repository:
rC Clang
https://reviews.llvm.org/D47953
___
cfe-commits mailing list
cfe-commits
Rakete added a comment.
@rsmith Should I only check for an identifier, like only "int" and nothing
else? Because parsing a full type specifier might be a bit expensive, no?
https://reviews.llvm.org/D36357
___
cfe-commits mailing list
cfe-commit
Author: jbcoe
Date: Thu Jun 21 13:07:03 2018
New Revision: 335282
URL: http://llvm.org/viewvc/llvm-project?rev=335282&view=rev
Log:
[bindings] Fix most Python binding unittests on Windows
Summary:
This fixes all but one of the test cases for Windows. TestCDB will
take more work to debug, as Compi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335282: [bindings] Fix most Python binding unittests on
Windows (authored by jbcoe, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47864
Files:
yaxunl added a comment.
In https://reviews.llvm.org/D48419#1139749, @Anastasia wrote:
> In https://reviews.llvm.org/D48419#1139601, @yaxunl wrote:
>
> > Did you notice the bug that C++ silently allows implicit casting of a
> > pointer to a pointer type with different address space?
> >
> > Do yo
Author: tobiasvk
Date: Thu Jun 21 13:20:41 2018
New Revision: 335284
URL: http://llvm.org/viewvc/llvm-project?rev=335284&view=rev
Log:
[LTO] Enable module summary emission by default for regular LTO
Summary:
With D33921, we gained the ability to have module summaries in regular
LTO modules withou
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335284: [LTO] Enable module summary emission by default for
regular LTO (authored by tobiasvk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/
rnk added a subscriber: dblaikie.
rnk added a comment.
`LangOpts.ModulesCodegen` is very related in spirit to this, but I think we
need a distinct option because that was designed to handle all inline functions
(too much), not just dllexport inline functions. + @dblaikie
Comm
Author: abataev
Date: Thu Jun 21 13:26:33 2018
New Revision: 335285
URL: http://llvm.org/viewvc/llvm-project?rev=335285&view=rev
Log:
[OPENMP, NVPTX] Fix globalization of the variables passed to orphaned
parallel region.
If the current construct requires sharing of the local variable in the
inner
Author: kzhuravl
Date: Thu Jun 21 13:27:47 2018
New Revision: 335287
URL: http://llvm.org/viewvc/llvm-project?rev=335287&view=rev
Log:
AMDGPU: Remove amdgpu-debugger-reserve-regs feature
Modified:
cfe/trunk/lib/Driver/ToolChains/AMDGPU.cpp
cfe/trunk/test/Driver/amdgpu-features.c
Modifie
Rakete updated this revision to Diff 152370.
Rakete added a comment.
Rebased + friendly ping :)
https://reviews.llvm.org/D39679
Files:
lib/Sema/SemaInit.cpp
test/SemaCXX/references.cpp
Index: test/SemaCXX/references.cpp
==
rsmith added a comment.
In https://reviews.llvm.org/D39679#1037591, @Rakete wrote:
> Note: I didn't change `Args[0]` to `OnlyArg` in
> `FK_AddressOfUnaddressableFunction`, because I'm pretty sure that C++ doesn't
> have unaddressable functions and thus there is no need to decompose an
> in
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
In any case, this looks good to me. It'll look even better with the
`FK_AddressOfUnaddressableFunction` case fixed :)
https://reviews.llvm.org/D39679
__
Rakete updated this revision to Diff 152374.
Rakete added a comment.
Rebased + friendly ping :)
https://reviews.llvm.org/D37442
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Parse/ParseDecl.cpp
lib/Parse/ParseDeclCXX.cpp
lib/Parse/ParseStmt.cp
eugenis added a comment.
Another option is to add a special case to blacklist logic to make it not apply
to __cfi_check_fail.
Yet another option is to make blacklist not apply to functions without a source
location, but that seems to be done intentionally here:
http://llvm-cs.pcc.me.uk/tools/cl
dschuff added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:1850
+FuncAttrs.addAttribute("no-prototype");
AddAttributesFromFunctionProtoType(
getContext(), FuncAttrs, Fn->getType()->getAs());
Would it make sense to put this in `Add
eugenis created this revision.
eugenis added reviewers: pcc, vlad.tsyrklevich.
Fixes PR37898.
https://reviews.llvm.org/D48454
Files:
clang/lib/CodeGen/CGExpr.cpp
clang/test/CodeGen/cfi-check-fail2.c
Index: clang/test/CodeGen/cfi-check-fail2.c
==
ashi1 created this revision.
ashi1 added a reviewer: yaxunl.
ashi1 added projects: clang, AMDGPU.
Herald added a subscriber: cfe-commits.
Removing hip.amdgcn.bc and hc.amdgcn.bc from HIP ToolChains. These need to be
removed in VDI build.
Repository:
rC Clang
https://reviews.llvm.org/D48455
rsmith accepted this revision.
rsmith added a comment.
Please also change the `EnterExpressionEvaluationContext` in
`TreeTransform::TransformTemplateArgument` to specify `EK_TemplateArgument`
(though that doesn't actually matter for the lambda diagnostics because we'll
find all the problems in
1 - 100 of 135 matches
Mail list logo
