ioeric added inline comments.
================ Comment at: clangd/Protocol.h:743 + /// FIXME: find a more precise way to identify a completion item. + std::string QualifiedSymbolName; }; ---------------- sammccall wrote: > So this is always set to scope + filterText (except for non-decl completions, > where you're not setting it in this patch). > > WDYT about just making that "scope", and for now relying on the fact that > scope + filtertext gives you a nice readable name? > > Advantages: > - it's a bit smaller > - as we add more structure to the C++ completion API, I think we'll want to > expose scope+name split, so this would be closer to the desired state. Sounds good. Done. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48425 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
