thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Looks like pretty straightforward plumbing. I can't think of a better place
than ASTContext either. I think this is fine with your two XXXs just removed.
Exciting build time wins!
================
Comment at: lib/AST/ASTContext.cpp:9557
+ if (D->isFromASTFile() && !BuildingPCHWithObjectFile) {
+ assert(getExternalSource() && "It's from an AST file; must be a source.");
+ // On Windows, PCH files are built together with an object file. If this
----------------
nit: s/be/have/
https://reviews.llvm.org/D48426
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
