aheejin added a comment.
@sbc100 ping :)
Repository:
rC Clang
https://reviews.llvm.org/D47620
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vlad.tsyrklevich updated this revision to Diff 149796.
vlad.tsyrklevich added a comment.
- Merge test with apsint.c and move to z3/apsint.c
Repository:
rC Clang
https://reviews.llvm.org/D47617
Files:
lib/StaticAnalyzer/Core/Z3ConstraintManager.cpp
test/Analysis/apsint.c
test/Analysis/z
rnk added subscribers: craig.topper, chandlerc.
rnk added a comment.
I read up a little bit on TSX and HLE:
https://software.intel.com/en-us/node/524022
https://en.wikipedia.org/wiki/Transactional_Synchronization_Extensions
These HLE variants of the usual atomic exchange intrinsics add the `xacqu
craig.topper added a comment.
Ping
Repository:
rL LLVM
https://reviews.llvm.org/D47401
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: juliehockett
Date: Mon Jun 4 10:22:20 2018
New Revision: 333932
URL: http://llvm.org/viewvc/llvm-project?rev=333932&view=rev
Log:
[clang-doc] Implement reducer portion of the frontend framework
Implements a simple, in-memory reducer for the mapped output of the
initial tool. This creates
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333932: [clang-doc] Implement reducer portion of the
frontend framework (authored by juliehockett, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D47628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
rkirsling added a comment.
FWIW, please note that this space-before-brace style is not specific to WebKit;
CppCoreGuidelines exhibits it as well:
http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es23-prefer-the--initializer-syntax
Repository:
rC Clang
https://reviews.llvm.org/D460
emmettneyman updated this revision to Diff 149807.
emmettneyman added a comment.
- Changed CLArgs into getter and deleted commented code
1. Updating https://reviews.llvm.org/D47666: Refactored clang-fuzzer and added
new (copy) files #
2. Enter a brief description of the changes included in this
jfb added a comment.
In https://reviews.llvm.org/D46024#1121242, @rkirsling wrote:
> FWIW, please note that this space-before-brace style is not specific to
> WebKit; CppCoreGuidelines exhibits it as well:
>
> http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es23-prefer-the--initial
Sure, the bots could do that, the more general point was that many
(probably most) people who want to enable asserts don't want to use shared
libs. I believe that only a few people use that config, so turning things
around why should everyone building with asserts have to pay the cost of
supporting
(Cost as in "shared library buildsof clang are ~35% slower than regular
clang" last we checked.)
On Mon, Jun 4, 2018 at 2:14 PM, Nico Weber wrote:
> Sure, the bots could do that, the more general point was that many
> (probably most) people who want to enable asserts don't want to use shared
> l
a.sidorin added a comment.
Hello Gabor,
This patch is really cool. Unfortunately, right now I don't have enough time
for reviewing large patches in a single review. Are you OK with incremental
review?
Comment at: lib/AST/ASTImporter.cpp:75
+ template
+ llvm::SmallVector
+
aheejin created this revision.
aheejin added a reviewer: juliehockett.
Herald added subscribers: cfe-commits, mgorny, klimek.
Without this, build with `-DSHARED_LIB=ON` fails.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47732
Files:
clang-doc/CMakeLists.txt
Index: clang-
Author: juliehockett
Date: Mon Jun 4 11:18:00 2018
New Revision: 333936
URL: http://llvm.org/viewvc/llvm-project?rev=333936&view=rev
Log:
[clang-doc] Adding missing dependencies to fix linker error on bot
Modified:
clang-tools-extra/trunk/clang-doc/CMakeLists.txt
Modified: clang-tools-extra
juliehockett added a comment.
Already fixed in https://reviews.llvm.org/rL333936, sorry!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47732
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
yaxunl created this revision.
yaxunl added reviewers: rjmccall, tra.
Currently clang set kernel calling convention for CUDA/HIP after
arranging function, which causes incorrect kernel function type since
it depends on calling convention.
This patch moves setting kernel convention before arranging
aheejin abandoned this revision.
aheejin added a comment.
Oh I see, thanks!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47732
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: aheejin
Date: Mon Jun 4 11:23:00 2018
New Revision: 333938
URL: http://llvm.org/viewvc/llvm-project?rev=333938&view=rev
Log:
Remove llvm::Triple argument from get***Personality() functions. NFC.
Summary:
Because `llvm::Triple` can be derived from `TargetInfo`, it is simpler
to take only
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333938: Remove llvm::Triple argument from
get***Personality() functions. NFC. (authored by aheejin, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47620?vs=149406&id=149814#toc
Repo
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333941: [CFG] Fix automatic destructors when a member is
bound to a reference. (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D44238
Files:
lib/Analysis/CFG.cp
Author: dergachev
Date: Mon Jun 4 11:56:25 2018
New Revision: 333941
URL: http://llvm.org/viewvc/llvm-project?rev=333941&view=rev
Log:
[CFG] Fix automatic destructors when a member is bound to a reference.
In code like
const int &x = A().x;
automatic destructor for the object A() lifetime-
lichray updated this revision to Diff 149824.
lichray added a comment.
Preserve value category in narrowing test.
Repository:
rCXX libc++
https://reviews.llvm.org/D44865
Files:
include/variant
test/std/utilities/variant/variant.variant/variant.assign/T.pass.cpp
test/std/utilities/varia
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D47617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
george.karpenkov added a comment.
Impressive, really. So almost all tests still pass.
However, a few questions should be resolved before we can merge:
- Do all tests for Z3 run when LLVM is configured to use Z3? I'm not sure if
that's the right thing: do all tests start to take 10x time to run o
lichray updated this revision to Diff 149825.
lichray added a comment.
Refine coding style
Repository:
rCXX libc++
https://reviews.llvm.org/D44865
Files:
include/variant
test/std/utilities/variant/variant.variant/variant.assign/T.pass.cpp
test/std/utilities/variant/variant.variant/vari
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
Seems to be good to merge regardless.
Repository:
rC Clang
https://reviews.llvm.org/D47726
___
cfe-commits mailing list
cf
Author: ctopper
Date: Mon Jun 4 12:28:09 2018
New Revision: 333944
URL: http://llvm.org/viewvc/llvm-project?rev=333944&view=rev
Log:
[X86] Avoid passing _mm_undefined* to builtin_shufflevector if we are able to
pass the first input a second time.
This is more consistent with other usages of bui
malaperle created this revision.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov,
klimek.
Signed-off-by: Marc-Andre Laperle
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47737
Files:
clangd/ClangdServer.cpp
Index: clangd/ClangdServer.cpp
==
smeenai added a comment.
In https://reviews.llvm.org/D47564#1119925, @rjmccall wrote:
> In https://reviews.llvm.org/D47564#1119874, @smeenai wrote:
>
> > In https://reviews.llvm.org/D47564#1118424, @rjmccall wrote:
> >
> > > No, it was just a general question. Have you gotten this to a point
>
ddcc added a subscriber: dcoughlin.
ddcc added a comment.
In https://reviews.llvm.org/D47726#1121395, @george.karpenkov wrote:
> - Do all tests for Z3 run when LLVM is configured to use Z3? I'm not sure if
> that's the right thing: do all tests start to take 10x time to run once Z3 is
> enabled
vitalybuka requested changes to this revision.
vitalybuka added inline comments.
This revision now requires changes to proceed.
Comment at: tools/clang-fuzzer/FuzzerInitialize.cpp:11
/// \file
/// This file implements a function that runs Clang on a single
/// input and uses
Author: dergachev
Date: Mon Jun 4 13:18:37 2018
New Revision: 333946
URL: http://llvm.org/viewvc/llvm-project?rev=333946&view=rev
Log:
[analyzer] Re-enable constructors when lifetime extension through fields occurs.
Temporary object constructor inlining was disabled in r326240 for code like
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333946: [analyzer] Re-enable constructors when lifetime
extension through fields occurs. (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D44239
Files:
include/c
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D47668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
xazax.hun added a comment.
So having an analyzer-config option would be useful for those codebases that
are expected to be compiled with less advanced compilers that do not elide
copies or not doing it aggressively enough. Maybe it is worth to ask on the
mailing list of the community wants to h
ahatanak added a comment.
Could you elaborate on what kind of changes you are planning to make in libc++
after committing this patch?
https://reviews.llvm.org/D45015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333948: Fix a strict aliasing violation in map and
unordered_map. (authored by epilk, committed by ).
Herald added a subsc
Author: epilk
Date: Mon Jun 4 13:38:23 2018
New Revision: 333948
URL: http://llvm.org/viewvc/llvm-project?rev=333948&view=rev
Log:
Fix a strict aliasing violation in map and unordered_map.
These containers type-punned between pair and pair as an
optimization. This commit instead provides access
emmettneyman updated this revision to Diff 149850.
emmettneyman added a comment.
- Updated and added header comments to two new files. Deleted loop fuzzer files.
Repository:
rC Clang
https://reviews.llvm.org/D47666
Files:
tools/clang-fuzzer/CMakeLists.txt
tools/clang-fuzzer/ExampleClangP
emmettneyman updated this revision to Diff 149851.
emmettneyman added a comment.
- Fixed file header comment
Repository:
rC Clang
https://reviews.llvm.org/D47666
Files:
tools/clang-fuzzer/CMakeLists.txt
tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp
tools/clang-fuzzer/FuzzerInitialize.
rnk added a comment.
This change appears to have caused some blink vector math unit tests to fail on
Windows. We are tracking it at https://crbug.com/849251.
It has a pretty small reproducer:
#include
__m256 loadit(__m256 *p) { return _mm256_loadu_ps((const float *)p); }
Compile for x86_6
tejohnson added a comment.
Herald added a subscriber: steven_wu.
ping
Repository:
rC Clang
https://reviews.llvm.org/D46700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sunil_Srivastava added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729
def err_no_dynamic_cast_with_fno_rtti : Error<
- "cannot use dynamic_cast with -fno-rtti">;
+ "use of dynamic_cast requires enabling RTTI">;
probinson wrote:
Author: dblaikie
Date: Mon Jun 4 14:23:29 2018
New Revision: 333955
URL: http://llvm.org/viewvc/llvm-project?rev=333955&view=rev
Log:
Update for an LLVM header file move
Modified:
cfe/trunk/lib/CodeGen/CGCall.cpp
Modified: cfe/trunk/lib/CodeGen/CGCall.cpp
URL:
http://llvm.org/viewvc/llvm-p
rnk added a comment.
It's the typedef alignment changes that are causing problems for us, not the
MaxVectorAlign changes. That makes more sense. The new alignment attribute
breaks our implementation of `_mm256_loadu_ps`, because the packed struct ends
up with a 32-byte alignment. Here's the imp
emmettneyman updated this revision to Diff 149854.
emmettneyman added a comment.
- Another edit to the file header comments.
Repository:
rC Clang
https://reviews.llvm.org/D47666
Files:
tools/clang-fuzzer/CMakeLists.txt
tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp
tools/clang-fuzzer/F
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D46700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
juliehockett updated this revision to Diff 149856.
juliehockett marked 4 inline comments as done.
juliehockett added a comment.
Addressing comments
https://reviews.llvm.org/D43667
Files:
clang-doc/CMakeLists.txt
clang-doc/Generators.cpp
clang-doc/Generators.h
clang-doc/Representation.h
emmettneyman added a comment.
In https://reviews.llvm.org/D47666#1121608, @emmettneyman wrote:
> - Updated and added header comments to two new files. Deleted loop fuzzer
> files.
I will commit the loop fuzzer files in a future patch.
Repository:
rC Clang
https://reviews.llvm.org/D47666
Author: rnk
Date: Mon Jun 4 14:39:20 2018
New Revision: 333958
URL: http://llvm.org/viewvc/llvm-project?rev=333958&view=rev
Log:
Revert r333791 "Cap "voluntary" vector alignment at 16 for all Darwin
platforms."
Adding __attribute__((aligned(32))) to __m256 breaks the implementation
of _mm256_lo
wristow added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729
def err_no_dynamic_cast_with_fno_rtti : Error<
- "cannot use dynamic_cast with -fno-rtti">;
+ "use of dynamic_cast requires enabling RTTI">;
Sunil_Srivastava wrote:
>
morehouse added inline comments.
Comment at: tools/clang-fuzzer/CMakeLists.txt:48
ExampleClangProtoFuzzer.cpp
+FuzzerInitialize.cpp
)
Rather than compiling `FuzzerInitialize.cpp` into the binary, can we make it a
library like `handle-cxx` or `proto
rjmccall added a comment.
In https://reviews.llvm.org/D46042#1121648, @rnk wrote:
> It's the typedef alignment changes that are causing problems for us, not the
> MaxVectorAlign changes. That makes more sense. The new alignment attribute
> breaks our implementation of `_mm256_loadu_ps`, because
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Okay, We can try this, then.
Repository:
rC Clang
https://reviews.llvm.org/D47564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rjmccall added a comment.
Oh, I see, because you're worried that the host code might contain
`dynamic_cast` or similar features which would complain if RTTI were disabled.
`getLangOpts().CUDAIsDevice` implies `getLangOpts().CUDA`, so I think you can
just check the former. Otherwise LGTM.
htt
emmettneyman updated this revision to Diff 149867.
emmettneyman added a comment.
- Refactored FuzzerInitialize into library
Repository:
rC Clang
https://reviews.llvm.org/D47666
Files:
tools/clang-fuzzer/CMakeLists.txt
tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp
tools/clang-fuzzer/fu
rnk added a comment.
In https://reviews.llvm.org/D46042#1121674, @rjmccall wrote:
> > I think we should revert this for now. Adding the alignment attribute to
> > all Intel vector typedefs is a bigger change than it seems.
>
> Ugh. That is just an awful language rule. Would it be reasonable t
trixirt updated this revision to Diff 149868.
trixirt added a comment.
Herald added a subscriber: klimek.
Convert to AST Visitor
Remove Ctx parameter from shouldNullCheckAllocation
Add a shouldNullCheckAllocation ASTMatcher
Repository:
rC Clang
https://reviews.llvm.org/D47554
Files:
incl
Author: tejohnson
Date: Mon Jun 4 16:05:24 2018
New Revision: 333966
URL: http://llvm.org/viewvc/llvm-project?rev=333966&view=rev
Log:
[ThinLTO] Add testing of new summary index format to a couple CFI tests
Summary:
Adds testing of combined index summary entries in disassembly format
to CFI test
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333966: [ThinLTO] Add testing of new summary index format to
a couple CFI tests (authored by tejohnson, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm
morehouse added inline comments.
Comment at: tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp:23
#include
I think `cstring` is no longer used after this change. So we can probably
remove this include.
Comment at: tools/clang-fuzzer/fuzzer
rnk added a comment.
By the way, I went ahead and reverted this in r333958.
Repository:
rC Clang
https://reviews.llvm.org/D46042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
In https://reviews.llvm.org/D45015#1121581, @ahatanak wrote:
> Could you elaborate on what kind of changes you are planning to make in
> libc++ after committing this patch?
Libc++ shouldn't actually need any changes if this current patch lands.
Currently libc++ is in a
emmettneyman updated this revision to Diff 149872.
emmettneyman added a comment.
- Removed unecessary includes and renamed library.
Repository:
rC Clang
https://reviews.llvm.org/D47666
Files:
tools/clang-fuzzer/CMakeLists.txt
tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp
tools/clang-f
morehouse accepted this revision.
morehouse added a comment.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D47666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jkorous accepted this revision.
jkorous added a comment.
LGTM.
Thank you for the explanation!
Repository:
rC Clang
https://reviews.llvm.org/D36918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333969: [clang-proto-fuzzer] Refactored LLVMFuzzerInitialize
into its own file. (authored by morehouse, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47666?vs=149872&id=149876#toc
Author: morehouse
Date: Mon Jun 4 17:11:41 2018
New Revision: 333969
URL: http://llvm.org/viewvc/llvm-project?rev=333969&view=rev
Log:
[clang-proto-fuzzer] Refactored LLVMFuzzerInitialize into its own file.
Copied and renamed some files in preparation for new loop-proto-fuzzer.
Patch By: emmett
george.karpenkov added a subscriber: mikhail.ramalho.
george.karpenkov added a comment.
@ddcc To be completely honest, I see a few design issues with the current
implementation of Z3 backend,
the main one being that it checks satisfiability after every single exploded
node.
To the best of my kn
ddcc added a comment.
> @ddcc To be completely honest, I see a few design issues with the current
> implementation of Z3 backend,
> the main one being that it checks satisfiability after every single exploded
> node.
> To the best of my knowledge, reasonable scalability would not be achieved
george.karpenkov added a comment.
> I agree, though a number of these are limitations in CSA, and not
> specifically the backend.
Yeah, so for instance we always assume that for a given state we know whether
it's feasible or not,
and IMO for efficient SMT solver support we would need to operate
Author: rnk
Date: Mon Jun 4 18:33:40 2018
New Revision: 333978
URL: http://llvm.org/viewvc/llvm-project?rev=333978&view=rev
Log:
Reimplement the bittest intrinsic family as builtins with inline asm
We need to implement _interlockedbittestandset as a builtin for
windows.h, so we might as well do
yaxunl updated this revision to Diff 149892.
yaxunl added a comment.
Revised by John's comments.
https://reviews.llvm.org/D47694
Files:
lib/CodeGen/CodeGenModule.cpp
test/CodeGenCUDA/device-vtable.cu
Index: test/CodeGenCUDA/device-vtable.cu
Author: phosek
Date: Mon Jun 4 18:50:59 2018
New Revision: 333979
URL: http://llvm.org/viewvc/llvm-project?rev=333979&view=rev
Log:
[Driver][Fuchsia] Pass LTO flags to linker
Even though we use lld by default for Fuchsia, we use Gold plugin
arguments like all other drivers as lld supports Gold p
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333979: [Driver][Fuchsia] Pass LTO flags to linker (authored
by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D47668?vs=149590&id=149
ahatanak added a comment.
I see, thank you.
clang front-end currently fails to issue a warning or error when an aligned
allocation/deallocation functions are required but not available in a few cases
(e.g., delete called from a deleting destructor, calls to operator or builtin
operator new/del
ahatanak created this revision.
ahatanak added reviewers: rsmith, vsapsai, EricWF, erik.pilkington.
Deallocation functions are called from deleting destructors that are declared
virtual. Issue an error if an aligned deallocation function is selected but is
not available.
Repository:
rC Clang
phosek created this revision.
phosek added reviewers: mcgrathr, juliehockett.
Herald added subscribers: cfe-commits, mgorny.
This enables the use of install-distribution-stripped target in the
2-stage builds.
Repository:
rC Clang
https://reviews.llvm.org/D47758
Files:
clang/cmake/caches/Fu
Author: ctopper
Date: Mon Jun 4 20:12:14 2018
New Revision: 333980
URL: http://llvm.org/viewvc/llvm-project?rev=333980&view=rev
Log:
[X86] Mark all the builtins and intrinsics that require MMX and an SSE feature
as requiring both mmx and the sse feature.
Previously we only checked the sse featu
dlj created this revision.
dlj added a reviewer: djasper.
dlj added a project: clang.
Herald added a subscriber: klimek.
ScopedMacroState injects its own EOF token under certain conditions, and the
returned token may be modified in several different locations. If multiple
reformat operations are s
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
https://reviews.llvm.org/D47694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
malaperle added a comment.
In https://reviews.llvm.org/D47643#1120913, @ilya-biryukov wrote:
> PS I've checked it on my Mac and lldb seems to attach just fine.
Working fine in my setup too!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47643
__
ebevhan added a comment.
There's actually a bit more to it than in these two patches. The complete diff
to this function in our downstream Clang looks like this:
QualType
ASTContext::getAddrSpaceQualType(QualType T, unsigned AddressSpace) const {
- QualType CanT = getCanonicalType(T);
aaron.ballman added a comment.
In https://reviews.llvm.org/D47201#1119947, @Hahnfeld wrote:
> In https://reviews.llvm.org/D47201#1119254, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D47201#1119249, @tra wrote:
> >
> > > IIUIC, nv_weak is a synonym for weak (why, oh why did they need
101 - 185 of 185 matches
Mail list logo
