morehouse added inline comments.
================ Comment at: tools/clang-fuzzer/CMakeLists.txt:48 ExampleClangProtoFuzzer.cpp + FuzzerInitialize.cpp ) ---------------- Rather than compiling `FuzzerInitialize.cpp` into the binary, can we make it a library like `handle-cxx` or `proto-to-cxx`? ================ Comment at: tools/clang-fuzzer/FuzzerInitialize.cpp:17 #include "cxx_proto.pb.h" ---------------- Do we need this include? ================ Comment at: tools/clang-fuzzer/FuzzerInitialize.h:20 + +#include <cstring> + ---------------- Why do we need these includes in the header? Doesn't look like they're used here. Repository: rC Clang https://reviews.llvm.org/D47666 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits