[PATCH] D44984: [HIP] Add hip file type and codegen for kernel launching

yaxunl marked an inline comment as done. yaxunl added a comment. > > >> Since the header file and library seem not to affect this patch, is it OK to >> defer their changes to be part of the toolchain patch? > > I'm not sure I understand. Could you elaborate? clang -cc1 does not include `__cla

[PATCH] D44720: [clangd] Simplify fuzzy matcher (sequence alignment) by removing some condition checks.

MaskRay added inline comments. Comment at: clangd/FuzzyMatch.cpp:93 + for (int I = PatN; I <= WordN; I++) +Best = std::max(Best, Scores[PatN][I][Match].Score); if (isAwful(Best)) sammccall wrote: > MaskRay wrote: > > sammccall wrote: > > > MaskRay wrote:

[PATCH] D44720: [clangd] Simplify fuzzy matcher (sequence alignment) by removing some condition checks.

MaskRay added a comment. In `buildGraph`, the nested loop for (int P = 0; P < PatN; ++P) { // Scores[P + 1][P][Miss] = Scores[P + 1][P][Match] = {AwfulScore, Miss}; for (int W = P; W < WordN; ++W) { is interpreted as: we are calculating the cell `Scores[P+1][W+1][*]`, using the ch

[PATCH] D44720: [clangd] Simplify fuzzy matcher (sequence alignment) by removing some condition checks.

MaskRay updated this revision to Diff 140311. MaskRay added a comment. Don't rename anything. I just want to have this revision reviewed as soon as possible Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44720 Files: clangd/FuzzyMatch.cpp clangd/FuzzyMatch.h Index: clangd

[PATCH] D44985: Remove initializer for CUDA shared varirable

yaxunl updated this revision to Diff 140310. yaxunl added a comment. Revised by John's comments. Also simplified the test by Artem's comments. https://reviews.llvm.org/D44985 Files: lib/CodeGen/CGDecl.cpp test/CodeGenCUDA/address-spaces.cu test/CodeGenCUDA/device-var-init.cu Index: test/

[PATCH] D44720: [clangd] Simplify fuzzy matcher (sequence alignment) by removing some condition checks.

MaskRay added inline comments. Comment at: clangd/FuzzyMatch.cpp:209 std::copy(NewWord.begin(), NewWord.begin() + WordN, Word); - if (PatN == 0) -return true; sammccall wrote: > similarly this one. > (ideally we wouldn't do the work above, it's just there

[PATCH] D45059: Add a clang-tidy check to catch comparisons in TEMP_FAILURE_RETRY

george.burgess.iv created this revision. george.burgess.iv added reviewers: aaron.ballman, alexfh. Herald added a subscriber: mgorny. `TEMP_FAILURE_RETRY(x)` is a macro that executes `x` until `(x) != -1 || errno != EINTR`, and evaluates to the result of the last execution of `x`. I've been told

[PATCH] D45059: Add a clang-tidy check to catch comparisons in TEMP_FAILURE_RETRY

Eugene.Zelenko added inline comments. Comment at: clang-tidy/bugprone/ComparisonInTempFailureRetryCheck.cpp:51 +} +} + Please add // namespace and remove one empty line below. Comment at: docs/ReleaseNotes.rst:60 +- New `bugprone-comparison-i

[PATCH] D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY

Eugene.Zelenko added a comment. Will be good idea to clarify where TEMP_FAILURE_RETRY come from. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D45060: Allow target to handle required features for TARGET_BUILTINs.

tra created this revision. tra added a reviewer: echristo. Herald added subscribers: jlebar, sanjoy. In some cases figuring out whether particular target builtin should be enabled is a bit more complicated than current implementation allow. This patch allows the target to override what it consider

[PATCH] D45061: [NVPTX, CUDA] Use custom feature detection to handle NVPTX target builtins.

tra created this revision. tra added a reviewer: jlebar. Herald added subscribers: hiraditya, sanjoy, jholewinski. When NVPTX TARGET_BUILTIN specifies sm_XX or ptxYY as required feature, consider those features available if we're compiling for GPU >= sm_XX or have enabled PTX version >= ptxYY. Th

r328825 - Mark __cfi_check as dso_local.

Author: rafael Date: Thu Mar 29 13:51:30 2018 New Revision: 328825 URL: http://llvm.org/viewvc/llvm-project?rev=328825&view=rev Log: Mark __cfi_check as dso_local. Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp cfe/trunk/test/CodeGen/cfi-icall-cross-dso.c Modified: cfe/trunk/lib/CodeGen/CGEx

[PATCH] D44985: Remove initializer for CUDA shared varirable

tra added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:235-240 + if (Ty.getAddressSpace() != LangAS::opencl_local && + !(getLangOpts().CUDA && getLangOpts().CUDAIsDevice && +D.hasAttr())) Init = EmitNullConstant(Ty); else Init = llvm::UndefValue:

r328826 - [AST] Fix some Clang-tidy modernize-use-auto warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Thu Mar 29 13:51:59 2018 New Revision: 328826 URL: http://llvm.org/viewvc/llvm-project?rev=328826&view=rev Log: [AST] Fix some Clang-tidy modernize-use-auto warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/AST/DeclTemplate.h cfe/trunk/includ

[PATCH] D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY

george.burgess.iv updated this revision to Diff 140324. george.burgess.iv marked 3 inline comments as done. george.burgess.iv edited the summary of this revision. george.burgess.iv added a comment. Addressed feedback. https://reviews.llvm.org/D45059 Files: clang-tidy/bugprone/BugproneTidyModu

[PATCH] D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY

george.burgess.iv added a comment. Thanks! > Will be good idea to clarify where TEMP_FAILURE_RETRY come from. Updated the CL summary and added "TEMP_FAILURE_RETRY is a macro provided by both glibc and Bionic." to ComparisonInTempFailureRetryCheck.h. Did you have anything else in mind? =

[PATCH] D45052: Mark __cfi_check as dso_local

espindola closed this revision. espindola added a comment. 328825 https://reviews.llvm.org/D45052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r328827 - [analyzer] Path-insensitive checker for writes into an auto-releasing pointer

Author: george.karpenkov Date: Thu Mar 29 13:55:34 2018 New Revision: 328827 URL: http://llvm.org/viewvc/llvm-project?rev=328827&view=rev Log: [analyzer] Path-insensitive checker for writes into an auto-releasing pointer from the wrong auto-releasing pool, as such writes may crash. rdar://253011

[PATCH] D45054: Set dso_local on cfi_slowpath

espindola added a comment. In https://reviews.llvm.org/D45054#1052118, @eugenis wrote: > This looks wrong. cfi_slowpath is defined in libclang_rt.cfi, which is linked > to the main executable. It is not always dso-local. On Android it is defined > in libdl.so and is never dso-local. And we do

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen

Charusso updated this revision to Diff 140330. Charusso marked 2 inline comments as done. Charusso added a comment. Fixed everything according to the comments. https://reviews.llvm.org/D45050 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/b

[PATCH] D44985: [CUDA] Let device-side shared variables be initialized with undef

yaxunl updated this revision to Diff 140329. yaxunl retitled this revision from "Remove initializer for CUDA shared varirable" to "[CUDA] Let device-side shared variables be initialized with undef". yaxunl edited the summary of this revision. yaxunl added a comment. Revised by Artem's comment. I

[PATCH] D45054: Set dso_local on cfi_slowpath

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM then. This naming is confusing. https://reviews.llvm.org/D45054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen

Eugene.Zelenko added inline comments. Comment at: clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp:46 +/// from ' "data_name", "data", ' to just 'data' by "memmoving" it char-by-char. +bool isTrimFunc(const MatchFinder::MatchResult &Result) { + const auto *FuncExpr = Result

[clang-tools-extra] r328819 - [clangd] Fix repeated word typo. NFC

Author: maskray Date: Thu Mar 29 13:03:16 2018 New Revision: 328819 URL: http://llvm.org/viewvc/llvm-project?rev=328819&view=rev Log: [clangd] Fix repeated word typo. NFC Modified: clang-tools-extra/trunk/clangd/JSONExpr.cpp clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp Modifi

r328829 - [AArch64]: Add support for parsing rN registers.

Author: manojgupta Date: Thu Mar 29 14:11:15 2018 New Revision: 328829 URL: http://llvm.org/viewvc/llvm-project?rev=328829&view=rev Log: [AArch64]: Add support for parsing rN registers. Summary: Allow rN registers to be simply parsed as correspoing xN registers. The "register ... asm("rN")" is an

[PATCH] D44815: [AArch64]: Add support for parsing rN registers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL328829: [AArch64]: Add support for parsing rN registers. (authored by manojgupta, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44815 Files:

[PATCH] D44985: [CUDA] Let device-side shared variables be initialized with undef

tra added a comment. Still LGTM. https://reviews.llvm.org/D44985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45061: [NVPTX, CUDA] Use custom feature detection to handle NVPTX target builtins.

tra updated this revision to Diff 140334. tra added a comment. Run the tests with -target-cpu sm_61 to make sure intrinsics that require sm_60 are still enabled. https://reviews.llvm.org/D45061 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/include/clang/Basic/Cuda.h clang/lib/

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen

Charusso updated this revision to Diff 140337. Charusso marked 6 inline comments as done. Charusso added a comment. Truly fixed everything according to the comments. https://reviews.llvm.org/D45050 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-

[PATCH] D44985: [CUDA] Let device-side shared variables be initialized with undef

rjmccall added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:235-240 + if (Ty.getAddressSpace() != LangAS::opencl_local && + !(getLangOpts().CUDA && getLangOpts().CUDAIsDevice && +D.hasAttr())) Init = EmitNullConstant(Ty); else Init = llvm::UndefV

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:60 +- New module `abseil` for checks related to the `Abseil `_ + library. Looks like you copied new version of file over old one. svn update and svn diff should be made

[PATCH] D45054: Set dso_local on cfi_slowpath

espindola closed this revision. espindola added a comment. 328836 https://reviews.llvm.org/D45054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r328835 - [analyzer] Better pretty-printing of regions in exploded graph

Author: george.karpenkov Date: Thu Mar 29 15:07:58 2018 New Revision: 328835 URL: http://llvm.org/viewvc/llvm-project?rev=328835&view=rev Log: [analyzer] Better pretty-printing of regions in exploded graph Differential Revision: https://reviews.llvm.org/D45010 Modified: cfe/trunk/lib/StaticA

r328836 - Set dso_local on cfi_slowpath.

Author: rafael Date: Thu Mar 29 15:08:01 2018 New Revision: 328836 URL: http://llvm.org/viewvc/llvm-project?rev=328836&view=rev Log: Set dso_local on cfi_slowpath. Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp cfe/trunk/test/CodeGen/cfi-icall-cross-dso.c Modified: cfe/trunk/lib/CodeGen/CGEx

r328837 - [analyzer] Fix target triple for autorelease-write-checker test

Author: george.karpenkov Date: Thu Mar 29 15:28:04 2018 New Revision: 328837 URL: http://llvm.org/viewvc/llvm-project?rev=328837&view=rev Log: [analyzer] Fix target triple for autorelease-write-checker test Modified: cfe/trunk/test/Analysis/autoreleasewritechecker_test.m Modified: cfe/trunk/

[PATCH] D45006: [Tooling] A CompilationDatabase wrapper that infers header commands.

sammccall updated this revision to Diff 140349. sammccall added a comment. Add tests, fix minor bugs, add lots of comments and structure. Repository: rC Clang https://reviews.llvm.org/D45006 Files: include/clang/Tooling/CompilationDatabase.h lib/Tooling/CMakeLists.txt lib/Tooling/Inter

[PATCH] D45007: [clangd] Use compile-command interpolation to provide commands for header files.

sammccall added a comment. Sending for review in case you have an opinion about whether it's worth plumbing a flag through here, or if it's fine to just always do it. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45007 ___ cfe-com

r328845 - Hoist MethodVFTableLocation out of MicrosoftVTableContext, NFC

Author: rnk Date: Thu Mar 29 15:42:24 2018 New Revision: 328845 URL: http://llvm.org/viewvc/llvm-project?rev=328845&view=rev Log: Hoist MethodVFTableLocation out of MicrosoftVTableContext, NFC This allows forward declaring it so that we can add it to MicrosoftMangleContext::mangleVirtualMemPtrThu

[PATCH] D45068: [NVPTX, CUDA] Added support for m8n32k16 and m32n8k16 variants of wmma instructions.

tra created this revision. tra added a reviewer: jlebar. Herald added subscribers: hiraditya, sanjoy, jholewinski. The new instructions were added added for sm_70+ GPUs in CUDA-9.1. https://reviews.llvm.org/D45068 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/lib/CodeGen/CGBuilti

[PATCH] D45068: [NVPTX, CUDA] Added support for m8n32k16 and m32n8k16 variants of wmma instructions.

jlebar accepted this revision. jlebar added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:578 + if (CudaInstallation.version() >= CudaVersion::CUDA_91) { +// CUDA-9 uses new instructions that are only avail

[PATCH] D45069: [clangd] synthesize fix message when the diagnostic doesn't provide one.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, MaskRay, ioeric, jkorous-apple, klimek. Currently if a fix is attached directly to a diagnostic, we repeat the diagnostic message as the fix message. From eyeballing the top diagnosti

[PATCH] D45061: [NVPTX, CUDA] Use custom feature detection to handle NVPTX target builtins.

jlebar accepted this revision. jlebar added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/Cuda.h:55 +static inline const std::vector CudaKnownArchList() { + return {CudaArch::SM_20, CudaArch::SM_21, CudaArch::SM_30, Cud

[PATCH] D45060: Allow target to handle required features for TARGET_BUILTINs.

jlebar accepted this revision. jlebar added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/TargetInfo.h:933 + /// FeatureMap. Targets may override this to provide custom handling of + /// required features. + virtual Opt

[PATCH] D45068: [NVPTX, CUDA] Added support for m8n32k16 and m32n8k16 variants of wmma instructions.

tra updated this revision to Diff 140363. tra added a comment. Updated comments. https://reviews.llvm.org/D45068 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/lib/CodeGen/CGBuiltin.cpp clang/lib/Driver/ToolChains/Cuda.cpp clang/test/CodeGen/builtins-nvptx-sm_70.cu llvm/incl

[PATCH] D45060: Allow target to handle required features for TARGET_BUILTINs.

tra updated this revision to Diff 140371. tra added a comment. Updated description of hasRequiredFeature. Set FirstMissing if target returns 'false' so diags still work. https://reviews.llvm.org/D45060 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/CodeGen/CodeGenFunction.cpp Ind

[PATCH] D45060: Allow target to handle required features for TARGET_BUILTINs.

tra marked an inline comment as done. tra added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:933 + /// FeatureMap. Targets may override this to provide custom handling of + /// required features. + virtual Optional jlebar wrote: > It's n

[PATCH] D45071: [analyzer] Track null or undef values through pointer arithmetic.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs, eraman. Pointer arithmetic on null or undefined pointers results in null or undefined pointers. This is obvious for undefined pointers; for n

[PATCH] D45013: Generate warning when over-aligned new call is required but not supported.

vsapsai added a comment. Does it make sense to have a warning for `__libcpp_deallocate` and `get_temporary_buffer` too? Not sure about deallocate as you have allocated memory already and allocation has a warning. So for deallocation a warning can be too noisy. But for `get_temporary_buffer` the

RE: r328837 - [analyzer] Fix target triple for autorelease-write-checker test

Hi George, This test is still failing on a bot (http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/16152): FAIL: Clang :: Analysis/autoreleasewritechecker_test.m (2908 of 39213) TEST 'Clang :: Analysis/autoreleasewritechecker_test.m' F

r328853 - Adding UNSUPPORTED: system-windows at George's request until the problem can be debugged.

Author: dyung Date: Thu Mar 29 18:29:07 2018 New Revision: 328853 URL: http://llvm.org/viewvc/llvm-project?rev=328853&view=rev Log: Adding UNSUPPORTED: system-windows at George's request until the problem can be debugged. Modified: cfe/trunk/test/Analysis/autoreleasewritechecker_test.m Mod

RE: r328837 - [analyzer] Fix target triple for autorelease-write-checker test

I've added "UNSUPPORTED: system-windows" in r328853. Hopefully that should disable it on Windows until you can get a chance to figure out the problem. Douglas Yung > -Original Message- > From: ekarpen...@apple.com [mailto:ekarpen...@apple.com] > Sent: Thursday, March 29, 2018 18:22 > To:

[PATCH] D44764: [clangd] Use operator<< to prevent printers issues in Gtest

malaperle updated this revision to Diff 140382. malaperle marked an inline comment as done. malaperle added a comment. Use raw_ostream instead. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44764 Files: clangd/Protocol.cpp clangd/Protocol.h unittests/clangd/CodeCompleteT

[PATCH] D44764: [clangd] Use operator<< to prevent printers issues in Gtest

malaperle added inline comments. Comment at: clangd/Protocol.h:673 json::Expr toJSON(const CompletionItem &); +std::ostream &operator<<(std::ostream &, const CompletionItem &); sammccall wrote: > I think raw_ostream should work fine here, it's what we've done

[PATCH] D45058: [X86] Disable SGX for Skylake Server

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D45058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

r328857 - [Modules] Improve fixit for framework private module maps

Author: bruno Date: Thu Mar 29 22:17:58 2018 New Revision: 328857 URL: http://llvm.org/viewvc/llvm-project?rev=328857&view=rev Log: [Modules] Improve fixit for framework private module maps The wrong source range was being provided in some case, fix that to get a better fixit. rdar://problem/385

<    1   2