espindola added a comment.

In https://reviews.llvm.org/D45054#1052118, @eugenis wrote:

> This looks wrong. cfi_slowpath is defined in libclang_rt.cfi, which is linked 
> to the main executable. It is not always dso-local. On Android it is defined 
> in libdl.so and is never dso-local.


And we don't set cfi_local in that case. See the ITANIUM lines is the testcase.

The CodegenModule functions are named setDSOLocal, setDLLImportDLLExport, etc, 
but they only set the corresponding flags when appropriate.


https://reviews.llvm.org/D45054



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D45054: ... Rafael Avila de Espindola via Phabricator via cfe-commits
    • [PATCH] D45... Evgenii Stepanov via Phabricator via cfe-commits
    • [PATCH] D45... Rafael Avila de Espindola via Phabricator via cfe-commits
    • [PATCH] D45... Evgenii Stepanov via Phabricator via cfe-commits
    • [PATCH] D45... Rafael Avila de Espindola via Phabricator via cfe-commits

Reply via email to