malaperle added inline comments.
================ Comment at: clangd/Protocol.h:673 json::Expr toJSON(const CompletionItem &); +std::ostream &operator<<(std::ostream &, const CompletionItem &); ---------------- sammccall wrote: > I think raw_ostream should work fine here, it's what we've done elsewhere. > Is there a reason to use std::ostream? > > (llvm's gtest is specially modified so raw_ostream printers can be used) No reason, I changed it. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44764 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
