[libcxx] r328477 - Fix test case initialization issues in permissions test

Author: ericwf Date: Mon Mar 26 00:06:25 2018 New Revision: 328477 URL: http://llvm.org/viewvc/llvm-project?rev=328477&view=rev Log: Fix test case initialization issues in permissions test Modified: libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.permissions/permissions.pass.

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

rjmccall added a comment. I'm not sure you really need to put these in their own warning sub-group just because they're user-defined operators. That's especially true because it appears we already have divisions in the warning group based on the form of the l-value; we don't want this to go co

[PATCH] D44826: Add -Wunused-using, a warning that finds unused using declarations.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D44826#1046910, @Eugene.Zelenko wrote: > This duplicates Clang-tidy misc-unused-using-decls > . > If Clang will provide same or better functionality, it s

[PATCH] D44826: Add -Wunused-using, a warning that finds unused using declarations.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D44826#1046913, @Eugene.Zelenko wrote: > Please also mention new warning in Release Notes and documentation. I will do it. > Will this warning be part of -Wall or -Wextra? The warning is part of -Wall Thanks for your feedback.

[PATCH] D43967: [ASTImporter] Add test helper Fixture

martong added a comment. Hi Aleksei, I don't have commit permissions, could you please help and commit? Repository: rC Clang https://reviews.llvm.org/D43967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D44831: [clang-format] Refine ObjC guesser to handle child lines of child lines

djasper added inline comments. Comment at: lib/Format/Format.cpp:1542 }; -for (auto Line : AnnotatedLines) { - if (LineContainsObjCCode(*Line)) +llvm::DenseSet LinesToCheckSet; +LinesToCheckSet.reserve(AnnotatedLines.size()); Wouldn't it be

[PATCH] D44272: [clangd] Support incremental document syncing

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Comment at: unittests/clangd/DraftStoreTests.cpp:1 +//===-- DraftStoreTests.cpp - Clangd unit tests -*- C++ -*-===// +//

[PATCH] D44764: [clangd] Use a header for common inclusions for tests

ilya-biryukov added a comment. In https://reviews.llvm.org/D44764#1046766, @sammccall wrote: > You raise a good point. If we can get away with using `operator <<` everywhere, it is definitely the best approach. Then our rule of thumb is: never define `PrintTo` overload, define `operator <<` f

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

ilya-biryukov added reviewers: sammccall, ilya-biryukov. ilya-biryukov added a subscriber: sammccall. ilya-biryukov added a comment. Adding @sammccall, he will definitely want to take a look at index-related changes. On a high level, the approach seems just right. A few questions immedieately tha

[PATCH] D44893: [ASTMatchers] Add isAssignmentOperator matcher

szepet created this revision. szepet added reviewers: aaron.ballman, alexfh. Herald added subscribers: dkrupp, rnkovacs, klimek. Adding a matcher for BinaryOperator and cxxOperatorCallExpr to be able to decide whether it is any kind of assignment operator or not. This would be useful since allow

[PATCH] D38921: [analyzer] LoopUnrolling: update the matched assignment operators

szepet marked 2 inline comments as done. szepet added a comment. In https://reviews.llvm.org/D38921#1037180, @alexfh wrote: > Do you want to submit the matcher part separately? Yepp, but added as a different patch since implemented it for cxxOperatorCall as well. (I guess Aaron's test request

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

lebedev.ri added a comment. In https://reviews.llvm.org/D44883#1048010, @rjmccall wrote: > I'm not sure you really need to put these in their own warning sub-group just > because they're user-defined operators. That's especially true because it > appears we already have divisions in the warnin

[PATCH] D44559: [Sema] Wrong width of result of mul operation

avt77 added a comment. In https://reviews.llvm.org/D44559#1045758, @rjmccall wrote: > No, I still oppose this patch. OK, we have 2 possibilities here (fmpov): 1. Forget about the issue and don't do anything now - it is not a bug 2. Return the width based on real analyze of mul args: - signed

[PATCH] D38921: [analyzer] LoopUnrolling: update the matched assignment operators

szepet updated this revision to Diff 139776. szepet added a comment. Added the assignment operator matcher patch as a dependency and rebased on top of that. https://reviews.llvm.org/D38921 Files: lib/StaticAnalyzer/Core/LoopUnrolling.cpp test/Analysis/loop-unrolling.cpp Index: test/Analys

[PATCH] D43821: [SemaCXX] _Pragma("clang optimize off") not affecting lambda.

This revision was automatically updated to reflect the committed changes. Closed by commit rL328494: [SemaCXX] _Pragma("clang optimize off") not affecting lambda. (authored by CarlosAlbertoEnciso, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[PATCH] D44787: Migrate dockerfiles to use multi-stage builds.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: docs/Docker.rst:64 If you want to write your own docker image, start with an ``example/`` subfolder. -It provides incomplete Dockerfiles with (very fe

r328495 - [clang-format] Wildcard expansion on Windows.

Author: alexfh Date: Mon Mar 26 06:54:17 2018 New Revision: 328495 URL: http://llvm.org/viewvc/llvm-project?rev=328495&view=rev Log: [clang-format] Wildcard expansion on Windows. Summary: Add support for wildcard expansion in command line arguments on Windows. See https://docs.microsoft.com/en-us

[PATCH] D44778: [clang-format] Wildcard expansion on Windows.

This revision was automatically updated to reflect the committed changes. Closed by commit rC328495: [clang-format] Wildcard expansion on Windows. (authored by alexfh, committed by ). Changed prior to commit: https://reviews.llvm.org/D44778?vs=139593&id=139784#toc Repository: rC Clang https

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle added a comment. In https://reviews.llvm.org/D44882#1048043, @ilya-biryukov wrote: > - Unconditionally storing much more symbols in the index might have subtle > performance implications, especially for our internal use (the codebase is > huge). I bet that internally we wouldn't want

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle added inline comments. Comment at: clangd/WorkspaceSymbols.cpp:165 +[](const SymbolInformation &A, const SymbolInformation &B) { + return A.name < B.name; +}); ilya-biryukov wrote: > We have `FuzzyMatcher`, it can pr

[PATCH] D44774: [Driver] Allow use of -fsyntax-only together with -MJ

dstenb added a comment. Downstream we use -MJ in a bit of an idiosyncratic way, as we're in a transition period where we, for a subset of the code base, only use the clang frontend for diagnostics, and not for the code generation. However, if you don't think that using -fsyntax-only and -MJ mak

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

lebedev.ri updated this revision to Diff 139788. lebedev.ri marked 3 inline comments as done. lebedev.ri added a comment. - Also warn on `BO_DivAssign`, `BO_SubAssign`, `BO_XorAssign`. - Add releasenotes entry. Repository: rC Clang https://reviews.llvm.org/D44883 Files: docs/ReleaseNotes.r

[PATCH] D44774: [Driver] Allow use of -fsyntax-only together with -MJ

joerg added a comment. Oh, we certainly should never be hitting an assertion on front-end flags. As such, there is a problem to fix here. I still maintain that the combination of flags is non-sense, so the question is: (1) Should be silently ignore -MJ? That would be useful for your use case, b

[PATCH] D44272: [clangd] Support incremental document syncing

This revision was automatically updated to reflect the committed changes. Closed by commit rL328500: [clangd] Support incremental document syncing (authored by simark, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D44272?vs=139596&id=

[PATCH] D44231: [clang-tidy] Check for sizeof that call functions

pfultz2 added a comment. So, I've added tests for class enums and bols. https://reviews.llvm.org/D44231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43967: [ASTImporter] Add test helper Fixture

martong updated this revision to Diff 139791. martong added a comment. - Fix gcc 5 warnings Repository: rC Clang https://reviews.llvm.org/D43967 Files: unittests/AST/ASTImporterTest.cpp unittests/AST/DeclMatcher.h Index: unittests/AST/DeclMatcher.h ==

[PATCH] D44787: Migrate dockerfiles to use multi-stage builds.

This revision was automatically updated to reflect the committed changes. Closed by commit rL328503: Migrate dockerfiles to use multi-stage builds. (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D44787?vs=139457&id=139792#toc Repository: rL LLVM ht

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

JonasToth updated this revision to Diff 139793. JonasToth added a comment. - [Feature] implement CAPS_ONLY features, adjust docs Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41648 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuide

[PATCH] D44831: [clang-format] Refine ObjC guesser to handle child lines of child lines

benhamilton added inline comments. Comment at: lib/Format/Format.cpp:1542 }; -for (auto Line : AnnotatedLines) { - if (LineContainsObjCCode(*Line)) +llvm::DenseSet LinesToCheckSet; +LinesToCheckSet.reserve(AnnotatedLines.size()); djasper wro

[PATCH] D44765: PR36643 Make clang-format support more generic TMarcos

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Thank you! One more comment from me and I'll leave the rest of the review to Krasimir, who has a better idea of how the configuration options should be named etc.

[libcxxabi] r328507 - [demangler] Fix a bug in r328464 found by oss-fuzz.

Author: epilk Date: Mon Mar 26 08:34:36 2018 New Revision: 328507 URL: http://llvm.org/viewvc/llvm-project?rev=328507&view=rev Log: [demangler] Fix a bug in r328464 found by oss-fuzz. Modified: libcxxabi/trunk/src/cxa_demangle.cpp Modified: libcxxabi/trunk/src/cxa_demangle.cpp URL: http://l

[PATCH] D44231: [clang-tidy] Check for sizeof that call functions

alexfh accepted this revision. alexfh added a comment. LG. Do you need someone to submit this for you? Comment at: test/clang-tidy/misc-sizeof-expression.cpp:17 +enum E { E_VALUE = 0 }; + aaron.ballman wrote: > Can you add a C++11 test case using `enum class`

[PATCH] D38455: [clang-tidy] new cppcoreguidelines-narrowing-conversions check.

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. > I agree that more data would be useful, so I'll do an analysis of flagging > all (non-ceil/floor float/double)->integral conversions. Removing from my dashboard for now. Reposito

[PATCH] D44852: [CodeGen] Mark fma as const for Android

pirama updated this revision to Diff 139798. pirama added a comment. Fix comment. Repository: rC Clang https://reviews.llvm.org/D44852 Files: lib/Sema/SemaDecl.cpp test/CodeGen/math-builtins.c Index: test/CodeGen/math-builtins.c =

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: docs/clang-tidy/checks/bugprone-parent-virtual-call.rst:26 + int foo() override {... A::foo()...} + warning: qual

[PATCH] D44831: [clang-format] Refine ObjC guesser to handle child lines of child lines

benhamilton added inline comments. Comment at: lib/Format/Format.cpp:1542 }; -for (auto Line : AnnotatedLines) { - if (LineContainsObjCCode(*Line)) +llvm::DenseSet LinesToCheckSet; +LinesToCheckSet.reserve(AnnotatedLines.size()); benhamilton

[PATCH] D44893: [ASTMatchers] Add isAssignmentOperator matcher

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG! Repository: rC Clang https://reviews.llvm.org/D44893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments

ahatanak updated this revision to Diff 139797. ahatanak added a comment. Assign an uninitialized APValue to a temporary instead of removing it from the temporary map when the temporary's lifetime has ended. https://reviews.llvm.org/D42776 Files: include/clang/AST/APValue.h lib/AST/APValue.

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/cppcoreguidelines-macro-usage.rst:26 + +This boolean flag disables all warnings for macros and checks only that +macro names are CAPS_ONLY. This option is meant to ease introduction of this ---

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/cppcoreguidelines-macro-usage.rst:24 + +.. option:: CheckCapsOnly + Will be good idea to generalize this option with other check which deal with macros. Repository: rCTE Clang Tools Ext

[libcxx] r328520 - Creating release directory for release_502.

Author: tstellar Date: Mon Mar 26 09:06:06 2018 New Revision: 328520 URL: http://llvm.org/viewvc/llvm-project?rev=328520&view=rev Log: Creating release directory for release_502. Added: libcxx/tags/RELEASE_502/ ___ cfe-commits mailing list cfe-comm

[libcxx] r328521 - Creating release candidate rc1 from release_502 branch

Author: tstellar Date: Mon Mar 26 09:06:11 2018 New Revision: 328521 URL: http://llvm.org/viewvc/llvm-project?rev=328521&view=rev Log: Creating release candidate rc1 from release_502 branch Added: libcxx/tags/RELEASE_502/rc1/ (props changed) - copied from r328520, libcxx/branches/rele

[libcxxabi] r328522 - Creating release directory for release_502.

Author: tstellar Date: Mon Mar 26 09:06:12 2018 New Revision: 328522 URL: http://llvm.org/viewvc/llvm-project?rev=328522&view=rev Log: Creating release directory for release_502. Added: libcxxabi/tags/RELEASE_502/ ___ cfe-commits mailing list cfe-c

[libcxxabi] r328523 - Creating release candidate rc1 from release_502 branch

Author: tstellar Date: Mon Mar 26 09:06:14 2018 New Revision: 328523 URL: http://llvm.org/viewvc/llvm-project?rev=328523&view=rev Log: Creating release candidate rc1 from release_502 branch Added: libcxxabi/tags/RELEASE_502/rc1/ - copied from r328522, libcxxabi/branches/release_50/ ___

[libunwind] r328534 - Creating release directory for release_502.

Author: tstellar Date: Mon Mar 26 09:06:38 2018 New Revision: 328534 URL: http://llvm.org/viewvc/llvm-project?rev=328534&view=rev Log: Creating release directory for release_502. Added: libunwind/tags/RELEASE_502/ ___ cfe-commits mailing list cfe-c

[libunwind] r328535 - Creating release candidate rc1 from release_502 branch

Author: tstellar Date: Mon Mar 26 09:06:40 2018 New Revision: 328535 URL: http://llvm.org/viewvc/llvm-project?rev=328535&view=rev Log: Creating release candidate rc1 from release_502 branch Added: libunwind/tags/RELEASE_502/rc1/ (props changed) - copied from r328534, libunwind/branche

[PATCH] D44831: [clang-format] Refine ObjC guesser to handle child lines of child lines

benhamilton updated this revision to Diff 139802. benhamilton added a comment. - Use recursion. Split lambda out into its own static method since recursion on lambdas is quite ugly until C++14 Repository: rC Clang https://reviews.llvm.org/D44831 Files: lib/Format/Format.cpp unittests/Fo

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

JonasToth added a comment. Which checks do you have in mind? Am 26.03.2018 um 18:07 schrieb Eugene Zelenko via Phabricator: > Eugene.Zelenko added inline comments. > > > Comment at: docs/clang-tidy/checks/cppcoreguidelines-macro-usage.rst:24 > + > +.. option:: CheckCapsOnly

[PATCH] D44831: [clang-format] Refine ObjC guesser to handle child lines of child lines

benhamilton updated this revision to Diff 139804. benhamilton added a comment. - Remove stray semicolon. Repository: rC Clang https://reviews.llvm.org/D44831 Files: lib/Format/Format.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 139805. zinovy.nis retitled this revision from "[clang-tidy] Detect and fix calls to grand-...parent virtual methods instead of calls to parent's virtual methods" to "[clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls

r328544 - [OPENMP] Codegen for declare target with link clause.

Author: abataev Date: Mon Mar 26 09:40:55 2018 New Revision: 328544 URL: http://llvm.org/viewvc/llvm-project?rev=328544&view=rev Log: [OPENMP] Codegen for declare target with link clause. If the link clause is used on the declare target directive, the object should be linked on target or target d

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

sammccall added a comment. Very nice! I'd like to reduce the scope of the initial patch, which seems to be possible, so we can review the details but not get bogged down too much. In https://reviews.llvm.org/D44882#1048179, @malaperle wrote: > In https://reviews.llvm.org/D44882#1048043, @ilya-b

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

mclow.lists requested changes to this revision. mclow.lists added a comment. This revision now requires changes to proceed. Please don't commit this. Comment at: libcxx/trunk/include/__split_buffer:201 __alloc_rr& __a = this->__alloc(); +pointer __to_be_end = this->__e

r328552 - [CodeGen] Mark fma as const for Android

Author: pirama Date: Mon Mar 26 10:03:34 2018 New Revision: 328552 URL: http://llvm.org/viewvc/llvm-project?rev=328552&view=rev Log: [CodeGen] Mark fma as const for Android Summary: r318093 sets fma, fmaf, fmal as const for Gnu and MSVC. Android also does not set errno for these functions. So m

[PATCH] D44852: [CodeGen] Mark fma as const for Android

This revision was automatically updated to reflect the committed changes. Closed by commit rL328552: [CodeGen] Mark fma as const for Android (authored by pirama, committed by ). Repository: rL LLVM https://reviews.llvm.org/D44852 Files: cfe/trunk/lib/Sema/SemaDecl.cpp cfe/trunk/test/CodeG

[PATCH] D44852: [CodeGen] Mark fma as const for Android

pirama added a comment. Thanks for the reviews! Repository: rL LLVM https://reviews.llvm.org/D44852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

Eugene.Zelenko added a comment. In https://reviews.llvm.org/D41648#1048312, @JonasToth wrote: > Which checks do you have in mind? bugprone-macro-*, bugprone-multiple-statement-macro. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41648 _

[PATCH] D44559: [Sema] Wrong width of result of mul operation

rjmccall added a comment. In https://reviews.llvm.org/D44559#1048085, @avt77 wrote: > In https://reviews.llvm.org/D44559#1045758, @rjmccall wrote: > > > No, I still oppose this patch. > > > OK, we have 2 possibilities here (fmpov): > > 1. Forget about the issue and don't do anything now - it is n

[PATCH] D44559: [Sema] Wrong width of result of mul operation

lebedev.ri added a comment. I'm having a very hard time following this thread. In fact, i can't follow the logic at all. In https://reviews.llvm.org/D44559#1041007, @rjmccall wrote: > ... > This patch, however, is contrary to the design of -Wconversion, which does > attempt to avoid warning i

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

rjmccall added a comment. In https://reviews.llvm.org/D44883#1048081, @lebedev.ri wrote: > In https://reviews.llvm.org/D44883#1048010, @rjmccall wrote: > > > I'm not sure you really need to put these in their own warning sub-group > > just because they're user-defined operators. That's especial

[PATCH] D44231: [clang-tidy] Check for sizeof that call functions

pfultz2 added a comment. > Do you need someone to submit this for you? Yes https://reviews.llvm.org/D44231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

Quuxplusone added a comment. Two more high-level comments from me, and then I'll try to butt out. Q1. I don't understand what `field-` is doing in the name of some diagnostics. Is there a situation where `x = x;` is "less/more of an error" just because `x` is a {data member, lambda capture, str

Re: r328282 - [analyzer] Trust _Nonnull annotations for system framework

This checker crashes on almost each file in our codebase. No test case yet, but here's a stack trace: clang::Type::getTypeClass clang::ReferenceType::classof llvm::isa_impl::doit llvm::isa_impl_cl::doit llvm::isa_impl_wrap::doit llvm::isa_impl_wrap::doit llvm::isa clang::Type::getAs clang::ASTConte

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

lebedev.ri added a subscriber: thakis. lebedev.ri added a comment. In https://reviews.llvm.org/D44883#1048421, @Quuxplusone wrote: > Two more high-level comments from me, and then I'll try to butt out. > > Q1. I don't understand what `field-` is doing in the name of some > diagnostics. Is there

Re: r328282 - [analyzer] Trust _Nonnull annotations for system framework

Yeah, I’m pretty sure this was fixed on Friday with https://reviews.llvm.org/rC328406 > On Mar 26, 2018, at 10:54 AM, Alexander Kornienko wrote: > > This checker crashes on almost each file in our codebase. No test case yet, > but here's a stack trace: > clang::Type::getTypeClass > clang::Refe

[PATCH] D44901: [Diag] Avoid emitting a redefinition note if no location is available.

mattd created this revision. mattd added reviewers: bruno, rsmith. The "previous definition is here" note is not helpful if there is no location information. The note will reference nothing in such a case. This patch first checks to see if there is location data, and if so the note diagnostic is

[PATCH] D44559: [Sema] Wrong width of result of mul operation

rjmccall added a comment. In https://reviews.llvm.org/D44559#1048399, @lebedev.ri wrote: > I'm having a very hard time following this thread. In fact, i can't follow > the logic at all. > > In https://reviews.llvm.org/D44559#1041007, @rjmccall wrote: > > > ... > > This patch, however, is contra

r328567 - [MS] Fix late-parsed template infinite loop in eager instantiation

Author: rnk Date: Mon Mar 26 11:22:47 2018 New Revision: 328567 URL: http://llvm.org/viewvc/llvm-project?rev=328567&view=rev Log: [MS] Fix late-parsed template infinite loop in eager instantiation Summary: This fixes PR33561 and PR34185. Don't store pending template instantiations for late-parse

[PATCH] D44846: [MS] Fix late-parsed template infinite loop in eager instantiation

This revision was automatically updated to reflect the committed changes. Closed by commit rL328567: [MS] Fix late-parsed template infinite loop in eager instantiation (authored by rnk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4

[PATCH] D44846: [MS] Fix late-parsed template infinite loop in eager instantiation

This revision was automatically updated to reflect the committed changes. Closed by commit rC328567: [MS] Fix late-parsed template infinite loop in eager instantiation (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D44846?vs=139663&id=139827#toc Repository:

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

rjmccall added a comment. In https://reviews.llvm.org/D44883#1048439, @lebedev.ri wrote: > In https://reviews.llvm.org/D44883#1048421, @Quuxplusone wrote: > > > Two more high-level comments from me, and then I'll try to butt out. > > > > Q1. I don't understand what `field-` is doing in the name o

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

rjmccall added a comment. In https://reviews.llvm.org/D44883#1048485, @rjmccall wrote: > In https://reviews.llvm.org/D44883#1048439, @lebedev.ri wrote: > > > In https://reviews.llvm.org/D44883#1048400, @rjmccall wrote: > > > > > Yeah, like I said, I'm just worried about the usability of having >

[PATCH] D44815: [AArch64]: Add support for parsing rN registers.

peter.smith added a comment. I think that we may have a bit of a conceptual difference with GCC here. As far as I can tell in GCC it doesn't matter if "rn", "wn", "xn" or even "bn" is used, this refers to register 0. The Operand constraint such as %w0 is used to control the substitution so the

[PATCH] D42938: [Sema] Emit -Winteger-overflow for arguments in function calls, ObjC messages.

vsapsai added a comment. Ping for reviewers. https://reviews.llvm.org/D42938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

lebedev.ri added a comment. Ok, once we understand why "field" diag is separate, and why since initial implementation it only warned for "builtin" operators, i'll work on the code further. In https://reviews.llvm.org/D44883#1048485, @rjmccall wrote: > That's an interesting question! You're ab

[PATCH] D44449: [Parser] Fix assertion-on-invalid for unexpected typename.

vsapsai added a comment. Ping. https://reviews.llvm.org/D9 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 139834. zinovy.nis added a comment. - Updated warning message to > warning: qualified name 'A::foo' refers to a member overridden in subclass; > did you mean 'B'? [bugprone-parent-virtual-call] https://reviews.llvm.org/D44295 Files: clang-tidy/bu

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

rjmccall added a comment. Is D not considered trivial there? Ugh, C++. Well, we certainly could justify treating D as a builtin operator as well, since it doesn't involve running any user code, but I don't think you're obligated to write a whole bunch of analysis just to make that work if the

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

lichray added inline comments. Comment at: libcxx/trunk/include/__split_buffer:201 __alloc_rr& __a = this->__alloc(); +pointer __to_be_end = this->__end_; do mclow.lists wrote: > I have been asked specifically by the optimizer folks to NOT do things

[PATCH] D44906: [clang-tidy] Define __clang_analyzer__ macro for clang-tidy for compatibility with clang static analyzer

zinovy.nis created this revision. zinovy.nis added a project: clang-tools-extra. Herald added subscribers: cfe-commits, a.sidorin, xazax.hun. Herald added a reviewer: george.karpenkov. This macro is widely used in many well-known projects, ex. Chromium

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

chandlerc resigned from this revision. chandlerc added a comment. I think this is more a question for Richard... Add me back to the reviewers if there is a specific need for my input here. Repository: rC Clang https://reviews.llvm.org/D43871 ___

[PATCH] D44330: CMake option to allow enabling experimental new pass manager by default

chandlerc requested changes to this revision. chandlerc added a comment. This revision now requires changes to proceed. Just a question really. Comment at: clang/CMakeLists.txt:215 +set(ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER FALSE CACHE BOOL + "Enable the experimental new pass

[PATCH] D42787: clang-format: do not add extra indent when wrapping last parameter

chandlerc resigned from this revision. chandlerc added a comment. Since this seems not going anywhere, removing it from my review dashboard. Repository: rC Clang https://reviews.llvm.org/D42787 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D44908: [ObjC++] Make parameter passing and function return compatible with ObjC

ahatanak created this revision. ahatanak added reviewers: rjmccall, doug.gregor, rsmith. r326307 and r327870 made changes that enable __strong and __weak fields to be declared in C structs. This patch changes the ObjC++ ABI so that structs with __strong or __weak pointers can be passed to or ret

[PATCH] D44908: [ObjC++] Make parameter passing and function return compatible with ObjC

ahatanak added a comment. I tried to move the code in MicrosoftCXXABI::getRecordArgABI and ItaniumCXXABI::passClassIndirect that determine whether a struct is passed indirectly to Sema::CheckCompletedCXXClass, but couldn't do so since getClangABICompat() is a method of CodeGenOpts, which Sema d

[PATCH] D44362: [clang] Change std::sort to llvm::sort in response to r327219

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D44362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

r328584 - [Frontend] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Mon Mar 26 14:45:04 2018 New Revision: 328584 URL: http://llvm.org/viewvc/llvm-project?rev=328584&view=rev Log: [Frontend] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/Frontend/Compiler

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

rjmccall added a comment. I tracked Chandler down, and he doesn't remember why user-defined operators are excluded. Repository: rC Clang https://reviews.llvm.org/D44883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D42938: [Sema] Emit -Winteger-overflow for arguments in function calls, ObjC messages.

jkorous-apple accepted this revision. jkorous-apple added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D42938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

lebedev.ri added a comment. In https://reviews.llvm.org/D44883#1048689, @rjmccall wrote: > I tracked Chandler down, and he doesn't remember why user-defined operators > are excluded. Ok then. Unless reviewers think it would be best to have separate diag groups for "builtin" and "user-provided

[PATCH] D44912: [clang-doc] Removing -Wunused-variable warning

juliehockett created this revision. juliehockett added reviewers: jakehehrlich, lebedev.ri, sammccall. juliehockett added a project: clang-tools-extra. Herald added subscribers: JDevlieghere, aprantl. Warning was appearing in release with debug info build, this removes it. https://reviews.llvm.o

[PATCH] D44912: [clang-doc] Removing -Wunused-variable warning

jakehehrlich accepted this revision. jakehehrlich added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D44912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

dblaikie added a subscriber: lebedev.ri. dblaikie added a comment. Historically Clang's policy on warnings was, I think, much more conservative than it seems to be today. There was a strong desire not to implement off-by-default warnings, and to have warnings with an exceptionally low false-positi

Re: [PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

Historically Clang's policy on warnings was, I think, much more conservative than it seems to be today. There was a strong desire not to implement off-by-default warnings, and to have warnings with an exceptionally low false-positive rate - maybe the user-defined operator detection was either assum

[PATCH] D44912: [clang-doc] Removing -Wunused-variable warning

lebedev.ri accepted this revision. lebedev.ri added a comment. LGTM. https://reviews.llvm.org/D44912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36918: [Sema] Take into account the current context when checking the accessibility of a member function pointer

ahatanak added a comment. ping https://reviews.llvm.org/D36918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r328588 - [clang-doc] Removing -Wunused-variable warning

Author: juliehockett Date: Mon Mar 26 15:37:31 2018 New Revision: 328588 URL: http://llvm.org/viewvc/llvm-project?rev=328588&view=rev Log: [clang-doc] Removing -Wunused-variable warning Warning was appearing in release with debug info build, this removes it. Differential Revision: https://review

[PATCH] D44912: [clang-doc] Removing -Wunused-variable warning

This revision was automatically updated to reflect the committed changes. Closed by commit rL328588: [clang-doc] Removing -Wunused-variable warning (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit: https://reviews.llvm.org/D44912

[PATCH] D44912: [clang-doc] Removing -Wunused-variable warning

Eugene.Zelenko added a comment. I think it's fine to commit trivial fixes without going via review. Repository: rL LLVM https://reviews.llvm.org/D44912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D44913: [ObjC] Enable using C++ triviality type traits for non-trivial C structs

ahatanak created this revision. ahatanak added reviewers: rjmccall, doug.gregor, rsmith. r326307 and r327870 made changes that allowed C structs to have __strong and __weak fields in ARC and be non-trivial. This patch make changes that allow using the following type traits for non-trivial C stru

  1   2   >