The problem is that your patch caused the reproducer to trigger an
assert, which it didn't do before, causing our builds to break.
Your patch seems like it does fix the PR, but it can't break currently
working builds.
$ build.release/bin/clang -cc1 -triple i386-pc-windows-msvc19.11.0
-emit-pch -f
Author: hans
Date: Tue Feb 20 01:26:38 2018
New Revision: 325566
URL: http://llvm.org/viewvc/llvm-project?rev=325566&view=rev
Log:
clang-format plugin: Add missing semicolon in list of file extensions (PR36383)
Modified:
cfe/trunk/tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs
Modif
a.sidorin added a comment.
Hello David,
There are still some items for improvement. However, if we move this checker
into 'alpha' category, as Artem pointed, I think it can be accepted for merge
in its current state and improved later.
Repository:
rC Clang
https://reviews.llvm.org/D42645
devnexen updated this revision to Diff 135027.
devnexen added a comment.
Moving back the checker to alpha.security level.
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/MmapWri
djasper added a comment.
Please given an explanation of what you are trying to achieve with this change.
Do you intend to set the penalty high so that clang-format does other things
first before falling back to wrapping template declarations?
Why treat separate declarations differently wrt. wra
Author: hans
Date: Tue Feb 20 02:47:14 2018
New Revision: 325571
URL: http://llvm.org/viewvc/llvm-project?rev=325571&view=rev
Log:
clang-cl: Make /d1PP an alias for -dD (PR36446)
Modified:
cfe/trunk/include/clang/Driver/CLCompatOptions.td
cfe/trunk/test/Driver/cl-options.c
Modified: cfe/
Author: xazax
Date: Tue Feb 20 02:48:38 2018
New Revision: 325572
URL: http://llvm.org/viewvc/llvm-project?rev=325572&view=rev
Log:
[clang-tidy] Replace the usage of std::uncaught_exception with
std::uncaught_exceptions
Patch by: Daniel Kolozsvari!
Differential Revision: https://reviews.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325572: [clang-tidy] Replace the usage of
std::uncaught_exception with std… (authored by xazax, committed by ).
Herald added subscribers: llvm-commits, klimek.
Changed prior to commit:
https://reviews.l
Author: sammccall
Date: Tue Feb 20 03:46:39 2018
New Revision: 325574
URL: http://llvm.org/viewvc/llvm-project?rev=325574&view=rev
Log:
[clangd] Dump stack on crash
Modified:
clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp
Modified: clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp
URL:
lebedev.ri added a comment.
After a brief disscussion with @aaron.ballman in IRC,
the question still stands whether this is really the correct approach,
or is there some nicer (TableGen-based?) approach.
Mainly waiting for @rsmith's opinion.
Repository:
rC Clang
https://reviews.llvm.org/D431
Author: kosarev
Date: Tue Feb 20 04:33:04 2018
New Revision: 325575
URL: http://llvm.org/viewvc/llvm-project?rev=325575&view=rev
Log:
[CodeGen] Fix generation of TBAA tags for may-alias accesses
This patch fixes creating TBAA access descriptors for
may_alias-marked access types. Currently, for su
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325575: [CodeGen] Fix generation of TBAA tags for may-alias
accesses (authored by kosarev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D42366
Files:
lib/CodeGen/CodeGenModule.cpp
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D43487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
Author: hans
Date: Tue Feb 20 04:43:02 2018
New Revision: 325576
URL: http://llvm.org/viewvc/llvm-project?rev=325576&view=rev
Log:
Revert r325375 "[MS] Make constexpr static data members implicitly inline"
This broke Clang bootstrap on Windows, PR36453.
> This handles them exactly the same way t
Reverted in r325576 due to PR36453, and merged the revert to 6.0 in r325577.
On Mon, Feb 19, 2018 at 3:09 PM, Hans Wennborg wrote:
> Merged to 6.0 in r325500.
>
> On Fri, Feb 16, 2018 at 8:44 PM, Reid Kleckner via cfe-commits
> wrote:
>> Author: rnk
>> Date: Fri Feb 16 11:44:47 2018
>> New Revis
aaron.ballman added a comment.
To be clear -- my concerns were mostly that it seems messy for this sort of
thing to require three different diagnostic entries and somewhat convoluted
logic to select them -- if we can find a way to generalize this, that'd be
better.
Repository:
rC Clang
htt
sdardis created this revision.
sdardis added a reviewer: EricWF.
Herald added subscribers: christof, mgorny.
When libcxx is built in tree for a host which requires libatomic, LLVM's
configuration steps will determine it is required and add it to
CMAKE_REQUIRED_LIBRARIES. When libcxx is later confi
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek.
Changes:
o Store both the original header and the canonical header in LSP command.
o Also check that both original and canonical headers are not already in
sammccall added inline comments.
Comment at: clangd/ClangdServer.h:239
+ /// Inserts a new #include into \p File, if it's not present in \p Code.
+ /// \p OriginalHeader The original header corresponding to this insertion.
+ /// This may be different from preferredHeader as a
yvvan added a comment.
ping
https://reviews.llvm.org/D41537
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall added a comment.
Mostly nits around naming/doc: you've convinced me that the two headers that
are paths or uris or at different times is the right thing, but we
need to be really clear about it.
Comment at: clangd/ClangdServer.cpp:320
+S
ping
Rafael Avila de Espindola via Phabricator
writes:
> espindola created this revision.
> espindola added a reviewer: rnk.
>
> The value of dso_local can be computed from just IR properties and global
> information (object file type, command line options, etc).
>
> With this patch we no longe
devnexen updated this revision to Diff 135067.
devnexen added a comment.
Updating tests accordingly
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp
te
ilya-biryukov added a comment.
Sorry for not getting back on this earlier.
I wanted to discuss whether returning correction as a enum value is a proper
interface for users of `libclang`.
It seems easy to replace `.` with `->` inside clang, properly handling all the
tricky cases (tokens coming f
miyuki added a comment.
In https://reviews.llvm.org/D42545#1010335, @rogfer01 wrote:
> Do you plan to submit (in another change) the unscoped enum → integer type
> testcases? If this is not currently tested anywhere I think it may be a good
> thing to have them too.
Yes, I'll submit them in a
Athosvk added a comment.
The changes seem good (both mapper and additional changes)! I've added some
comments, but those are primarily details.
What I'm however primarily interested in is the following:
1. You seemingly output only little information for declarations that are not
definition. I
Author: kamil
Date: Tue Feb 20 08:27:28 2018
New Revision: 325593
URL: http://llvm.org/viewvc/llvm-project?rev=325593&view=rev
Log:
Stop linking sanitized applications with -lutil and -lkvm on NetBSD
The proper approach is to rebuild libutil and libkvm with a desired sanitizer.
An alternative app
Author: dblaikie
Date: Tue Feb 20 08:35:08 2018
New Revision: 325594
URL: http://llvm.org/viewvc/llvm-project?rev=325594&view=rev
Log:
PR36442: Correct description of -fsplit-dwarf-inlining
Modified:
cfe/trunk/include/clang/Driver/Options.td
Modified: cfe/trunk/include/clang/Driver/Options.t
juliehockett added a comment.
> 2. I've mentioned it before as a comment, but to what extent will you be
> parsing information in this frontend? Currently the links between types are
> primarily stored as strings. Are you planning to have the backend that
> generates the MarkDown parse those st
ioeric added inline comments.
Comment at: clangd/ClangdServer.h:243
+ /// string quoted with <> or "" that can be #included directly.
+ /// \p PreferredHeader The preferred header to be inserted. The has the same
+ /// semantic as \p OriginalHeader. If empty, \p OriginalHeader
ioeric updated this revision to Diff 135074.
ioeric marked 16 inline comments as done.
ioeric added a comment.
- Addressed review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43510
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
carlo.bertolli created this revision.
carlo.bertolli added a reviewer: ABataev.
Herald added a subscriber: guansong.
This is a bug fix that removes the emission of reduction support for pragma
'distribute' when found alone or in combinations without simd.
Pragma 'distribute' does not have a reduc
espindola created this revision.
espindola added a reviewer: rnk.
Herald added subscribers: eraman, javed.absar.
With this there are still some GVs where we don't set dso_local because
setGVProperties is never called. I intend to fix that in followup commits. This
is just the bare minimum to tea
ABataev added a comment.
Tests?
Repository:
rC Clang
https://reviews.llvm.org/D43513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
m.ostapenko added a comment.
In https://reviews.llvm.org/D16403#1011218, @NoQ wrote:
> In https://reviews.llvm.org/D16403#1010096, @szepet wrote:
>
> > In https://reviews.llvm.org/D16403#992454, @NoQ wrote:
> >
> > > @szepet: so i see that `LoopExit` goes in the beginning of the cleanup
> > > bl
hfinkel added a comment.
In https://reviews.llvm.org/D42366#1012211, @rjmccall wrote:
> I'm fine with that plan. LGTM.
Thanks.
We should probably discuss what we want to do with unknown-sized things.
UINT64_MAX is the conservative answer, but maybe there's some value in just
having 0 mean "
m.ostapenko added a comment.
In https://reviews.llvm.org/D16403#1001466, @NoQ wrote:
> I poked Devin offline and we agreed that the overall approach is good to go.
> Maxim, thank you for picking it up!
>
> We still don't have scopes for segments of code that don't have any variables
> in them,
NoQ added a comment.
In https://reviews.llvm.org/D16403#1013346, @m.ostapenko wrote:
> In https://reviews.llvm.org/D16403#1011218, @NoQ wrote:
>
> > Yeah, i mean, like, if we change the scope markers to also appear even when
> > no variables are present in the scope, then it would be possible to
tra added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:4659
if (IsCuda) {
-// Host-side cuda compilation receives device-side outputs as Inputs[1...].
-// Include them with -fcuda-include-gpubinary.
+// Host-side cuda compilation receives device-sid
Hahnfeld added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:1044-1045
- Opts.CudaGpuBinaryFileNames =
- Args.getAllArgValues(OPT_fcuda_include_gpubinary);
+ Opts.CudaGpuBinaryFileName =
+ Args.getLastArgValue(OPT_fcuda_include_gpubinary);
-
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:15
+#include "../utils/LexerUtils.h"
+
Please place it on a top, since header belong to project.
Comment at: clang-tidy/modernize/UseDefaultM
tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Frontend/CompilerInvocation.cpp:1044-1045
- Opts.CudaGpuBinaryFileNames =
- Args.getAllArgValues(OPT_fcuda_include_gpubinary);
+ Opts.CudaGpuBinaryFile
Author: erichkeane
Date: Tue Feb 20 10:44:50 2018
New Revision: 325610
URL: http://llvm.org/viewvc/llvm-project?rev=325610&view=rev
Log:
Correct multiversion unsupported target behavior, add a test.
Multiversioning SEMA failed to set the declaration as invalid on unsupported
targets. This patch
Hahnfeld added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:1044-1045
- Opts.CudaGpuBinaryFileNames =
- Args.getAllArgValues(OPT_fcuda_include_gpubinary);
+ Opts.CudaGpuBinaryFileName =
+ Args.getLastArgValue(OPT_fcuda_include_gpubinary);
-
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, ioeric, jkorous-apple, klimek.
Through the C++ API, we support for a given snapshot version:
- Yes: make sure we generate diagnostics for exactly this version
- Auto: generate eventu
vsapsai added inline comments.
Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:2969
+if (!DD && RD->isBeingDefined())
+ return nullptr;
aprantl wrote:
> Perhaps add a comment explaining what's going on in this early exit?
While I was trying to ex
yaxunl updated this revision to Diff 135109.
yaxunl added a comment.
Extends NeedsCopy of CallArg for indirect byval arguments.
https://reviews.llvm.org/D34367
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGCall.h
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGObjCGNU.cpp
aaron.ballman added a comment.
> It seems, when they are apply directly from clang-tidy, the RefactoringTool
> engine is smart enough to remove trailing tokens. However, when fixes are
> exported, clang-apply-replacements cannot do the same trick and will lead
> trailing commas and colon
Is th
Author: simark
Date: Tue Feb 20 08:57:47 2018
New Revision: 325596
URL: http://llvm.org/viewvc/llvm-project?rev=325596&view=rev
Log:
[clangd] Fix formatting in XRefs.cpp
This is also to test my commit access.
Modified:
clang-tools-extra/trunk/clangd/XRefs.cpp
Modified: clang-tools-extra/tr
mgrang updated this revision to Diff 135112.
mgrang added a comment.
Updated patch to add -fno version of the flag -fforce-enable-int128.
Repository:
rC Clang
https://reviews.llvm.org/D43105
Files:
include/clang/Basic/TargetInfo.h
include/clang/Basic/TargetOptions.h
include/clang/Drive
russellmcc added a comment.
Bumping again - thanks so much for your time!
https://reviews.llvm.org/D40988
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kcc added a comment.
We use function attributes in similar situations for asan/tsan/msan.
Similar, but not equivalent, so I don't know if we must follow the same pattern
here.
The difference here is that we should keep the ability to turn optimization on
and off from command line, regardless o
malcolm.parsons added a comment.
In https://reviews.llvm.org/D43500#1013497, @aaron.ballman wrote:
> Is there a way to make clang-apply-replacements smarter rather than forcing
> every check to jump through hoops? I'm worried that if we have to fix
> individual checks we'll just run into the sa
benhamilton created this revision.
benhamilton added a reviewer: jolesiak.
Herald added subscribers: cfe-commits, klimek.
benhamilton added a reviewer: krasimir.
For clients which don't have a filesystem, calling getStyle() doesn't
make much sense (there's no .clang-format files to search for).
I
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Please post a follow-up to add this to the 7.0 release notes.
Repository:
rC Clang
https://reviews.llvm.org/D43105
___
cfe-commits m
Author: tra
Date: Tue Feb 20 13:25:30 2018
New Revision: 325626
URL: http://llvm.org/viewvc/llvm-project?rev=325626&view=rev
Log:
[CUDA] Added missing __threadfence_system() function for CUDA9.
Modified:
cfe/trunk/lib/Headers/__clang_cuda_device_functions.h
Modified: cfe/trunk/lib/Headers/__
Hello,
Please see https://reviews.llvm.org/D42968
For the fix of the assertion belwo.
Thanks.
-Original Message-
From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans
Wennborg
Sent: Tuesday, February 20, 2018 4:04 AM
To: Ammarguellat, Zahira
Cc: cfe-commits
Subject
tmsriram updated this revision to Diff 135144.
tmsriram added a comment.
Updated patch.
https://reviews.llvm.org/D42217
Files:
lib/CodeGen/CodeGenModule.cpp
test/CodeGen/noplt.c
Index: test/CodeGen/noplt.c
===
--- test/CodeGe
Author: erichkeane
Date: Tue Feb 20 14:25:28 2018
New Revision: 325633
URL: http://llvm.org/viewvc/llvm-project?rev=325633&view=rev
Log:
[NFC] In Multiversion Check function, switch to return Diag
This function did a lot of 'Diag, return true' stuff. This resulted in needing
to introduce scopes
vsapsai added inline comments.
Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:2969
+if (!DD && RD->isBeingDefined())
+ return nullptr;
vsapsai wrote:
> aprantl wrote:
> > Perhaps add a comment explaining what's going on in this early exit?
> Whi
Author: rsmith
Date: Tue Feb 20 15:17:41 2018
New Revision: 325640
URL: http://llvm.org/viewvc/llvm-project?rev=325640&view=rev
Log:
When multiple sanitizers are enabled (ubsan + something else), use all relevant
blacklists.
Ideally, we'd only use the ubsan blacklist for ubsan sanitizers, and on
simark updated this revision to Diff 135153.
simark added a comment.
New version, take 2
The previous version contains the changes of already merged patches, I'm not
sure what I did wrong. This is another try.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D39571
Files:
clan
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs, mgorny.
NoQ added a dependency: D43497: [analyzer] Introduce correct lifetime extension
behavior in simple cases..
`ConstructionContext` is m
NoQ updated this revision to Diff 135154.
NoQ added a comment.
Remove unused methods.
https://reviews.llvm.org/D43533
Files:
include/clang/Analysis/CFG.h
include/clang/Analysis/ConstructionContext.h
lib/Analysis/CFG.cpp
lib/Analysis/CMakeLists.txt
lib/Analysis/ConstructionContext.cpp
Author: rsmith
Date: Tue Feb 20 15:47:12 2018
New Revision: 325646
URL: http://llvm.org/viewvc/llvm-project?rev=325646&view=rev
Log:
Fix assert when template argument deduction's original call arg checking
triggers class template instantiation.
Added:
cfe/trunk/test/SemaTemplate/temp_arg_pac
Author: sdardis
Date: Tue Feb 20 16:05:05 2018
New Revision: 325651
URL: http://llvm.org/viewvc/llvm-project?rev=325651&view=rev
Log:
[mips] Spectre variant two mitigation for MIPSR2
This patch provides mitigation for CVE-2017-5715, Spectre variant two,
which affects the P5600 and P6600. It provi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325651: [mips] Spectre variant two mitigation for MIPSR2
(authored by sdardis, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43487
Files:
cfe
Author: ctopper
Date: Tue Feb 20 16:16:50 2018
New Revision: 325655
URL: http://llvm.org/viewvc/llvm-project?rev=325655&view=rev
Log:
[X86] Disable CLWB in Cannon Lake
Cannon Lake does not support CLWB, therefore it
does not include all features listed under SKX.
Patch by Gabor Buella
Different
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325655: [X86] Disable CLWB in Cannon Lake (authored by
ctopper, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43459
Files:
cfe/trunk/lib/Basi
juliehockett updated this revision to Diff 135168.
juliehockett marked 13 inline comments as done.
juliehockett added a comment.
1. Updating mapper keys to use USRs instead of names
2. Also updating internal representation to use USRs instead of names
3. Renaming files (getting rid of the ClangDoc
juliehockett added a comment.
In https://reviews.llvm.org/D41102#1011299, @lebedev.ri wrote:
> I don't know the protocol, but i think it might be a good idea
> to add a new entry to `CODE_OWNERS.TXT` for `clang-doc`?
>
> `clang-doc` going to be quite distinctive, and bigger/complicated
> than w
rsmith added inline comments.
Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:2969
+if (!DD && RD->isBeingDefined())
+ return nullptr;
vsapsai wrote:
> vsapsai wrote:
> > aprantl wrote:
> > > Perhaps add a comment explaining what's going on in th
juliehockett created this revision.
juliehockett added reviewers: aaron.ballman, hokein, alexfh.
juliehockett added a project: clang-tools-extra.
Herald added a subscriber: xazax.hun.
Updating the run-clang-tidy.py script to allow specification of the config
argument to the clang-tidy invocation.
sunfish created this revision.
sunfish added a reviewer: sbc100.
Herald added subscribers: llvm-commits, aheejin, jfb.
WebAssembly, the architecture, is not designed to support unprototyped calling
conventions. For example, clang tends to assume that it can use varargs to
implement parts of the
vsapsai updated this revision to Diff 135179.
vsapsai added a comment.
- Set `D->DefinitionData` early.
We already call `MergeDefinitionData` after definition data deserialization is
complete. And I removed previously added `IsBeingDefined`, so left the "all the
bits must match" checks in `MergeD
sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.
Might want to line wrap your change description.
Repository:
rL LLVM
https://reviews.llvm.org/D43540
___
cfe-commits mailing list
cfe-commits@
sbc100 added a comment.
Hmm.. actually this is probably going to break the waterfall pretty badly.
But maybe we can fix it by re-disabling this explicitly when we build the gcc
tests.
Repository:
rL LLVM
https://reviews.llvm.org/D43540
___
c
juliehockett updated this revision to Diff 135181.
juliehockett marked 10 inline comments as done.
juliehockett added a comment.
Updating check to allow for #pragma and command line visibility specs, and
updating tests
https://reviews.llvm.org/D43392
Files:
clang-tidy/fuchsia/AddVisibilityCh
juliehockett added inline comments.
Comment at: clang-tidy/fuchsia/AddVisibilityCheck.cpp:68
+ diag(MatchedDecl->getLocStart(),
+ "visibility attribute not set for specified function")
+ << MatchedDecl
aaron.ballman wrote:
> jakehehrlich w
Author: eugenezelenko
Date: Tue Feb 20 17:45:26 2018
New Revision: 325659
URL: http://llvm.org/viewvc/llvm-project?rev=325659&view=rev
Log:
[Sema] Fix some Clang-tidy modernize and Include What You Use warnings; other
minor fixes (NFC).
Modified:
cfe/trunk/include/clang/Sema/DelayedDiagnosti
efriedma added a comment.
If someone is compiling C code that doesn't have undefined behavior, it should
work; if it doesn't, that's a clear bug. (As far as I know, there shouldn't be
any issues here, but if there are, file a bug and CC me.)
WebAssembly is not the only platform where varargs a
Author: sepavloff
Date: Tue Feb 20 18:02:39 2018
New Revision: 325661
URL: http://llvm.org/viewvc/llvm-project?rev=325661&view=rev
Log:
Clean up use of C allocation functions
If the value returned by `malloc`, `calloc` or `realloc` is not checked
for null pointer, this change replaces them for `s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325661: Clean up use of C allocation functions (authored by
sepavloff, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43017?vs=133201&id=1351
Author: malaperle
Date: Tue Feb 20 18:39:08 2018
New Revision: 325662
URL: http://llvm.org/viewvc/llvm-project?rev=325662&view=rev
Log:
[clangd] #include statements support for Open definition
Summary: ctrl-clicking on #include statements now opens the file being pointed
by that statement.
Revi
NoQ updated this revision to Diff 135186.
NoQ added a comment.
Add one more FIXME test (`dont_forget_destructor_around_logical_op` in
`temporaries.cpp`) which demonstrates a situation where we fail to call the
temporary destructor after calling the temporary constructor. It should be
fixed once
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325662: [clangd] #include statements support for Open
definition (authored by malaperle, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D38639
dcoughlin added a comment.
This looks great to me Artem! I'll be very curious to see how you extend this
to handle initializer lists.
Comment at: lib/Analysis/CFG.cpp:4737
+}
+case ConstructionContext::SimpleVariableKind: {
+ const auto *DSCC = cast(CC
Author: rsmith
Date: Tue Feb 20 19:38:30 2018
New Revision: 325663
URL: http://llvm.org/viewvc/llvm-project?rev=325663&view=rev
Log:
In C++14 onwards, it is permitted to read mutable members in constant
expressions, if their lifetime began during the evaluation of the expression.
This is technica
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Looks good to me. I have a comment about simplifying
createTemporaryRegionIfNeeded() (if possible) inline.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:281
+
+
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
It seems kind of sketchy to me that we're recursing over an expression to find
construction contexts and then later doing it again for sub-expressions. I
guess there is precedent here wi
phosek created this revision.
phosek added reviewers: mcgrathr, jakehehrlich.
Herald added a subscriber: cfe-commits.
We never want to generate common symbols on Fuchsia.
Repository:
rC Clang
https://reviews.llvm.org/D43545
Files:
clang/lib/Driver/ToolChains/Clang.cpp
clang/test/Driver/f
Author: phosek
Date: Tue Feb 20 20:39:15 2018
New Revision: 325665
URL: http://llvm.org/viewvc/llvm-project?rev=325665&view=rev
Log:
[Fuchsia] Include libClang and clang-include-fixer in the toolchain
libClang is used by other Clang based tools such as cquery while
clang-include-fixer is generall
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325665: [Fuchsia] Include libClang and clang-include-fixer
in the toolchain (authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43404?vs=134687&id=135195#toc
Reposit
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D43477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
This seems reasonable to me.
https://reviews.llvm.org/D43483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
djasper added a comment.
In https://reviews.llvm.org/D43290#1008647, @Typz wrote:
> Tweaking the penalty handling would still be needed in any case, since the
> problem happens also when Cpp11BracedListStyle is true (though the effect is
> more subtle)
I don't understand this. Which style do
96 matches
Mail list logo
