[PATCH] D43110: [Sema] Don't mark plain MS enums as fixed

rnk updated this revision to Diff 133670. rnk added a comment. - Add test, update comments https://reviews.llvm.org/D43110 Files: clang/include/clang/AST/Decl.h clang/include/clang/Sema/Sema.h clang/lib/AST/Type.cpp clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaTemplateInstantiateDec

[PATCH] D43110: [Sema] Don't mark plain MS enums as fixed

rnk added a comment. In https://reviews.llvm.org/D43110#1003171, @thakis wrote: > Nice! > > Test? Yeah, I forgot to get that in. From the test you can see that we have weirdly different behavior in C and C++ mode. Do people care? This is pre-existing behavior. My change makes the enum "unfixe

[PATCH] D43104: [analyzer] Find correct region for simple temporary destructor calls and inline them if possible.

NoQ updated this revision to Diff 133672. NoQ marked an inline comment as done. NoQ added a comment. Assert that the destructors are cleaned up. This assertion is pretty important because it says that we didn't miss any destructors for initialized temporaries during analysis. Disable tracking i

[PATCH] D43089: clang: Add ARCTargetInfo

petecoup updated this revision to Diff 133674. petecoup added a comment. Hello Eugene, Thanks for taking a look. Changed // End anonymous namespace. -> // namespace https://reviews.llvm.org/D43089 Files: clang/lib/Basic/CMakeLists.txt clang/lib/Basic/Targets.cpp clang/lib/Basic/Targets/A

[PATCH] D42779: [analyzer] NFC: Make sure we don't ever inline the constructor for which the temporary destructor is noreturn and missing.

NoQ updated this revision to Diff 133675. NoQ marked an inline comment as done. NoQ added a comment. Add the comment. https://reviews.llvm.org/D42779 Files: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp Index: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp ===

r324776 - [CodeGen] Use the zero initializer instead of storing an all zero representation.

Author: mattd Date: Fri Feb 9 14:10:09 2018 New Revision: 324776 URL: http://llvm.org/viewvc/llvm-project?rev=324776&view=rev Log: [CodeGen] Use the zero initializer instead of storing an all zero representation. Summary: This change avoids the overhead of storing, and later crawling, an initia

[PATCH] D42549: [CodeGen] Use the zero initializer instead of storing an all zero representation.

This revision was automatically updated to reflect the committed changes. Closed by commit rC324776: [CodeGen] Use the zero initializer instead of storing an all zero… (authored by mattd, committed by ). Repository: rC Clang https://reviews.llvm.org/D42549 Files: lib/CodeGen/CGExprConstant.

[PATCH] D43144: [analyzer] Implement path notes for temporary destructors.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. Temporaries are destroyed at the end of their `CXXBindTemporaryExpr`, which can be picked up from their `CFGTemporaryDtor`. Note that lifetim

[PATCH] D43144: [analyzer] Implement path notes for temporary destructors.

NoQ updated this revision to Diff 133687. NoQ added a comment. Minor indent fix. https://reviews.llvm.org/D43144 Files: lib/StaticAnalyzer/Core/PathDiagnostic.cpp test/Analysis/inlining/temp-dtors-path-notes.cpp Index: test/Analysis/inlining/temp-dtors-path-notes.cpp =

[PATCH] D43089: clang: Add ARCTargetInfo

tatyana-krasnukha added a comment. Hello Pete, Thank you for upstreaming ARC target to clang! I checked it in couple with lldb - works well. So, the revision is good to me. But it seems, I have no rights to accept revisions yet... https://reviews.llvm.org/D43089 ___

[PATCH] D43144: [analyzer] Implement path notes for temporary destructors.

george.karpenkov accepted this revision. george.karpenkov added inline comments. This revision is now accepted and ready to land. Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:586 +// they'd be dealt with via an AutomaticObjectDtor instead. +const CFGTemporaryDto

[PATCH] D43089: clang: Add ARCTargetInfo

petecoup added a comment. Hi Tatyana, Thanks for checking against lldb! I will try and find a couple of people who can review this as a clang change. Pete https://reviews.llvm.org/D43089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D43144: [analyzer] Implement path notes for temporary destructors.

NoQ added inline comments. Comment at: test/Analysis/inlining/temp-dtors-path-notes.cpp:17 +// expected-note@-2{{Returning from constructor for 'C'}} +// expected-note@-3{{Calling '~C'}} +} george.karpenkov wrote: > Should we have "returning from

[PATCH] D43144: [analyzer] Implement path notes for temporary destructors.

NoQ added a comment. Another question is why do we have such inconsistency between `Calling constructor for 'C'` and `Calling '~C'`, i.e. why not `Calling destructor for 'C'`. Seems accidental. https://reviews.llvm.org/D43144 ___ cfe-commits maili

[PATCH] D43144: [analyzer] Implement path notes for temporary destructors.

NoQ updated this revision to Diff 133692. NoQ added a comment. Add a test for returning from destructor. https://reviews.llvm.org/D43144 Files: lib/StaticAnalyzer/Core/PathDiagnostic.cpp test/Analysis/inlining/temp-dtors-path-notes.cpp Index: test/Analysis/inlining/temp-dtors-path-notes.

[PATCH] D43089: clang: Add ARCTargetInfo

tatyana-krasnukha added a comment. This is what I could note Comment at: clang/lib/Basic/Targets/ARC.h:26 +class LLVM_LIBRARY_VISIBILITY ARCTargetInfo : public TargetInfo { + static const Builtin::Info BuiltinInfo[]; + Looks like unused member, while getTarget

r324780 - [NFC] Extract method to SourceManager for traversing the macro "stack"

Author: george.karpenkov Date: Fri Feb 9 15:30:07 2018 New Revision: 324780 URL: http://llvm.org/viewvc/llvm-project?rev=324780&view=rev Log: [NFC] Extract method to SourceManager for traversing the macro "stack" The code for going up the macro arg expansion is duplicated in many places (and we

[PATCH] D42458: [NFC] Extract method to SourceManager for traversing the macro "stack"

This revision was automatically updated to reflect the committed changes. Closed by commit rL324780: [NFC] Extract method to SourceManager for traversing the macro "stack" (authored by george.karpenkov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D42458: [NFC] Extract method to SourceManager for traversing the macro "stack"

This revision was automatically updated to reflect the committed changes. Closed by commit rC324780: [NFC] Extract method to SourceManager for traversing the macro "stack" (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://review

[PATCH] D43148: Adding msan support for FreeBSD

devnexen created this revision. devnexen added a reviewer: krytarowski. devnexen created this object with visibility "All Users". Herald added subscribers: cfe-commits, emaste. Enabling memory sanitiser for X86_64 arch only. To match the sanitiser counterpart. Repository: rC Clang https://re

r324785 - [analyzer] Introduce statistics for the total number of visited basic blocks

Author: george.karpenkov Date: Fri Feb 9 15:37:47 2018 New Revision: 324785 URL: http://llvm.org/viewvc/llvm-project?rev=324785&view=rev Log: [analyzer] Introduce statistics for the total number of visited basic blocks Differential Revision: https://reviews.llvm.org/D43133 Modified: cfe/tru

[PATCH] D43149: [analyzer] Fix a crash on destroying a temporary array.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. Tried to actually run the analyzer with temporary destructor support on some real code, found two crashes for now - https://reviews.llvm.org/

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 133714. juliehockett marked 6 inline comments as done. juliehockett added a comment. 1. Implementing the bitstream decoder (and fixing the encoder) 2. Setting up new tests for the mapper output 3. Fixing comments https://reviews.llvm.org/D41102 Files:

[PATCH] D43149: [analyzer] Fix a crash on destroying a temporary array.

NoQ updated this revision to Diff 133718. NoQ added a comment. > And even then, calling a destructor of a single array element does not > invalidate the whole array for us, because destructors are `const` (unless > there are mutable members). So we'd have to do this manually later as well. Hmm,

r324789 - [analyzer] Add support for __builtin_constant_p.

Author: dergachev Date: Fri Feb 9 16:51:47 2018 New Revision: 324789 URL: http://llvm.org/viewvc/llvm-project?rev=324789&view=rev Log: [analyzer] Add support for __builtin_constant_p. This builtin is evaluated in compile time. But in the analyzer we don't yet automagically evaluate all calls tha

[PATCH] D42745: [analyzer] Add support for __builtin_constant_p to BuiltinFunctionChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rC324789: [analyzer] Add support for __builtin_constant_p. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D42745 Files: lib/StaticAnalyzer/Checkers/BuiltinFuncti

[PATCH] D42745: [analyzer] Add support for __builtin_constant_p to BuiltinFunctionChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rL324789: [analyzer] Add support for __builtin_constant_p. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42745?vs=1334

r324790 - [analyzer] Add missing pre-post-statement callbacks for OffsetOfExpr.

Author: dergachev Date: Fri Feb 9 16:55:49 2018 New Revision: 324790 URL: http://llvm.org/viewvc/llvm-project?rev=324790&view=rev Log: [analyzer] Add missing pre-post-statement callbacks for OffsetOfExpr. This expression may or may not be evaluated in compile time, so tracking the result symbol

[PATCH] D42300: [Analyzer] Add PreStmt and PostStmt callbacks for OffsetOfExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL324790: [analyzer] Add missing pre-post-statement callbacks for OffsetOfExpr. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D42310: Formalize FreeBSD support of compiler rt

trixirt added a comment. I think it is overkill to look for fbsd 8, it was eol-ed 2015, and 9 in 2016. A native build of clang 7 on fbsd 8 would be difficult to pull off, needing at least 1-3 intermediate clang's/gcc's Repository: rC Clang https://reviews.llvm.org/D42310

Buildbot numbers for the week of 1/21/2018 - 1/27/2018

Hello everyone, Below are some buildbot numbers for the week of 1/21/2018 - 1/27/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to r

Buildbot numbers for the last week of 1/28/2018 - 2/03/2018

Hello everyone, Below are some buildbot numbers for the last week of 1/28/2018 - 2/03/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 133726. juliehockett added a comment. Updating documentation https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/CMakeLists.txt clang-doc/ClangDoc.cpp clang-doc/ClangDoc.h clang-doc/ClangDocBinary.cpp clang-doc/ClangDocBinary.h

[PATCH] D42310: Formalize FreeBSD support of compiler rt

trixirt added a comment. The symlinks were useful in the transition from gcc to clang. Now they don't serve any purpose. Clang uses libcompiler_rt, not libgcc. Repository: rC Clang https://reviews.llvm.org/D42310 ___ cfe-commits mailing list cfe-

[PATCH] D42920: [CUDA] Fix test cuda-external-tools.cu

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: test/Driver/cuda-external-tools.cu:11 +// RUN: | FileCheck -check-prefix CHECK -check-prefix ARCH64 \ +// RUN: -check-prefix SM20 -check-prefix OPT0 %s

[PATCH] D42921: [CUDA] Add option to generate relocatable device code

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Driver/Options.td:572 + HelpText<"Generate relocatable device code, also known as separate compilation mode.">; +def fno_cuda_rdc : Flag<["-"], "fno

r324793 - [analyzer] Serialize statistics to plist when serialize-stats=true is set

Author: george.karpenkov Date: Fri Feb 9 17:49:20 2018 New Revision: 324793 URL: http://llvm.org/viewvc/llvm-project?rev=324793&view=rev Log: [analyzer] Serialize statistics to plist when serialize-stats=true is set Differential Revision: https://reviews.llvm.org/D43131 Added: cfe/trunk/tes

[PATCH] D43131: [analyzer] Serialize statistics to plist when serialize-stats=true is set

This revision was automatically updated to reflect the committed changes. Closed by commit rC324793: [analyzer] Serialize statistics to plist when serialize-stats=true is set (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://

[PATCH] D43110: [Sema] Don't mark plain MS enums as fixed

rsmith accepted this revision. rsmith added a comment. Thanks! I'd noticed this weirdness but wasn't sure what we could do about it without breaking MS compat. I like this approach a lot. If we want to change the C behavior too, I think that should be a separate change. How does MSVC behave in

r324794 - [CFG] Add construction context for simple variable declarations.

Author: dergachev Date: Fri Feb 9 17:55:23 2018 New Revision: 324794 URL: http://llvm.org/viewvc/llvm-project?rev=324794&view=rev Log: [CFG] Add construction context for simple variable declarations. Constructors of simple variables now can be queried to discover that they're constructing into s

[PATCH] D41316: [libcxx] Allow random_device to be built optionally

EricWF added a comment. I think the direction here is OK. Although I really hate allowing bits of libc++ to be "optional". In this case it should be OK, but often it makes the library trickier to maintain -- and these configurations often go untested between releases. Commen

[PATCH] D41316: [libcxx] Allow random_device to be built optionally

EricWF added inline comments. Comment at: test/std/experimental/filesystem/lit.local.cfg:5 + +# filesystem_test_helper uses random_device to generate random path. +if 'libcpp-has-no-random-device' in config.available_features: EricWF wrote: > I would rather keep

[PATCH] D41316: [libcxx] Allow random_device to be built optionally

EricWF added inline comments. Comment at: test/std/experimental/filesystem/lit.local.cfg:5 + +# filesystem_test_helper uses random_device to generate random path. +if 'libcpp-has-no-random-device' in config.available_features: EricWF wrote: > EricWF wrote: > > I

r324796 - [CFG] Add construction context for constructor initializers.

Author: dergachev Date: Fri Feb 9 18:18:04 2018 New Revision: 324796 URL: http://llvm.org/viewvc/llvm-project?rev=324796&view=rev Log: [CFG] Add construction context for constructor initializers. CFG elements for constructors of fields and base classes that are being initialized before the body

r324798 - [CFG] Provide construction contexts when constructors have cleanups.

Author: dergachev Date: Fri Feb 9 18:46:14 2018 New Revision: 324798 URL: http://llvm.org/viewvc/llvm-project?rev=324798&view=rev Log: [CFG] Provide construction contexts when constructors have cleanups. Now that we make it possible to query the CFG constructor element to find information about

[PATCH] D42721: [analyzer] NFC: Use construction contexts for finding the target region for the construction.

NoQ updated this revision to Diff 133732. NoQ added a comment. Rebase. https://reviews.llvm.org/D42721 Files: include/clang/Analysis/CFG.h include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h lib/StaticAnalyzer/Core/ExprEngineCXX.cpp Index: lib/StaticAnalyzer/Core/ExprEngineCXX.c

[PATCH] D42719: [CFG] [analyzer] Add construction context when constructor is wrapped into ExprWithCleanups.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL324798: [CFG] Provide construction contexts when constructors have cleanups. (authored by dergachev, committed by ). Heral

[PATCH] D42344: [libc++] Use multi-key tree search for {map, set}::{count, equal_range}

EricWF closed this revision. EricWF added a comment. Committed as r324799. Thank you! https://reviews.llvm.org/D42344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r324799 - Use multi-key tree search for {map, set}::{count, equal_range}

Author: ericwf Date: Fri Feb 9 18:53:47 2018 New Revision: 324799 URL: http://llvm.org/viewvc/llvm-project?rev=324799&view=rev Log: Use multi-key tree search for {map, set}::{count, equal_range} Patch from ngolovl...@gmail.com Reviewed as: https://reviews.llvm.org/D42344 As described in llvm.or

r324800 - [analyzer] NFC: Use CFG construction contexts instead of homemade lookahead.

Author: dergachev Date: Fri Feb 9 18:55:08 2018 New Revision: 324800 URL: http://llvm.org/viewvc/llvm-project?rev=324800&view=rev Log: [analyzer] NFC: Use CFG construction contexts instead of homemade lookahead. The analyzer was relying on peeking the next CFG element during analysis whenever it

[PATCH] D42721: [analyzer] NFC: Use construction contexts for finding the target region for the construction.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL324800: [analyzer] NFC: Use CFG construction contexts instead of homemade lookahead. (authored by dergachev, committed by

r324801 - [analyzer] Fix a merge error in -analyzer-config tests.

Author: dergachev Date: Fri Feb 9 19:04:59 2018 New Revision: 324801 URL: http://llvm.org/viewvc/llvm-project?rev=324801&view=rev Log: [analyzer] Fix a merge error in -analyzer-config tests. It was introduced when two -analyzer-config options were added almost simultaneously in r324793 and r3246

[PATCH] D43153: [clang] Implement P0692 "Access Checking on Specializations"

AntonBikineev created this revision. AntonBikineev added reviewers: rsmith, lebedev.ri. This is an attempt to implement P0692 Please note a couple of things: 1. given that clang already suppresses access checks on explicit s

r324802 - [analyzer] NFC: Assert that our fix for noreturn destructors keeps working.

Author: dergachev Date: Fri Feb 9 19:14:22 2018 New Revision: 324802 URL: http://llvm.org/viewvc/llvm-project?rev=324802&view=rev Log: [analyzer] NFC: Assert that our fix for noreturn destructors keeps working. Massive false positives were known to be caused by continuing the analysis after a de

[PATCH] D42779: [analyzer] NFC: Make sure we don't ever inline the constructor for which the temporary destructor is noreturn and missing.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324802: [analyzer] NFC: Assert that our fix for noreturn destructors keeps working. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D43153: [clang] Implement P0692 "Access Checking on Specializations"

rsmith added a comment. How do you avoid suppressing diagnostics in the declaration of a template that is not a partial specialization? For example: class A { class B {}; }; template A::B x; // error, but... template A::B x; // ok! I would expect you'd need to delay the access checking di

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

EricWF added a comment. Some initial thoughts. @mclow.lists Are you planning on moving forward with your implementation as well? Comment at: include/charconv:89 +_LIBCPP_BEGIN_NAMESPACE_STD + +enum class _LIBCPP_ENUM_VIS chars_format We need to hide these nam

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

EricWF added a comment. @lichray I should have mentioned: Although this header is C++17 only, the bits compiled into the dylib need to compile as C++11 still. Repository: rCXX libc++ https://reviews.llvm.org/D41458 ___ cfe-commits mailing list c

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray added a comment. I will pick up the changes later next week. Comment at: include/charconv:89 +_LIBCPP_BEGIN_NAMESPACE_STD + +enum class _LIBCPP_ENUM_VIS chars_format EricWF wrote: > We need to hide these names when `_LIBCPP_STD_VER < 17`, since we're no

<    1   2