george.karpenkov accepted this revision.
george.karpenkov added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:586
+ // they'd be dealt with via an AutomaticObjectDtor instead.
+ const CFGTemporaryDtor &Dtor = Source.castAs<CFGTemporaryDtor>();
+ return PathDiagnosticLocation::createEnd(Dtor.getBindTemporaryExpr(), SM,
----------------
auto?
================
Comment at: test/Analysis/inlining/temp-dtors-path-notes.cpp:17
+ // expected-note@-2{{Returning from constructor for 'C'}}
+ // expected-note@-3{{Calling '~C'}}
+}
----------------
Should we have "returning from ~C"? At least we do have it for inlined
functions.
https://reviews.llvm.org/D43144
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
