yvvan added a comment.
Ping!!!
https://reviews.llvm.org/D41537
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
Herald added subscribers: hintonda, ioeric, jkorous-apple.
LGTM.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41454
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D42428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Author: teemperor
Date: Wed Jan 24 01:40:16 2018
New Revision: 323310
URL: http://llvm.org/viewvc/llvm-project?rev=323310&view=rev
Log:
Refactor RecursiveASTVisitor test for post-order traversal
Summary:
The new test is now in the right directory with the other ASTVisitor tests and
uses
now the
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323310: Refactor RecursiveASTVisitor test for post-order
traversal (authored by teemperor, committed by ).
Herald added a
teemperor updated this revision to Diff 131204.
teemperor added a comment.
Herald added a subscriber: hintonda.
- Rebased and clang formatted.
https://reviews.llvm.org/D37557
Files:
unittests/AST/CMakeLists.txt
unittests/AST/PostOrderASTVisitor.cpp
unittests/Tooling/CMakeLists.txt
unitt
ilya-biryukov added a comment.
Hi @simark , thanks for picking up this change.
Comment at: clangd/ClangdLSPServer.cpp:302
+// FIXME: This function needs to be properly tested.
+void ClangdLSPServer::onChangeConfiguration(
Are you planning to to address this F
krasimir added a comment.
So, we found out other cases where this is especially painful:
- breaking long URLs into multiple lines
- updating the text of a paragraph and breaking again with combination of
no-reflow
We could disable it for now and enable it when we have string literal reflow.
R
Author: malcolm.parsons
Date: Wed Jan 24 02:26:09 2018
New Revision: 323316
URL: http://llvm.org/viewvc/llvm-project?rev=323316&view=rev
Log:
Fix typos of occurred and occurrence
Modified:
cfe/trunk/docs/ClangFormatStyleOptions.rst
cfe/trunk/include/clang/Analysis/CloneDetection.h
cfe
sdardis marked an inline comment as done.
sdardis added a comment.
Thanks, will fix the nit on commit.
Repository:
rC Clang
https://reviews.llvm.org/D42416
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Change the comment and possibly also the patch description along the lines of
what I have suggested. Other than that, looks good to me.
Comment at: lib/Format/Format.cpp:6
hokein created this revision.
hokein added a reviewer: ilya-biryukov.
Repository:
rC Clang
https://reviews.llvm.org/D42466
Files:
include/clang/Sema/CodeCompleteConsumer.h
include/clang/Sema/CodeCompleteOptions.h
lib/Sema/Sema.cpp
unittests/Sema/CodeCompleteTest.cpp
Index: unittests/S
krasimir updated this revision to Diff 131216.
krasimir added a comment.
- Update comment
Repository:
rC Clang
https://reviews.llvm.org/D42373
Files:
lib/Format/Format.cpp
Index: lib/Format/Format.cpp
===
--- lib/Format/Form
Author: krasimir
Date: Wed Jan 24 03:18:39 2018
New Revision: 323319
URL: http://llvm.org/viewvc/llvm-project?rev=323319&view=rev
Log:
[clang-format] Disable string literal breaking for text protos
Summary:
Commonly string literals in protos are already multiline, so breaking them
further is unde
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323319: [clang-format] Disable string literal breaking for
text protos (authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D4237
devnexen created this revision.
devnexen added reviewers: joerg, vitalybuka.
devnexen created this object with visibility "All Users".
Herald added subscribers: cfe-commits, krytarowski, emaste.
As NetBSD, FreeBSD needs execinfo for backtrace's matters.
Repository:
rC Clang
https://reviews.ll
devnexen updated this revision to Diff 131220.
devnexen retitled this revision from "FreeBSD needs also execinfo" to "FreeBSD
needs also execinfo and libutil".
devnexen edited the summary of this revision.
Repository:
rC Clang
https://reviews.llvm.org/D42467
Files:
lib/Driver/ToolChains/Com
krytarowski added a comment.
Do you plan to use MSan? If so, `-lkvm` might be useful as well.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:552
CmdArgs.push_back("-ldl");
// Required for forkpty on some OSes
+ if (TC.getTriple().getOS() == llvm::Triple::NetBSD ||
--
bebuch requested changes to this revision.
bebuch added a comment.
This revision now requires changes to proceed.
I get some new errors:
/home/pi/projects/llvm/llvm/projects/libcxxabi/src/cxa_personality.cpp: In
function ‘void __cxxabiv1::scan_eh_tab(__cxxabiv1::{anonymous}::scan_results&,
_U
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX323322: [libcxx] Correctly handle invalid regex character
class names (authored by miyuki, committed by ).
Repository:
rCXX libc++
https://reviews.llvm.org/D42291
Files:
include/regex
test/std/r
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323322: [libcxx] Correctly handle invalid regex character
class names (authored by miyuki, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D422
Author: miyuki
Date: Wed Jan 24 04:45:18 2018
New Revision: 323322
URL: http://llvm.org/viewvc/llvm-project?rev=323322&view=rev
Log:
[libcxx] Correctly handle invalid regex character class names
Summary:
Currently when a regular expression contains an invalid character
class name std::regex const
devnexen added a comment.
In https://reviews.llvm.org/D42467#986214, @krytarowski wrote:
> Do you plan to use MSan? If so, `-lkvm` might be useful as well.
This is indeed the plan. Updated.
Repository:
rC Clang
https://reviews.llvm.org/D42467
devnexen updated this revision to Diff 131229.
devnexen retitled this revision from "FreeBSD needs also execinfo and libutil"
to "FreeBSD needs also execinfo, libutil and libkvm".
devnexen edited the summary of this revision.
Repository:
rC Clang
https://reviews.llvm.org/D42467
Files:
lib/D
krytarowski added a comment.
Please update the `-lutil` comment in the code according to the comment. I can
land this for you once it will be accepted.
Repository:
rC Clang
https://reviews.llvm.org/D42467
___
cfe-commits mailing list
cfe-commits
devnexen added a comment.
In https://reviews.llvm.org/D42467#986279, @krytarowski wrote:
> Please update the `-lutil` comment in the code according to the comment. I
> can land this for you once it will be accepted.
In fact the review comment is wrong/confusing :-) lutil is for forkpty only as
krytarowski added a comment.
In https://reviews.llvm.org/D42467#986280, @devnexen wrote:
> In https://reviews.llvm.org/D42467#986279, @krytarowski wrote:
>
> > Please update the `-lutil` comment in the code according to the comment. I
> > can land this for you once it will be accepted.
>
>
> In
a.sidorin added inline comments.
Comment at: lib/AST/ASTImporter.cpp:6207
+TypeSourceInfo *TSI = Importer.Import(E->getTypeOperandSourceInfo());
+if (!TSI && E->getTypeOperandSourceInfo())
+ return nullptr;
As I see from usage of `getTypeOperandSourc
devnexen updated this revision to Diff 131239.
devnexen edited the summary of this revision.
Repository:
rC Clang
https://reviews.llvm.org/D42467
Files:
lib/Driver/ToolChains/CommonArgs.cpp
Index: lib/Driver/ToolChains/CommonArgs.cpp
ilya-biryukov created this revision.
Herald added a subscriber: cfe-commits.
Not intended to be submitted, this is a suggestion on how to make the
code in https://reviews.llvm.org/D41537 easier.
Repository:
rC Clang
https://reviews.llvm.org/D42474
Files:
include/clang/Sema/Sema.h
lib/Par
ilya-biryukov added a comment.
Sorry for not taking a look for a long time. I think that would be a very
useful feature to have.
Here are a few comments (also see the inline comments)
- Please add tests
- How would the clients know how to correct dot to arrow? It'd be cool if code
completion re
ilya-biryukov added a comment.
I also propose to try correcting in both directions, i.e. here's how completion
completion could work with this feature:
struct X { int foobarbaz; };
void test() {
X var;
X* ptr;
std::unique_ptr uptr;
var->foobar // replace with var.foo
ilya-biryukov added inline comments.
Comment at: lib/Sema/Sema.cpp:143
ArgumentPackSubstitutionIndex(-1), CurrentInstantiationScope(nullptr),
- DisableTypoCorrection(false), TyposCorrected(0), AnalysisWarnings(*this),
+ DisableTypoCorrection(
+ CodeCompl
kosarev updated this revision to Diff 131257.
kosarev added a comment.
The copying functions changed to take LValues. It seems Address-taking versions
are not very useful so we don't bother with overloading.
https://reviews.llvm.org/D41539
Files:
lib/CodeGen/CGAtomic.cpp
lib/CodeGen/CGCall
baloghadamsoftware added a comment.
Thank you for your comments. Since the original author of this particular code
is Artem, I think he will answer your questions.
https://reviews.llvm.org/D41938
___
cfe-commits mailing list
cfe-commits@lists.llvm.
Author: hans
Date: Wed Jan 24 07:18:12 2018
New Revision: 323330
URL: http://llvm.org/viewvc/llvm-project?rev=323330&view=rev
Log:
clang-cl: Parse /permissive-, /Bt, Bt+ (PR32672)
Modified:
cfe/trunk/include/clang/Driver/CLCompatOptions.td
cfe/trunk/test/Driver/cl-options.c
Modified: cfe
ilya-biryukov created this revision.
ilya-biryukov added reviewers: sammccall, ioeric, hokein.
Herald added subscribers: jkorous-apple, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42480
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
On Wed, Jan 24, 2018 at 4:30 PM, Hans Wennborg wrote:
> Merged to 6.0 in r32 as requested in PR36043. Richard, please
> complain if you don't agree.
Actually cc'ing Richard this time.
>
> On Sat, Jan 20, 2018 at 12:41 AM, Volodymyr Sapsai via cfe-commits
> wrote:
>> Author: vsapsai
>> Date:
Merged to 6.0 in r32 as requested in PR36043. Richard, please
complain if you don't agree.
On Sat, Jan 20, 2018 at 12:41 AM, Volodymyr Sapsai via cfe-commits
wrote:
> Author: vsapsai
> Date: Fri Jan 19 15:41:47 2018
> New Revision: 323008
>
> URL: http://llvm.org/viewvc/llvm-project?rev=32300
(see also this thread for some prior discussion on /permissive-:
https://marc.info/?t=14930460853&r=1&w=2 Ignoring seems like a good
thing to do for now.)
On Wed, Jan 24, 2018 at 10:18 AM, Hans Wennborg via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: hans
> Date: Wed Jan 24 07:
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: ioeric, jkorous-apple, ilya-biryukov, klimek.
- truncate symbols from static/dynamic index to the limited number
(which would save lots of cost in constructing the merged symbols).
- add an CLI option all
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thank you!
Comment at: clangd/tool/ClangdMain.cpp:128
+static llvm::cl::opt LimitCompletionResult(
+"limit-completion-results",
+llvm::cl::desc("Limit the numbe
simark added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:302
+// FIXME: This function needs to be properly tested.
+void ClangdLSPServer::onChangeConfiguration(
ilya-biryukov wrote:
> Are you planning to to address this FIXME before checking the cod
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D42455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.sidorin updated this revision to Diff 131279.
a.sidorin added a comment.
Addressed review comments
Repository:
rC Clang
https://reviews.llvm.org/D42301
Files:
lib/AST/ASTImporter.cpp
lib/AST/ASTStructuralEquivalence.cpp
lib/AST/ExternalASTMerger.cpp
test/ASTMerge/class-template/Inp
a.sidorin added a comment.
In https://reviews.llvm.org/D42301#984695, @xazax.hun wrote:
> High level note: `clang::TypeAliasDecl` has the same issue as
> `CXXRecordDecl`, so templated versions should not be added to the
> DeclContext. Could you add that just for the sake of completeness?
I'd
hokein abandoned this revision.
hokein added inline comments.
Comment at: lib/Sema/Sema.cpp:143
ArgumentPackSubstitutionIndex(-1), CurrentInstantiationScope(nullptr),
- DisableTypoCorrection(false), TyposCorrected(0), AnalysisWarnings(*this),
+ DisableTypoCorrect
hintonda created this revision.
hintonda added reviewers: beanz, compnerd, phosek, EricWF.
Herald added subscribers: cfe-commits, mgorny.
Set cmake policy CMP0068=NEW, if available -- depends on
https://reviews.llvm.org/D42463 which
also adds target property "BUILD_WITH_INSTALL_NAME_DIR On" to ma
hokein created this revision.
hokein added a reviewer: ilya-biryukov.
Herald added subscribers: ioeric, jkorous-apple, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42491
Files:
clangd/CodeComplete.cpp
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clangd/
jolesiak created this revision.
Herald added subscribers: cfe-commits, klimek.
jolesiak edited the summary of this revision.
Fixes formatting of ObjC message arguments when inline block is a first
argument.
Having inline block as a first when method has multiple parameters is
discouraged by Apple
benhamilton added inline comments.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:52
/// FIXME: provide fix for snake_case to snakeCase
-FixItHint generateFixItHint(const ObjCPropertyDecl *Decl) {
- if (isupper(Decl->getName()[0])) {
-auto NewName = Decl->getName(
Author: tra
Date: Wed Jan 24 09:41:02 2018
New Revision: 323345
URL: http://llvm.org/viewvc/llvm-project?rev=323345&view=rev
Log:
[CUDA] Disable PGO and coverage instrumentation in NVPTX.
NVPTX does not have runtime support necessary for profiling to work
and even call arc collection is prohibiti
This revision was automatically updated to reflect the committed changes.
Closed by commit rC323345: [CUDA] Disable PGO and coverage instrumentation in
NVPTX. (authored by tra, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42452?vs=131170&id=131298#toc
Repository:
rC Cla
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323345: [CUDA] Disable PGO and coverage instrumentation in
NVPTX. (authored by tra, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42452?vs=1
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323347: [CodeComplete] only respect LoadExternal hint at
namespace/tu scope (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org
Author: sammccall
Date: Wed Jan 24 09:50:20 2018
New Revision: 323347
URL: http://llvm.org/viewvc/llvm-project?rev=323347&view=rev
Log:
[CodeComplete] only respect LoadExternal hint at namespace/tu scope
Reviewers: ilya-biryukov
Subscribers: cfe-commits
Differential Revision: https://reviews.ll
Author: sammccall
Date: Wed Jan 24 09:53:32 2018
New Revision: 323350
URL: http://llvm.org/viewvc/llvm-project?rev=323350&view=rev
Log:
[clangd] add test for r323347 CodeComplete behavior we rely on
Modified:
clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp
Modified: clang-tool
simark updated this revision to Diff 131305.
simark added a comment.
Move implementation of setCompileCommandsDir to .cpp
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D39571
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/Clang
koldaniel added inline comments.
Herald added a subscriber: hintonda.
Comment at: test/clang-tidy/modernize-use-uncaught-exceptions.cpp:64
+ // CHECK-MESSAGES: [[@LINE-1]]:10: warning: 'std::uncaught_exception' is
deprecated, use 'std::uncaught_exceptions' instead
+ // CHECK-F
Hi Felix,
If you would like to get the patch reviewed and committed the best way is to
create a review in phabricator
(http://reviews.llvm.org) and add Devin Coughlin, me, and Artem Dergachev as
reviewers.
> On Jan 16, 2018, at 7:30 PM, Vedant Kumar wrote:
>
> + Devin and George
>
>> On Jan
NoQ added a comment.
George's style comments are usually super spot-on. Please feel free to improve
my code. Also it was only written as a proof-of-concept because i failed to
explain my approach with natural language, so it definitely needs polishing.
I'd let you know when i disagree with anyt
Author: kparzysz
Date: Wed Jan 24 10:42:19 2018
New Revision: 323360
URL: http://llvm.org/viewvc/llvm-project?rev=323360&view=rev
Log:
[Hexagon] Accept lowercase b in -hvx-length=64b and -hvx-length=128b
Modified:
cfe/trunk/lib/Driver/ToolChains/Hexagon.cpp
cfe/trunk/test/Driver/hexagon-h
Author: rafael
Date: Wed Jan 24 10:58:32 2018
New Revision: 323361
URL: http://llvm.org/viewvc/llvm-project?rev=323361&view=rev
Log:
Don't create hidden dllimport global values.
Hidden visibility is almost the opposite of dllimport. We were
producing them before (dllimport wins in the existing ll
Author: pcc
Date: Wed Jan 24 10:59:58 2018
New Revision: 323362
URL: http://llvm.org/viewvc/llvm-project?rev=323362&view=rev
Log:
IRGen: Emit an inline implementation of __builtin_wmemcmp on MSVCRT platforms.
The MSVC runtime library does not provide a definition of wmemcmp,
so we need an inline
espindola closed this revision.
espindola added a comment.
323361
https://reviews.llvm.org/D42455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: test/clang-tidy/modernize-use-uncaught-exceptions.cpp:64
+ // CHECK-MESSAGES: [[@LINE-1]]:10: warning: 'std::uncaught_exception' is
deprecated, use 'std::uncaught_exceptions' instead
+ // CHECK-FIXES: foo = &uncaught_exceptions;
Wizard added inline comments.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:102
+bool hasCategoryPropertyPrefix(const llvm::StringRef &PropertyName) {
+ for (size_t i = 0; i < PropertyName.size() - 1; ++i) {
+if (PropertyName[i] == '_') {
benhamil
NoQ added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:572
+bool IsConstructorWithImproperlyModeledTargetRegion : 1;
+bool IsArrayConstructorOrDestructor : 1;
+ };
george.karpenkov wrote:
> OK my C++ knowledge
NoQ updated this revision to Diff 131321.
NoQ marked 8 inline comments as done.
NoQ added a comment.
Address comments.
https://reviews.llvm.org/D42457
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h
lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
lib/StaticAnalyzer/Core/Expr
Author: vvassilev
Date: Wed Jan 24 11:26:50 2018
New Revision: 323368
URL: http://llvm.org/viewvc/llvm-project?rev=323368&view=rev
Log:
Revert r323051 "[cmake] Use CLANG_BINARY_DIR to determine the build directory."
This broke swift builds.
Thanks for the post-commit review of Chris Bieneman and
thakis created this revision.
thakis added a reviewer: rnk.
Herald added subscribers: fedor.sergeev, kristof.beyls, sdardis, emaste,
aemerson.
r213083 initially implemented /arch: support by mapping it to CPU features.
Then r241077 additionally mapped it to CPU, which made the feature flags
red
vsapsai created this revision.
vsapsai added reviewers: rsmith, efriedma.
When indirect field is initialized with another field, you have
MemberExpr with CXXThisExpr that corresponds to the field's immediate
anonymous parent. But 'this' was referring to the non-anonymous parent.
So when we were bu
Author: dergachev
Date: Wed Jan 24 12:32:26 2018
New Revision: 323370
URL: http://llvm.org/viewvc/llvm-project?rev=323370&view=rev
Log:
[analyzer] Assume that the allocated value is non-null before construction.
I.e. not after. In the c++-allocator-inlining=true mode, we need to make the
assumpti
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323370: [analyzer] Assume that the allocated value is
non-null before construction. (authored by dergachev, committed by )
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, ioeric, jkorous-apple, klimek.
This is probably the right behavior for distributed tracers, and makes unpaired
begin-end events impossible without requiring Spans to be bound to a thr
Author: dergachev
Date: Wed Jan 24 12:59:40 2018
New Revision: 323373
URL: http://llvm.org/viewvc/llvm-project?rev=323373&view=rev
Log:
[analyzer] Enable c++-allocator-inlining by default.
This allows the analyzer to analyze ("inline") custom operator new() calls and,
even more importantly, inlin
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323373: [analyzer] Enable c++-allocator-inlining by default.
(authored by dergachev, committed by ).
Herald added a subscr
krasimir created this revision.
krasimir added a reviewer: djasper.
Herald added a subscriber: klimek.
Consider the text proto:
message {
sub { key: value }
}
Previously the first `{` was TT_Unknown, which caused the inner message to be
indented by the continuation width. This didn't hap
sammccall updated this revision to Diff 131335.
sammccall added a comment.
Remove obsolete typedef
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42499
Files:
clangd/ClangdUnit.cpp
clangd/Context.h
clangd/Function.h
clangd/JSONRPCDispatcher.cpp
clangd/Trace.cpp
clan
EricWF updated this revision to Diff 131334.
EricWF edited the summary of this revision.
EricWF added a comment.
- Use a better formulation for detecting when the Gro should be an NRVO
variable.
https://reviews.llvm.org/D42343
Files:
lib/Sema/SemaCoroutine.cpp
test/CodeGenCoroutines/coro-a
xazax.hun added a comment.
In https://reviews.llvm.org/D42301#986583, @a.sidorin wrote:
> I'd rather create a separate patch - this one is already large enough. Is it
> OK?
Yeah, that is fine by me.
Repository:
rC Clang
https://reviews.llvm.org/D42301
__
Author: dergachev
Date: Wed Jan 24 13:24:10 2018
New Revision: 323376
URL: http://llvm.org/viewvc/llvm-project?rev=323376&view=rev
Log:
[analyzer] NFC: Run many existing C++ tests with a custom operator new().
In order to provide more test coverage for inlined operator new(), add more
run-lines t
This revision was automatically updated to reflect the committed changes.
Closed by commit rC323376: [analyzer] NFC: Run many existing C++ tests with a
custom operator new(). (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D42221
Files:
test/Analysis/In
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good
Repository:
rC Clang
https://reviews.llvm.org/D42500
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Yeah, i guess that'd work as well :)
Repository:
rL LLVM
https://reviews.llvm.org/D42396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
Author: ericwf
Date: Wed Jan 24 14:14:01 2018
New Revision: 323380
URL: http://llvm.org/viewvc/llvm-project?rev=323380&view=rev
Log:
[libc++] Fix PR20855 -- libc++ incorrectly diagnoses illegal reference binding
in std::tuple.
Summary:
See https://bugs.llvm.org/show_bug.cgi?id=20855
Libc++ goes
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX323380: [libc++] Fix PR20855 -- libc++ incorrectly
diagnoses illegal reference binding… (authored by EricWF, committed by ).
Repository:
rCXX libc++
https://reviews.llvm.org/D41977
Files:
include/
EricWF updated this revision to Diff 131348.
EricWF added a comment.
- Improve diagnostic as per @rsmiths suggestion.
https://reviews.llvm.org/D41977
Files:
include/tuple
test/libcxx/utilities/tuple/tuple.tuple/diagnose_reference_binding.fail.cpp
test/libcxx/utilities/tuple/tuple.tuple/di
Author: modocache
Date: Wed Jan 24 14:15:42 2018
New Revision: 323381
URL: http://llvm.org/viewvc/llvm-project?rev=323381&view=rev
Log:
[coroutines] Pass coro func args to promise ctor
Summary:
Use corutine function arguments to initialize a promise type, but only
if the promise type defines a co
Author: alexshap
Date: Wed Jan 24 14:17:30 2018
New Revision: 323382
URL: http://llvm.org/viewvc/llvm-project?rev=323382&view=rev
Log:
[analyzer] Do not attempt to get the pointee of void*
Do not attempt to get the pointee of void* while generating a bug report
(otherwise it will trigger an asse
This revision was automatically updated to reflect the committed changes.
Closed by commit rC323381: [coroutines] Pass coro func args to promise ctor
(authored by modocache, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41820?vs=129785&id=131351#toc
Repository:
rC Clang
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323381: [coroutines] Pass coro func args to promise ctor
(authored by modocache, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D41820
Files:
c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323382: [analyzer] Do not attempt to get the pointee of
void* (authored by alexshap, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42396?vs=130979&id=131352#toc
Repository:
rL LL
modocache added a comment.
Great, thanks for the reviews!
Repository:
rC Clang
https://reviews.llvm.org/D41820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen updated this revision to Diff 131356.
Repository:
rC Clang
https://reviews.llvm.org/D42467
Files:
lib/Driver/ToolChains/CommonArgs.cpp
Index: lib/Driver/ToolChains/CommonArgs.cpp
===
--- lib/Driver/ToolChains/CommonAr
krytarowski added a comment.
I propose to skip now `-lkvm` and `-lutil` for FreeBSD. I'm researching now an
option to rebuild these libraries against sanitizers and so stop teaching the
world how to handle its API.
Please keep these patches locally for now.
Repository:
rC Clang
https://rev
devnexen updated this revision to Diff 131358.
Repository:
rC Clang
https://reviews.llvm.org/D42467
Files:
lib/Driver/ToolChains/CommonArgs.cpp
Index: lib/Driver/ToolChains/CommonArgs.cpp
===
--- lib/Driver/ToolChains/CommonAr
devnexen added a comment.
In https://reviews.llvm.org/D42467#987140, @krytarowski wrote:
> I propose to skip now `-lkvm` and `-lutil` for FreeBSD. I'm researching now
> an option to rebuild these libraries against sanitizers and so stop teaching
> the world how to handle its API.
>
> Please kee
devnexen updated this revision to Diff 131359.
devnexen edited the summary of this revision.
Repository:
rC Clang
https://reviews.llvm.org/D42467
Files:
lib/Driver/ToolChains/CommonArgs.cpp
Index: lib/Driver/ToolChains/CommonArgs.cpp
Author: marshall
Date: Wed Jan 24 14:42:25 2018
New Revision: 323385
URL: http://llvm.org/viewvc/llvm-project?rev=323385&view=rev
Log:
Implement LWG2783: stack::emplace() and queue::emplace() should return
decltype(auto)
Modified:
libcxx/trunk/include/queue
libcxx/trunk/include/stack
1 - 100 of 126 matches
Mail list logo
