ilya-biryukov added a comment.
Hi @simark , thanks for picking up this change.
================
Comment at: clangd/ClangdLSPServer.cpp:302
+// FIXME: This function needs to be properly tested.
+void ClangdLSPServer::onChangeConfiguration(
----------------
Are you planning to to address this FIXME before checking the code in?
================
Comment at: clangd/GlobalCompilationDatabase.h:64
+ void setCompileCommandsDir(Path P) {
+ std::lock_guard<std::mutex> Lock(Mutex);
----------------
Maybe move definition to `.cpp` file?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D39571
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
