sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
I'm not actually sure we're doing the user a service with this error handling.
LSP errors aren't surfaced to the user with a decent UI in practice.
Plus it adds a bunch of internal complex
bebuch accepted this revision.
bebuch added a comment.
Please commit!
https://reviews.llvm.org/D38831
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall added a comment.
Hmm, I looked into the empty diagnostic ranges, and it overlaps here a lot.
Feel free to go ahead and land this and I can merge, otherwise I can include
this fix there.
Regardless of how it gets landed, thanks for finding and fixing this, this
explains a lot of weird
JonasToth added a comment.
> What do you think about making this check fully configurable through the
> check options? The options could list the functions to check. The
> documentation could suggest some candidate functions from std lib to
> configure checks for.
That sound reasonable. A simi
ilya-biryukov added inline comments.
Comment at: clangd/Context.h:169
+ struct ContextData {
+// We need to make sure Parent outlives the Value, so the order of members
+// is important. We do that to allow classes stored in Context's child
sammccall wro
Upgrading Phabricator to a newer version. Sorry for the short notice!
- Eric
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
It was faster than I thought. Phabricator is up again.
The most noticeable new feature is the ability to hide inline comments:[image:
xkhNjkAc2ma.png]
Cheers,
Eric
On Tue, Dec 12, 2017 at 11:32 AM Eric Liu wrote:
> Upgrading Phabricator to a newer version. Sorry for the short notice!
>
> - Eri
ilya-biryukov updated this revision to Diff 126515.
ilya-biryukov marked 4 inline comments as done.
ilya-biryukov added a comment.
- Change derive() signature to accept a value instead of the variadic arguments.
- Rewrite a while loop into a for loop.
- Return a value from Context::empty() instead
ioeric added a comment.
Ping?
Repository:
rC Clang
https://reviews.llvm.org/D40562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JonasToth added a comment.
Hi julie,
i like the new approach for doc generator. I added my thoughts on the code :)
Comment at: tools/clang-doc/ClangDoc.cpp:81
+ llvm::StringRef InFile) {
+ return std::unique_ptr(
+ new ClangDocConsumer(&C
lichray added inline comments.
Comment at: include/ostream:225
+basic_ostream& operator<<(nullptr_t)
+{ return *this << (const void*)0; }
+
Oh, common, I persuaded the committee to allow you to print a `(null)` and you
don't do it...
https://reviews.l
Author: ibiryukov
Date: Tue Dec 12 03:16:45 2017
New Revision: 320468
URL: http://llvm.org/viewvc/llvm-project?rev=320468&view=rev
Log:
[clangd] Introduced a Context that stores implicit data
Summary:
It will be used to pass around things like Logger and Tracer throughout
clangd classes.
Reviewe
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE320468: [clangd] Introduced a Context that stores implicit
data (authored by ibiryukov, committed by ).
Changed prior t
hokein updated this revision to Diff 126519.
hokein marked 4 inline comments as done.
hokein added a comment.
Address remaining comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40897
Files:
clangd/CMakeLists.txt
clangd/index/CMakeLists.txt
clangd/index/Index.cpp
lichray added a comment.
[...]test/std/utilities/meta/meta.rel/is_nothrow_invocable.pass.cpp:118:9:
error: static_assert failed due to requirement
'!std::is_nothrow_invocable_r_v' ""
static_assert(!std::is_nothrow_invocable_r_v, "");
^ ~~
hokein added inline comments.
Comment at: clangd/index/Index.cpp:34
+
+SymbolSlab::const_iterator SymbolSlab::find(const SymbolID& SymID) const {
+ return Symbols.find(SymID);
sammccall wrote:
> assert frozen? (and in begin())
We may not do the assert "frozen" i
Author: ioeric
Date: Tue Dec 12 03:35:46 2017
New Revision: 320471
URL: http://llvm.org/viewvc/llvm-project?rev=320471&view=rev
Log:
[SemaCodeComplete] Allow passing out scope specifiers in qualified-id
completions via completion context.
Reviewers: ilya-biryukov, arphaman
Reviewed By: arphaman
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320471: [SemaCodeComplete] Allow passing out scope
specifiers in qualified-id… (authored by ioeric, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D40563
Files:
cfe/trunk/include/clang
stettberger updated this revision to Diff 126523.
stettberger added a comment.
I removed the magic constants and added the number of children for various AST
nodes. This should avoid hash collisions.
Repository:
rC Clang
https://reviews.llvm.org/D40731
Files:
include/clang/AST/AttrDataCol
jolesiak created this revision.
jolesiak added a reviewer: krasimir.
Herald added a subscriber: klimek.
This patch improves detection of ObjC header files.
Right now many ObjC headers, especially short ones, are categorized as C/C++.
Way of filtering still isn't the best, as most likely it should
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM minor a slight tweak to fix compilation. I'll land this today.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D38425
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320474: [clangd] Document highlights for clangd (authored by
ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D38425?vs=126371&id=126529#toc
Repository:
rL LLVM
https://r
Author: ibiryukov
Date: Tue Dec 12 04:27:47 2017
New Revision: 320474
URL: http://llvm.org/viewvc/llvm-project?rev=320474&view=rev
Log:
[clangd] Document highlights for clangd
Summary: Implementation of Document Highlights Request as described in
LSP.
Contributed by William Enright (nebiroth).
JDevlieghere requested changes to this revision.
JDevlieghere added inline comments.
This revision now requires changes to proceed.
Comment at: tools/clang-doc/ClangDocReporter.cpp:106
+ FI.Filename = Filename;
+ FileRecords.insert(std::pair(Filename,
std::move(FI)));
+}
-
Author: ibiryukov
Date: Tue Dec 12 04:56:46 2017
New Revision: 320476
URL: http://llvm.org/viewvc/llvm-project?rev=320476&view=rev
Log:
[clangd] clang-format the code. NFC
Modified:
clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp
clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp
K-ballo added a comment.
In https://reviews.llvm.org/D38831#952228, @lichray wrote:
> [...]test/std/utilities/meta/meta.rel/is_nothrow_invocable.pass.cpp:118:9:
> error: static_assert failed due to requirement
> '!std::is_nothrow_invocable_r_v' ""
> static_assert(!std::is_nothrow_in
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Thank you! I'll go ahead and commit this for you!
Repository:
rC Clang
https://reviews.llvm.org/D41108
___
cfe-commits mailing list
cfe-co
Author: krasimir
Date: Tue Dec 12 05:43:59 2017
New Revision: 320479
URL: http://llvm.org/viewvc/llvm-project?rev=320479&view=rev
Log:
[clang-format] Improve ObjC headers detection.
This patch improves detection of ObjC header files.
Right now many ObjC headers, especially short ones, are categor
jklaehn added a comment.
In https://reviews.llvm.org/D36952#951616, @arphaman wrote:
> LGTM
Thanks! Can you submit this for me? (I do not have commit access yet.)
https://reviews.llvm.org/D36952
___
cfe-commits mailing list
cfe-commits@lists.llvm
sammccall added inline comments.
Comment at: clangd/index/CMakeLists.txt:5
+
+add_clang_library(clangdIndex
+ Index.cpp
hmm, I'm not sure whether we actually want this to be a separate library. This
means we can't depend on anything from elsewhere in clangd, an
hokein updated this revision to Diff 126538.
hokein added a comment.
- Get rid of clangdIndex library, using the existing clangDaemon library.
- Remove the getID() method.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40897
Files:
clangd/CMakeLists.txt
clangd/index/Index.c
Author: ibiryukov
Date: Tue Dec 12 06:15:01 2017
New Revision: 320482
URL: http://llvm.org/viewvc/llvm-project?rev=320482&view=rev
Log:
[clangd] Removed unused variable. NFC
Modified:
clang-tools-extra/trunk/clangd/ClangdUnit.cpp
Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp
URL:
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clangd/index/CMakeLists.txt:5
+
+add_clang_library(clangdIndex
+ Index.cpp
sammccall wrote:
> hmm, I'm not sure whether we actually want this to be a separate library.
> This mea
mclow.lists added a comment.
> Avoid MSVC "warning C4293: '<<': shift count negative or too big, undefined
> behavior".
> MSVC sees (1ULL << N) and warns - being guarded by const bool canFit is
> insufficient. A small change to the code
Your compiler needs to either (a) get much smarter about
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
These look fine to me. Thanks for the attention to detail.
https://reviews.llvm.org/D41030
___
cfe-commits mailing list
cfe-commits@li
ilya-biryukov updated this revision to Diff 126544.
ilya-biryukov marked 7 inline comments as done.
ilya-biryukov added a comment.
- Added a helper that runs functions in destructor.
- Fixed compilation after rebase.
- Got rid of FulfilContextPromiseGuard
- Added a FIXME to remove the Ctx typedef.
ilya-biryukov added a comment.
I think all the comments are addressed now and this change is ready for another
round of review.
Let me know if I missed something.
Comment at: clangd/ClangdServer.cpp:36
- ~FulfillPromiseGuard() { Promise.set_value(); }
+ ~FulfillContextProm
K-ballo updated this revision to Diff 126545.
K-ballo added a comment.
Fixed incorrect test case.
https://reviews.llvm.org/D38831
Files:
include/type_traits
include/variant
test/std/utilities/function.objects/func.not_fn/not_fn.pass.cpp
test/std/utilities/function.objects/unord.hash/non
hokein marked an inline comment as done.
hokein added a comment.
I'm going to submit this patch to unblock the stuff in
https://reviews.llvm.org/D40548. Would be happy to address any further comments
afterwards.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40897
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE320486: [clangd] Introduce a "Symbol" class.
(authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D40897?vs=126538&id=126548#toc
Repository:
rCTE Clang Tools Extra
Author: hokein
Date: Tue Dec 12 07:42:10 2017
New Revision: 320486
URL: http://llvm.org/viewvc/llvm-project?rev=320486&view=rev
Log:
[clangd] Introduce a "Symbol" class.
Summary:
* The "Symbol" class represents a C++ symbol in the codebase, containing all the
information of a C++ symbol needed
ilya-biryukov updated this revision to Diff 126551.
ilya-biryukov added a comment.
- Make Context the first parameter everywhere.
- Add a SFINAE check to UniqueFunction's constructor to avoid creating it from
non-callable objects.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D
Author: erichkeane
Date: Tue Dec 12 08:02:06 2017
New Revision: 320489
URL: http://llvm.org/viewvc/llvm-project?rev=320489&view=rev
Log:
Fix ICE when __has_unqiue_object_representations called with invalid decl
Modified:
cfe/trunk/lib/AST/ASTContext.cpp
cfe/trunk/lib/Sema/SemaExprCXX.cpp
ilya-biryukov added a comment.
This is now ready for review.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov added inline comments.
Comment at: clangd/Function.h:44
+/// A sfinae-check that Callable can be called with Args...
+class = decltype(std::declval()(std::declval()...),
+ void())>
We need this che
On 12 Dec 2017 16:02, "Erich Keane via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
Author: erichkeane
Date: Tue Dec 12 08:02:06 2017
New Revision: 320489
URL: http://llvm.org/viewvc/llvm-project?rev=320489&view=rev
Log:
Fix ICE when __has_unqiue_object_representations called with invalid de
ilya-biryukov updated this revision to Diff 126554.
ilya-biryukov added a comment.
- Also check that return type of Callable is correct.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40486
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
Gah, no it wasn’t. I’ll revert that now.
From: Richard Smith [mailto:rich...@metafoo.co.uk]
Sent: Tuesday, December 12, 2017 8:07 AM
To: Keane, Erich
Cc: cfe-commits
Subject: Re: r320489 - Fix ICE when __has_unqiue_object_representations called
with invalid decl
On 12 Dec 2017 16:02, "Erich K
Author: erichkeane
Date: Tue Dec 12 08:22:31 2017
New Revision: 320493
URL: http://llvm.org/viewvc/llvm-project?rev=320493&view=rev
Log:
Revert a part of 320489 that was submitted unintentionally.
Modified:
cfe/trunk/lib/Sema/SemaExprCXX.cpp
Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp
URL:
Fixed in 320493. Thanks for catching that.
From: Richard Smith [mailto:rich...@metafoo.co.uk]
Sent: Tuesday, December 12, 2017 8:07 AM
To: Keane, Erich
Cc: cfe-commits
Subject: Re: r320489 - Fix ICE when __has_unqiue_object_representations called
with invalid decl
On 12 Dec 2017 16:02, "Erich
ioeric added inline comments.
Comment at: clangd/index/Index.h:52
+private:
+ friend class llvm::DenseMapInfo;
+
warning: class 'DenseMapInfo' was previously declared as a struct
[-Wmismatched-tags]
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.o
aaron.ballman added a comment.
In https://reviews.llvm.org/D41056#951507, @khuttun wrote:
> P0600R1 seems to suggest quite conservative approach (and rightly so, IMO) in
> taking `[[nodiscard]]` in use in std lib. For example it proposes *not* to
> use it with `unique_ptr::release`. I think the
Thanks Zachary.
Maybe, we can approach the issue through another, hopefully less controversial
angle. Clang currently has a limited number of tests verifying that it
correctly handles all types of line endings. IMHO, Zhen's solution (dos2unix &
unix2dos conversions) provides an handy mechanism
xazax.hun updated this revision to Diff 126543.
xazax.hun added a comment.
- Further improvements to python script part.
https://reviews.llvm.org/D30691
Files:
include/clang/AST/ASTContext.h
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
include/clang/StaticAnalyzer/Core/PathSensitiv
Author: dhinton
Date: Tue Dec 12 08:48:35 2017
New Revision: 320494
URL: http://llvm.org/viewvc/llvm-project?rev=320494&view=rev
Log:
[debuginfo-tests] Add support for moving debuginfo-tests from clang/test to
llvm/projects or monorepo.
Summary:
The new version of debuginfo-tests will have it's
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320494: [debuginfo-tests] Add support for moving
debuginfo-tests from clang/test to… (authored by dhinton, committed by ).
malaperle added inline comments.
Comment at: clangd/Symbol.h:37
+// The class presents a C++ symbol, e.g. class, function.
+struct Symbol {
+ // The symbol identifier, using USR.
sammccall wrote:
> malaperle wrote:
> > malaperle wrote:
> > > sammccall wrote:
> >
CaseyCarter updated this revision to Diff 126559.
CaseyCarter added a comment.
Better/simpler workaround from Zhihao.
https://reviews.llvm.org/D41048
Files:
include/tuple
Index: include/tuple
===
--- include/tuple
+++ include/t
CaseyCarter added a comment.
This new-and-improved workaround - thanks to @lichray - is unintrusive enough
that I can't imagine it being unnacceptable to anyone. I'm going to go ahead
and check this in.
https://reviews.llvm.org/D41048
___
cfe-comm
sammccall created this revision.
sammccall added reviewers: rwols, hokein.
Herald added subscribers: cfe-commits, ilya-biryukov, klimek.
- when the diagnostic has an explicit range, we prefer that
- if the diagnostic has a fixit, its RemoveRange is our next choice
- otherwise we try to expand the
Author: caseycarter
Date: Tue Dec 12 09:22:24 2017
New Revision: 320500
URL: http://llvm.org/viewvc/llvm-project?rev=320500&view=rev
Log:
workaround PR 28385 in __find_exactly_one_checked
Fixes #35578.
Differential Revision: D41048
Modified:
libcxx/trunk/include/tuple
Modified: libcxx/trun
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320500: workaround PR 28385 in __find_exactly_one_checked
(authored by CaseyCarter, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41048?vs=126559&id=126564#toc
Repository:
rL LLV
sammccall added a comment.
https://reviews.llvm.org/D41118 adds real (non-empty) ranges for diagnostics.
I've copied all the changes you've made here with some slight tweaks, as they
were required for that too.
If you like it as-is, probably easiest to land that instead.
But I'm also happy for y
tstellar added a comment.
Ping.
https://reviews.llvm.org/D34848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: kli
Date: Tue Dec 12 10:33:39 2017
New Revision: 320506
URL: http://llvm.org/viewvc/llvm-project?rev=320506&view=rev
Log:
Add --cuda-path to mock a CUDA Toolkit installation to avoid
unexpected error messages for incompatibility between the
default SM level and the support in the installed
This revision was automatically updated to reflect the committed changes.
Closed by commit rC320506: Add --cuda-path to mock a CUDA Toolkit installation
to avoid (authored by kli, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D40996
Files:
test/Driver/unknown-std.cpp
Index
Author: lichray
Date: Tue Dec 12 10:42:04 2017
New Revision: 320509
URL: http://llvm.org/viewvc/llvm-project?rev=320509&view=rev
Log:
[libcxx] P0604, invoke_result and is_invocable
Summary:
Introduce a new form of `result_of` without function type encoding.
Rename and split `is_callable/is_nothr
arphaman marked an inline comment as done.
arphaman added inline comments.
Comment at: lib/Lex/PPMacroExpansion.cpp:1923
+ Tok, *this, diag::err_feature_check_malformed);
+ return II ? getTargetInfo().getTriple().getArchName().equals_lower(
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320509: [libcxx] P0604, invoke_result and is_invocable
(authored by lichray, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D38831?vs=126545&id=126580#toc
Repository:
rL LLVM
http
arphaman updated this revision to Diff 126581.
arphaman added a comment.
Herald added a subscriber: javed.absar.
- Change error message.
- Take sub arch into account.
https://reviews.llvm.org/D41087
Files:
include/clang/Lex/Preprocessor.h
lib/Lex/PPMacroExpansion.cpp
test/Preprocessor/is_
On Mon, Dec 11, 2017 at 5:38 PM John McCall wrote:
> On Mon, Dec 11, 2017 at 6:19 PM, David Blaikie wrote:
>
>> On Mon, Dec 11, 2017 at 3:16 PM John McCall via Phabricator <
>> revi...@reviews.llvm.org> wrote:
>>
>>> rjmccall added a comment.
>>>
>>> In https://reviews.llvm.org/D41039#951648, @a
lichray added a comment.
That commit message generated from `arc` wasn't all that friendly :/
Thanks for the patch, and @K-ballo you should ask Chris for a commit bit :)
Repository:
rL LLVM
https://reviews.llvm.org/D38831
___
cfe-commits mailing
gtbercea created this revision.
gtbercea added reviewers: hfinkel, Hahnfeld, ABataev, carlo.bertolli, caomhin.
Herald added a subscriber: jholewinski.
The backend should only emit data sharing code for the cases where it is needed.
A new function attribute is used by Clang to enable data sharing o
ABataev added inline comments.
Comment at: test/OpenMP/nvptx_data_sharing.cpp:25-43
+// CK1: define internal void @__omp_offloading_{{.*}}test_ds{{.*}}worker() #0
// CK1: [[SHAREDARGS:%.+]] = alloca i8**
// CK1: call i1 @__kmpc_kernel_parallel(i8** %work_fn, i8*** [[SHAREDARGS]
rjmccall added a comment.
Alternative #1 is actually the right option — only it shouldn't be an
objc_retain, it should be an objc_retainAutoreleasedReturnValue.
Repository:
rC Clang
https://reviews.llvm.org/D41050
___
cfe-commits mailing list
cf
gtbercea updated this revision to Diff 126594.
gtbercea added a comment.
Fix test.
Repository:
rL LLVM
https://reviews.llvm.org/D41123
Files:
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
test/OpenMP/nvptx_data_sharing.cpp
Index: test/OpenMP/nvptx_data_sharing.cpp
==
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
https://reviews.llvm.org/D41123
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: dhinton
Date: Tue Dec 12 11:47:40 2017
New Revision: 320519
URL: http://llvm.org/viewvc/llvm-project?rev=320519&view=rev
Log:
[cmake] Follow-up to rL320494.
EXISTS requires full paths.
Modified:
cfe/trunk/test/CMakeLists.txt
Modified: cfe/trunk/test/CMakeLists.txt
URL:
http://llvm.
rwols accepted this revision.
rwols added a comment.
This revision is now accepted and ready to land.
LGTM, you can go ahead and land this, I'll drop
https://reviews.llvm.org/D40860. I'm happy we got to the bottom of this :)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41118
danzimm added a comment.
@rjmccall ah right, good point -- I think it's ok to elide that
objc_retainAutoreleasedReturnValue/objc_autoreleaseReturnValue pair in this
case though, since all of this is generated within clang itself (and thus we
can make the guarentee that the object will properly
danzimm added a comment.
Or do we need to abide by those semantics strictly here? Could you expand on
why that is, if that's the case?
Repository:
rC Clang
https://reviews.llvm.org/D41050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
nathawes planned changes to this revision.
nathawes added a comment.
Thanks for taking another look @ioeric – I'll work through your comments and
update.
https://reviews.llvm.org/D39050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
Author: kli
Date: Tue Dec 12 12:08:12 2017
New Revision: 320521
URL: http://llvm.org/viewvc/llvm-project?rev=320521&view=rev
Log:
[OpenMP] Diagnose function name on the link clause
This patch is to add diagnose when a function name is
specified on the link clause. According to the OpenMP
spec, o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320521: [OpenMP] Diagnose function name on the link clause
(authored by kli, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D40968?vs=126217&id=126600#toc
Repository:
rL LLVM
http
On Tue, Dec 12, 2017 at 1:45 PM, David Blaikie wrote:
> On Mon, Dec 11, 2017 at 5:38 PM John McCall wrote:
>
>> On Mon, Dec 11, 2017 at 6:19 PM, David Blaikie
>> wrote:
>>
>>> On Mon, Dec 11, 2017 at 3:16 PM John McCall via Phabricator <
>>> revi...@reviews.llvm.org> wrote:
>>>
rjmccall ad
rjmccall added a comment.
In https://reviews.llvm.org/D41050#952720, @danzimm wrote:
> Or do we need to abide by those semantics strictly here? Could you expand on
> why that is, if that's the case?
The autoreleased-return-value optimization cannot be understood purely in terms
of its impact
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320524: [clangd] (Attempt to) read clang-format file for
document formatting (authored by rwols, committed by ).
Herald added a subscriber: klimek.
Changed prior to commit:
https://reviews.llvm.org/D410
rjmccall added a comment.
This looks good to me.
https://reviews.llvm.org/D36915
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
Hmm. The OVE-ing of the RHS of a property assignment is just there to make the
original source structure clearer. Maybe the right solution here is to set a
flag in the OVE that says that it's a unique semantic reference to its source
expression, and then change IRGen
aaron.ballman added inline comments.
Comment at: lib/Sema/Sema.cpp:1677-1684
+Sema::DefaultArgRAII::DefaultArgRAII(Sema &S)
+: Actions(S), PrevParent(S.getParentOfDefaultArg()) {
+ S.setParentOfDefaultArg(S.CurContext);
+}
+
+Sema::DefaultArgRAII::~DefaultArgRAII() {
+ Acti
george.karpenkov added inline comments.
Comment at: tools/scan-build-py/libscanbuild/report.py:257
def read_bugs(output_dir, html):
+# type: (str, bool) -> Generator[Dict[str, Any], None, None]
""" Generate a unique sequence of bugs from given output directory.
Author: rwols
Date: Tue Dec 12 12:25:06 2017
New Revision: 320524
URL: http://llvm.org/viewvc/llvm-project?rev=320524&view=rev
Log:
[clangd] (Attempt to) read clang-format file for document formatting
Summary:
Takes into account the clang-format file of the project, if any.
Reverts to LLVM if not
lodato created this revision.
lodato added reviewers: djasper, klimek.
This feature had never worked at all because the code incorrectly used
<`commit2>` for both the "old" and "new", so the diff was always empty! Now we
correctly use `` where we should and it works fine.
https://reviews.llvm.
lodato created this revision.
lodato added reviewers: djasper, klimek.
This makes the code a bit easier to understand. Also add a docstring to `run()`.
Note: This means that we read the entire index into memory when calling `git
update-index`, whereas previously we would send the data line-by-li
aaron.ballman added a comment.
In https://reviews.llvm.org/D40854#950640, @JonasToth wrote:
> > The "enforcement" listed on the C++ Core Guidelines is very unhelpful, so
> > it might be worth bringing it up as an issue on their bug tracker. ES.100
> > basically says "you know what we mean, wink
lodato added a comment.
Actually the old code might have been working fine. Please hold off on
reviewing.
https://reviews.llvm.org/D41129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
lodato added a comment.
Yeah, I was incorrect. The feature worked fine. I don't know what I was
thinking.
https://reviews.llvm.org/D41129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320527: [OpenMP] Add function attribute for triggering data
sharing. (authored by gbercea, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41123?vs=126594&id=126618#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320528: [libunwind][MIPS]: Add support for unwinding in O32
and N64 processes. (authored by jhb, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D38110
Files:
libunwind/trunk/include/__
Author: jhb
Date: Tue Dec 12 13:43:36 2017
New Revision: 320528
URL: http://llvm.org/viewvc/llvm-project?rev=320528&view=rev
Log:
[libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.
This supports the soft-float ABI only and has been tested with both clang
and gcc on FreeBSD.
R
1 - 100 of 140 matches
Mail list logo
