[PATCH] D41031: [clangd] (Attempt to) read clang-format file for document formatting

2017-12-12 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. I'm not actually sure we're doing the user a service with this error handling. LSP errors aren't surfaced to the user with a decent UI in practice. Plus it adds a bunch of internal complex

[PATCH] D38831: [libcxx] P0604, invoke_result and is_invocable

2017-12-12 Thread Benjamin Buch via Phabricator via cfe-commits
bebuch accepted this revision. bebuch added a comment. Please commit! https://reviews.llvm.org/D38831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40860: [clangd] Fix diagnostic positions

2017-12-12 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Hmm, I looked into the empty diagnostic ranges, and it overlaps here a lot. Feel free to go ahead and land this and I can merge, otherwise I can include this fix there. Regardless of how it gets landed, thanks for finding and fixing this, this explains a lot of weird

[PATCH] D41056: [clang-tidy] New check misc-uniqueptr-release-unused-retval

2017-12-12 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. > What do you think about making this check fully configurable through the > check options? The options could list the functions to check. The > documentation could suggest some candidate functions from std lib to > configure checks for. That sound reasonable. A simi

[PATCH] D40485: [clangd] Introduced a Context that stores implicit data

2017-12-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clangd/Context.h:169 + struct ContextData { +// We need to make sure Parent outlives the Value, so the order of members +// is important. We do that to allow classes stored in Context's child sammccall wro

Phabricator will be down for ~30 mins

2017-12-12 Thread Eric Liu via cfe-commits
Upgrading Phabricator to a newer version. Sorry for the short notice! - Eric ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: Phabricator will be down for ~30 mins

2017-12-12 Thread Eric Liu via cfe-commits
It was faster than I thought. Phabricator is up again. The most noticeable new feature is the ability to hide inline comments:[image: xkhNjkAc2ma.png] Cheers, Eric On Tue, Dec 12, 2017 at 11:32 AM Eric Liu wrote: > Upgrading Phabricator to a newer version. Sorry for the short notice! > > - Eri

[PATCH] D40485: [clangd] Introduced a Context that stores implicit data

2017-12-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 126515. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Change derive() signature to accept a value instead of the variadic arguments. - Rewrite a while loop into a for loop. - Return a value from Context::empty() instead

[PATCH] D40562: [Sema] Ignore decls in namespaces when global decls are not wanted.

2017-12-12 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D40562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41102: Setup clang-doc frontend framework

2017-12-12 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. Hi julie, i like the new approach for doc generator. I added my thoughts on the code :) Comment at: tools/clang-doc/ClangDoc.cpp:81 + llvm::StringRef InFile) { + return std::unique_ptr( + new ClangDocConsumer(&C

[PATCH] D33776: [libcxx] LWG2221: No formatted output operator for nullptr

2017-12-12 Thread Zhihao Yuan via Phabricator via cfe-commits
lichray added inline comments. Comment at: include/ostream:225 +basic_ostream& operator<<(nullptr_t) +{ return *this << (const void*)0; } + Oh, common, I persuaded the committee to allow you to print a `(null)` and you don't do it... https://reviews.l

[clang-tools-extra] r320468 - [clangd] Introduced a Context that stores implicit data

2017-12-12 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Dec 12 03:16:45 2017 New Revision: 320468 URL: http://llvm.org/viewvc/llvm-project?rev=320468&view=rev Log: [clangd] Introduced a Context that stores implicit data Summary: It will be used to pass around things like Logger and Tracer throughout clangd classes. Reviewe

[PATCH] D40485: [clangd] Introduced a Context that stores implicit data

2017-12-12 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCTE320468: [clangd] Introduced a Context that stores implicit data (authored by ibiryukov, committed by ). Changed prior t

[PATCH] D40897: [clangd] Introduce a "Symbol" class.

2017-12-12 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 126519. hokein marked 4 inline comments as done. hokein added a comment. Address remaining comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40897 Files: clangd/CMakeLists.txt clangd/index/CMakeLists.txt clangd/index/Index.cpp

[PATCH] D38831: [libcxx] P0604, invoke_result and is_invocable

2017-12-12 Thread Zhihao Yuan via Phabricator via cfe-commits
lichray added a comment. [...]test/std/utilities/meta/meta.rel/is_nothrow_invocable.pass.cpp:118:9: error: static_assert failed due to requirement '!std::is_nothrow_invocable_r_v' "" static_assert(!std::is_nothrow_invocable_r_v, ""); ^ ~~

[PATCH] D40897: [clangd] Introduce a "Symbol" class.

2017-12-12 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clangd/index/Index.cpp:34 + +SymbolSlab::const_iterator SymbolSlab::find(const SymbolID& SymID) const { + return Symbols.find(SymID); sammccall wrote: > assert frozen? (and in begin()) We may not do the assert "frozen" i

r320471 - [SemaCodeComplete] Allow passing out scope specifiers in qualified-id completions via completion context.

2017-12-12 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Dec 12 03:35:46 2017 New Revision: 320471 URL: http://llvm.org/viewvc/llvm-project?rev=320471&view=rev Log: [SemaCodeComplete] Allow passing out scope specifiers in qualified-id completions via completion context. Reviewers: ilya-biryukov, arphaman Reviewed By: arphaman

[PATCH] D40563: [SemaCodeComplete] Allow passing out scope specifiers in qualified-id completions via completion context.

2017-12-12 Thread Eric Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320471: [SemaCodeComplete] Allow passing out scope specifiers in qualified-id… (authored by ioeric, committed by ). Repository: rL LLVM https://reviews.llvm.org/D40563 Files: cfe/trunk/include/clang

[PATCH] D40731: Integrate CHash into CLang

2017-12-12 Thread Christian Dietrich via Phabricator via cfe-commits
stettberger updated this revision to Diff 126523. stettberger added a comment. I removed the magic constants and added the number of children for various AST nodes. This should avoid hash collisions. Repository: rC Clang https://reviews.llvm.org/D40731 Files: include/clang/AST/AttrDataCol

[PATCH] D41108: [clang-format] Improve ObjC headers detection.

2017-12-12 Thread Jacek Olesiak via Phabricator via cfe-commits
jolesiak created this revision. jolesiak added a reviewer: krasimir. Herald added a subscriber: klimek. This patch improves detection of ObjC header files. Right now many ObjC headers, especially short ones, are categorized as C/C++. Way of filtering still isn't the best, as most likely it should

[PATCH] D38425: [clangd] Document highlights for clangd

2017-12-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM minor a slight tweak to fix compilation. I'll land this today. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38425 _

[PATCH] D38425: [clangd] Document highlights for clangd

2017-12-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320474: [clangd] Document highlights for clangd (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D38425?vs=126371&id=126529#toc Repository: rL LLVM https://r

[clang-tools-extra] r320474 - [clangd] Document highlights for clangd

2017-12-12 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Dec 12 04:27:47 2017 New Revision: 320474 URL: http://llvm.org/viewvc/llvm-project?rev=320474&view=rev Log: [clangd] Document highlights for clangd Summary: Implementation of Document Highlights Request as described in LSP. Contributed by William Enright (nebiroth).

[PATCH] D41102: Setup clang-doc frontend framework

2017-12-12 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: tools/clang-doc/ClangDocReporter.cpp:106 + FI.Filename = Filename; + FileRecords.insert(std::pair(Filename, std::move(FI))); +} -

[clang-tools-extra] r320476 - [clangd] clang-format the code. NFC

2017-12-12 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Dec 12 04:56:46 2017 New Revision: 320476 URL: http://llvm.org/viewvc/llvm-project?rev=320476&view=rev Log: [clangd] clang-format the code. NFC Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp

[PATCH] D38831: [libcxx] P0604, invoke_result and is_invocable

2017-12-12 Thread Agustín Bergé via Phabricator via cfe-commits
K-ballo added a comment. In https://reviews.llvm.org/D38831#952228, @lichray wrote: > [...]test/std/utilities/meta/meta.rel/is_nothrow_invocable.pass.cpp:118:9: > error: static_assert failed due to requirement > '!std::is_nothrow_invocable_r_v' "" > static_assert(!std::is_nothrow_in

[PATCH] D41108: [clang-format] Improve ObjC headers detection.

2017-12-12 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! I'll go ahead and commit this for you! Repository: rC Clang https://reviews.llvm.org/D41108 ___ cfe-commits mailing list cfe-co

r320479 - [clang-format] Improve ObjC headers detection.

2017-12-12 Thread Krasimir Georgiev via cfe-commits
Author: krasimir Date: Tue Dec 12 05:43:59 2017 New Revision: 320479 URL: http://llvm.org/viewvc/llvm-project?rev=320479&view=rev Log: [clang-format] Improve ObjC headers detection. This patch improves detection of ObjC header files. Right now many ObjC headers, especially short ones, are categor

[PATCH] D36952: [libclang] Add support for checking abstractness of records

2017-12-12 Thread Johann Klähn via Phabricator via cfe-commits
jklaehn added a comment. In https://reviews.llvm.org/D36952#951616, @arphaman wrote: > LGTM Thanks! Can you submit this for me? (I do not have commit access yet.) https://reviews.llvm.org/D36952 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D40897: [clangd] Introduce a "Symbol" class.

2017-12-12 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clangd/index/CMakeLists.txt:5 + +add_clang_library(clangdIndex + Index.cpp hmm, I'm not sure whether we actually want this to be a separate library. This means we can't depend on anything from elsewhere in clangd, an

[PATCH] D40897: [clangd] Introduce a "Symbol" class.

2017-12-12 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 126538. hokein added a comment. - Get rid of clangdIndex library, using the existing clangDaemon library. - Remove the getID() method. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40897 Files: clangd/CMakeLists.txt clangd/index/Index.c

[clang-tools-extra] r320482 - [clangd] Removed unused variable. NFC

2017-12-12 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Dec 12 06:15:01 2017 New Revision: 320482 URL: http://llvm.org/viewvc/llvm-project?rev=320482&view=rev Log: [clangd] Removed unused variable. NFC Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp URL:

[PATCH] D40897: [clangd] Introduce a "Symbol" class.

2017-12-12 Thread Haojian Wu via Phabricator via cfe-commits
hokein marked an inline comment as done. hokein added inline comments. Comment at: clangd/index/CMakeLists.txt:5 + +add_clang_library(clangdIndex + Index.cpp sammccall wrote: > hmm, I'm not sure whether we actually want this to be a separate library. > This mea

[PATCH] D41030: [libcxx] [test] Fix MSVC warnings, null pointer deref.

2017-12-12 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists added a comment. > Avoid MSVC "warning C4293: '<<': shift count negative or too big, undefined > behavior". > MSVC sees (1ULL << N) and warns - being guarded by const bool canFit is > insufficient. A small change to the code Your compiler needs to either (a) get much smarter about

[PATCH] D41030: [libcxx] [test] Fix MSVC warnings, null pointer deref.

2017-12-12 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. These look fine to me. Thanks for the attention to detail. https://reviews.llvm.org/D41030 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D40486: [clangd] Implemented logging using Context

2017-12-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 126544. ilya-biryukov marked 7 inline comments as done. ilya-biryukov added a comment. - Added a helper that runs functions in destructor. - Fixed compilation after rebase. - Got rid of FulfilContextPromiseGuard - Added a FIXME to remove the Ctx typedef.

[PATCH] D40486: [clangd] Implemented logging using Context

2017-12-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. I think all the comments are addressed now and this change is ready for another round of review. Let me know if I missed something. Comment at: clangd/ClangdServer.cpp:36 - ~FulfillPromiseGuard() { Promise.set_value(); } + ~FulfillContextProm

[PATCH] D38831: [libcxx] P0604, invoke_result and is_invocable

2017-12-12 Thread Agustín Bergé via Phabricator via cfe-commits
K-ballo updated this revision to Diff 126545. K-ballo added a comment. Fixed incorrect test case. https://reviews.llvm.org/D38831 Files: include/type_traits include/variant test/std/utilities/function.objects/func.not_fn/not_fn.pass.cpp test/std/utilities/function.objects/unord.hash/non

[PATCH] D40897: [clangd] Introduce a "Symbol" class.

2017-12-12 Thread Haojian Wu via Phabricator via cfe-commits
hokein marked an inline comment as done. hokein added a comment. I'm going to submit this patch to unblock the stuff in https://reviews.llvm.org/D40548. Would be happy to address any further comments afterwards. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40897 _

[PATCH] D40897: [clangd] Introduce a "Symbol" class.

2017-12-12 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE320486: [clangd] Introduce a "Symbol" class. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D40897?vs=126538&id=126548#toc Repository: rCTE Clang Tools Extra

[clang-tools-extra] r320486 - [clangd] Introduce a "Symbol" class.

2017-12-12 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Dec 12 07:42:10 2017 New Revision: 320486 URL: http://llvm.org/viewvc/llvm-project?rev=320486&view=rev Log: [clangd] Introduce a "Symbol" class. Summary: * The "Symbol" class represents a C++ symbol in the codebase, containing all the information of a C++ symbol needed

[PATCH] D40486: [clangd] Implemented logging using Context

2017-12-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 126551. ilya-biryukov added a comment. - Make Context the first parameter everywhere. - Add a SFINAE check to UniqueFunction's constructor to avoid creating it from non-callable objects. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D

r320489 - Fix ICE when __has_unqiue_object_representations called with invalid decl

2017-12-12 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Dec 12 08:02:06 2017 New Revision: 320489 URL: http://llvm.org/viewvc/llvm-project?rev=320489&view=rev Log: Fix ICE when __has_unqiue_object_representations called with invalid decl Modified: cfe/trunk/lib/AST/ASTContext.cpp cfe/trunk/lib/Sema/SemaExprCXX.cpp

[PATCH] D40486: [clangd] Implemented logging using Context

2017-12-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. This is now ready for review. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40486: [clangd] Implemented logging using Context

2017-12-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clangd/Function.h:44 +/// A sfinae-check that Callable can be called with Args... +class = decltype(std::declval()(std::declval()...), + void())> We need this che

Re: r320489 - Fix ICE when __has_unqiue_object_representations called with invalid decl

2017-12-12 Thread Richard Smith via cfe-commits
On 12 Dec 2017 16:02, "Erich Keane via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: erichkeane Date: Tue Dec 12 08:02:06 2017 New Revision: 320489 URL: http://llvm.org/viewvc/llvm-project?rev=320489&view=rev Log: Fix ICE when __has_unqiue_object_representations called with invalid de

[PATCH] D40486: [clangd] Implemented logging using Context

2017-12-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 126554. ilya-biryukov added a comment. - Also check that return type of Callable is correct. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40486 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.h

RE: r320489 - Fix ICE when __has_unqiue_object_representations called with invalid decl

2017-12-12 Thread Keane, Erich via cfe-commits
Gah, no it wasn’t. I’ll revert that now. From: Richard Smith [mailto:rich...@metafoo.co.uk] Sent: Tuesday, December 12, 2017 8:07 AM To: Keane, Erich Cc: cfe-commits Subject: Re: r320489 - Fix ICE when __has_unqiue_object_representations called with invalid decl On 12 Dec 2017 16:02, "Erich K

r320493 - Revert a part of 320489 that was submitted unintentionally.

2017-12-12 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Dec 12 08:22:31 2017 New Revision: 320493 URL: http://llvm.org/viewvc/llvm-project?rev=320493&view=rev Log: Revert a part of 320489 that was submitted unintentionally. Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp URL:

RE: r320489 - Fix ICE when __has_unqiue_object_representations called with invalid decl

2017-12-12 Thread Keane, Erich via cfe-commits
Fixed in 320493. Thanks for catching that. From: Richard Smith [mailto:rich...@metafoo.co.uk] Sent: Tuesday, December 12, 2017 8:07 AM To: Keane, Erich Cc: cfe-commits Subject: Re: r320489 - Fix ICE when __has_unqiue_object_representations called with invalid decl On 12 Dec 2017 16:02, "Erich

[PATCH] D40897: [clangd] Introduce a "Symbol" class.

2017-12-12 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: clangd/index/Index.h:52 +private: + friend class llvm::DenseMapInfo; + warning: class 'DenseMapInfo' was previously declared as a struct [-Wmismatched-tags] Repository: rCTE Clang Tools Extra https://reviews.llvm.o

[PATCH] D41056: [clang-tidy] New check misc-uniqueptr-release-unused-retval

2017-12-12 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In https://reviews.llvm.org/D41056#951507, @khuttun wrote: > P0600R1 seems to suggest quite conservative approach (and rightly so, IMO) in > taking `[[nodiscard]]` in use in std lib. For example it proposes *not* to > use it with `unique_ptr::release`. I think the

Re: [PATCH] D41081: Fix clang Lexer Windows line-ending bug

2017-12-12 Thread Benoit Belley via cfe-commits
Thanks Zachary. Maybe, we can approach the issue through another, hopefully less controversial angle. Clang currently has a limited number of tests verifying that it correctly handles all types of line endings. IMHO, Zhen's solution (dos2unix & unix2dos conversions) provides an handy mechanism

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

2017-12-12 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun updated this revision to Diff 126543. xazax.hun added a comment. - Further improvements to python script part. https://reviews.llvm.org/D30691 Files: include/clang/AST/ASTContext.h include/clang/StaticAnalyzer/Core/AnalyzerOptions.h include/clang/StaticAnalyzer/Core/PathSensitiv

r320494 - [debuginfo-tests] Add support for moving debuginfo-tests from clang/test to llvm/projects or monorepo.

2017-12-12 Thread Don Hinton via cfe-commits
Author: dhinton Date: Tue Dec 12 08:48:35 2017 New Revision: 320494 URL: http://llvm.org/viewvc/llvm-project?rev=320494&view=rev Log: [debuginfo-tests] Add support for moving debuginfo-tests from clang/test to llvm/projects or monorepo. Summary: The new version of debuginfo-tests will have it's

[PATCH] D41055: [debuginfo-tests] Add support for moving debuginfo-tests from clang/test to llvm/projects or monorepo.

2017-12-12 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL320494: [debuginfo-tests] Add support for moving debuginfo-tests from clang/test to… (authored by dhinton, committed by ).

[PATCH] D40897: [clangd] Introduce a "Symbol" class.

2017-12-12 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle added inline comments. Comment at: clangd/Symbol.h:37 +// The class presents a C++ symbol, e.g. class, function. +struct Symbol { + // The symbol identifier, using USR. sammccall wrote: > malaperle wrote: > > malaperle wrote: > > > sammccall wrote: > >

[PATCH] D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked

2017-12-12 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter updated this revision to Diff 126559. CaseyCarter added a comment. Better/simpler workaround from Zhihao. https://reviews.llvm.org/D41048 Files: include/tuple Index: include/tuple === --- include/tuple +++ include/t

[PATCH] D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked

2017-12-12 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter added a comment. This new-and-improved workaround - thanks to @lichray - is unintrusive enough that I can't imagine it being unnacceptable to anyone. I'm going to go ahead and check this in. https://reviews.llvm.org/D41048 ___ cfe-comm

[PATCH] D41118: [clangd] Emit ranges for clangd diagnostics, and fix off-by-one positions

2017-12-12 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added reviewers: rwols, hokein. Herald added subscribers: cfe-commits, ilya-biryukov, klimek. - when the diagnostic has an explicit range, we prefer that - if the diagnostic has a fixit, its RemoveRange is our next choice - otherwise we try to expand the

[libcxx] r320500 - workaround PR 28385 in __find_exactly_one_checked

2017-12-12 Thread Casey Carter via cfe-commits
Author: caseycarter Date: Tue Dec 12 09:22:24 2017 New Revision: 320500 URL: http://llvm.org/viewvc/llvm-project?rev=320500&view=rev Log: workaround PR 28385 in __find_exactly_one_checked Fixes #35578. Differential Revision: D41048 Modified: libcxx/trunk/include/tuple Modified: libcxx/trun

[PATCH] D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked

2017-12-12 Thread Casey Carter via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320500: workaround PR 28385 in __find_exactly_one_checked (authored by CaseyCarter, committed by ). Changed prior to commit: https://reviews.llvm.org/D41048?vs=126559&id=126564#toc Repository: rL LLV

[PATCH] D40860: [clangd] Fix diagnostic positions

2017-12-12 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. https://reviews.llvm.org/D41118 adds real (non-empty) ranges for diagnostics. I've copied all the changes you've made here with some slight tweaks, as they were required for that too. If you like it as-is, probably easiest to land that instead. But I'm also happy for y

[PATCH] D34848: Driver: Don't mix system tools with devtoolset tools on RHEL

2017-12-12 Thread Tom Stellard via Phabricator via cfe-commits
tstellar added a comment. Ping. https://reviews.llvm.org/D34848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r320506 - Add --cuda-path to mock a CUDA Toolkit installation to avoid

2017-12-12 Thread Kelvin Li via cfe-commits
Author: kli Date: Tue Dec 12 10:33:39 2017 New Revision: 320506 URL: http://llvm.org/viewvc/llvm-project?rev=320506&view=rev Log: Add --cuda-path to mock a CUDA Toolkit installation to avoid unexpected error messages for incompatibility between the default SM level and the support in the installed

[PATCH] D40996: Add --no-cuda-version-check in unknown-std.cpp

2017-12-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC320506: Add --cuda-path to mock a CUDA Toolkit installation to avoid (authored by kli, committed by ). Repository: rC Clang https://reviews.llvm.org/D40996 Files: test/Driver/unknown-std.cpp Index

[libcxx] r320509 - [libcxx] P0604, invoke_result and is_invocable

2017-12-12 Thread Zhihao Yuan via cfe-commits
Author: lichray Date: Tue Dec 12 10:42:04 2017 New Revision: 320509 URL: http://llvm.org/viewvc/llvm-project?rev=320509&view=rev Log: [libcxx] P0604, invoke_result and is_invocable Summary: Introduce a new form of `result_of` without function type encoding. Rename and split `is_callable/is_nothr

[PATCH] D41087: [Preprocessor] Implement __is_target_{arch|vendor|os|environment} function-like builtin macros

2017-12-12 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman marked an inline comment as done. arphaman added inline comments. Comment at: lib/Lex/PPMacroExpansion.cpp:1923 + Tok, *this, diag::err_feature_check_malformed); + return II ? getTargetInfo().getTriple().getArchName().equals_lower( +

[PATCH] D38831: [libcxx] P0604, invoke_result and is_invocable

2017-12-12 Thread Zhihao Yuan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320509: [libcxx] P0604, invoke_result and is_invocable (authored by lichray, committed by ). Changed prior to commit: https://reviews.llvm.org/D38831?vs=126545&id=126580#toc Repository: rL LLVM http

[PATCH] D41087: [Preprocessor] Implement __is_target_{arch|vendor|os|environment} function-like builtin macros

2017-12-12 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 126581. arphaman added a comment. Herald added a subscriber: javed.absar. - Change error message. - Take sub arch into account. https://reviews.llvm.org/D41087 Files: include/clang/Lex/Preprocessor.h lib/Lex/PPMacroExpansion.cpp test/Preprocessor/is_

Re: [PATCH] D41039: Add support for attribute "trivial_abi"

2017-12-12 Thread David Blaikie via cfe-commits
On Mon, Dec 11, 2017 at 5:38 PM John McCall wrote: > On Mon, Dec 11, 2017 at 6:19 PM, David Blaikie wrote: > >> On Mon, Dec 11, 2017 at 3:16 PM John McCall via Phabricator < >> revi...@reviews.llvm.org> wrote: >> >>> rjmccall added a comment. >>> >>> In https://reviews.llvm.org/D41039#951648, @a

[PATCH] D38831: [libcxx] P0604, invoke_result and is_invocable

2017-12-12 Thread Zhihao Yuan via Phabricator via cfe-commits
lichray added a comment. That commit message generated from `arc` wasn't all that friendly :/ Thanks for the patch, and @K-ballo you should ask Chris for a commit bit :) Repository: rL LLVM https://reviews.llvm.org/D38831 ___ cfe-commits mailing

[PATCH] D41123: [OpenMP] Add function attribute for triggering data sharing.

2017-12-12 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea created this revision. gtbercea added reviewers: hfinkel, Hahnfeld, ABataev, carlo.bertolli, caomhin. Herald added a subscriber: jholewinski. The backend should only emit data sharing code for the cases where it is needed. A new function attribute is used by Clang to enable data sharing o

[PATCH] D41123: [OpenMP] Add function attribute for triggering data sharing.

2017-12-12 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: test/OpenMP/nvptx_data_sharing.cpp:25-43 +// CK1: define internal void @__omp_offloading_{{.*}}test_ds{{.*}}worker() #0 // CK1: [[SHAREDARGS:%.+]] = alloca i8** // CK1: call i1 @__kmpc_kernel_parallel(i8** %work_fn, i8*** [[SHAREDARGS]

[PATCH] D41050: Fix over-release of return value of lambda implicitly converted to block

2017-12-12 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Alternative #1 is actually the right option — only it shouldn't be an objc_retain, it should be an objc_retainAutoreleasedReturnValue. Repository: rC Clang https://reviews.llvm.org/D41050 ___ cfe-commits mailing list cf

[PATCH] D41123: [OpenMP] Add function attribute for triggering data sharing.

2017-12-12 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea updated this revision to Diff 126594. gtbercea added a comment. Fix test. Repository: rL LLVM https://reviews.llvm.org/D41123 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp test/OpenMP/nvptx_data_sharing.cpp Index: test/OpenMP/nvptx_data_sharing.cpp ==

[PATCH] D41123: [OpenMP] Add function attribute for triggering data sharing.

2017-12-12 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D41123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

r320519 - [cmake] Follow-up to rL320494.

2017-12-12 Thread Don Hinton via cfe-commits
Author: dhinton Date: Tue Dec 12 11:47:40 2017 New Revision: 320519 URL: http://llvm.org/viewvc/llvm-project?rev=320519&view=rev Log: [cmake] Follow-up to rL320494. EXISTS requires full paths. Modified: cfe/trunk/test/CMakeLists.txt Modified: cfe/trunk/test/CMakeLists.txt URL: http://llvm.

[PATCH] D41118: [clangd] Emit ranges for clangd diagnostics, and fix off-by-one positions

2017-12-12 Thread Raoul Wols via Phabricator via cfe-commits
rwols accepted this revision. rwols added a comment. This revision is now accepted and ready to land. LGTM, you can go ahead and land this, I'll drop https://reviews.llvm.org/D40860. I'm happy we got to the bottom of this :) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41118

[PATCH] D41050: Fix over-release of return value of lambda implicitly converted to block

2017-12-12 Thread Dan Zimmerman via Phabricator via cfe-commits
danzimm added a comment. @rjmccall ah right, good point -- I think it's ok to elide that objc_retainAutoreleasedReturnValue/objc_autoreleaseReturnValue pair in this case though, since all of this is generated within clang itself (and thus we can make the guarentee that the object will properly

[PATCH] D41050: Fix over-release of return value of lambda implicitly converted to block

2017-12-12 Thread Dan Zimmerman via Phabricator via cfe-commits
danzimm added a comment. Or do we need to abide by those semantics strictly here? Could you expand on why that is, if that's the case? Repository: rC Clang https://reviews.llvm.org/D41050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D39050: Add index-while-building support to Clang

2017-12-12 Thread Nathan Hawes via Phabricator via cfe-commits
nathawes planned changes to this revision. nathawes added a comment. Thanks for taking another look @ioeric – I'll work through your comments and update. https://reviews.llvm.org/D39050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

r320521 - [OpenMP] Diagnose function name on the link clause

2017-12-12 Thread Kelvin Li via cfe-commits
Author: kli Date: Tue Dec 12 12:08:12 2017 New Revision: 320521 URL: http://llvm.org/viewvc/llvm-project?rev=320521&view=rev Log: [OpenMP] Diagnose function name on the link clause This patch is to add diagnose when a function name is specified on the link clause. According to the OpenMP spec, o

[PATCH] D40968: [OpenMP] Diagnose function name on the link clause

2017-12-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320521: [OpenMP] Diagnose function name on the link clause (authored by kli, committed by ). Changed prior to commit: https://reviews.llvm.org/D40968?vs=126217&id=126600#toc Repository: rL LLVM http

Re: [PATCH] D41039: Add support for attribute "trivial_abi"

2017-12-12 Thread John McCall via cfe-commits
On Tue, Dec 12, 2017 at 1:45 PM, David Blaikie wrote: > On Mon, Dec 11, 2017 at 5:38 PM John McCall wrote: > >> On Mon, Dec 11, 2017 at 6:19 PM, David Blaikie >> wrote: >> >>> On Mon, Dec 11, 2017 at 3:16 PM John McCall via Phabricator < >>> revi...@reviews.llvm.org> wrote: >>> rjmccall ad

[PATCH] D41050: Fix over-release of return value of lambda implicitly converted to block

2017-12-12 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In https://reviews.llvm.org/D41050#952720, @danzimm wrote: > Or do we need to abide by those semantics strictly here? Could you expand on > why that is, if that's the case? The autoreleased-return-value optimization cannot be understood purely in terms of its impact

[PATCH] D41031: [clangd] (Attempt to) read clang-format file for document formatting

2017-12-12 Thread Raoul Wols via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320524: [clangd] (Attempt to) read clang-format file for document formatting (authored by rwols, committed by ). Herald added a subscriber: klimek. Changed prior to commit: https://reviews.llvm.org/D410

[PATCH] D36915: [Sema] Diagnose local variables and parameters captured by lambda and block expressions in a default argument

2017-12-12 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. This looks good to me. https://reviews.llvm.org/D36915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39562: [CodeGen][ObjC] Fix an assertion failure caused by copy elision

2017-12-12 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Hmm. The OVE-ing of the RHS of a property assignment is just there to make the original source structure clearer. Maybe the right solution here is to set a flag in the OVE that says that it's a unique semantic reference to its source expression, and then change IRGen

[PATCH] D36915: [Sema] Diagnose local variables and parameters captured by lambda and block expressions in a default argument

2017-12-12 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: lib/Sema/Sema.cpp:1677-1684 +Sema::DefaultArgRAII::DefaultArgRAII(Sema &S) +: Actions(S), PrevParent(S.getParentOfDefaultArg()) { + S.setParentOfDefaultArg(S.CurContext); +} + +Sema::DefaultArgRAII::~DefaultArgRAII() { + Acti

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

2017-12-12 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov added inline comments. Comment at: tools/scan-build-py/libscanbuild/report.py:257 def read_bugs(output_dir, html): +# type: (str, bool) -> Generator[Dict[str, Any], None, None] """ Generate a unique sequence of bugs from given output directory.

[clang-tools-extra] r320524 - [clangd] (Attempt to) read clang-format file for document formatting

2017-12-12 Thread Raoul Wols via cfe-commits
Author: rwols Date: Tue Dec 12 12:25:06 2017 New Revision: 320524 URL: http://llvm.org/viewvc/llvm-project?rev=320524&view=rev Log: [clangd] (Attempt to) read clang-format file for document formatting Summary: Takes into account the clang-format file of the project, if any. Reverts to LLVM if not

[PATCH] D41129: Fix `git-clang-format `.

2017-12-12 Thread Mark Lodato via Phabricator via cfe-commits
lodato created this revision. lodato added reviewers: djasper, klimek. This feature had never worked at all because the code incorrectly used <`commit2>` for both the "old" and "new", so the diff was always empty! Now we correctly use `` where we should and it works fine. https://reviews.llvm.

[PATCH] D41130: git-clang-format: cleanup: Use run() when possible.

2017-12-12 Thread Mark Lodato via Phabricator via cfe-commits
lodato created this revision. lodato added reviewers: djasper, klimek. This makes the code a bit easier to understand. Also add a docstring to `run()`. Note: This means that we read the entire index into memory when calling `git update-index`, whereas previously we would send the data line-by-li

[PATCH] D40854: [clang-tidy] WIP implement cppcoreguidelines check for mixed integer arithmetic

2017-12-12 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In https://reviews.llvm.org/D40854#950640, @JonasToth wrote: > > The "enforcement" listed on the C++ Core Guidelines is very unhelpful, so > > it might be worth bringing it up as an issue on their bug tracker. ES.100 > > basically says "you know what we mean, wink

[PATCH] D41129: Fix `git-clang-format `.

2017-12-12 Thread Mark Lodato via Phabricator via cfe-commits
lodato added a comment. Actually the old code might have been working fine. Please hold off on reviewing. https://reviews.llvm.org/D41129 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D41129: Fix `git-clang-format `.

2017-12-12 Thread Mark Lodato via Phabricator via cfe-commits
lodato added a comment. Yeah, I was incorrect. The feature worked fine. I don't know what I was thinking. https://reviews.llvm.org/D41129 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D41123: [OpenMP] Add function attribute for triggering data sharing.

2017-12-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320527: [OpenMP] Add function attribute for triggering data sharing. (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D41123?vs=126594&id=126618#toc Repository:

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

2017-12-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320528: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes. (authored by jhb, committed by ). Repository: rL LLVM https://reviews.llvm.org/D38110 Files: libunwind/trunk/include/__

[libunwind] r320528 - [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

2017-12-12 Thread John Baldwin via cfe-commits
Author: jhb Date: Tue Dec 12 13:43:36 2017 New Revision: 320528 URL: http://llvm.org/viewvc/llvm-project?rev=320528&view=rev Log: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes. This supports the soft-float ABI only and has been tested with both clang and gcc on FreeBSD. R

  1   2   >