aaron.ballman added a comment.

In https://reviews.llvm.org/D41056#951507, @khuttun wrote:

> P0600R1 seems to suggest quite conservative approach (and rightly so, IMO) in 
> taking `[[nodiscard]]` in use in std lib. For example it proposes *not* to 
> use it with `unique_ptr::release`. I think there could still be room for 
> static unused ret val checking for parts of std lib not covered by P0600R1, 
> but also for boost, POSIX APIs etc.
>
> What do you think about making this check fully configurable through the 
> check options? The options could list the functions to check. The 
> documentation could suggest some candidate functions from std lib to 
> configure checks for.


Agreed; that's largely what I was suggesting with my previous comment. I think 
this should be a generic, configurable check that is prepopulated with some 
APIs that make sense. You can use P0600R1 as a starting point, but I'd 
encourage you to find a pretty decent (but still conservative) list of APIs.


Repository:
  rL LLVM

https://reviews.llvm.org/D41056



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to