sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
I'm not actually sure we're doing the user a service with this error handling. LSP errors aren't surfaced to the user with a decent UI in practice. Plus it adds a bunch of internal complexity. I'd strongly consider just falling back to LLVM style on any error, inside ClangdServer::formatCode. I think the UX will be better, and the code will be simpler. But up to you. https://reviews.llvm.org/D41031 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
