ilya-biryukov added a comment.
In https://reviews.llvm.org/D41005#949550, @cameron314 wrote:
> It's been a while since I was in this code, but I seem to recall the file
> needed to exist on disk in order to uniquely identify it (via inode). Does
> this break the up-to-date check?
When the fil
a.sidorin added a comment.
Hello Alexey,
Thank you for the update. The code looks much cleaner now.
Comment at: lib/StaticAnalyzer/Checkers/LabelInsideSwitchChecker.cpp:115
+
+namespace clang {
+ namespace ento {
alexey.knyshev wrote:
> a.sidorin wrote:
> > Y
miyuki added a comment.
Ping
https://reviews.llvm.org/D40705
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
miyuki added a comment.
Ping
https://reviews.llvm.org/D40707
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov updated this revision to Diff 126315.
ilya-biryukov added a comment.
- Made ContextData a private member of Context.
- Added clone method.
- Added forgotten header guard in TypedValueMap.h
- Pass Key<> by const-ref instead of by-ref.
- Pass Context by-const-ref instead of by-ref.
- M
ilya-biryukov updated this revision to Diff 126316.
ilya-biryukov added a comment.
- Pass Context by const-ref instead of by-ref.
- Don't expose global logger, it is only used in log method now.
- Renamed logImpl to log.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40486
File
rogfer01 added inline comments.
Comment at: lib/Parse/ParseTemplate.cpp:702
+ReportStorageClass(DS.getStorageClassSpecLoc());
+ if (DS.getThreadStorageClassSpec() != DeclSpec::TSCS_unspecified)
+ReportStorageClass(DS.getThreadStorageClassSpecLoc());
You
ilya-biryukov updated this revision to Diff 126317.
ilya-biryukov added a comment.
- Return `const Type*` instead of `Type*` in map getters.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40485
Files:
clangd/CMakeLists.txt
clangd/Context.cpp
clangd/Context.h
clangd/Type
ilya-biryukov updated this revision to Diff 126318.
ilya-biryukov added a comment.
- Update the patch to accomodate changes from tracing and Context patches.
- Updated tracing after changes to Context. We now store a clone() of Context
in Span instead of ContextData.
- Pass Context by const-ref i
ilya-biryukov updated this revision to Diff 126319.
ilya-biryukov marked 4 inline comments as done.
ilya-biryukov added a comment.
- Added a comment about the Parent vs Data lifetimes.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40485
Files:
clangd/CMakeLists.txt
clangd/
ilya-biryukov updated this revision to Diff 126320.
ilya-biryukov added a comment.
- Rephrase the comment.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40485
Files:
clangd/CMakeLists.txt
clangd/Context.cpp
clangd/Context.h
clangd/TypedValueMap.h
unittests/clangd/CMa
ilya-biryukov updated this revision to Diff 126321.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Added r-value overload for derive().
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40485
Files:
clangd/CMakeLists.txt
clangd/Context.cpp
c
ilya-biryukov updated this revision to Diff 126322.
ilya-biryukov added a comment.
- Replaced emptyCtx with Context::empty
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40485
Files:
clangd/CMakeLists.txt
clangd/Context.cpp
clangd/Context.h
clangd/TypedValueMap.h
unit
rogfer01 added a comment.
Hi @miyuki I can commit it.
https://reviews.llvm.org/D40415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexey.knyshev added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/LabelInsideSwitchChecker.cpp:87
+BugReporter &BR) const {
+ auto LabelStmt = stmt(hasDescendant(switchStmt(
+ eachOf(has(compoundStmt(forEach(labelS
miyuki added a comment.
In https://reviews.llvm.org/D40415#950793, @rogfer01 wrote:
> Hi @miyuki I can commit it.
Please do so.
https://reviews.llvm.org/D40415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
yvvan added a comment.
Can we still have it in 5.0?
Repository:
rL LLVM
https://reviews.llvm.org/D40746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov added inline comments.
Comment at: clangd/Context.h:11
+// Context for storing and retrieving implicit data. Useful for passing
implicit
+// parameters on a per-request basis.
+//
sammccall wrote:
> This could use a bit more I think, e.g.
>
>
ilya-biryukov added inline comments.
Comment at: clangd/Context.h:65
+ Context *Parent;
+ TypedValueMap Data;
+};
sammccall wrote:
> ilya-biryukov wrote:
> > sammccall wrote:
> > > We add complexity here (implementation and conceptual) to allow multiple
> > >
miyuki updated this revision to Diff 126325.
miyuki added a comment.
Added a test for thead_local.
https://reviews.llvm.org/D40705
Files:
include/clang/Basic/DiagnosticParseKinds.td
lib/Parse/ParseTemplate.cpp
test/CXX/temp/temp.param/p2-cpp11.cpp
test/CXX/temp/temp.param/p2.cpp
Index
ilya-biryukov updated this revision to Diff 126327.
ilya-biryukov added a comment.
Udpated the patch after changes in Context
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40486
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/Clan
ilya-biryukov updated this revision to Diff 126328.
ilya-biryukov added a comment.
Updated the patch after changes to Context
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40488
Files:
clangd/ClangdUnit.cpp
clangd/JSONRPCDispatcher.cpp
clangd/Trace.cpp
clangd/Trace.h
ilya-biryukov updated this revision to Diff 126329.
ilya-biryukov added a comment.
Updated the patch after changes to Context
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40489
Files:
clangd/Trace.cpp
clangd/Trace.h
Index: clangd/Trace.h
=
abeserminji updated this revision to Diff 126331.
abeserminji added a comment.
Comment addressed.
https://reviews.llvm.org/D35624
Files:
include/clang/Basic/DiagnosticCommonKinds.td
lib/Basic/Targets/Mips.cpp
Index: lib/Basic/Targets/Mips.cpp
==
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1992
+def ext_auto_new_list_init : Extension<
+ "ISO C++ standards before C++17 does not allow new expression for
sdardis added inline comments.
Comment at: lib/Basic/Targets/Mips.cpp:209
bool MipsTargetInfo::validateTarget(DiagnosticsEngine &Diags) const {
+ // microMIPS64R6 backend is removed
+ if ((getTriple().getArch() == llvm::Triple::mips64 ||
"was removed."
https
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320351: [mips] Removal of microMIPS64R6 (authored by
abeserminji).
Changed prior to commit:
https://reviews.llvm.org/D35624?vs=126331&id=126332#toc
Repository:
rL LLVM
https://reviews.llvm.org/D3562
sammccall added a comment.
Thanks for the restructuring? I want to take another pass today, but wanted to
mention some SymbolID things.
Comment at: clangd/Symbol.h:37
+// The class presents a C++ symbol, e.g. class, function.
+struct Symbol {
+ // The symbol identifier, using
sammccall added a comment.
Thanks for the changes. I don't think `TypedValueMap`/`ContextBuilder` pull
their weight, but let's get another opinion on this.
Comment at: clangd/Context.h:65
+ Context *Parent;
+ TypedValueMap Data;
+};
ilya-biryukov wrote:
> sa
ilya-biryukov updated this revision to Diff 126337.
ilya-biryukov marked 15 inline comments as done.
ilya-biryukov added a comment.
- Copy Context in forceReparse's call to scheduleCancelRebuild.
- Renamed Key<> for ID, Out and Span.
- Removed the FIXME
- Got rid of getExisting(RequestSpan)
- Remo
dim created this revision.
When compiling and/or with -Wsystem-headers, in
C++14 or higher mode, clang produces warnings about the literal suffixes
defined in them, e.g.:
$ cat test.cpp
#include
$ clang -std=c++14 -Wsystem-headers -Wall -Wextra -c test.cpp
In file included from test
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.cpp:220
- // Note that std::future from this cleanup action is ignored.
- scheduleCancelRebuild(std::move(Recreated.RemovedFile));
+ // Note that std::future from this cleanup action.
+ // FIXME(ibiryukov)
ilya-biryukov updated this revision to Diff 126340.
ilya-biryukov added a comment.
- Remove mention of globalLogger() from the comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40486
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
ilya-biryukov updated this revision to Diff 126345.
ilya-biryukov added a comment.
- Use `derive() &&` instead of `derive() const &&`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40485
Files:
clangd/CMakeLists.txt
clangd/Context.cpp
clangd/Context.h
clangd/TypedValue
ilya-biryukov added inline comments.
Comment at: clangd/Context.h:92
+ ContextBuilder derive() const &;
+ ContextBuilder derive() const &&;
+
sammccall wrote:
> `&&`, not `const&&` :-)
>
> Maybe add a trailing `//takes ownership`
Right. Copy-paste is gonna kil
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D40561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
aaron.ballman added a comment.
I think that it would be more appropriate to fix this in Clang rather than
libc++. For instance, we don't want libstdc++ to have to silence our same
diagnostic here.
Repository:
rCXX libc++
https://reviews.llvm.org/D41064
___
ilya-biryukov updated this revision to Diff 126346.
ilya-biryukov added a comment.
- Removed buildCtx(). Now Contexts can only be created using emptyCtx().derive()
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40485
Files:
clangd/CMakeLists.txt
clangd/Context.cpp
clangd/
Author: rogfer01
Date: Mon Dec 11 05:54:58 2017
New Revision: 320363
URL: http://llvm.org/viewvc/llvm-project?rev=320363&view=rev
Log:
[libcxx] Define istream_iterator equality comparison operators out-of-line
Currently libc++ defines operator== and operator!= as friend functions in the
definitio
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320363: [libcxx] Define istream_iterator equality comparison
operators out-of-line (authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D40415?vs=124155&id=126349#toc
Repository:
seaneveson updated this revision to Diff 126350.
seaneveson added a comment.
Improve tests.
https://reviews.llvm.org/D40712
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/BackendUtil.cpp
lib/Driver/ToolChains/Clang.cpp
lib/Frontend/Compile
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D40968
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
nik added a comment.
Thanks for the review. Please submit as I don't have the permissions for this.
https://reviews.llvm.org/D40561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nik marked 2 inline comments as done.
nik added inline comments.
Comment at: include/clang/Frontend/PrecompiledPreamble.h:109
+ std::chrono::steady_clock::time_point getCreationTimePoint() const {
+return CreationTimePoint;
ilya-biryukov wrote:
> Having th
nik updated this revision to Diff 126353.
nik marked 2 inline comments as done.
nik added a comment.
Addressed Ilya's comments.
Repository:
rC Clang
https://reviews.llvm.org/D41005
Files:
include/clang/Frontend/ASTUnit.h
lib/Frontend/ASTUnit.cpp
lib/Frontend/PrecompiledPreamble.cpp
u
nik added inline comments.
Comment at: include/clang/Frontend/ASTUnit.h:196
+ /// \brief Counter indicating how often the preamble was build in total.
+ unsigned PreambleCounter;
+
Any better name for this one? Otherwise I would suggest renaming
PreambleRebuil
Author: abeserminji
Date: Mon Dec 11 04:12:16 2017
New Revision: 320354
URL: http://llvm.org/viewvc/llvm-project?rev=320354&view=rev
Log:
[mips] Minor update to the comment (NFC)
Modified:
cfe/trunk/lib/Basic/Targets/Mips.cpp
Modified: cfe/trunk/lib/Basic/Targets/Mips.cpp
URL:
http://llvm.
gerazo added inline comments.
Comment at: tools/scan-build-py/libscanbuild/analyze.py:44
+CTU_FUNCTION_MAP_FILENAME = 'externalFnMap.txt'
+CTU_TEMP_FNMAP_FOLDER = 'tmpExternalFnMaps'
george.karpenkov wrote:
> gerazo wrote:
> > george.karpenkov wrote:
> > > What
Author: abeserminji
Date: Mon Dec 11 03:29:17 2017
New Revision: 320351
URL: http://llvm.org/viewvc/llvm-project?rev=320351&view=rev
Log:
[mips] Removal of microMIPS64R6
microMIPS64R6 is removed from backend, and therefore frontend
will show an error when target is microMIPS64R6.
This is Clang p
klimek added inline comments.
Comment at: clangd/Context.h:65
+ Context *Parent;
+ TypedValueMap Data;
+};
sammccall wrote:
> ilya-biryukov wrote:
> > sammccall wrote:
> > > ilya-biryukov wrote:
> > > > sammccall wrote:
> > > > > We add complexity here (impleme
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Sorry for the delay getting this reviewed.
LG, thanks for fixing this! Just style nits.
Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:124
+/// Convert a clang::So
alexfh added a comment.
In https://reviews.llvm.org/D41056#950605, @khuttun wrote:
> In https://reviews.llvm.org/D41056#950570, @Eugene.Zelenko wrote:
>
> > May be //bugprone// is better module then //misc//?
>
>
> Maybe. I can move it if all the reviewers think that it would be better
> suited
Nebiroth updated this revision to Diff 126371.
Nebiroth marked 3 inline comments as done.
Nebiroth added a comment.
Herald added a subscriber: mgrang.
Merged with latest llvm/clang
Minor code cleanup
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D38425
Files:
clangd/ClangdLSP
Nebiroth added a comment.
@ilya-biryukov Need someone to land this.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D38425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
ilya-biryukov updated this revision to Diff 126373.
ilya-biryukov added a comment.
- Removed ContextBuilder and TypedValueMap.
- Updated the docs.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40485
Files:
clangd/CMakeLists.txt
clangd/Context.cpp
clangd/Context.h
unitt
ilya-biryukov updated this revision to Diff 126375.
ilya-biryukov added a comment.
- Use derive(key, val) instead of derive().add(key, val).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40486
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.
ilya-biryukov updated this revision to Diff 126376.
ilya-biryukov added a comment.
- Use derive(key, value) instead of derive().add(key, value).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40488
Files:
clangd/ClangdUnit.cpp
clangd/JSONRPCDispatcher.cpp
clangd/Trace.cpp
ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.
Comment at: clangd/Context.h:65
+ Context *Parent;
+ TypedValueMap Data;
+};
klimek wrote:
> sammccall wrote:
> > ilya-biryukov wrote:
> > > sammccall wrote:
> > > > ilya-biryu
hokein updated this revision to Diff 126378.
hokein marked 5 inline comments as done.
hokein added a comment.
Address comments on SymbolID.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40897
Files:
clangd/CMakeLists.txt
clangd/index/CMakeLists.txt
clangd/index/Index.cpp
aaron.ballman added a comment.
In https://reviews.llvm.org/D41056#951083, @alexfh wrote:
> In https://reviews.llvm.org/D41056#950605, @khuttun wrote:
>
> > In https://reviews.llvm.org/D41056#950570, @Eugene.Zelenko wrote:
> >
> > > May be //bugprone// is better module then //misc//?
> >
> >
> > M
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.cpp:36
- ~FulfillPromiseGuard() { Promise.set_value(); }
+ ~FulfillContextPromiseGuard() { Promise.set_value(std::move(Ctx)); }
sammccall wrote:
> Yikes, I can see how we got here, but we
ioeric updated this revision to Diff 126379.
ioeric marked 8 inline comments as done.
ioeric added a comment.
- Address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40548
Files:
clangd/CMakeLists.txt
clangd/ClangdIndex.cpp
clangd/ClangdIndex.h
clangd/
ioeric added inline comments.
Comment at: clangd/ClangdIndex.h:1
+//===--- ClangdIndex.h - Symbol indexes for clangd.---*-
C++-*-===//
+//
sammccall wrote:
> nit: `Clangd` prefix doesn't do much.
> I'd suggest `Index.h` for the interface (including S
sammccall accepted this revision.
sammccall added a comment.
Thanks, this looks like exactly the right amount of magic to me :-)
Comment at: clangd/Context.h:91
+ /// functions that require a context when no explicit context is available.
+ static const Context &empty();
+
--
+Tom
I expect it's too late since 5.0.1 is virtually out the door already.
On Mon, Dec 11, 2017 at 2:35 AM, Ivan Donchevskii via Phabricator <
revi...@reviews.llvm.org> wrote:
> yvvan added a comment.
>
> Can we still have it in 5.0?
>
>
> Repository:
> rL LLVM
>
> https://reviews.llvm.org/D40
Thanks!
On 10 December 2017 at 03:05, Simon Pilgrim via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rksimon
> Date: Sun Dec 10 03:05:14 2017
> New Revision: 320297
>
> URL: http://llvm.org/viewvc/llvm-project?rev=320297&view=rev
> Log:
> Fix MSVC 'not all control paths return a val
Author: erichkeane
Date: Mon Dec 11 09:36:42 2017
New Revision: 320391
URL: http://llvm.org/viewvc/llvm-project?rev=320391&view=rev
Log:
For Linux/gnu compatibility, preinclude if the file is available
As reported in llvm bugzilla 32377.
Here’s a patch to add preinclude of stdc-predef.h.
The gc
NoQ added a comment.
Yeah, we usually try to avoid omissions of modeling in on-by-default checkers
because the user may accidentally run into projects in which the unmodeled
idiom is common, and then he'd get false positives all over the place. In my
case it was just two new positives, both fal
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320391: For Linux/gnu compatibility, preinclude
if the file is available (authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D34158?vs=123613&id=126386#toc
Repository:
rL LLV
This revision was automatically updated to reflect the committed changes.
Closed by commit rC320391: For Linux/gnu compatibility, preinclude
if the file is available (authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D34158?vs=123613&id=126387#toc
Repository:
rC Cla
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
\o/
Comment at: clangd/index/Index.cpp:34
+
+SymbolSlab::const_iterator SymbolSlab::find(const SymbolID& SymID) const {
+ return Symbols.find(SymID);
arphaman updated this revision to Diff 126388.
arphaman marked an inline comment as done.
arphaman added a comment.
Don't warn about the redundant environment variable
Repository:
rC Clang
https://reviews.llvm.org/D40998
Files:
lib/Driver/ToolChains/Darwin.cpp
test/Driver/darwin-version.
spetrovic added a comment.
ping
https://reviews.llvm.org/D39053
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ updated this revision to Diff 126390.
NoQ added a comment.
Add a FIXME test.
https://reviews.llvm.org/D41042
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp
test/Analysis/stack-capture-leak-arc.mm
test/Analysis/stack-ca
malcolm.parsons updated this revision to Diff 126394.
malcolm.parsons marked an inline comment as done.
malcolm.parsons added a comment.
Add assert.
Repository:
rC Clang
https://reviews.llvm.org/D41016
Files:
include/clang/Sema/ScopeInfo.h
lib/Sema/SemaLambda.cpp
test/SemaCXX/warn-unus
Author: malcolm.parsons
Date: Mon Dec 11 10:00:36 2017
New Revision: 320396
URL: http://llvm.org/viewvc/llvm-project?rev=320396&view=rev
Log:
[Sema] Fix crash in unused-lambda-capture warning for VLAs
Summary:
Clang was crashing when diagnosing an unused-lambda-capture for a VLA because
From.getV
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320396: [Sema] Fix crash in unused-lambda-capture warning
for VLAs (authored by malcolm.parsons).
Repository:
rL LLVM
https://reviews.llvm.org/D41016
Files:
cfe/trunk/include/clang/Sema/ScopeInfo.h
malcolm.parsons added inline comments.
Comment at: lib/Sema/SemaLambda.cpp:1491
else
diag << From.getVariable();
diag << From.isNonODRUsed();
dim wrote:
> Just for sanity's sake, I would still put an assert here, that
> `getVariable()` does not return
mclow.lists requested changes to this revision.
mclow.lists added a comment.
This revision now requires changes to proceed.
In https://reviews.llvm.org/D41064#950946, @aaron.ballman wrote:
> I think that it would be more appropriate to fix this in Clang rather than
> libc++. For instance, we don
ncw created this revision.
Herald added subscribers: cfe-commits, aheejin, jfb.
Herald added a reviewer: EricWF.
It turns out that this is the only change required in libcxx for it to compile
with the new `wasm32-unknown-unknown-wasm` target recently added to Clang.
I haven't done much testing o
dim updated this revision to Diff 126397.
dim added a comment.
Updated to also include and . I think all cases are
covered now.
Repository:
rCXX libc++
https://reviews.llvm.org/D41064
Files:
include/chrono
include/complex
include/string
include/string_view
Index: include/string_v
benhamilton created this revision.
Herald added a subscriber: cfe-commits.
The Google style guide is neutral on whether there should be a
space before the protocol list in an Objective-C @interface or
@implementation.
The majority of Objective-C code in both Apple's public
header files and Google
Author: erichkeane
Date: Mon Dec 11 10:14:51 2017
New Revision: 320398
URL: http://llvm.org/viewvc/llvm-project?rev=320398&view=rev
Log:
Revert 320391: Certain targets are failing, pulling back to diagnose.
Removed:
cfe/trunk/test/Driver/Inputs/stdc-predef/
cfe/trunk/test/Driver/stdc-pred
mclow.lists added a comment.
Except for the stuff in TODO.txt these look good to me.
We need to do some work on that file - it's pretty out of date.
https://reviews.llvm.org/D40991
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
mclow.lists added a comment.
Dan - I think I need a bit more context here.
How does UBSan get triggered?
Repository:
rCXX libc++
https://reviews.llvm.org/D40743
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: lichray
Date: Mon Dec 11 10:29:54 2017
New Revision: 320401
URL: http://llvm.org/viewvc/llvm-project?rev=320401&view=rev
Log:
P0620 follow-up: deducing `auto` from braced-init-list in new expr
Summary:
This is a side-effect brought in by p0620r0, which allows other placeholder
types (der
This revision was automatically updated to reflect the committed changes.
Closed by commit rC320401: P0620 follow-up: deducing `auto` from
braced-init-list in new expr (authored by lichray).
Changed prior to commit:
https://reviews.llvm.org/D39451?vs=126092&id=126400#toc
Repository:
rC Clang
arphaman created this revision.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D41075
Files:
lib/Driver/ToolChains/Darwin.cpp
test/Driver/darwin-version.c
Index: test/Driver/darwin-version.c
==
arphaman abandoned this revision.
arphaman added a comment.
Accidental 'return', will reopen
Repository:
rC Clang
https://reviews.llvm.org/D41075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
arphaman created this revision.
This patch ensures that '-target' can be used to set the 'simulator'
environment component in the target triple.
Repository:
rC Clang
https://reviews.llvm.org/D41076
Files:
lib/Driver/ToolChains/Darwin.cpp
test/Driver/darwin-version.c
Index: test/Driver
mclow.lists added a comment.
This looks good to me; with a couple of nits.
Comment at:
test/std/input.output/string.streams/stringbuf/stringbuf.cons/default.pass.cpp:26
+{
+assert(this->eback() == 0);
+assert(this->gptr() == 0);
Not zero, p
alexey.knyshev created this revision.
alexey.knyshev added a project: clang.
Herald added a subscriber: mgorny.
CallArgsOrderChecker which looks for accidental swap or skip of arguments in
function, methods, constructors and operators calls
Repository:
rC Clang
https://reviews.llvm.org/D4107
asb updated this revision to Diff 126404.
asb marked 3 inline comments as done.
asb retitled this revision from "[RISCV][RFC] Add initial RISC-V target and
driver support" to "[RISCV] Add initial RISC-V target and driver support".
asb edited the summary of this revision.
asb added a comment.
Heral
Author: hans
Date: Mon Dec 11 10:58:18 2017
New Revision: 320405
URL: http://llvm.org/viewvc/llvm-project?rev=320405&view=rev
Log:
Fix warn-enum-compare.cpp on Windows
It's been failing since r319875.
Modified:
cfe/trunk/test/SemaCXX/warn-enum-compare.cpp
Modified: cfe/trunk/test/SemaCXX/wa
I've committed a fix to pacify the test in r320405.
On Wed, Dec 6, 2017 at 12:27 PM, Galina Kistanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hello Richard,
>
> This commit broke the tests on the builder:
>
> http://lab.llvm.org:8011/builders/llvm-clang-x86_64-
> expensive-checks-w
CaseyCarter updated this revision to Diff 126406.
CaseyCarter added a comment.
Make the workaround unconditional.
https://reviews.llvm.org/D41048
Files:
include/tuple
Index: include/tuple
===
--- include/tuple
+++ include/tuple
Author: alexfh
Date: Mon Dec 11 11:02:26 2017
New Revision: 320406
URL: http://llvm.org/viewvc/llvm-project?rev=320406&view=rev
Log:
[clang-tidy] Correctly classify constant arrays and constant strings as
constants when checking identifiers naming
Summary:
They are not locally const qualified so
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320406: [clang-tidy] Correctly classify constant arrays and
constant strings as… (authored by alexfh).
Repository:
rL LLVM
https://reviews.llvm.org/D39363
Files:
clang-tools-extra/trunk/clang-tidy/r
dim created this revision.
In https://reviews.llvm.org/D41064, I proposed adding `#pragma clang diagnostic
ignored
"-Wuser-defined-literals"` to some of libc++'s headers, since these
warnings are now triggered by clang's new `-std=gnu++14` default:
$ cat test.cpp
#include
$ clang -std=
dim abandoned this revision.
dim added a comment.
Abandoned in favor of https://reviews.llvm.org/D41080.
Repository:
rCXX libc++
https://reviews.llvm.org/D41064
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
1 - 100 of 150 matches
Mail list logo
